sr-dev September 2014

sr-dev@lists.kamailio.org

33 participants
375 discussions

git:master: registrar Minor doc updates, adding section ID's
by Olle E. Johansson 26 Sep '14

26 Sep '14

Module: sip-router Branch: master Commit: b5c5090cc902043c8d0dddcfbf21b415c7643df6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b5c5090… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Fri Sep 26 22:14:15 2014 +0200 registrar Minor doc updates, adding section ID's --- modules/registrar/README | 188 ++++++++++++++------------- modules/registrar/doc/registrar_admin.xml | 197 +++++++++++++++-------------- modules/registrar/doc/registrar_faq.xml | 2 +- 3 files changed, 201 insertions(+), 186 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=b5c…

1 0

git:master: exec: Minor doc updates, adding section ID's
by Olle E. Johansson 26 Sep '14

26 Sep '14

Module: sip-router Branch: master Commit: 073620366761402e129d4585bb5728dae7469df6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0736203… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Fri Sep 26 22:15:02 2014 +0200 exec: Minor doc updates, adding section ID's --- modules/exec/README | 4 ++-- modules/exec/doc/exec_admin.xml | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/exec/README b/modules/exec/README index 0b7c1da..b28278d 100644 --- a/modules/exec/README +++ b/modules/exec/README @@ -216,5 +216,5 @@ exec_avp("echo TEST", "$avp(s:test)"); 5. Known Issues There is currently no guarantee that scripts ever return and stop - blocking SIP server. (There is kill.c but it is not used along with the - current mechanisms based on popen. Besides that kill.c is ugly). + blocking the SIP server. (There is kill.c but it is not used along with + the current mechanisms based on popen. Besides that kill.c is ugly). diff --git a/modules/exec/doc/exec_admin.xml b/modules/exec/doc/exec_admin.xml index 45ae097..0e933ab 100644 --- a/modules/exec/doc/exec_admin.xml +++ b/modules/exec/doc/exec_admin.xml @@ -13,7 +13,7 @@ <title>&adminguide;</title> - <section> + <section id="exec.overview"> <title>Overview</title> <para> The exec module allows external commands to be executed from a &kamailio; @@ -112,7 +112,7 @@ <section> <title>Parameters</title> - <section> + <section id="exec.p.setvars"> <title><varname>setvars</varname> (integer)</title> <para> Turn off to disable setting environment variables for executed commands. @@ -131,7 +131,7 @@ modparam("exec", "setvars", 1) </programlisting> </example> </section> - <section> + <section id="exec.p.time_to_kill"> <title> <varname>time_to_kill</varname> (integer) </title> @@ -156,7 +156,7 @@ modparam("exec", "time_to_kill", 20) </section> <section> <title>Functions</title> - <section> + <section id="exec.f.exec_dset"> <title> <function moreinfo="none">exec_dset(command)</function> </title> @@ -191,7 +191,7 @@ exec_dset("echo TEST > /tmp/$rU.txt"); </programlisting> </example> </section> - <section> + <section id="exec.f.exec_msg"> <title> <function moreinfo="none">exec_msg(command)</function> </title> @@ -230,7 +230,7 @@ exec_msg("echo TEST > /tmp/$rU.txt"); </programlisting> </example> </section> - <section> + <section id="exec.f.exec_avp"> <title> <function moreinfo="none">exec_avp(command [, avplist])</function> </title> @@ -271,11 +271,11 @@ exec_avp("echo TEST", "$avp(s:test)"); </example> </section> </section> - <section> + <section id="exec.known_issues"> <title>Known Issues</title> <para> There is currently no guarantee that scripts ever return and stop - blocking &sip; server. (There is kill.c but it is not used along with + blocking the &sip; server. (There is kill.c but it is not used along with the current mechanisms based on popen. Besides that kill.c is ugly). </para> </section>

1 0

[tracker] Task opened: tm.t_uac_wait does not use advertise address
by sip-router 26 Sep '14

26 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - tm.t_uac_wait does not use advertise address Task Type - Bug Report Category - tm Status - New Assigned To - Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - when listen line has advertise address, tm.t_uac_wait does not use it when it replaces !! strings in headers of outgoing request, for example, in contact uri. as result, sip proxy behind nat cannot be reached from outside using the uri. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=471 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: CANCEL sent shortly after '100 trying' response to INVITE does not always end the call
by sip-router 26 Sep '14

26 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#468 - CANCEL sent shortly after '100 trying' response to INVITE does not always end the call User who did this - Daniel-Constantin Mierla (miconda) ---------- I pushed a patch to detect if the transaction was canceled during execution of branch_route and skip forwarding the branches. - http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b66033d… If you can test and report back the results, then I will backport, provided all is ok. On the other hand, this INVITE-CANCEL-1xx race can happen even later. Like the process is losing the CPU just before writing the branch to the socket and the one that gets the CPU gets the CANCEL and processes it. In such case, the race will be caught later by one of the nodes (proxy, or even UA). The UA should be prepared to handle CANCEL races anyhow, a 200ok can be on the wire towards it at the moment it sends CANCEL. Due to network transmission delays, it is impossible to avoid such races. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=468#comment1650 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.1: dialog: fixed typo/ copy&paste oversight to dlg pointer name in clean routine
by Daniel-Constantin Mierla 26 Sep '14

26 Sep '14

Module: sip-router Branch: 4.1 Commit: a8427ce51f8b4a31fa122844db8ceec9c728a1ac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a8427ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 26 09:16:39 2014 +0200 dialog: fixed typo/copy&paste oversight to dlg pointer name in clean routine - credits to Alex Balshov for report, troubleshooting and spotting the fix (cherry picked from commit 8e6c83182677ec234c5f44c5dfcb40e421a21bcb) --- modules/dialog/dlg_hash.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 8b94b01..4284801 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -250,11 +250,11 @@ int dlg_clean_run(ticks_t ti) destroy_dlg(tdlg); } if(tdlg->state==DLG_STATE_CONFIRMED_NA && tdlg->start_ts<tm-60) { - if(update_dlg_timer(&dlg->tl, 10)<0) { + if(update_dlg_timer(&tdlg->tl, 10)<0) { LM_ERR("failed to update dialog lifetime in long non-ack state\n"); } - dlg->lifetime = 10; - dlg->dflags |= DLG_FLAG_CHANGED; + tdlg->lifetime = 10; + tdlg->dflags |= DLG_FLAG_CHANGED; } } lock_set_release(d_table->locks, d_table->entries[i].lock_idx);

1 0

git:master: dialog: fixed typo/ copy&paste oversight to dlg pointer name in clean routine
by Daniel-Constantin Mierla 26 Sep '14

26 Sep '14

Module: sip-router Branch: master Commit: 8e6c83182677ec234c5f44c5dfcb40e421a21bcb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8e6c831… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 26 09:16:39 2014 +0200 dialog: fixed typo/copy&paste oversight to dlg pointer name in clean routine - credits to Alex Balshov for report, troubleshooting and spotting the fix --- modules/dialog/dlg_hash.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 937f006..09166b8 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -250,11 +250,11 @@ int dlg_clean_run(ticks_t ti) destroy_dlg(tdlg); } if(tdlg->state==DLG_STATE_CONFIRMED_NA && tdlg->start_ts<tm-60) { - if(update_dlg_timer(&dlg->tl, 10)<0) { + if(update_dlg_timer(&tdlg->tl, 10)<0) { LM_ERR("failed to update dialog lifetime in long non-ack state\n"); } - dlg->lifetime = 10; - dlg->dflags |= DLG_FLAG_CHANGED; + tdlg->lifetime = 10; + tdlg->dflags |= DLG_FLAG_CHANGED; } } lock_set_release(d_table->locks, d_table->entries[i].lock_idx);

1 0

crash on dlg_clean_run
by Alex Balashov 26 Sep '14

26 Sep '14

I'm on the latest 4.1 clone and seem to occasionally run into this crash: #0 0x00007f7bd49e15ce in update_dlg_timer (tl=0x58, timeout=10) at dlg_timer.c:203 #1 0x00007f7bd49cf35a in dlg_clean_run (ti=73979985) at dlg_hash.c:253 #2 0x00007f7bd49b90ec in dlg_clean_timer_exec (ticks=73979985, param=0x0) at dialog.c:1246 #3 0x0000000000537091 in fork_sync_timer (child_id=-1, desc=0x7f7bd49ec431 "Dialog Clean Timer", make_sock=1, f=0x7f7bd49b90d3 <dlg_clean_timer_exec>, param=0x0, interval=90) at timer_proc.c:232 #4 0x00007f7bd49b5b7b in child_init (rank=0) at dialog.c:733 The address of 'tl' appears to be bogus; that doesn't look like a valid 64 bit vmem address to me. I'm investigating further to see if I can track it down, but I don't have much more information right now. -- Alex Balashov - Principal Evariste Systems LLC Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/ Please be kind to the English language: http://www.entrepreneur.com/article/232906

2 6

git:master: tm: extra checks to see if the transaction was canceled before forwarding branches
by Daniel-Constantin Mierla 26 Sep '14

26 Sep '14

Module: sip-router Branch: master Commit: b66033d0546bf57cfb0cd16f1072da80c5a79d34 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b66033d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 26 08:59:17 2014 +0200 tm: extra checks to see if the transaction was canceled before forwarding branches - catch cases when CANCEL arrives during branch_route execution - reported Sławomir Bocheński, FS#468 --- modules/tm/t_fwd.c | 26 +++++++++++++++++++------- 1 files changed, 19 insertions(+), 7 deletions(-) diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index 3903679..61b6e6a 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -1664,11 +1664,10 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , /* make -Wall happy */ current_uri.s=0; - if (t->flags & T_CANCELED){ - DBG("t_forward_non_ack: no forwarding on a canceled transaction\n"); - ser_error=E_CANCELED; - return -1; - } + getbflagsval(0, &backup_bflags); + + if (t->flags & T_CANCELED) goto canceled; + if (p_msg->REQ_METHOD==METHOD_CANCEL) { t_invite=t_lookupOriginalT( p_msg ); if (t_invite!=T_NULL_CELL) { @@ -1681,8 +1680,6 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , } } - getbflagsval(0, &backup_bflags); - /* if no more specific error code is known, use this */ lowest_ret=E_UNSPEC; /* branches added */ @@ -1727,6 +1724,8 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , p_msg->fwd_send_flags, proto, (p_msg->dst_uri.len)?0:UAC_SKIP_BR_DST_F, &p_msg->instance, &p_msg->ruid, &p_msg->location_ua); + /* test if cancel was received meanwhile */ + if (t->flags & T_CANCELED) goto canceled; if (branch_ret>=0) added_branches |= 1<<branch_ret; else @@ -1744,6 +1743,8 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , &path, proxy, si, p_msg->fwd_send_flags, proto, (dst_uri.len)?0:UAC_SKIP_BR_DST_F, &instance, &ruid, &location_ua); + /* test if cancel was received meanwhile */ + if (t->flags & T_CANCELED) goto canceled; /* pick some of the errors in case things go wrong; note that picking lowest error is just as good as any other algorithm which picks any other negative @@ -1817,6 +1818,17 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , ser_error=0; /* clear branch send errors, we have overall success */ set_kr(REQ_FWDED); return 1; + +canceled: + DBG("t_forward_non_ack: no forwarding on a canceled transaction\n"); + /* reset processed branches */ + clear_branches(); + /* restore backup flags from initial env */ + setbflagsval(0, backup_bflags); + /* update message flags, if changed in branch route */ + t->uas.request->flags = p_msg->flags; + ser_error=E_CANCELED; + return -1; }

1 0

git:master: call_control: Minor doc updates, adding section ID's
by Olle E. Johansson 26 Sep '14

26 Sep '14

Module: sip-router Branch: master Commit: 2328948053cfd3bfec0ceef0e3ceca96a01f3271 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2328948… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Fri Sep 26 08:35:13 2014 +0200 call_control: Minor doc updates, adding section ID's --- modules/call_control/README | 10 ++++---- modules/call_control/doc/call_control_admin.xml | 24 +++++++++++----------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/modules/call_control/README b/modules/call_control/README index bd9007b..66c6c01 100644 --- a/modules/call_control/README +++ b/modules/call_control/README @@ -172,7 +172,7 @@ Chapter 1. Admin Guide Boolean flag that specifies if callcontrol should be disabled. This is useful when you want to use the same Kamailio configuration in two - different context, one using callcontrol, the other not. In the case + different contexts, one using callcontrol, the other not. In the case callcontrol is disabled, calls to the call_control() function will return a code indicating that there is no limit associated with the call, allowing the use of the same configuration without changes. @@ -186,8 +186,8 @@ modparam("call_control", "disable", 1) 5.2. socket_name (string) - It is the path to the filesystem socket where the callcontrol - application listens for commands from the module. + The path to the filesystem socket where the callcontrol application + listens for commands from the module. Default value is "/var/run/callcontrol/socket". @@ -198,10 +198,10 @@ modparam("call_control", "socket_name", "/var/run/callcontrol/socket") 5.3. socket_timeout (int) - How much time (in milliseconds) to wait for an answer from the + How long time (in milliseconds) to wait for an answer from the callcontrol application. - Default value is "500" (ms). + Default value is "500" ms. Example 1.3. Setting the socket_timeout parameter ... diff --git a/modules/call_control/doc/call_control_admin.xml b/modules/call_control/doc/call_control_admin.xml index b3281db..bce0916 100644 --- a/modules/call_control/doc/call_control_admin.xml +++ b/modules/call_control/doc/call_control_admin.xml @@ -13,7 +13,7 @@ <title>&adminguide;</title> - <section> + <section id="call_control.overview"> <title>Overview</title> <para> This module allows one to limit the duration of calls and automatically @@ -164,12 +164,12 @@ <section> <title>Exported parameters</title> - <section> + <section id="call_control.p.disable"> <title><varname>disable</varname> (int)</title> <para> Boolean flag that specifies if callcontrol should be disabled. This is useful when you want to use the same &kamailio; configuration in - two different context, one using callcontrol, the other not. In the + two different contexts, one using callcontrol, the other not. In the case callcontrol is disabled, calls to the call_control() function will return a code indicating that there is no limit associated with the call, allowing the use of the same configuration without changes. @@ -191,10 +191,10 @@ modparam("call_control", "disable", 1) </example> </section> - <section> + <section id="call_control.p.socket_name"> <title><varname>socket_name</varname> (string)</title> <para> - It is the path to the filesystem socket where the callcontrol + The path to the filesystem socket where the callcontrol application listens for commands from the module. </para> @@ -215,16 +215,16 @@ modparam("call_control", "socket_name", "/var/run/callcontrol/socket") </example> </section> - <section> + <section id="call_control.p.socket_time"> <title><varname>socket_timeout</varname> (int)</title> <para> - How much time (in milliseconds) to wait for an answer from the + How long time (in milliseconds) to wait for an answer from the callcontrol application. </para> <para> <emphasis> - Default value is <quote>500</quote> (ms). + Default value is <quote>500</quote> ms. </emphasis> </para> @@ -238,7 +238,7 @@ modparam("call_control", "socket_timeout", 500) </example> </section> - <section> + <section id="call_control.p.signaling_ip_avp"> <title><varname>signaling_ip_avp</varname> (string)</title> <para> Specification of the AVP which holds the IP address from where @@ -278,7 +278,7 @@ modparam("call_control", "signaling_ip_avp", "$avp(s:signaling_ip)") </example> </section> - <section> + <section id="call_control.p.canonical_uri_avp"> <title><varname>canonical_uri_avp</varname> (string)</title> <para> Specification of the AVP which holds an optional application defined @@ -305,7 +305,7 @@ modparam("call_control", "canonical_uri_avp", "$avp(s:can_uri)") </example> </section> - <section> + <section id="call_control.p.diverter_avp_id"> <title><varname>diverter_avp_id</varname> (string)</title> <para> Specification of the id of an integer AVP which holds an optional @@ -351,7 +351,7 @@ route { <section> <title>Functions</title> - <section> + <section id="call_control.f.call_control"> <title><function moreinfo="none">call_control()</function></title> <para> Trigger the use of callcontrol for the dialog started by the INVITE

1 0

[tracker] Task closed: zombie dialogs in state 5
by sip-router 25 Sep '14

25 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#424 - zombie dialogs in state 5 User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=424 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
2
3
4
5
6
7
8
...
38
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2014