sr-dev January 2015

sr-dev@lists.kamailio.org

38 participants
530 discussions

by Alex Balashov

Hi, I am initiating lots of subscriptions (several thousand) using the pua_subscribe MI command exported by the pua_mi module: http://kamailio.org/docs/modules/4.2.x/modules/pua_mi.html#idp267208 The immediate issue I am having is that the From-tag and Call-ID are reused in multiple successive subscriptions--at least 10 to 20 out of my several thousand. When combined with PUA db_mode 2 (DB-backed) this is disastrous: Jan 24 14:50:28 sip /usr/local/sbin/kamailio[27986]: ERROR: db_mysql [km_dbase.c:123]: db_mysql_submit_query(): driver error on query: Duplicate entry '6e14fe38006106fb-14b28de6edf11d3914a0aa090636030d-b1f4' for key 'pua_idx' Jan 24 14:50:28 sip /usr/local/sbin/kamailio[27986]: ERROR: <core> [db_query.c:235]: db_do_insert_cmd(): error while submitting query Jan 24 14:50:28 sip /usr/local/sbin/kamailio[27986]: ERROR: pua [pua_db.c:1190]: insert_dialog_puadb(): DB insert failed This is because the 'pua' table has a UNIQUE constraint on a tuple of <tuple_id, etag, call_id, from_tag> in the schema definition: CREATE TABLE pua ( ... CONSTRAINT pua_idx UNIQUE (etag, tuple_id, call_id, from_tag) ); The 'etag' and 'tuple_id' values are empty strings (''), so the same call_id and from_tag cause this error. If I remove the unique constraint, other problems result that ultimately do not lead to correct management of the subscriptions in the 'pua' table: Jan 23 12:50:56 sip /usr/local/sbin/kamailio[12101]: ERROR: pua [pua_db.c:1263]: get_dialog_puadb(): Too many rows found (2)... deleting The From-tag and Call-ID is not unique in the SUBSCRIBEs generated by PUA. So, what I am wondering if there is a global option I can set for TM that leads to absolutely unique tags and Call-ID GUIDs in every case. Otherwise, I suspect the issue is that the random seeds used to generate the GUIDs are based on time(NULL) or something of that ilk, because this is not so much a problem if the subscriptions are spread out across the time domain. It's a problem that arises when I send several thousand pua_subscribe MI commands within 1-2 seconds. Thanks! -- Alex -- Alex Balashov - Principal Evariste Systems LLC 235 E Ponce de Leon Ave Suite 106 Decatur, GA 30030 United States Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/

9 years, 10 months

git:master:9596546c: jsonrpc-c Remove SVN ID

by Olle E. Johansson

Module: kamailio Branch: master Commit: 9596546c4eb5ae2e9b086cf3fe3e08337216d0f5 URL: https://github.com/kamailio/kamailio/commit/9596546c4eb5ae2e9b086cf3fe3e083… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-24T22:13:55+01:00 jsonrpc-c Remove SVN ID --- Modified: modules/jsonrpc-c/jsonrpc.c Modified: modules/jsonrpc-c/jsonrpc.h Modified: modules/jsonrpc-c/jsonrpc_io.c Modified: modules/jsonrpc-c/jsonrpc_io.h Modified: modules/jsonrpc-c/jsonrpc_mod.c Modified: modules/jsonrpc-c/jsonrpc_request.c Modified: modules/jsonrpc-c/jsonrpc_request.h Modified: modules/jsonrpc-c/netstring.c Modified: modules/jsonrpc-c/netstring.h --- Diff: https://github.com/kamailio/kamailio/commit/9596546c4eb5ae2e9b086cf3fe3e083… Patch: https://github.com/kamailio/kamailio/commit/9596546c4eb5ae2e9b086cf3fe3e083… --- diff --git a/modules/jsonrpc-c/jsonrpc.c b/modules/jsonrpc-c/jsonrpc.c index ce17f15..7baed54 100644 --- a/modules/jsonrpc-c/jsonrpc.c +++ b/modules/jsonrpc-c/jsonrpc.c @@ -1,5 +1,4 @@ -/** - * $Id$ +/* * * Copyright (C) 2011 Flowroute LLC (flowroute.com) * diff --git a/modules/jsonrpc-c/jsonrpc.h b/modules/jsonrpc-c/jsonrpc.h index 7780034..9aa0aeb 100644 --- a/modules/jsonrpc-c/jsonrpc.h +++ b/modules/jsonrpc-c/jsonrpc.h @@ -1,5 +1,4 @@ -/** - * $Id$ +/* * * Copyright (C) 2011 Flowroute LLC (flowroute.com) * diff --git a/modules/jsonrpc-c/jsonrpc_io.c b/modules/jsonrpc-c/jsonrpc_io.c index df61a31..188d2e6 100644 --- a/modules/jsonrpc-c/jsonrpc_io.c +++ b/modules/jsonrpc-c/jsonrpc_io.c @@ -1,5 +1,4 @@ -/** - * $Id$ +/* * * Copyright (C) 2011 Flowroute LLC (flowroute.com) * diff --git a/modules/jsonrpc-c/jsonrpc_io.h b/modules/jsonrpc-c/jsonrpc_io.h index 774af91..d5dd1b0 100644 --- a/modules/jsonrpc-c/jsonrpc_io.h +++ b/modules/jsonrpc-c/jsonrpc_io.h @@ -1,5 +1,4 @@ -/** - * $Id$ +/* * * Copyright (C) 2011 Flowroute LLC (flowroute.com) * diff --git a/modules/jsonrpc-c/jsonrpc_mod.c b/modules/jsonrpc-c/jsonrpc_mod.c index 0b27137..49c7162 100644 --- a/modules/jsonrpc-c/jsonrpc_mod.c +++ b/modules/jsonrpc-c/jsonrpc_mod.c @@ -1,5 +1,4 @@ -/** - * $Id$ +/* * * Copyright (C) 2011 Flowroute LLC (flowroute.com) * diff --git a/modules/jsonrpc-c/jsonrpc_request.c b/modules/jsonrpc-c/jsonrpc_request.c index 6a1b5b8..19dade8 100644 --- a/modules/jsonrpc-c/jsonrpc_request.c +++ b/modules/jsonrpc-c/jsonrpc_request.c @@ -1,6 +1,4 @@ -/** - * $Id$ -* +/* * Copyright (C) 2011 Flowroute LLC (flowroute.com) * * This file is part of Kamailio, a free SIP server. diff --git a/modules/jsonrpc-c/jsonrpc_request.h b/modules/jsonrpc-c/jsonrpc_request.h index 0aaacbc..4c77660 100644 --- a/modules/jsonrpc-c/jsonrpc_request.h +++ b/modules/jsonrpc-c/jsonrpc_request.h @@ -1,6 +1,4 @@ -/** - * $Id$ - * +/* * Copyright (C) 2011 Flowroute LLC (flowroute.com) * * This file is part of Kamailio, a free SIP server. diff --git a/modules/jsonrpc-c/netstring.c b/modules/jsonrpc-c/netstring.c index e65d8a5..6c668e4 100644 --- a/modules/jsonrpc-c/netstring.c +++ b/modules/jsonrpc-c/netstring.c @@ -1,6 +1,4 @@ -/** - * $Id$ - * +/* * Copyright (C) 2011 Flowroute LLC (flowroute.com) * * This file is part of Kamailio, a free SIP server. diff --git a/modules/jsonrpc-c/netstring.h b/modules/jsonrpc-c/netstring.h index 0c68fdf..9af5d3f 100644 --- a/modules/jsonrpc-c/netstring.h +++ b/modules/jsonrpc-c/netstring.h @@ -1,6 +1,4 @@ -/** - * $Id$ - * +/* * Copyright (C) 2011 Flowroute LLC (flowroute.com) * * This file is part of Kamailio, a free SIP server.

9 years, 10 months

git:4.1:7ec74722: dialog: use proper flags for script callback that clean dlg shortcuts

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.1 Commit: 7ec74722f6731539aa11db1f5a3322204c17694e URL: https://github.com/kamailio/kamailio/commit/7ec74722f6731539aa11db1f5a33222… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T18:47:34+01:00 dialog: use proper flags for script callback that clean dlg shortcuts (cherry picked from commit b0679c91f22a9eb9b995175b1d1abfb836a5a3f6) (cherry picked from commit 4fa400f262d2426a8a714ec65c5c88ec8e67f733) --- Modified: modules/dialog/dialog.c Modified: modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/7ec74722f6731539aa11db1f5a33222… Patch: https://github.com/kamailio/kamailio/commit/7ec74722f6731539aa11db1f5a33222… --- diff --git a/modules/dialog/dialog.c b/modules/dialog/dialog.c index 566eb0d..0bcaff5 100644 --- a/modules/dialog/dialog.c +++ b/modules/dialog/dialog.c @@ -639,17 +639,17 @@ static int mod_init(void) return -1; } - if (register_script_cb( spiral_detect_reset, POST_SCRIPT_CB|REQUEST_CB,0)<0) { + if (register_script_cb(spiral_detect_reset,POST_SCRIPT_CB|REQUEST_CB,0)<0) { LM_ERR("cannot register req pre-script spiral detection reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|ONREPLY_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|ONREPLY_CB,0)<0) { LM_ERR("cannot register reply post-script dlg locals reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|FAILURE_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|FAILURE_CB,0)<0) { LM_ERR("cannot register failure post-script dlg locals reset callback\n"); return -1; } diff --git a/modules/dialog/dlg_var.c b/modules/dialog/dlg_var.c index fd1e9b0..20a5968 100644 --- a/modules/dialog/dlg_var.c +++ b/modules/dialog/dlg_var.c @@ -78,7 +78,7 @@ int cb_dlg_cfg_reset(sip_msg_t *msg, unsigned int flags, void *cbp) int cb_dlg_locals_reset(sip_msg_t *msg, unsigned int flags, void *cbp) { - LM_DBG("resetting the local dialog shortcuts\n"); + LM_DBG("resetting the local dialog shortcuts on script callback: %u\n", flags); cb_dlg_cfg_reset(msg, flags, cbp); cb_profile_reset(msg, flags, cbp);

9 years, 10 months

git:4.1:6da6904f: dialog: removed end of line in middle of log message

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.1 Commit: 6da6904f02da3fa1ac9ac9527dce046ce0b39d35 URL: https://github.com/kamailio/kamailio/commit/6da6904f02da3fa1ac9ac9527dce046… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T18:47:24+01:00 dialog: removed end of line in middle of log message (cherry picked from commit 3b89c83bceb70da6fcbc9495dbcfec04e3f65ba4) (cherry picked from commit cd0e341cba059f43ac204a5d13e4baee9c5948f1) --- Modified: modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/6da6904f02da3fa1ac9ac9527dce046… Patch: https://github.com/kamailio/kamailio/commit/6da6904f02da3fa1ac9ac9527dce046… --- diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 39ff50e..b9ed0e9 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -710,7 +710,7 @@ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, if (match_dialog( dlg, callid, ftag, ttag, dir)==1) { ref_dlg_unsafe(dlg, 1); dlg_unlock( d_table, d_entry); - LM_DBG("dialog callid='%.*s' found\n on entry %u, dir=%d\n", + LM_DBG("dialog callid='%.*s' found on entry %u, dir=%d\n", callid->len, callid->s,h_entry,*dir); return dlg; }

9 years, 10 months

git:4.2:4fa400f2: dialog: use proper flags for script callback that clean dlg shortcuts

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: 4fa400f262d2426a8a714ec65c5c88ec8e67f733 URL: https://github.com/kamailio/kamailio/commit/4fa400f262d2426a8a714ec65c5c88e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T18:46:05+01:00 dialog: use proper flags for script callback that clean dlg shortcuts (cherry picked from commit b0679c91f22a9eb9b995175b1d1abfb836a5a3f6) --- Modified: modules/dialog/dialog.c Modified: modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/4fa400f262d2426a8a714ec65c5c88e… Patch: https://github.com/kamailio/kamailio/commit/4fa400f262d2426a8a714ec65c5c88e… --- diff --git a/modules/dialog/dialog.c b/modules/dialog/dialog.c index 58c40da..96bca17 100644 --- a/modules/dialog/dialog.c +++ b/modules/dialog/dialog.c @@ -621,17 +621,17 @@ static int mod_init(void) return -1; } - if (register_script_cb( spiral_detect_reset, POST_SCRIPT_CB|REQUEST_CB,0)<0) { + if (register_script_cb(spiral_detect_reset,POST_SCRIPT_CB|REQUEST_CB,0)<0) { LM_ERR("cannot register req pre-script spiral detection reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|ONREPLY_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|ONREPLY_CB,0)<0) { LM_ERR("cannot register reply post-script dlg locals reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|FAILURE_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|FAILURE_CB,0)<0) { LM_ERR("cannot register failure post-script dlg locals reset callback\n"); return -1; } diff --git a/modules/dialog/dlg_var.c b/modules/dialog/dlg_var.c index ccd316d..b3d4f05 100644 --- a/modules/dialog/dlg_var.c +++ b/modules/dialog/dlg_var.c @@ -78,7 +78,7 @@ int cb_dlg_cfg_reset(sip_msg_t *msg, unsigned int flags, void *cbp) int cb_dlg_locals_reset(sip_msg_t *msg, unsigned int flags, void *cbp) { - LM_DBG("resetting the local dialog shortcuts\n"); + LM_DBG("resetting the local dialog shortcuts on script callback: %u\n", flags); cb_dlg_cfg_reset(msg, flags, cbp); cb_profile_reset(msg, flags, cbp);

9 years, 10 months

git:4.2:cd0e341c: dialog: removed end of line in middle of log message

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: cd0e341cba059f43ac204a5d13e4baee9c5948f1 URL: https://github.com/kamailio/kamailio/commit/cd0e341cba059f43ac204a5d13e4bae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T18:45:52+01:00 dialog: removed end of line in middle of log message (cherry picked from commit 3b89c83bceb70da6fcbc9495dbcfec04e3f65ba4) --- Modified: modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/cd0e341cba059f43ac204a5d13e4bae… Patch: https://github.com/kamailio/kamailio/commit/cd0e341cba059f43ac204a5d13e4bae… --- diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 4ac2a34..0ca7d3d 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -710,7 +710,7 @@ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, if (match_dialog( dlg, callid, ftag, ttag, dir)==1) { ref_dlg_unsafe(dlg, 1); dlg_unlock( d_table, d_entry); - LM_DBG("dialog callid='%.*s' found\n on entry %u, dir=%d\n", + LM_DBG("dialog callid='%.*s' found on entry %u, dir=%d\n", callid->len, callid->s,h_entry,*dir); return dlg; }

9 years, 10 months

git:master:b0679c91: dialog: use proper flags for script callback that clean dlg shortcuts

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b0679c91f22a9eb9b995175b1d1abfb836a5a3f6 URL: https://github.com/kamailio/kamailio/commit/b0679c91f22a9eb9b995175b1d1abfb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T18:33:45+01:00 dialog: use proper flags for script callback that clean dlg shortcuts --- Modified: modules/dialog/dialog.c Modified: modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/b0679c91f22a9eb9b995175b1d1abfb… Patch: https://github.com/kamailio/kamailio/commit/b0679c91f22a9eb9b995175b1d1abfb… --- diff --git a/modules/dialog/dialog.c b/modules/dialog/dialog.c index 6f42faf..16328b0 100644 --- a/modules/dialog/dialog.c +++ b/modules/dialog/dialog.c @@ -615,17 +615,17 @@ static int mod_init(void) return -1; } - if (register_script_cb( spiral_detect_reset, POST_SCRIPT_CB|REQUEST_CB,0)<0) { + if (register_script_cb(spiral_detect_reset,POST_SCRIPT_CB|REQUEST_CB,0)<0) { LM_ERR("cannot register req pre-script spiral detection reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|ONREPLY_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|ONREPLY_CB,0)<0) { LM_ERR("cannot register reply post-script dlg locals reset callback\n"); return -1; } - if (register_script_cb( cb_dlg_locals_reset, POST_SCRIPT_CB|FAILURE_CB_TYPE,0)<0) { + if (register_script_cb(cb_dlg_locals_reset,POST_SCRIPT_CB|FAILURE_CB,0)<0) { LM_ERR("cannot register failure post-script dlg locals reset callback\n"); return -1; } diff --git a/modules/dialog/dlg_var.c b/modules/dialog/dlg_var.c index aeb9d97..b4f821e 100644 --- a/modules/dialog/dlg_var.c +++ b/modules/dialog/dlg_var.c @@ -83,7 +83,7 @@ int cb_dlg_cfg_reset(sip_msg_t *msg, unsigned int flags, void *cbp) int cb_dlg_locals_reset(sip_msg_t *msg, unsigned int flags, void *cbp) { - LM_DBG("resetting the local dialog shortcuts\n"); + LM_DBG("resetting the local dialog shortcuts on script callback: %u\n", flags); cb_dlg_cfg_reset(msg, flags, cbp); cb_profile_reset(msg, flags, cbp);

9 years, 10 months

git:master:3b89c83b: dialog: removed end of line in middle of log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3b89c83bceb70da6fcbc9495dbcfec04e3f65ba4 URL: https://github.com/kamailio/kamailio/commit/3b89c83bceb70da6fcbc9495dbcfec0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-24T12:25:26+01:00 dialog: removed end of line in middle of log message --- Modified: modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/3b89c83bceb70da6fcbc9495dbcfec0… Patch: https://github.com/kamailio/kamailio/commit/3b89c83bceb70da6fcbc9495dbcfec0… --- diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 134626a..1c42bed 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -689,7 +689,7 @@ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, if (match_dialog( dlg, callid, ftag, ttag, dir)==1) { ref_dlg_unsafe(dlg, 1); dlg_unlock( d_table, d_entry); - LM_DBG("dialog callid='%.*s' found\n on entry %u, dir=%d\n", + LM_DBG("dialog callid='%.*s' found on entry %u, dir=%d\n", callid->len, callid->s,h_entry,*dir); return dlg; }

9 years, 10 months

git:4.2:96c44ab3: kazoo : fix memory allocation errors

by Luis Azedo

Module: kamailio Branch: 4.2 Commit: 96c44ab31df9cc1a4400ad16515191332ef767fc URL: https://github.com/kamailio/kamailio/commit/96c44ab31df9cc1a4400ad165151913… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-01-23T23:54:59Z kazoo : fix memory allocation errors (cherry picked from commit fa5468c24283c8ff0a1b2254e927a128d03137fd) --- Modified: modules/kazoo/kazoo.c Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_trans.c Modified: modules/kazoo/kz_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/96c44ab31df9cc1a4400ad165151913… Patch: https://github.com/kamailio/kamailio/commit/96c44ab31df9cc1a4400ad165151913…

9 years, 10 months

git:master:fa5468c2: kazoo : fix memory allocation errors

by Luis Azedo

Module: kamailio Branch: master Commit: fa5468c24283c8ff0a1b2254e927a128d03137fd URL: https://github.com/kamailio/kamailio/commit/fa5468c24283c8ff0a1b2254e927a12… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-01-23T23:52:57Z kazoo : fix memory allocation errors --- Modified: modules/kazoo/kazoo.c Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_trans.c Modified: modules/kazoo/kz_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/fa5468c24283c8ff0a1b2254e927a12… Patch: https://github.com/kamailio/kamailio/commit/fa5468c24283c8ff0a1b2254e927a12…

9 years, 10 months

← Newer
1
...
9
10
11
12
13
14
15
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2015