sr-dev January 2015

sr-dev@lists.kamailio.org

38 participants
531 discussions

git:4.2:d08a9258: exec: proper handling of empty headers for exec_bash_safety
by Daniel-Constantin Mierla 13 Jan '15

13 Jan '15

Module: kamailio Branch: 4.2 Commit: d08a925872aa9bb2b22552171281cbe18783cbef URL: https://github.com/kamailio/kamailio/commit/d08a925872aa9bb2b22552171281cbe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-13T12:41:05+01:00 exec: proper handling of empty headers for exec_bash_safety (cherry picked from commit ae491ab355f0b2441bc20060154107b9163597de) --- Modified: modules/exec/exec_hf.c --- Diff: https://github.com/kamailio/kamailio/commit/d08a925872aa9bb2b22552171281cbe… Patch: https://github.com/kamailio/kamailio/commit/d08a925872aa9bb2b22552171281cbe… --- diff --git a/modules/exec/exec_hf.c b/modules/exec/exec_hf.c index bed4541..bbdbaaf 100644 --- a/modules/exec/exec_hf.c +++ b/modules/exec/exec_hf.c @@ -258,8 +258,8 @@ static int print_hf_var(struct hf_wrapper *w, int offset) memcpy(envvar, w->prefix, w->prefix_len); c=envvar+w->prefix_len; memcpy(c, hname, hlen ); c+=hlen; *c=EV_ASSIGN;c++; - if (exec_bash_safety && !strncmp(w->u.hf->body.s, "() {", - MIN(w->u.hf->body.len,4))) { + if (exec_bash_safety && w->u.hf->body.len>=4 + && !strncmp(w->u.hf->body.s, "() {", 4)) { memcpy(c, w->u.hf->body.s+offset+2, w->u.hf->body.len-2 ); c+=(w->u.hf->body.len-2); } else { @@ -268,8 +268,8 @@ static int print_hf_var(struct hf_wrapper *w, int offset) } for(wi=w->next_same; wi; wi=wi->next_same) { *c=HF_SEPARATOR;c++; - if (exec_bash_safety && !strncmp(wi->u.hf->body.s, "() {", - MIN(w->u.hf->body.len,4))) { + if (exec_bash_safety && wi->u.hf->body.len>=4 + && !strncmp(wi->u.hf->body.s, "() {", 4)) { memcpy(c, wi->u.hf->body.s+offset+2, wi->u.hf->body.len-2 ); c+=(wi->u.hf->body.len-2); } else {

1 0

git:master:ae491ab3: exec: proper handling of empty headers for exec_bash_safety
by Daniel-Constantin Mierla 13 Jan '15

13 Jan '15

Module: kamailio Branch: master Commit: ae491ab355f0b2441bc20060154107b9163597de URL: https://github.com/kamailio/kamailio/commit/ae491ab355f0b2441bc20060154107b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-13T12:39:10+01:00 exec: proper handling of empty headers for exec_bash_safety --- Modified: modules/exec/exec_hf.c --- Diff: https://github.com/kamailio/kamailio/commit/ae491ab355f0b2441bc20060154107b… Patch: https://github.com/kamailio/kamailio/commit/ae491ab355f0b2441bc20060154107b… --- diff --git a/modules/exec/exec_hf.c b/modules/exec/exec_hf.c index 2ada14a..c20c265 100644 --- a/modules/exec/exec_hf.c +++ b/modules/exec/exec_hf.c @@ -256,8 +256,8 @@ static int print_hf_var(struct hf_wrapper *w, int offset) memcpy(envvar, w->prefix, w->prefix_len); c=envvar+w->prefix_len; memcpy(c, hname, hlen ); c+=hlen; *c=EV_ASSIGN;c++; - if (exec_bash_safety && !strncmp(w->u.hf->body.s, "() {", - MIN(w->u.hf->body.len,4))) { + if (exec_bash_safety && w->u.hf->body.len>=4 + && !strncmp(w->u.hf->body.s, "() {", 4)) { memcpy(c, w->u.hf->body.s+offset+2, w->u.hf->body.len-2 ); c+=(w->u.hf->body.len-2); } else { @@ -266,8 +266,8 @@ static int print_hf_var(struct hf_wrapper *w, int offset) } for(wi=w->next_same; wi; wi=wi->next_same) { *c=HF_SEPARATOR;c++; - if (exec_bash_safety && !strncmp(wi->u.hf->body.s, "() {", - MIN(w->u.hf->body.len,4))) { + if (exec_bash_safety && wi->u.hf->body.len>=4 + && !strncmp(wi->u.hf->body.s, "() {", 4)) { memcpy(c, wi->u.hf->body.s+offset+2, wi->u.hf->body.len-2 ); c+=(wi->u.hf->body.len-2); } else {

1 0

topoh and locally-generated requests
by Alex Balashov 13 Jan '15

13 Jan '15

Hello, I have found that topoh does not seem to operate correctly on locally-generated requests, such as dialog timeout-fired BYEs. e.g. Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10357]: INFO: [R-TM-LOCAL-REQUEST:1-4289383-6930886-1692777-3284@127.0.1.1] Local request BYE to sip:sipp@127.0.1.1:5060 Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10357]: INFO: [R-TM-LOCAL-REQUEST:1-4289383-6930886-1692777-3284@127.0.1.1] Local request BYE to sip:172.30.110.5:5060;transport=UDP Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10348]: ERROR: topoh [th_mask.c:165]: th_mask_decode(): invalid input string"1-4289383-6930886-1692777-3284(a)127.0.1.1" Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10348]: ERROR: topoh [th_msg.c:484]: th_unmask_callid(): cannot decode callid You can see these BYEs are not TOPOH'd at all: 17:23:34.097128 IP 172.30.110.4.sip > 127.0.1.1.sip: SIP, length: 346 E..v....@.?]..n..........b..BYE sip:sipp@127.0.1.1:5060 SIP/2.0 Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bK00ac.30df1375000000000000000000000000.0 To: <sip:4916095083616@127.0.1.1:5060>;tag=3287SIPpTag001 From: <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 CSeq: 1 BYE Call-ID: 1-4289383-6930886-1692777-3287(a)127.0.1.1 Content-Length: 0 Max-Forwards: 70 17:23:34.097239 IP 172.30.110.4.sip > 172.30.110.5.sip: SIP, length: 358 E.......@.V...n...n......n5.BYE sip:172.30.110.5:5060;transport=UDP SIP/2.0 Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bKdf9c.08ed9677000000000000000000000000.0 To: <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 From: <sip:4916095083616@127.0.1.1:5060>;tag=3287SIPpTag001 CSeq: 2 BYE Call-ID: 1-4289383-6930886-1692777-3287(a)127.0.1.1 Content-Length: 0 Max-Forwards: 70 in contrast to the other messages in this dialog: 7:23:30.871062 IP 172.30.110.5.sip > 172.30.110.4.sip: SIP, length: 844 E..h!5@.@.. ..n...n......Th.SIP/2.0 200 OK Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bK00ac.127fd0993a0e4c8a82474038472e09d2.0, SIP/2.0/UDP 172.30.110.4;branch=z9hG4bKsr-goq-nEDchKUa9vuehzD2nruchwxHmrgFJru63LarksqBks-Uhz3WnrhFnrPHhKxWmd9D0s97YrRS3LvcjBeUXrqi9E9SwWoEhre2nzPRhu** From: sipp <sip:4916095083616@172.30.110.4>;tag=3287SIPpTag001 To: 17069950290 <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 Call-ID: CSEVhwoohreOhEeEnzjOhEuxmGjRhzjOhr32JWoEhre2-GPWJWxFnrPch-** Record-Route: <sip:172.30.110.4;lr=on;ftag=3287SIPpTag001;fromcor=ejFwbUZxUmpUUFNBejFwbUZxUm9RUFBfZS5wZ111ZFo-;dlgcor=9c9.77a1> CSeq: 1 INVITE Contact: <sip:172.30.110.5:5060;transport=UDP> Content-Type: application/sdp Content-Length: 135 v=0 o=user1 53655765 2353687637 IN IP4 172.30.110.5 s=- c=IN IP4 172.30.110.5 t=0 0 m=audio 6000 RTP/AVP 0 a=rtpmap:0 PCMU/8000 Maybe this is not possible to fix because of where topoh intercepts the messages (transparently to the config script writer) in relation to how the TM API is used to generate spoof requests. I just thought I would report it. -- Alex Balashov - Principal Evariste Systems LLC 235 E Ponce de Leon Ave Suite 106 Decatur, GA 30030 United States Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/

2 2

[kamailio] ERROR: topoh th_mask_decode(): invalid input string"1-4289383-6930886-1692777-3284@127.0.1.1" (#15)
by klistrod 13 Jan '15

13 Jan '15

Hello, I have found that topoh does not seem to operate correctly on locally-generated requests, such as dialog timeout-fired BYEs. e.g. Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10357]: INFO: [R-TM-LOCAL-REQUEST:1-4289383-6930886-1692777-3284@127.0.1.1] Local request BYE to sip:sipp@127.0.1.1:5060 Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10357]: INFO: [R-TM-LOCAL-REQUEST:1-4289383-6930886-1692777-3284@127.0.1.1] Local request BYE to sip:172.30.110.5:5060;transport=UDP Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10348]: ERROR: topoh [th_mask.c:165]: th_mask_decode(): invalid input string"1-4289383-6930886-1692777-3284(a)127.0.1.1" Nov 17 17:20:16 centosity6 /usr/local/sbin/kamailio[10348]: ERROR: topoh [th_msg.c:484]: th_unmask_callid(): cannot decode callid You can see these BYEs are not TOPOH'd at all: 17:23:34.097128 IP 172.30.110.4.sip > 127.0.1.1.sip: SIP, length: 346 E..v....@.?]..n..........b..BYE sip:sipp@127.0.1.1:5060 SIP/2.0 Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bK00ac.30df1375000000000000000000000000.0 To: <sip:4916095083616@127.0.1.1:5060>;tag=3287SIPpTag001 From: <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 CSeq: 1 BYE Call-ID: 1-4289383-6930886-1692777-3287(a)127.0.1.1 Content-Length: 0 Max-Forwards: 70 17:23:34.097239 IP 172.30.110.4.sip > 172.30.110.5.sip: SIP, length: 358 E.......@.V...n...n......n5.BYE sip:172.30.110.5:5060;transport=UDP SIP/2.0 Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bKdf9c.08ed9677000000000000000000000000.0 To: <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 From: <sip:4916095083616@127.0.1.1:5060>;tag=3287SIPpTag001 CSeq: 2 BYE Call-ID: 1-4289383-6930886-1692777-3287(a)127.0.1.1 Content-Length: 0 Max-Forwards: 70 in contrast to the other messages in this dialog: 7:23:30.871062 IP 172.30.110.5.sip > 172.30.110.4.sip: SIP, length: 844 E..h!5@.@.. ..n...n......Th.SIP/2.0 200 OK Via: SIP/2.0/UDP 172.30.110.4;branch=z9hG4bK00ac.127fd0993a0e4c8a82474038472e09d2.0, SIP/2.0/UDP 172.30.110.4;branch=z9hG4bKsr-goq-nEDchKUa9vuehzD2nruchwxHmrgFJru63LarksqBks-Uhz3WnrhFnrPHhKxWmd9D0s97YrRS3LvcjBeUXrqi9E9SwWoEhre2nzPRhu** From: sipp <sip:4916095083616@172.30.110.4>;tag=3287SIPpTag001 To: 17069950290 <sip:17069950290@172.30.110.4:5060>;tag=2117SIPpTag015 Call-ID: CSEVhwoohreOhEeEnzjOhEuxmGjRhzjOhr32JWoEhre2-GPWJWxFnrPch-** Record-Route: <sip:172.30.110.4;lr=on;ftag=3287SIPpTag001;fromcor=ejFwbUZxUmpUUFNBejFwbUZxUm9RUFBfZS5wZ111ZFo-;dlgcor=9c9.77a1> CSeq: 1 INVITE Contact: <sip:172.30.110.5:5060;transport=UDP> Content-Type: application/sdp Content-Length: 135 v=0 o=user1 53655765 2353687637 IN IP4 172.30.110.5 s=- c=IN IP4 172.30.110.5 t=0 0 m=audio 6000 RTP/AVP 0 a=rtpmap:0 PCMU/8000 Maybe this is not possible to fix because of where topoh intercepts the messages (transparently to the config script writer) in relation to how the TM API is used to generate spoof requests. I just thought I would report it. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/15

3 6

[kamailio] FreeBSD port of 4.2.2 kamailio, small issues (#24)
by pi 13 Jan '15

13 Jan '15

FYI, in https://lists.freebsd.org/pipermail/svn-ports-all/2015-January/082830.html you can see the changes required to get kamailio 4.2.2 build as the freebsd port. Can you integrate those changes upstream ? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/24

2 10

git:4.2:f0159a19: ratelimit: _SC_NPROCESSORS_ONLN is available on FreeBSD
by Daniel-Constantin Mierla 13 Jan '15

13 Jan '15

Module: kamailio Branch: 4.2 Commit: f0159a194a8ac0c0f5599867764d447ef2b5bf45 URL: https://github.com/kamailio/kamailio/commit/f0159a194a8ac0c0f5599867764d447… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-13T11:27:46+01:00 ratelimit: _SC_NPROCESSORS_ONLN is available on FreeBSD - used for getting number of cpus - reported on GH#24 (cherry picked from commit 7886ddc516f5a4cef1d3730306a2a2ded06d4986) --- Modified: modules/ratelimit/ratelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/f0159a194a8ac0c0f5599867764d447… Patch: https://github.com/kamailio/kamailio/commit/f0159a194a8ac0c0f5599867764d447… --- diff --git a/modules/ratelimit/ratelimit.c b/modules/ratelimit/ratelimit.c index 561185f..2770822 100644 --- a/modules/ratelimit/ratelimit.c +++ b/modules/ratelimit/ratelimit.c @@ -293,7 +293,7 @@ static int str_cpy(str * dest, str * src) return 0; } -#if defined (__OS_darwin) || defined (__OS_freebsd) +#ifdef __OS_darwin #include <sys/param.h> #include <sys/sysctl.h> #else @@ -303,7 +303,7 @@ static int str_cpy(str * dest, str * src) int get_num_cpus() { int count = 0; -#if defined (__OS_darwin) || defined (__OS_freebsd) +#ifdef __OS_darwin int nm[2]; size_t len;

1 0

git:4.2:a711f12d: pipelimit: _SC_NPROCESSORS_ONLN is available on FreeBSD
by Daniel-Constantin Mierla 13 Jan '15

13 Jan '15

Module: kamailio Branch: 4.2 Commit: a711f12d5f4b48b3ccf385492d4c93ace7db515c URL: https://github.com/kamailio/kamailio/commit/a711f12d5f4b48b3ccf385492d4c93a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-13T11:27:35+01:00 pipelimit: _SC_NPROCESSORS_ONLN is available on FreeBSD - used for getting number of cpus - reported on GH#24 (cherry picked from commit cf65a6ad41396bf5e67d23e12720c420688d7880) --- Modified: modules/pipelimit/pipelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/a711f12d5f4b48b3ccf385492d4c93a… Patch: https://github.com/kamailio/kamailio/commit/a711f12d5f4b48b3ccf385492d4c93a… --- diff --git a/modules/pipelimit/pipelimit.c b/modules/pipelimit/pipelimit.c index b966fc5..882c205 100644 --- a/modules/pipelimit/pipelimit.c +++ b/modules/pipelimit/pipelimit.c @@ -182,7 +182,7 @@ struct module_exports exports= { }; -#if defined (__OS_darwin) || defined (__OS_freebsd) +#ifdef __OS_darwin #include <sys/param.h> #include <sys/sysctl.h> #else @@ -192,7 +192,7 @@ struct module_exports exports= { int get_num_cpus() { int count = 0; -#if defined (__OS_darwin) || defined (__OS_freebsd) +#ifdef __OS_darwin int nm[2]; size_t len;

1 0

Fwd: listening to specific interface with ip
by Jijo 13 Jan '15

13 Jan '15

HI All. I know that kamailio support listen on an interface with port (listen = eth0:5060). Does it support listen on an interface with ip, port, transport? For example listen=eth0: udp:10.10.10.10:5060 Thanks Jijo

2 3

git:master:55393719: Merge pull request #28 from seudin/siputil_fix
by Victor Seva 12 Jan '15

12 Jan '15

Module: kamailio Branch: master Commit: 55393719873b39c3fe66689539e35cf6c8969abe URL: https://github.com/kamailio/kamailio/commit/55393719873b39c3fe66689539e35cf… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-01-12T22:21:33+01:00 Merge pull request #28 from seudin/siputil_fix siputils: fix for e164_check() Closes #28 --- Modified: modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/55393719873b39c3fe66689539e35cf… Patch: https://github.com/kamailio/kamailio/commit/55393719873b39c3fe66689539e35cf… --- diff --git a/modules/siputils/checks.c b/modules/siputils/checks.c index 76ab43d..9a53010 100644 --- a/modules/siputils/checks.c +++ b/modules/siputils/checks.c @@ -417,7 +417,7 @@ static inline int e164_check(str* _user) char c; if ((_user->len > 2) && (_user->len < 17) && ((_user->s)[0] == '+')) { - for (i = 1; i <= _user->len; i++) { + for (i = 1; i < _user->len; i++) { c = (_user->s)[i]; if (c < '0' || c > '9') return -1; }

1 0

git:master:160710af: siputils: fix for e164_check()
by Seudin Kasumovic 12 Jan '15

12 Jan '15

Module: kamailio Branch: master Commit: 160710af0ab85dbf211fa7d445d6d4be9b66db10 URL: https://github.com/kamailio/kamailio/commit/160710af0ab85dbf211fa7d445d6d4b… Author: Seudin Kasumovic <seudin.kasumovic(a)gmail.com> Committer: Seudin Kasumovic <seudin.kasumovic(a)gmail.com> Date: 2015-01-12T16:24:04+01:00 siputils: fix for e164_check() - the condition for non-digit matching was always false --- Modified: modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/160710af0ab85dbf211fa7d445d6d4b… Patch: https://github.com/kamailio/kamailio/commit/160710af0ab85dbf211fa7d445d6d4b… --- diff --git a/modules/siputils/checks.c b/modules/siputils/checks.c index 76ab43d..9a53010 100644 --- a/modules/siputils/checks.c +++ b/modules/siputils/checks.c @@ -417,7 +417,7 @@ static inline int e164_check(str* _user) char c; if ((_user->len > 2) && (_user->len < 17) && ((_user->s)[0] == '+')) { - for (i = 1; i <= _user->len; i++) { + for (i = 1; i < _user->len; i++) { c = (_user->s)[i]; if (c < '0' || c > '9') return -1; }

1 0

← Newer
1
...
25
26
27
28
29
30
31
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2015