THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#141 - Uninitialized $var returns 0 instead of <null>
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Implemented
Additional comments about closing: Implemented as $vn(name).
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=141
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Hello,
here I am proposing some items for removing from the source code, to
keep it cleaner:
- $Id$ or the other SVN expandable tokens - they are svn specific, some
of them even included expanded. Typical location is at the beginning of
the file. They are useless now or very old (when expanded)
- the 'history' section in source code - typical location is after
license at the beginning of the source code files. Used mainly during
CVS times, the content is very old (even more than 10 years) and in many
cases misleading now. If there is something relevant, we can discuss and
eventually move as comments to functions or parts of the code. We have
no proper commit logs and git blame is helping to track what is current
in the code
- git branches that were merged or very old (no longer suitable for merging)
If there is something else that should be part of this process, just
name it here.
This is not going to happen quickly (although it would be good) and it
is addressed here to make the developed aware, when they work on a file
or have spare time ( :-) ), to consider removing those parts.
I would prefer to be a dedicated commit (can be for many files at once,
but not across components -- e.g., one commit for a module, not mixing
for many modules or modules+core+libs ...), to be easy to check it
doesn't break the code.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Hello,
is there any doc presenting when Travis CI (from github) is doing the
notifications? Or, maybe someone familiar with the system can provide
more details.
I see it is sent for pull requests and commits to new branches. Maybe we
can limit to get those notifications only for the official branches,
either from some config or a filter on our email server, otherwise it
may create a lot of noise.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda