sr-dev October 2015

sr-dev@lists.kamailio.org

28 participants
236 discussions

[kamailio] Makefile.radius : about radius library selection (#354)

by Yasin

Hello; Makefile selects wrong radius library on make and then gives error. Makefile always select radiusclient-ng even if freeradius-client has been installed.i am not good at Makefile s so could you check Makefile.radius . ---------------- ERROR ------------- CC (gcc) [M acc_radius.so] acc_radius_mod.o In file included from acc_radius_mod.c:44: ../../lib/kcore/radius.h:35:30: warning: radiusclient-ng.h: No such file or directory acc_radius_mod.c: In function âinit_acc_radâ: acc_radius_mod.c:264: warning: implicit declaration of function ârc_read_configâ ------------------------------------ --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/354

9 years, 1 month

[kamailio] Latest 4.3.3 commit e275bc fails to write cdr (acc module) (#359)

by MayamaTakeshi

This is an intermittent problem (it doesn't happen all the time). Version: ``` [root@lab002189-flip-server install]# kamctl fifo version Server:: kamailio (4.3.3 (x86_64/linux)) Build:: mi_core.c compiled on 17:06:31 Oct 5 2015 with gcc 4.4.7 Flags:: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES GIT:: e275bc ``` Full log: ``` [root@lab002189-flip-server install]# cat /var/log/kamailio/kamailio.log 2015-10-06T06:50:44.443018+09:00 lab002189-flip-server /usr/local/src/git/kamailio-4.3/kamailio[6126]: WARNING: dispatcher [dispatch.c:792]: ds_load_db(): no dispatching data in the db -- empty destination set 2015-10-06T06:50:56.409999+09:00 lab002189-flip-server /usr/local/src/git/kamailio-4.3/kamailio[6110]: ERROR: acc [acc_cdr.c:199]: db_write_cdr(): failed to convert string to double - 111. 2015-10-06T06:50:56.410019+09:00 lab002189-flip-server /usr/local/src/git/kamailio-4.3/kamailio[6110]: ERROR: acc [acc_cdr.c:636]: cdr_on_failed(): failed to write cdr! ``` The code is this in modules/acc/acc_cdr.c: ``` case TYPE_DOUBLE: VAL_TYPE(db_cdr_vals+i)=DB1_DOUBLE; VAL_NULL(db_cdr_vals+i)=0; double_val = strtod(cdr_value_array[i].s, &end); if(errno && (errno != EAGAIN)) { LM_ERR("failed to convert string to double - %d.\n", errno); goto error; } VAL_DOUBLE(db_cdr_vals+i) = double_val; break; ``` The value errno=111 (ECONNREFUSED) doesn't make sense for strtod so i understand the problem is that the errno is not being zeroed before entering the loop that processes the cdr data, so errno is being set somewhere else, strtod is successful but the errno check fails. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/359

9 years, 1 month

git:4.3:b7678a7c: acc: reset errno for converting numbers for cdr generation

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: b7678a7c920f82ab23e495e76db99d7b2457395e URL: https://github.com/kamailio/kamailio/commit/b7678a7c920f82ab23e495e76db99d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-06T00:35:07+02:00 acc: reset errno for converting numbers for cdr generation - reported by Mayama Takeshi, GH#359 (cherry picked from commit caf477104c90049bf0c5e163d7eff89111448776) --- Modified: modules/acc/acc_cdr.c --- Diff: https://github.com/kamailio/kamailio/commit/b7678a7c920f82ab23e495e76db99d7… Patch: https://github.com/kamailio/kamailio/commit/b7678a7c920f82ab23e495e76db99d7… --- diff --git a/modules/acc/acc_cdr.c b/modules/acc/acc_cdr.c index d5b16e3..73bdd45 100644 --- a/modules/acc/acc_cdr.c +++ b/modules/acc/acc_cdr.c @@ -163,6 +163,8 @@ static int db_write_cdr( struct dlg_cell* dialog, for(i=0; i<m; i++) { db_cdr_keys[i] = &cdr_attrs[i]; + /* reset errno, some strtoX don't reset it */ + errno = 0; switch(cdr_type_array[i]) { case TYPE_NULL: VAL_NULL(db_cdr_vals+i)=1;

9 years, 1 month

Failed to suspend processing error

by M S

Hi, I have upgraded to Kamailio v4.3.3 rev. e275bc on my test server running debian wheezy 32 bit and getting this error, -- ERROR: async [async_sleep.c:248]: async_send_task(): failed to suspend the processing -- Basically, I am running a sql query in script which if returns any records then i suspend the transaction with "async_task_route" to process data returned by query later on. The problem happens when this "async_task_route" method is executed. This is old code which was working perfectly fine with Kamailio v4.3.2 and it only gives error after the upgrade to v4.3.3. Please help. Thank you.

9 years, 1 month

git:master:caf47710: acc: reset errno for converting numbers for cdr generation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: caf477104c90049bf0c5e163d7eff89111448776 URL: https://github.com/kamailio/kamailio/commit/caf477104c90049bf0c5e163d7eff89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-06T00:29:38+02:00 acc: reset errno for converting numbers for cdr generation - reported by Mayama Takeshi, GH#359 --- Modified: modules/acc/acc_cdr.c --- Diff: https://github.com/kamailio/kamailio/commit/caf477104c90049bf0c5e163d7eff89… Patch: https://github.com/kamailio/kamailio/commit/caf477104c90049bf0c5e163d7eff89… --- diff --git a/modules/acc/acc_cdr.c b/modules/acc/acc_cdr.c index d5b16e3..73bdd45 100644 --- a/modules/acc/acc_cdr.c +++ b/modules/acc/acc_cdr.c @@ -163,6 +163,8 @@ static int db_write_cdr( struct dlg_cell* dialog, for(i=0; i<m; i++) { db_cdr_keys[i] = &cdr_attrs[i]; + /* reset errno, some strtoX don't reset it */ + errno = 0; switch(cdr_type_array[i]) { case TYPE_NULL: VAL_NULL(db_cdr_vals+i)=1;

9 years, 1 month

git:master:2db0d8da: acc_radius doc: information about freeradius-client

by Yasin

Module: kamailio Branch: master Commit: 2db0d8da92aed22ebddc4df79e6f472a0284298a URL: https://github.com/kamailio/kamailio/commit/2db0d8da92aed22ebddc4df79e6f472… Author: Yasin <yasin.caner(a)netgsm.com.tr> Committer: Yasin <yasin.caner(a)netgsm.com.tr> Date: 2015-10-05T17:54:03+03:00 acc_radius doc: information about freeradius-client Added some information for freeradius-client to acc documents. radiusclient-ng website isn't avaible so is removed. --- Modified: modules/acc_radius/doc/acc_radius_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2db0d8da92aed22ebddc4df79e6f472… Patch: https://github.com/kamailio/kamailio/commit/2db0d8da92aed22ebddc4df79e6f472… --- diff --git a/modules/acc_radius/doc/acc_radius_admin.xml b/modules/acc_radius/doc/acc_radius_admin.xml index c0e4fac..17ebd2c 100644 --- a/modules/acc_radius/doc/acc_radius_admin.xml +++ b/modules/acc_radius/doc/acc_radius_admin.xml @@ -50,10 +50,18 @@ </para> <itemizedlist> <listitem> - <para><emphasis>radiusclient-ng</emphasis> 0.5.0 or higher. + <para><emphasis>radiusclient-ng</emphasis> 0.5.0 or freeradius-client + or higher. See <ulink - url='http://developer.berlios.de/projects/radiusclient-ng/'> - http://developer.berlios.de/projects/radiusclient-ng/</ulink>. + url='https://github.com/FreeRADIUS/freeradius-client/'> + https://github.com/FreeRADIUS/freeradius-client/</ulink>. + </para> + </listitem> + <listitem> + <para> + <emphasis>freeradius-client</emphasis> library can be used after + setting FREERADIUS variable in source code with + <emphasis>'export FREERADIUS=1'</emphasis> before compile. </para> </listitem> </itemizedlist>

9 years, 1 month

git:master:3ad2e31d: Merge pull request #356 from ycaner06/patch-3

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3ad2e31dbd8fe37ad0d330655561b943eb0accdb URL: https://github.com/kamailio/kamailio/commit/3ad2e31dbd8fe37ad0d330655561b94… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-05T19:18:21+02:00 Merge pull request #356 from ycaner06/patch-3 acc_radius doc: information about freeradius-client --- Modified: modules/acc_radius/doc/acc_radius_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/3ad2e31dbd8fe37ad0d330655561b94… Patch: https://github.com/kamailio/kamailio/commit/3ad2e31dbd8fe37ad0d330655561b94… --- diff --git a/modules/acc_radius/doc/acc_radius_admin.xml b/modules/acc_radius/doc/acc_radius_admin.xml index c0e4fac..17ebd2c 100644 --- a/modules/acc_radius/doc/acc_radius_admin.xml +++ b/modules/acc_radius/doc/acc_radius_admin.xml @@ -50,10 +50,18 @@ </para> <itemizedlist> <listitem> - <para><emphasis>radiusclient-ng</emphasis> 0.5.0 or higher. + <para><emphasis>radiusclient-ng</emphasis> 0.5.0 or freeradius-client + or higher. See <ulink - url='http://developer.berlios.de/projects/radiusclient-ng/'> - http://developer.berlios.de/projects/radiusclient-ng/</ulink>. + url='https://github.com/FreeRADIUS/freeradius-client/'> + https://github.com/FreeRADIUS/freeradius-client/</ulink>. + </para> + </listitem> + <listitem> + <para> + <emphasis>freeradius-client</emphasis> library can be used after + setting FREERADIUS variable in source code with + <emphasis>'export FREERADIUS=1'</emphasis> before compile. </para> </listitem> </itemizedlist>

9 years, 1 month

[kamailio] acc_radius doc: information about freeradius-client (#356)

by Yasin

Added some information for freeradius-client to acc documents. radiusclient-ng website isn't avaible so is removed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/356 -- Commit Summary -- * acc_radius doc: information about freeradius-client -- File Changes -- M modules/acc_radius/doc/acc_radius_admin.xml (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/356.patch https://github.com/kamailio/kamailio/pull/356.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/356

9 years, 1 month

git:master:623a51da: Merge pull request #355 from kamailio/vseva/acc_prepare_always

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 623a51da5d7e2c5dae848137267260ce1ddf9d95 URL: https://github.com/kamailio/kamailio/commit/623a51da5d7e2c5dae848137267260c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-05T19:07:41+02:00 Merge pull request #355 from kamailio/vseva/acc_prepare_always acc: add acc_prepare_always parameter --- Modified: modules/acc/acc_logic.c Modified: modules/acc/acc_mod.c Modified: modules/acc/acc_mod.h Modified: modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/623a51da5d7e2c5dae848137267260c… Patch: https://github.com/kamailio/kamailio/commit/623a51da5d7e2c5dae848137267260c… --- diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 16a97e5..0d453a7 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -102,7 +102,7 @@ struct acc_enviroment acc_env; (((_rq)->REQ_METHOD==METHOD_CANCEL) && report_cancels==0) #define is_acc_prepare_on(_rq) \ - (is_acc_flag_set(_rq,acc_prepare_flag)) + (acc_prepare_always || is_acc_flag_set(_rq,acc_prepare_flag)) static void tmcb_func( struct cell* t, int type, struct tmcb_params *ps ); diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index 91b47d0..d412dbf 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -108,6 +108,7 @@ static char *failed_filter_str = 0; /* by default, do not filter logging of unsigned short failed_filter[MAX_FAILED_FILTER_COUNT + 1]; static char* leg_info_str = 0; /*!< multi call-leg support */ struct acc_extra *leg_info = 0; +int acc_prepare_always = 0; /* prepare the request always for later acc */ int acc_prepare_flag = -1; /*!< should the request be prepared for later acc */ char *acc_time_format = "%Y-%m-%d %H:%M:%S"; int reason_from_hf = 0; /*!< assign reason from reason hf if present */ @@ -262,6 +263,7 @@ static param_export_t params[] = { {"multi_leg_info", PARAM_STRING, &leg_info_str }, {"detect_direction", INT_PARAM, &detect_direction }, {"acc_prepare_flag", INT_PARAM, &acc_prepare_flag }, + {"acc_prepare_always", INT_PARAM, &acc_prepare_always }, {"reason_from_hf", INT_PARAM, &reason_from_hf }, /* syslog specific */ {"log_flag", INT_PARAM, &log_flag }, diff --git a/modules/acc/acc_mod.h b/modules/acc/acc_mod.h index c746ffb..055ac61 100644 --- a/modules/acc/acc_mod.h +++ b/modules/acc/acc_mod.h @@ -103,5 +103,6 @@ extern int acc_time_mode; extern str acc_time_attr; extern str acc_time_exten; +extern int acc_prepare_always; #endif diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index fbe7dc3..c047873 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -624,7 +624,7 @@ modparam("acc", "detect_direction", 1) later, with flags set in TM module specific routes (e.g., like failure_route). If this flag is not set and acc or missed_call flag are not set either in request route block, there is no way to mark the - request for transaction later. If either acc or missed_call flags are + request for transaction later unless you set acc_prepare_always. If either acc or missed_call flags are set in request route block, there is no need to set this flag. </para> <para> @@ -639,6 +639,23 @@ modparam("acc", "acc_prepare_flag", 5) </programlisting> </example> </section> + <section id="acc.p.acc_prepare_always"> + <title><varname>acc_prepare_always</varname> (integer)</title> + <para> + Prepare all request even if acc_prepare_flag is not set to mark the request for transaction later. + </para> + <para> + Default value is not-set (previous behaviour). + </para> + <example> + <title>acc_prepare_flag example</title> + <programlisting format="linespecific"> +... +modparam("acc", "acc_prepare_always", 1) +... +</programlisting> + </example> + </section> <section id="acc.p.multi_leg_info"> <title><varname>multi_leg_info</varname> (string)</title> <para>

9 years, 1 month

[kamailio] acc: add acc_prepare_always parameter (#355)

by Victor Seva

This will force the preparation of the request no matter if the acc_prepare_flag is set at the moment of the transaction creation. Following @miconda idea at: http://lists.sip-router.org/pipermail/sr-users/2015-July/089191.html You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/355 -- Commit Summary -- * acc: add acc_prepare_always parameter -- File Changes -- M modules/acc/acc_logic.c (2) M modules/acc/acc_mod.c (2) M modules/acc/acc_mod.h (1) M modules/acc/doc/acc_admin.xml (19) -- Patch Links -- https://github.com/kamailio/kamailio/pull/355.patch https://github.com/kamailio/kamailio/pull/355.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/355

9 years, 1 month

← Newer
1
...
14
15
16
17
18
19
20
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2015