sr-dev November 2015

sr-dev@lists.kamailio.org

27 participants
315 discussions

[kamailio] patches to fix some clang errors and warnings (#395)

by Mikko Lehto

low hanging fruits first, other warnings still left You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/395 -- Commit Summary -- * modules/ims_charging: fixes prototype declatation for destroy_ro_session() * modules/ims_charging: fixes always true comparison of unsigned int * modules/ims_registrar_scscf: adds missing jump to error1 label * modules/ims_usrloc_scscf: to avoid clang warning, include atomic_t declaration -- File Changes -- M modules/ims_charging/ro_session_hash.h (3) M modules/ims_charging/ro_timer.c (2) M modules/ims_registrar_scscf/cxdx_sar.c (2) M modules/ims_usrloc_scscf/hslot.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/395.patch https://github.com/kamailio/kamailio/pull/395.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/395

9 years

[kamailio] kamailio master@4b4dc89 SIGSEGV ALERT: <core> [main.c:737]: handle_sigs(): child process 16507 exited by a signal 11 (#393)

by Anthony Messina

``` Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -m 128 -M 8'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x000000000041b5c9 in _dns_hash_remove (e=0x7f3321d5dde0) at dns_cache.c:495 495 debug_lu_lst("_dns_hash_remove: post rm:", &e->last_used_lst); (gdb) bt full #0 0x000000000041b5c9 in _dns_hash_remove (e=0x7f3321d5dde0) at dns_cache.c:495 __func__ = "_dns_hash_remove" #1 0x0000000000420eb8 in dns_cache_clean (no=4294967295, expired_only=1) at dns_cache.c:637 e = 0x7f3321d5dde0 now = 1894768549 n = 0 deleted = 0 l = 0x7f3321d5ddf0 tmp = 0x7f3321e6e528 #2 0x000000000041906d in dns_timer (ticks=1894768549, tl=0x7f331eaf10e8, data=0x0) at dns_cache.c:206 No locals. #3 0x000000000049e6aa in slow_timer_main () at timer.c:1130 n = 12 ret = 4294967295 tl = 0x7f331eaf10e8 i = 243 __func__ = "slow_timer_main" #4 0x00000000005251dc in main_loop () at main.c:1645 i = 2 pid = 0 si = 0x0 si_desc = "udp receiver child=1 sock=[2001:55C:DC00:100:0:0:0:3]:5060\000\000\001\000\000\000h\227\036\060\063\177\000\000 \230\036\060\063\177\000\000\000n\\R\377\177\000\000\350\352\345\036\063\177\000\000\260~\260&3\177\000\000P\\O33\177\000\000 Q\260&3\177\000\000\003\000\000\000\001\000\000" nrprocs = 2 woneinit = 1 __func__ = "main_loop" #5 0x000000000052b540 in main (argc=7, argv=0x7fff525c7158) at main.c:2591 cfg_stream = 0x1279010 c = -1 r = 0 tmp = 0x7fff525c7f3d "" tmp_len = 0 port = 1700966438 proto = 32767 options = 0x74c478 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:" ret = -1 seed = 3889260924 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x0 p = 0x7 <error: Cannot access memory at address 0x7> st = {st_dev = 20, st_ino = 1223079, st_nlink = 2, st_mode = 16872, st_uid = 986, st_gid = 983, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1447110524, tv_nsec = 573100727}, st_mtim = {tv_sec = 1447110524, tv_nsec = 573100727}, st_ctim = {tv_sec = 1447110524, tv_nsec = 573100727}, __glibc_reserved = {0, 0, 0}} __func__ = "main" ``` --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/393

9 years

Transaction Suspend and Resume

by M. Imran Iqbal

Hi, I want to suspend a transaction to send Push Notification and want to resume after 120 seconds.. I am successfully able to implement following http://www.slideshare.net/miconda/26-danielconstantinmierlakamailiocfgasync I can resume transaction when B user Registers its self. But i want system to wait for 120 second and resume transaction. How can I achieve that ??. I tried multiple things but failed. -- M Imran Iqbal

9 years

git:master:3a19b122: modules/ims_charging: add direction for Ro session in debug print

by jaybeepee

Module: kamailio Branch: master Commit: 3a19b122572ed70b8d5f6da59dd506c2f98b0e31 URL: https://github.com/kamailio/kamailio/commit/3a19b122572ed70b8d5f6da59dd506c… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-11T13:41:32+02:00 modules/ims_charging: add direction for Ro session in debug print --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/3a19b122572ed70b8d5f6da59dd506c… Patch: https://github.com/kamailio/kamailio/commit/3a19b122572ed70b8d5f6da59dd506c… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 2d6c84a..f736311 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -973,13 +973,12 @@ int Ro_Send_CCR(struct sip_msg *msg, struct dlg_cell *dlg, int dir, int reservat int sdp_stream_num = 0; - LM_DBG("Sending initial CCR request for reservation_units [%d] incoming_trunk_id [%.*s] outgoing_trunk_id [%.*s]\n", - reservation_units, + LM_DBG("Sending initial CCR request (%c) for reservation_units [%d] incoming_trunk_id [%.*s] outgoing_trunk_id [%.*s]\n", + dir==RO_ORIG_DIRECTION?'O':'T', + reservation_units, incoming_trunk_id->len, incoming_trunk_id->s, outgoing_trunk_id->len, outgoing_trunk_id->s); - - ssd = shm_malloc(sizeof (struct session_setup_data)); // lookup structure used to load session info from cdp callback on CCA if (!ssd) { LM_ERR("no more shm mem\n");

9 years

[kamailio] FTBFS on mips: gcc error: '-march=r3000' requires '-mfp32' (#394)

by Victor Seva

``` /usr/bin/make all quiet=verbose make[1]: Entering directory '/«PKGBUILDDIR»' config.mak loaded Makefile.defs defs skipped config.mak loaded Makefile.defs defs skipped gcc -funroll-loops -march=r3000 -ftree-vectorize -fno-strict-overflow -Wall -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"4.3.3"' -DARCH='"mips"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 5.2.1"' -D__CPU_mips -D__OS_linux -DSER_VER=4003003 -DCFG_DIR='"/etc/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DWITH_XAVP -DDBG_QM_MALLOC -DMEM_JOIN_FREE -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DMIPS_HAS_LLSC -DNOSMP -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DUSE_RAW_SOCKS -DUSE_PTHREAD_MUTEX -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -c pass_fd.c -o pass_fd.o -MMD -MP pass_fd.c:1:0: error: '-march=r3000' requires '-mfp32' /* ^ Makefile.rules:97: recipe for target 'pass_fd.o' failed make[1]: *** [pass_fd.o] Error 1 ``` https://buildd.debian.org/status/fetch.php?pkg=kamailio&arch=mips&ver=4.3.3… --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/394

9 years

git:4.3:22e4556c: Makefile.defs: gcc 5.2 option -mfp32 is required by -march=r3000 for mips arch

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: 22e4556c91377ecdab849fe181b6a8397bfada7c URL: https://github.com/kamailio/kamailio/commit/22e4556c91377ecdab849fe181b6a83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-11T09:01:16+01:00 Makefile.defs: gcc 5.2 option -mfp32 is required by -march=r3000 for mips arch - reported by Victor Seva, GH#394 (cherry picked from commit b2ff2745b97051625509de0f328e5b1a8f584387) --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/22e4556c91377ecdab849fe181b6a83… Patch: https://github.com/kamailio/kamailio/commit/22e4556c91377ecdab849fe181b6a83… --- diff --git a/Makefile.defs b/Makefile.defs index 0b809a9..87d89c4 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1272,7 +1272,7 @@ ifeq ($(CC_NAME), gcc) CFLAGS=$(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-march=r3000 \ + CFLAGS+=-mfp32 -march=r3000 \ -ftree-vectorize -fno-strict-overflow # not supported on mips: -minline-all-stringops else

9 years

git:master:b2ff2745: Makefile.defs: gcc 5.2 option -mfp32 is required by -march=r3000 for mips arch

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b2ff2745b97051625509de0f328e5b1a8f584387 URL: https://github.com/kamailio/kamailio/commit/b2ff2745b97051625509de0f328e5b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-11T08:59:10+01:00 Makefile.defs: gcc 5.2 option -mfp32 is required by -march=r3000 for mips arch - reported by Victor Seva, GH#394 --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/b2ff2745b97051625509de0f328e5b1… Patch: https://github.com/kamailio/kamailio/commit/b2ff2745b97051625509de0f328e5b1… --- diff --git a/Makefile.defs b/Makefile.defs index 9fa586f..82653fa 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1263,7 +1263,7 @@ ifeq ($(CC_NAME), gcc) CFLAGS=$(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-march=r3000 \ + CFLAGS+=-mfp32 -march=r3000 \ -ftree-vectorize -fno-strict-overflow # not supported on mips: -minline-all-stringops else

9 years

Kamailio 4.3.3 HTABALE issues

by M. Imran Iqbal

Hi, I'm facing issue in htable module when I use following parameter 1- modparam("htable", "timer_mode", 1); ERROR: <core> [modparam.c:139]: set_mod_param_regex(): parameter <timer_mode> of type <2> not found in module <htable> 2- htable Expiry route is not triggering. event_route[htable:expired:mytable] I think there is an issue with the documentation and the code available on GIT -- Imran Iqbal

9 years

git:master:70699ae8: core: dns cache - test for null pointers before debug checks after removing from list

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 70699ae8b9159c18bdd73c3092ccb19691edf0fd URL: https://github.com/kamailio/kamailio/commit/70699ae8b9159c18bdd73c3092ccb19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-10T10:08:20+01:00 core: dns cache - test for null pointers before debug checks after removing from list - next/prev are set to null after remove from list by commit 0fbcca38574139f1cd8ba7506ee5e204be5f2da7 --- Modified: dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/70699ae8b9159c18bdd73c3092ccb19… Patch: https://github.com/kamailio/kamailio/commit/70699ae8b9159c18bdd73c3092ccb19… --- diff --git a/dns_cache.c b/dns_cache.c index cb2d5be..21b780e 100644 --- a/dns_cache.c +++ b/dns_cache.c @@ -459,15 +459,15 @@ int init_dns_cache_stats(int iproc_num) #define debug_lu_lst( txt, l) \ do{ \ - if (check_lu_lst((l))){ \ + if ((l) && check_lu_lst((l))){ \ dbg_lu_lst(txt " crt:", (l)); \ abort(); \ } \ - if (check_lu_lst((l)->next)){ \ + if (((l)->next) && check_lu_lst((l)->next)){ \ dbg_lu_lst(txt " next:", (l)); \ abort(); \ } \ - if (check_lu_lst((l)->prev)){ \ + if (((l)->prev) && check_lu_lst((l)->prev)){ \ dbg_lu_lst(txt " prev:", (l)); \ abort(); \ } \

9 years

git:master:d73d56b4: modules/ims_charging: removed unused impu_data parcel (memory leak)

by jaybeepee

Module: kamailio Branch: master Commit: d73d56b41028341c46a331dfb74f5805248aae56 URL: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-10T10:36:16+02:00 modules/ims_charging: removed unused impu_data parcel (memory leak) --- Modified: modules/ims_charging/mod.c Modified: modules/ims_charging/ro_session_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… Patch: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… --- diff --git a/modules/ims_charging/mod.c b/modules/ims_charging/mod.c index 48f050b..d2f371d 100644 --- a/modules/ims_charging/mod.c +++ b/modules/ims_charging/mod.c @@ -378,10 +378,7 @@ static int w_ro_ccr(struct sip_msg *msg, char* c_route_name, char* c_direction, tm_cell_t *t; unsigned int tindex = 0, tlabel = 0; - struct impu_data *impu_data; - char *p; struct dlg_cell* dlg; - unsigned int len; struct ro_session *ro_session = 0; int free_contact = 0; @@ -457,34 +454,6 @@ static int w_ro_ccr(struct sip_msg *msg, char* c_route_name, char* c_direction, } LM_DBG("IMPU data to pass to usrloc: contact <%.*s> identity <%.*s>\n", contact.len, contact.s, identity.len, identity.s); - - //create impu_data_parcel - len = identity.len + contact.len + sizeof (struct impu_data); - impu_data = (struct impu_data*) shm_malloc(len); - if (!impu_data) { - LM_ERR("Unable to allocate memory for impu_data, trying to send CCR\n"); - ret = RO_RETURN_ERROR; - goto done; - } - memset(impu_data, 0, len); - - p = (char*) (impu_data + 1); - impu_data->identity.s = p; - impu_data->identity.len = identity.len; - memcpy(p, identity.s, identity.len); - p += identity.len; - - impu_data->contact.s = p; - impu_data->contact.len = contact.len; - memcpy(p, contact.s, contact.len); - p += contact.len; - - if (p != (((char*) impu_data) + len)) { - LM_ERR("buffer overflow creating impu data, trying to send CCR\n"); - shm_free(impu_data); - ret = RO_RETURN_ERROR; - goto done; - } send_ccr: diff --git a/modules/ims_charging/ro_session_hash.h b/modules/ims_charging/ro_session_hash.h index dcd79e5..7257721 100644 --- a/modules/ims_charging/ro_session_hash.h +++ b/modules/ims_charging/ro_session_hash.h @@ -173,12 +173,6 @@ static inline void unlink_unsafe_ro_session(struct ro_session_entry *ro_session_ int init_ro_session_table(unsigned int size); /*! - * \brief Destroy a ro_session and free memory - * \param ro_session destroyed Ro Session - */ -inline void destroy_ro_session(struct ro_session *ro_session); - -/*! * \brief Destroy the ro_session dialog table */ void destroy_ro_session_table(void);

9 years

← Newer
1
...
21
22
23
24
25
26
27
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2015