sr-dev December 2015

sr-dev@lists.kamailio.org

30 participants
230 discussions

git:master:fd79adb4: dispatcher: proper handling of socket parameter when is not last in attrs

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fd79adb4975fc0799fe8488d1dd1a771041a0939 URL: https://github.com/kamailio/kamailio/commit/fd79adb4975fc0799fe8488d1dd1a77… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-10T09:33:32+01:00 dispatcher: proper handling of socket parameter when is not last in attrs - parsing socket function expects a null terminated string --- Modified: modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/fd79adb4975fc0799fe8488d1dd1a77… Patch: https://github.com/kamailio/kamailio/commit/fd79adb4975fc0799fe8488d1dd1a77… --- diff --git a/modules/dispatcher/dispatch.c b/modules/dispatcher/dispatch.c index 1188692..3638a9c 100644 --- a/modules/dispatcher/dispatch.c +++ b/modules/dispatcher/dispatch.c @@ -255,6 +255,7 @@ int add_dest2list(int id, str uri, int flags, int priority, str *attrs, int orig_id = 0, orig_nr = 0; str host; int port, proto; + char c = 0; ds_set_t *orig_ds_lists = ds_lists[list_idx]; /* check uri */ @@ -329,11 +330,23 @@ int add_dest2list(int id, str uri, int flags, int priority, str *attrs, /* check socket attribute */ if (dp->attrs.socket.s && dp->attrs.socket.len > 0) { + /* parse_phostport(...) expects 0-terminated string + * - after socket parameter is either ';' or '\0' */ + if(dp->attrs.socket.s[dp->attrs.socket.len]!='\0') { + c = dp->attrs.socket.s[dp->attrs.socket.len]; + dp->attrs.socket.s[dp->attrs.socket.len] = '\0'; + } if (parse_phostport(dp->attrs.socket.s, &host.s, &host.len, &port, &proto)!=0) { LM_ERR("bad socket <%.*s>\n", dp->attrs.socket.len, dp->attrs.socket.s); + if(c!=0) { + dp->attrs.socket.s[dp->attrs.socket.len] = c; + } goto err; } + if(c!=0) { + dp->attrs.socket.s[dp->attrs.socket.len] = c; + } dp->sock = grep_sock_info( &host, (unsigned short)port, proto); if (dp->sock==0) { LM_ERR("non-local socket <%.*s>\n", dp->attrs.socket.len, dp->attrs.socket.s);

8 years, 11 months

[kamailio] dialog's keepalives keep sending to old address after re-INVITE with updated location (#273)

by Andrey Utkin

Hi, we use pretty recent kamailio: ``` version: kamailio 4.4.0-dev2 (x86_64/linux) 1a758d flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 1a758d compiled on 14:49:47 Jul 20 2015 with gcc 4.8.2 ``` The case: consider the mobile SIP agent which switches between networks (e.g. wifi -> mobile) during the call. It sends re-INVITE with its new location. We use keep-alives provided by dialog module. And it seems that keep-alives don't use new address and are always sent to initial address. Any thoughts? Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/273

8 years, 11 months

git:master:12160de3: core: skip zero char and whitespaces before parsing first line in parse_msg()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 12160de3c2052c4696b8c073b9fa5919f6da7060 URL: https://github.com/kamailio/kamailio/commit/12160de3c2052c4696b8c073b9fa591… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-09T23:27:09+01:00 core: skip zero char and whitespaces before parsing first line in parse_msg() - reported by Vasiliy Ganchev --- Modified: parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/12160de3c2052c4696b8c073b9fa591… Patch: https://github.com/kamailio/kamailio/commit/12160de3c2052c4696b8c073b9fa591… --- diff --git a/parser/msg_parser.c b/parser/msg_parser.c index b907772..21b3cc2 100644 --- a/parser/msg_parser.c +++ b/parser/msg_parser.c @@ -589,9 +589,11 @@ int parse_msg(char* const buf, const unsigned int len, struct sip_msg* const msg int offset; hdr_flags_t flags; - /* eat crlf from the beginning */ - for (tmp=buf; (*tmp=='\n' || *tmp=='\r')&& - tmp-buf < len ; tmp++); + /* eat crlf & whitespaces from the beginning */ + for (tmp=buf; (tmp-buf < len) + && (*tmp=='\n' || *tmp=='\r' || *tmp=='\0' + || *tmp=='\t' || *tmp==' '); + tmp++); offset=tmp-buf; fl=&(msg->first_line); rest=parse_first_line(tmp, len-offset, fl);

8 years, 11 months

info: kamailio.org updates - letsencrypt for https and dkim for email

by Daniel-Constantin Mierla

Hello, during the past few days I made some updates related to the security aspects of kamailio.org services. Two are relevant for the community. 1) First, kamailio.org uses now a TLS certificate signed by letsencrypt.org, a free trusted CA backed up by Mozilla and other internet companies, so browsing via HTTPS should no longer issue any warning of untrusted certificate (previously we used a CACert.org certificate which was not trusted automatically by browsers). Wiki and mailing lists portals use the letsencrypt certificate as well, so is no reason not to browse all kamailio.org and lists.sip-router.org pages only via HTTPS. Perhaps in the near future we will try to enable redirect of HTTP to HTTPS at least for the main page and login pages for wiki, mailing lists and other places that require sensitive data. Now SSLLabs test ranks https://kamailio.org with grade A: * https://www.ssllabs.com/ssltest/analyze.html?d=kamailio.org&latest As a side note, for those that haven't noticed it, for quite some time kamailio.org is available also over IPv6. 2) Second, emails forwarded by kamailio.org and lists.sip-router.org are having now a DKIM signature. Also, there are SPF records in DNS for these domains. Hopefully, those two will help getting the emails to be allowed by various spam filters out there, as their legit origin can be checked. If you check the sources of an email messages and the email server of receiving party is doing DKIM/SPF checks, you should see some headers like next (taken from an email I received to my gmail account from sr-users mailing list): """ Authentication-Results: mx.google.com; spf=pass (google.com: domain of sr-users-bounces(a)lists.sip-router.org designates 193.22.119.66 as permitted sender) smtp.mailfrom=sr-users-bounces(a)lists.sip-router.org; dkim=pass header.i=(a)lists.sip-router.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sip-router.org; s=20151206; h=Sender:Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Reply-To:Subject:MIME-Version:Message-ID:To:From:Date; bh=lGjvCZYcxBHUHaJDnut1j2YTyPsXTnXHzUb0CgcDc1Q=; b=DlD+MKoEqyISB5Ba775t3zg70FC6ouC+tEo7j5zv4dn2Dhm4pWqkQXSfU4Kp1NqW1ZRYFC/mpg/7LEcGW2FlDL9J0FpUg1VjNmN7D1wvtW08hBBw91tsXImu9yf7KZjg/p4IbXu6vznldubrSxweIaV3q/xbrLgaqP5Dsrvs/9A=; """ Kamailio is not enforcing any of those policies on received email messages, so sending to the lists should not be affected. Should anyone discover problems when browsing the web portals or notices issues with emails from our mailing lists, report them to sr-dev mailing list. Also, if anyone has more hints on increasing the security/privacy for the web server and email systems we run for kamailio.org, do not hesitate to provide us suggestions. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com http://miconda.eu

8 years, 11 months

git:master:01060e98: Merge branch 'master' of github.com:kamailio/kamailio

by Hugh Waite

Module: kamailio Branch: master Commit: 01060e983d3de5bf798c7f9725dcd85e23c6c3d5 URL: https://github.com/kamailio/kamailio/commit/01060e983d3de5bf798c7f9725dcd85… Author: Hugh Waite <hugh.waite(a)xura.com> Committer: Hugh Waite <hugh.waite(a)xura.com> Date: 2015-12-09T14:20:07Z Merge branch 'master' of github.com:kamailio/kamailio --- Modified: modules/db_mysql/km_dbase.c Modified: utils/kamctl/kamctl Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/01060e983d3de5bf798c7f9725dcd85… Patch: https://github.com/kamailio/kamailio/commit/01060e983d3de5bf798c7f9725dcd85… --- diff --git a/modules/db_mysql/km_dbase.c b/modules/db_mysql/km_dbase.c index 9b220c3..2b3d1c9 100644 --- a/modules/db_mysql/km_dbase.c +++ b/modules/db_mysql/km_dbase.c @@ -80,9 +80,13 @@ static int db_mysql_submit_query(const db1_con_t* _h, const str* _s) if (my_ping_interval) { t = time(0); if ((t - CON_TIMESTAMP(_h)) > my_ping_interval) { - if (mysql_ping(CON_CONNECTION(_h))) { - LM_WARN("driver error on ping: %s\n", mysql_error(CON_CONNECTION(_h))); - counter_inc(mysql_cnts_h.driver_err); + for (i=0; i < (db_mysql_auto_reconnect ? 3 : 1); i++) { + if (mysql_ping(CON_CONNECTION(_h))) { + LM_WARN("driver error on ping: %s\n", mysql_error(CON_CONNECTION(_h))); + counter_inc(mysql_cnts_h.driver_err); + } else { + break; + } } } /* diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 22d9643..974f457 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='4.2.0' +VERSION='4.4.0' PATH=$PATH:/usr/local/sbin/ diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index e8915d1..224111b 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='4.2.0' +VERSION='4.4.0' PATH=$PATH:/usr/local/sbin/

8 years, 11 months

git:master:3b6d7a28: utils: Fix crash in http_query

by Hugh Waite

Module: kamailio Branch: master Commit: 3b6d7a28ea0b053f27cb169ac31259e20ef4ece0 URL: https://github.com/kamailio/kamailio/commit/3b6d7a28ea0b053f27cb169ac31259e… Author: Hugh Waite <hugh.waite(a)xura.com> Committer: Hugh Waite <hugh.waite(a)xura.com> Date: 2015-12-09T14:15:47Z utils: Fix crash in http_query - Fixes incorrect fixup logic for http_query_post_hdr - Bug reported by jayesh1017 --- Modified: modules/utils/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/3b6d7a28ea0b053f27cb169ac31259e… Patch: https://github.com/kamailio/kamailio/commit/3b6d7a28ea0b053f27cb169ac31259e… --- diff --git a/modules/utils/utils.c b/modules/utils/utils.c index 368f5b9..b407742 100644 --- a/modules/utils/utils.c +++ b/modules/utils/utils.c @@ -361,8 +361,7 @@ static int fixup_http_query_get(void** param, int param_no) static int fixup_free_http_query_get(void** param, int param_no) { if (param_no == 1) { - LM_WARN("free function has not been defined for spve\n"); - return 0; + return fixup_free_spve_null(param, 1); } if (param_no == 2) { @@ -406,7 +405,7 @@ static int fixup_http_query_post(void** param, int param_no) */ static int fixup_http_query_post_hdr(void** param, int param_no) { - if ((param_no >= 1) || (param_no <= 3)) { + if ((param_no >= 1) && (param_no <= 3)) { return fixup_spve_null(param, 1); } @@ -432,8 +431,7 @@ static int fixup_http_query_post_hdr(void** param, int param_no) static int fixup_free_http_query_post(void** param, int param_no) { if ((param_no == 1) || (param_no == 2)) { - LM_WARN("free function has not been defined for spve\n"); - return 0; + return fixup_free_spve_null(param, 1); } if (param_no == 3) { @@ -449,12 +447,11 @@ static int fixup_free_http_query_post(void** param, int param_no) */ static int fixup_free_http_query_post_hdr(void** param, int param_no) { - if ((param_no >= 1) || (param_no <= 2)) { - LM_WARN("free function has not been defined for spve\n"); - return 0; + if ((param_no >= 1) && (param_no <= 3)) { + return fixup_free_spve_null(param, 1); } - if (param_no == 3) { + if (param_no == 4) { return fixup_free_pvar_null(param, 1); }

8 years, 11 months

git:tmp/hpw_curl_improvements:9fd99efc: Fixes and improvements to curl module

by Hugh Waite

Module: kamailio Branch: tmp/hpw_curl_improvements Commit: 9fd99efc683f2ccb4e5b7e88ae891d808e2efdcd URL: https://github.com/kamailio/kamailio/commit/9fd99efc683f2ccb4e5b7e88ae891d8… Author: Hugh Waite <hugh.waite(a)xura.com> Committer: Hugh Waite <hugh.waite(a)xura.com> Date: 2015-12-09T09:59:46Z Fixes and improvements to curl module - Fix invalid check of uri and postdata parameters - Fix fixup functions - Refactor curl function to remove dependance on pv/fixup structures - Export curl_connect through C API - Fix buffer overflow in curl write function --- Added: modules/curl/curl_api.c Added: modules/curl/curl_api.h Modified: modules/curl/curl.c Modified: modules/curl/functions.c Modified: modules/curl/functions.h --- Diff: https://github.com/kamailio/kamailio/commit/9fd99efc683f2ccb4e5b7e88ae891d8… Patch: https://github.com/kamailio/kamailio/commit/9fd99efc683f2ccb4e5b7e88ae891d8…

8 years, 11 months

[kamailio] PDB module prefixes (#433)

by igorPot

Hi all, I had configured my pdb module to accept 5 number prefixes by modifying: In pdbt.c: bufsize = slen + 1 + 1 + 4 + 1 + 1; // line buffer (telephone number + colon + white space + carrier ID + newline + \0) ... ret = snprintf(p, 7, "%d\n", node->carrier); if (ret < 1 || ret > 6) { And in common.h: #define MAX_PDB_CARRIERID 99999 And i hadn't had any problem until now. I had rows in my .csv like: 0645052050;10122 And it worked. The problem I have now is with prefixes bigger than 40000. I get segmentation fault when doiong a query with pdbt, however the pdbt build works good without any error. At first i thought of a buffer problem but eventhough testing with a .csv of 2 rows with 50000 prefixes will not work. Another curious effect is that for a prefix like 84238 the server changes the answer to 18754. I dont know why... Could anyone help me please? Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/433

8 years, 11 months

git:master:5816e685: kamctl: updated version of the scripts

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5816e6852306c943f9b39cf8d8243201bbbdc132 URL: https://github.com/kamailio/kamailio/commit/5816e6852306c943f9b39cf8d824320… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-08T22:56:53+01:00 kamctl: updated version of the scripts --- Modified: utils/kamctl/kamctl Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/5816e6852306c943f9b39cf8d824320… Patch: https://github.com/kamailio/kamailio/commit/5816e6852306c943f9b39cf8d824320… --- diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 22d9643..974f457 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='4.2.0' +VERSION='4.4.0' PATH=$PATH:/usr/local/sbin/ diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index e8915d1..224111b 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='4.2.0' +VERSION='4.4.0' PATH=$PATH:/usr/local/sbin/

8 years, 11 months

Proposing new logo for Kamailio project

by Daniel-Constantin Mierla

Hello, upon a process initiated before the summer during the IRC Devel Meeting, when we started to look for refreshing the logo of Kamailio project, we are now trying to finalize the decision and we are proposing a new logo for Kamailio project. The new proposed logo, as well as more details, can be seen at: * http://www.kamailio.org/w/2015/12/proposing-new-logo-for-kamailio-project/ We look forward to the feedback from community about this proposal - you like it or not, is too similar with other logos, etc... This announcement was sent to few of our mailing lists, but please reply to sr-users(a)lists.sip-router.org, being something concerning the community and definitely not something about development. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com http://miconda.eu

8 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2015