sr-dev February 2015

sr-dev@lists.kamailio.org

39 participants
342 discussions

[kamailio] For dbmongo update, use an update document using the set update operator (#75)
by mikomarrache 11 Feb '15

11 Feb '15

...instead of replacing the entire document with partial data. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/75 -- Commit Summary -- * For dbmongo updates, use an update document using the set update operator -- File Changes -- M modules/db_mongodb/mongodb_dbase.c (15) -- Patch Links -- https://github.com/kamailio/kamailio/pull/75.patch https://github.com/kamailio/kamailio/pull/75.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/75

2 2

git:lazedo/presence:265a38a0: presence : add min_expires_action parameter
by Luis Azedo 11 Feb '15

11 Feb '15

Module: kamailio Branch: lazedo/presence Commit: 265a38a08a21dbeab2b9d310bd521e9c25f5d24a URL: https://github.com/kamailio/kamailio/commit/265a38a08a21dbeab2b9d310bd521e9… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-02-11T17:39:27Z presence : add min_expires_action parameter action to take when min_expires > 0 possible values are 1 - RC compliant, return "423 Interval Too Brief" 2 - force min_expires in the subscription --- Modified: modules/presence/doc/presence_admin.xml Modified: modules/presence/presence.c Modified: modules/presence/presence.h Modified: modules/presence/subscribe.c Modified: modules/presence/subscribe.h Modified: modules/presence/utils_func.c Modified: modules/presence/utils_func.h --- Diff: https://github.com/kamailio/kamailio/commit/265a38a08a21dbeab2b9d310bd521e9… Patch: https://github.com/kamailio/kamailio/commit/265a38a08a21dbeab2b9d310bd521e9…

1 0

Next IRC development meeting
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Hello, I thought to propose organizing the next IRC meeting to discuss and sync each other about Kamailio development and surrounding ecosystem. First date proposal is next week, Wednesday, 15:00GMT, Feb 11, 2015, on the usual #kamailio channel at freenode.net. The date can be changed, based on feedback from the people that want to attends. I made a wiki page for the event at: - http://www.kamailio.org/wiki/devel/irc-meetings/2015a Feel free to propose topics to the agenda and/or new date. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

3 4

git:master:112e83c2: sqlops: added note to sql_async_query() about core async_workers
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: 112e83c2e8b72be04f7ad5b896db0bf3bcbdbe8f URL: https://github.com/kamailio/kamailio/commit/112e83c2e8b72be04f7ad5b896db0bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T11:50:43Z sqlops: added note to sql_async_query() about core async_workers - the parameter must be set to enable the async framework used by this function --- Diff: https://github.com/kamailio/kamailio/commit/112e83c2e8b72be04f7ad5b896db0bf… Patch: https://github.com/kamailio/kamailio/commit/112e83c2e8b72be04f7ad5b896db0bf… --- diff --git a/modules/sqlops/doc/sqlops_admin.xml b/modules/sqlops/doc/sqlops_admin.xml index ec61cac..bb9011b 100644 --- a/modules/sqlops/doc/sqlops_admin.xml +++ b/modules/sqlops/doc/sqlops_admin.xml @@ -385,7 +385,9 @@ sql_result_free("ra"); driver module (e.g., db_mysql). The query is executed in another process and result is not available back to config, thus it should be used only for sql statements that don't return values (e.g., - insert, delete, update...). + insert, delete, update...). Note that async_workers core parameter + must be set in order to enable the asyncronous framework + needed by this function. </para> <itemizedlist> <listitem>

1 0

git:master:7ae56a33: db_mongodb: regenerated README file
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: 7ae56a331209adeff7c5da86e1ebd8321d586a35 URL: https://github.com/kamailio/kamailio/commit/7ae56a331209adeff7c5da86e1ebd83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T11:37:22Z db_mongodb: regenerated README file --- Diff: https://github.com/kamailio/kamailio/commit/7ae56a331209adeff7c5da86e1ebd83… Patch: https://github.com/kamailio/kamailio/commit/7ae56a331209adeff7c5da86e1ebd83… --- diff --git a/modules/db_mongodb/README b/modules/db_mongodb/README index a0f779c..9205d80 100644 --- a/modules/db_mongodb/README +++ b/modules/db_mongodb/README @@ -10,7 +10,7 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> - Copyright Â© 2014 asipto.com + Copyright © 2014 asipto.com __________________________________________________________________ Table of Contents @@ -62,8 +62,12 @@ Chapter 1. Admin Guide 1.1. Limitations - * This module has implemented INSERT, UPDATE and DELETE. Query - (SELECT) is not yet storing the result. + * This module has implemented the equivalent operations for INSERT, + UPDATE, DELETE and SELECT. The match condition (WHERE clause) works + with the operators: equal, not equal, greater than, less than, + equal or greater than, equal or less than. Raw query is not + implemented inside this module, use ndb_mongodb for sending any + kind of command to a MongoDB server. 2. Dependencies

1 0

git:master:6940ce0e: db_mongodb: updated details in docs about the limitations
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: 6940ce0e991fd5b6af9ef5822dc2b1a324319174 URL: https://github.com/kamailio/kamailio/commit/6940ce0e991fd5b6af9ef5822dc2b1a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T11:19:45Z db_mongodb: updated details in docs about the limitations --- Diff: https://github.com/kamailio/kamailio/commit/6940ce0e991fd5b6af9ef5822dc2b1a… Patch: https://github.com/kamailio/kamailio/commit/6940ce0e991fd5b6af9ef5822dc2b1a… --- diff --git a/modules/db_mongodb/doc/db_mongodb_admin.xml b/modules/db_mongodb/doc/db_mongodb_admin.xml index 5971e7d..ee34cb2 100644 --- a/modules/db_mongodb/doc/db_mongodb_admin.xml +++ b/modules/db_mongodb/doc/db_mongodb_admin.xml @@ -34,8 +34,12 @@ <itemizedlist> <listitem> <para> - This module has implemented INSERT, UPDATE and DELETE. Query - (SELECT) is not yet storing the result. + This module has implemented the equivalent operations for INSERT, + UPDATE, DELETE and SELECT. The match condition (WHERE clause) + works with the operators: equal, not equal, greater than, less than, + equal or greater than, equal or less than. Raw query is not + implemented inside this module, use ndb_mongodb for sending any + kind of command to a MongoDB server. </para> </listitem> </itemizedlist>

1 0

git:master:e31e4632: db_mongo_db: use mongoc_collection_update() for update operation
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: e31e4632f83e805775bbc1e208178bee11ab137b URL: https://github.com/kamailio/kamailio/commit/e31e4632f83e805775bbc1e208178be… Author: mikomarrache <mikomarrache(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T10:47:17Z db_mongo_db: use mongoc_collection_update() for update operation - used instead of mongoc_collection_find_and_modify(), which returns the document, but it is not needed --- Diff: https://github.com/kamailio/kamailio/commit/e31e4632f83e805775bbc1e208178be… Patch: https://github.com/kamailio/kamailio/commit/e31e4632f83e805775bbc1e208178be… --- diff --git a/modules/db_mongodb/mongodb_dbase.c b/modules/db_mongodb/mongodb_dbase.c index 808575b..5acc269 100644 --- a/modules/db_mongodb/mongodb_dbase.c +++ b/modules/db_mongodb/mongodb_dbase.c @@ -1226,8 +1226,8 @@ int db_mongodb_update(const db1_con_t* _h, const db_key_t* _k, } } - if (!mongoc_collection_find_and_modify (collection, mdoc, NULL, udoc, NULL, - false, false, false, NULL, &error)) { + if (!mongoc_collection_update (collection, MONGOC_UPDATE_NONE, mdoc, + udoc, NULL, &error)) { LM_ERR("failed to update in collection: %s\n", error.message); goto error; }

1 0

git:master:2a045585: db_mongodb: use $set operator to update a specific list of fields in a document
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: 2a045585efc9a8e5b17123d320539d0c8cb6be77 URL: https://github.com/kamailio/kamailio/commit/2a045585efc9a8e5b17123d320539d0… Author: mikomarrache <mikomarrache(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T10:42:14Z db_mongodb: use $set operator to update a specific list of fields in a document - fix to keep all the other fields unchanged --- Diff: https://github.com/kamailio/kamailio/commit/2a045585efc9a8e5b17123d320539d0… Patch: https://github.com/kamailio/kamailio/commit/2a045585efc9a8e5b17123d320539d0… --- diff --git a/modules/db_mongodb/mongodb_dbase.c b/modules/db_mongodb/mongodb_dbase.c index b48a5c0..808575b 100644 --- a/modules/db_mongodb/mongodb_dbase.c +++ b/modules/db_mongodb/mongodb_dbase.c @@ -1155,7 +1155,7 @@ int db_mongodb_update(const db1_con_t* _h, const db_key_t* _k, mongoc_collection_t *collection = NULL; bson_error_t error; bson_t *mdoc = NULL; - bson_t *udoc = NULL; + bson_t *udoc = NULL, *sdoc = NULL; char *cname; char b1; @@ -1189,6 +1189,11 @@ int db_mongodb_update(const db1_con_t* _h, const db_key_t* _k, LM_ERR("cannot initialize update bson document\n"); goto error; } + sdoc = bson_new(); + if(sdoc==NULL) { + LM_ERR("cannot initialize update bson document\n"); + goto error; + } mdoc = bson_new(); if(mdoc==NULL) { LM_ERR("cannot initialize match bson document\n"); @@ -1196,9 +1201,13 @@ int db_mongodb_update(const db1_con_t* _h, const db_key_t* _k, } for(i = 0; i < _un; i++) { - if(db_mongodb_bson_add(udoc, _uk[i], _uv+i, i)<0) + if(db_mongodb_bson_add(sdoc, _uk[i], _uv+i, i)<0) goto error; } + if(bson_append_document(udoc, "$set", 4, sdoc)<0) { + LM_ERR("failed to append document to bson document\n"); + goto error; + } if(_o==NULL) { for(i = 0; i < _n; i++) { @@ -1224,12 +1233,14 @@ int db_mongodb_update(const db1_con_t* _h, const db_key_t* _k, } bson_destroy (mdoc); bson_destroy (udoc); + bson_destroy (sdoc); mongoc_collection_destroy (collection); return 0; error: if(mdoc) bson_destroy (mdoc); if(udoc) bson_destroy (udoc); + if(sdoc) bson_destroy (sdoc); if(collection) mongoc_collection_destroy (collection); return -1; }

1 0

git:master:e122c5ee: dialog: fix initialization of slot next_id to avoid colision after restart
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Module: kamailio Branch: master Commit: e122c5ee8c6055c033cc11f14e5308ed94461fe6 URL: https://github.com/kamailio/kamailio/commit/e122c5ee8c6055c033cc11f14e5308e… Author: mikomarrache <mikomarrache(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-11T10:37:26Z dialog: fix initialization of slot next_id to avoid colision after restart - next_id was set to the highest id of a dialog loaded from database, next new dialog was reusing the same value --- Diff: https://github.com/kamailio/kamailio/commit/e122c5ee8c6055c033cc11f14e5308e… Patch: https://github.com/kamailio/kamailio/commit/e122c5ee8c6055c033cc11f14e5308e… --- diff --git a/modules/dialog/dlg_db_handler.c b/modules/dialog/dlg_db_handler.c index 2de4e7e..9e8d2c4 100644 --- a/modules/dialog/dlg_db_handler.c +++ b/modules/dialog/dlg_db_handler.c @@ -366,7 +366,7 @@ static int load_dialog_info_from_db(int dlg_hash_size, int fetch_num_rows) next_id = d_table->entries[dlg->h_entry].next_id; d_table->entries[dlg->h_entry].next_id = - (next_id < dlg->h_id) ? (dlg->h_id+1) : next_id; + (next_id <= dlg->h_id) ? (dlg->h_id+1) : next_id; GET_STR_VALUE(to_tag, values, 6, 1, 1);

1 0

notifications for several commits are missing
by Daniel-Constantin Mierla 11 Feb '15

11 Feb '15

Hello, I noticed that several commits I did in the past hour were not notified to sr-dev mailing list. Checking the github project setting, the web hook callback from github failed to execute, reporting timeout. Apparently it just started to work again. I will try to see if there is a way to trigger those notifications. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2015