sr-dev February 2015

sr-dev@lists.kamailio.org

39 participants
341 discussions

by GG GG

Hi ! Aastra phone can support outbound (RFC 5626) but they put reg-id=0 in the SIP REGISTER. So the registrar server can't save the AOR and says "invalid reg-id value". I know Aastra should change that for reg-id=1, I already reported an issue but no feedback... Finally I applied a patch in modules/registrar/save.c: -- if(str2int(&_c->reg_id->body, &ci.reg_id)<0 || ci.reg_id==0) ++ if(str2int(&_c->reg_id->body, &ci.reg_id)<0) { LM_ERR("invalid reg-id value\n"); goto error; } Do you think it's safe to do that ? Thank you !

9 years, 9 months

Issue after tcpops enhancement for lifetime per connection

by Daniel-Constantin Mierla

Hi Camille, can you check and see what could have resulted in the issue reported on users mailing list referred in the next link? http://lists.sip-router.org/pipermail/sr-users/2015-February/087101.html There were couple of replies with some other details. Thanks, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com

9 years, 9 months

git:4.2:e24c9ff7: sdpops: safety check when location a= line not to exceed end of message

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: e24c9ff7038534e07682e8a7bafd903e4303590e URL: https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-23T22:02:51+01:00 sdpops: safety check when location a= line not to exceed end of message (cherry picked from commit 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285) --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903… Patch: https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903… --- diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 8717343..98c2f84 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -156,12 +156,17 @@ static int mod_init(void) int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) { char *p; + char *bend; + p = pos; while(*p!='\n') p--; aline->s = p + 1; p = pos; - while(*p!='\n') p++; + bend = msg->buf+msg->len; + while(*p!='\n' && p<bend) p++; aline->len = p - aline->s + 1; + if(unlikely(p==bend)) aline->len--; + return 0; }

9 years, 9 months

git:4.2:449ba0c0: kazoo - fix timeouts

by Luis Azedo

Module: kamailio Branch: 4.2 Commit: 449ba0c0a3a1c79c597452c3411fd823465c9482 URL: https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd82… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-02-23T20:56:53Z kazoo - fix timeouts timeout should be ms not sec set time before state so timeout check doesn't set timeout immediately separate proc for handling timeouts (cherry picked from commit b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3) --- Modified: modules/kazoo/kazoo.c Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_amqp.h --- Diff: https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd82… Patch: https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd82…

9 years, 9 months

git:master:b9e5b918: kazoo - fix timeouts

by Luis Azedo

Module: kamailio Branch: master Commit: b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3 URL: https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-02-23T20:55:57Z kazoo - fix timeouts timeout should be ms not sec set time before state so timeout check doesn't set timeout immediately separate proc for handling timeouts --- Modified: modules/kazoo/kazoo.c Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_amqp.h --- Diff: https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5… Patch: https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5…

9 years, 9 months

git:master:91596953: sdpops: safety check when location a= line not to exceed end of message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285 URL: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-23T14:29:46+01:00 sdpops: safety check when location a= line not to exceed end of message --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… Patch: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… --- diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 3357bb2..2a4aa6b 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -159,12 +159,17 @@ static int mod_init(void) int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) { char *p; + char *bend; + p = pos; while(*p!='\n') p--; aline->s = p + 1; p = pos; - while(*p!='\n') p++; + bend = msg->buf+msg->len; + while(*p!='\n' && p<bend) p++; aline->len = p - aline->s + 1; + if(unlikely(p==bend)) aline->len--; + return 0; }

9 years, 9 months

git:master:4b682e15: tls: use proper start of ipv6 address in tls.cfg

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4b682e15fcd14fc3eb153865c2071162c7592220 URL: https://github.com/kamailio/kamailio/commit/4b682e15fcd14fc3eb153865c207116… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-23T11:23:53+01:00 tls: use proper start of ipv6 address in tls.cfg - reported by Anthony Messina --- Modified: modules/tls/tls_config.c --- Diff: https://github.com/kamailio/kamailio/commit/4b682e15fcd14fc3eb153865c207116… Patch: https://github.com/kamailio/kamailio/commit/4b682e15fcd14fc3eb153865c207116… --- diff --git a/modules/tls/tls_config.c b/modules/tls/tls_config.c index 8d6b390..3960c5f 100644 --- a/modules/tls/tls_config.c +++ b/modules/tls/tls_config.c @@ -52,13 +52,13 @@ static int parse_ipv6(struct ip_addr* ip, cfg_token_t* token, struct ip_addr* ipv6; str ip6_str; + ip6_str.s = t.val.s; while(1) { ret = cfg_get_token(&t, st, 0); if (ret != 0) goto err; if (t.type == ']') break; if (t.type != CFG_TOKEN_ALPHA && t.type != ':') goto err; } - ip6_str.s = t.val.s; ip6_str.len = (int)(long)(t.val.s - ip6_str.s); ipv6 = str2ip6(&ip6_str);

9 years, 9 months

setting traced_user_avp after calling sip_trace()

by Juha Heinanen

i would prefer to call sip_trace() up front in the script in order to avoid calling it many places. currently, however, looks like setting of traced_user_avp after sip_trace() is called has no effect. how about if i add a module var delayed_avp_trace (or something) so that if it has value 1, trusted_user_avp value is checked when the message is actually stored by sip_trace_store_db function? -- juha

9 years, 9 months

git:master:6a97c65c: modules/siptrace: small README clarification

by Juha Heinanen

Module: kamailio Branch: master Commit: 6a97c65c122400e46a4103b756c6973f7bea134e URL: https://github.com/kamailio/kamailio/commit/6a97c65c122400e46a4103b756c6973… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2015-02-22T01:10:12+02:00 modules/siptrace: small README clarification --- Modified: modules/siptrace/README Modified: modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6a97c65c122400e46a4103b756c6973… Patch: https://github.com/kamailio/kamailio/commit/6a97c65c122400e46a4103b756c6973… --- diff --git a/modules/siptrace/README b/modules/siptrace/README index 1eaea86..5dfa7a7 100644 --- a/modules/siptrace/README +++ b/modules/siptrace/README @@ -16,9 +16,9 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> - Copyright © 2010 asipto.com + Copyright (c) 2010 asipto.com - Copyright © 2006 voice-system.ro + Copyright (c) 2006 voice-system.ro __________________________________________________________________ Table of Contents @@ -215,7 +215,7 @@ modparam("siptrace", "table", "strace") 3.3. trace_flag (integer) - Which flag is used to mark messages to trace + Which flag is used to mark messages to trace without traced user. Default value is "0". @@ -424,7 +424,7 @@ modparam("siptrace", "force_send_sock", "sip:10.1.1.2:5000") 4.1. sip_trace([address]) -4.1. sip_trace([address]) +4.1. sip_trace([address]) Store or forward the current processed SIP message in database. It is stored in the form prior applying changes made to it. @@ -449,7 +449,7 @@ sip_trace("sip:10.1.1.2:5085"); 5.1. sip_trace -5.1. sip_trace +5.1. sip_trace Name: sip_trace @@ -470,7 +470,7 @@ sip_trace("sip:10.1.1.2:5085"); 6.1. siptrace.status param -6.1. siptrace.status param +6.1. siptrace.status param Name: siptrace.status diff --git a/modules/siptrace/doc/siptrace_admin.xml b/modules/siptrace/doc/siptrace_admin.xml index 1524e01..c766531 100644 --- a/modules/siptrace/doc/siptrace_admin.xml +++ b/modules/siptrace/doc/siptrace_admin.xml @@ -132,7 +132,8 @@ modparam("siptrace", "table", "strace") <section id="siptrace.p.trace_flag"> <title><varname>trace_flag</varname> (integer)</title> <para> - Which flag is used to mark messages to trace + Which flag is used to mark messages to trace without + traced user. </para> <para> <emphasis>

9 years, 9 months

git:master:3f6fc7d4: Registrar Remove SVN ID and history

by Olle E. Johansson

Module: kamailio Branch: master Commit: 3f6fc7d42100800f94a5f3b66409164013fffc96 URL: https://github.com/kamailio/kamailio/commit/3f6fc7d42100800f94a5f3b66409164… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-02-21T18:56:12+01:00 Registrar Remove SVN ID and history --- Modified: modules/registrar/api.c Modified: modules/registrar/api.h Modified: modules/registrar/common.c Modified: modules/registrar/common.h Modified: modules/registrar/config.c Modified: modules/registrar/config.h Modified: modules/registrar/lookup.c Modified: modules/registrar/lookup.h Modified: modules/registrar/path.c Modified: modules/registrar/path.h Modified: modules/registrar/reg_mod.c Modified: modules/registrar/reg_mod.h Modified: modules/registrar/regpv.c Modified: modules/registrar/regpv.h Modified: modules/registrar/regtime.c Modified: modules/registrar/regtime.h Modified: modules/registrar/reply.c Modified: modules/registrar/reply.h Modified: modules/registrar/rerrno.c Modified: modules/registrar/rerrno.h Modified: modules/registrar/save.c Modified: modules/registrar/save.h Modified: modules/registrar/sip_msg.c Modified: modules/registrar/sip_msg.h --- Diff: https://github.com/kamailio/kamailio/commit/3f6fc7d42100800f94a5f3b66409164… Patch: https://github.com/kamailio/kamailio/commit/3f6fc7d42100800f94a5f3b66409164…

9 years, 9 months

← Newer
1
...
5
6
7
8
9
10
11
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2015