sr-dev June 2015

sr-dev@lists.kamailio.org

34 participants
274 discussions

Re: [sr-dev] Kamailio crashes when using replace_body_atonce from Textops
by denis＠dilvest.com 17 Jun '15

17 Jun '15

update + workaround replace_body_atonce function is very similar to replace_body_all but is replace_body_atonce is defined to use fixup_regexpNL_none for incoming parameters processing. Apparantly something in fixup_regexpNL_none is causing the issue because when I change definition for replace_body_atonce to use fixup_regexp_none (just like its "sister" function replace_body_all) everything is working fine and no crash. I am not sure about significance of fixup_regexpNL_none as it is not used by any other function but replace_body_atonce however, as workaround I ended up utilizing replace_body_all for my search + replace needs. As far as fixup_regexpNL_none; I see it uses regcomp but I do not see a call to regfee... So that is might be the root cause of the memory issue. -----Original Message----- From: denis(a)dilvest.com [mailto:denis@dilvest.com] Sent: Wednesday, June 17, 2015 4:59 PM To: 'sr-dev(a)lists.sip-router.org' Subject: RE: Kamailio crashes when using replace_body_atonce from Textops upon further tracing it looks like crash happens in action.c MODF_RVE_PARAM_FREE when calling pkg_free((dst)[i+2].u.data); -----Original Message----- From: denis(a)dilvest.com [mailto:denis@dilvest.com] Sent: Wednesday, June 17, 2015 1:25 PM To: 'sr-dev(a)lists.sip-router.org' Subject: Kamailio crashes when using replace_body_atonce from Textops Hi, Need some help resolving Kamailio crash. Kamailio version 4.1 on Centos (uname -r "Linux 2.6.18-164.11.1.el5") The issue: I want to replace text in the message body using replace_body_atonce from TextOps module Works fine when called like: replace_body_atonce("123456789","000"); Works fine when called like: $var(replacewith)="000"; replace_body_atonce("123456789",$var(replacewith)); However, Kamailio crashes when called like $var(findwhat)="123456789"; $var(replacewith)="000"; replace_body_atonce($var(findwhat),$var(replacewith)); The following is in the log Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: ERROR: textops [textops.c:570]: do_replace_body_f(): exit Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: : <core> [mem/q_malloc.c:454]: qm_free(): BUG: qm_free: bad pointer 0xc0c0c0c0 (out of memory block!) called from <core>: action.c: do_action(1164) - aborting Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:778]: handle_sigs(): child process 18614 exited by a signal 6 Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:781]: handle_sigs(): core was not generated For some reason no core dump is generated ( i have tried "ulimit -c unlimited" and "echo "1" > /proc/sys/kernel/core_uses_pid"). However, I added log entry right before replace_body_atonce returns and I do see that replace_body_atonce completes and returns but then crashes. I can easily reproduce the issue. Please let me know if you have some suggestion to try (even in the code as I can recompile it). Thanks, Denis

1 0

Re: [sr-dev] Kamailio crashes when using replace_body_atonce from Textops
by denis＠dilvest.com 17 Jun '15

17 Jun '15

upon further tracing it looks like crash happens in action.c MODF_RVE_PARAM_FREE when calling pkg_free((dst)[i+2].u.data); -----Original Message----- From: denis(a)dilvest.com [mailto:denis@dilvest.com] Sent: Wednesday, June 17, 2015 1:25 PM To: 'sr-dev(a)lists.sip-router.org' Subject: Kamailio crashes when using replace_body_atonce from Textops Hi, Need some help resolving Kamailio crash. Kamailio version 4.1 on Centos (uname -r "Linux 2.6.18-164.11.1.el5") The issue: I want to replace text in the message body using replace_body_atonce from TextOps module Works fine when called like: replace_body_atonce("123456789","000"); Works fine when called like: $var(replacewith)="000"; replace_body_atonce("123456789",$var(replacewith)); However, Kamailio crashes when called like $var(findwhat)="123456789"; $var(replacewith)="000"; replace_body_atonce($var(findwhat),$var(replacewith)); The following is in the log Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: ERROR: textops [textops.c:570]: do_replace_body_f(): exit Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: : <core> [mem/q_malloc.c:454]: qm_free(): BUG: qm_free: bad pointer 0xc0c0c0c0 (out of memory block!) called from <core>: action.c: do_action(1164) - aborting Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:778]: handle_sigs(): child process 18614 exited by a signal 6 Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:781]: handle_sigs(): core was not generated For some reason no core dump is generated ( i have tried "ulimit -c unlimited" and "echo "1" > /proc/sys/kernel/core_uses_pid"). However, I added log entry right before replace_body_atonce returns and I do see that replace_body_atonce completes and returns but then crashes. I can easily reproduce the issue. Please let me know if you have some suggestion to try (even in the code as I can recompile it). Thanks, Denis

1 0

Kamailio crashes when using replace_body_atonce from Textops
by denis＠dilvest.com 17 Jun '15

17 Jun '15

Hi, Need some help resolving Kamailio crash. Kamailio version 4.1 on Centos (uname -r "Linux 2.6.18-164.11.1.el5") The issue: I want to replace text in the message body using replace_body_atonce from TextOps module Works fine when called like: replace_body_atonce("123456789","000"); Works fine when called like: $var(replacewith)="000"; replace_body_atonce("123456789",$var(replacewith)); However, Kamailio crashes when called like $var(findwhat)="123456789"; $var(replacewith)="000"; replace_body_atonce($var(findwhat),$var(replacewith)); The following is in the log Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: ERROR: textops [textops.c:570]: do_replace_body_f(): exit Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18614]: : <core> [mem/q_malloc.c:454]: qm_free(): BUG: qm_free: bad pointer 0xc0c0c0c0 (out of memory block!) called from <core>: action.c: do_action(1164) - aborting Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:778]: handle_sigs(): child process 18614 exited by a signal 6 Jun 17 16:21:08 tms /usr/local/sbin/kamailio[18612]: ALERT: <core> [main.c:781]: handle_sigs(): core was not generated For some reason no core dump is generated ( i have tried "ulimit -c unlimited" and "echo "1" > /proc/sys/kernel/core_uses_pid"). However, I added log entry right before replace_body_atonce returns and I do see that replace_body_atonce completes and returns but then crashes. I can easily reproduce the issue. Please let me know if you have some suggestion to try (even in the code as I can recompile it). Thanks, Denis

1 0

[kamailio] added RURI-pattern matching and priority (#152)
by Emmanuel Schmidbauer 17 Jun '15

17 Jun '15

Hello, This pull request adds 2 features. --Prioritize the trusted records (highest to lowest priority) --Match from-uri AND request-uri, if either is blank only one is matched. Please review the pull request and let me know if any other changes are needed. Thank you. Emmanuel You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/152 -- Commit Summary -- * added RURI-pattern matching and priority -- File Changes -- M modules/permissions/hash.c (65) M modules/permissions/hash.h (8) M modules/permissions/permissions.c (4) M modules/permissions/permissions.h (2) M modules/permissions/trusted.c (103) M utils/kamctl/db_sqlite/permissions-create.sql (6) M utils/kamctl/mysql/permissions-create.sql (6) M utils/kamctl/oracle/permissions-create.sql (6) M utils/kamctl/postgres/permissions-create.sql (6) M utils/kamctl/xhttp_pi/permissions-table (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/152.patch https://github.com/kamailio/kamailio/pull/152.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/152

2 11

git:master:6b76de9f: kamctl: regenerated database creation scripts
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 6b76de9f7d991ed3fdc5f2f28dde7bcb1962108b URL: https://github.com/kamailio/kamailio/commit/6b76de9f7d991ed3fdc5f2f28dde7bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:24:53+02:00 kamctl: regenerated database creation scripts --- Modified: utils/kamctl/db_berkeley/kamailio/trusted Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/db_sqlite/permissions-create.sql Modified: utils/kamctl/dbtext/kamailio/trusted Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mysql/permissions-create.sql Modified: utils/kamctl/oracle/permissions-create.sql Modified: utils/kamctl/postgres/permissions-create.sql Modified: utils/kamctl/xhttp_pi/permissions-mod Modified: utils/kamctl/xhttp_pi/permissions-table Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/6b76de9f7d991ed3fdc5f2f28dde7bc… Patch: https://github.com/kamailio/kamailio/commit/6b76de9f7d991ed3fdc5f2f28dde7bc…

1 0

git:master:2e370f28: lib/srdb1: updated schema for trusted table of permissions module
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 2e370f2868f01f6a3fd0bc98159ee2e2d5fea25e URL: https://github.com/kamailio/kamailio/commit/2e370f2868f01f6a3fd0bc98159ee2e… Author: Emmanuel Schmidbauer <eschmidbauer(a)voipxswitch.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:24:08+02:00 lib/srdb1: updated schema for trusted table of permissions module --- Modified: lib/srdb1/schema/trusted.xml --- Diff: https://github.com/kamailio/kamailio/commit/2e370f2868f01f6a3fd0bc98159ee2e… Patch: https://github.com/kamailio/kamailio/commit/2e370f2868f01f6a3fd0bc98159ee2e… --- diff --git a/lib/srdb1/schema/trusted.xml b/lib/srdb1/schema/trusted.xml index 179e3f4..3959851 100644 --- a/lib/srdb1/schema/trusted.xml +++ b/lib/srdb1/schema/trusted.xml @@ -9,7 +9,7 @@ <table id="trusted" xmlns:db="http://docbook.org/ns/docbook"> <name>trusted</name> - <version>5</version> + <version>6</version> <type db="mysql">&MYSQL_TABLE_TYPE;</type> <description> <db:para>This table is used by the permissions module to determine if a call has the appropriate permission to be established. More information about the permissions module can be found at: &KAMAILIO_MOD_DOC;permissions.html @@ -51,6 +51,15 @@ </column> <column> + <name>ruri_pattern</name> + <type>string</type> + <size>&id_len;</size> + <default><null/></default> + <null/> + <description>Regular expression matches Request URI of request.</description> + </column> + + <column> <name>tag</name> <type>string</type> <size>64</size> @@ -58,6 +67,13 @@ <description>Tag</description> </column> + <column> + <name>priority</name> + <type>int</type> + <default>0</default> + <description>Priority of rule.</description> + </column> + <index> <name>peer_idx</name> <colref linkend="src_ip"/>

1 0

git:master:4f635fad: permissions: match trusted rules considering priority and regexp over r-uri
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 4f635fadff53ef54d152d9690e080eb07a5786b0 URL: https://github.com/kamailio/kamailio/commit/4f635fadff53ef54d152d9690e080eb… Author: Emmanuel Schmidbauer <eschmidbauer(a)voipxswitch.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:18:18+02:00 permissions: match trusted rules considering priority and regexp over r-uri - two new columns to set priority of the rule as well as regular expression matching over r-uri --- Modified: modules/permissions/hash.c Modified: modules/permissions/hash.h Modified: modules/permissions/permissions.c Modified: modules/permissions/permissions.h Modified: modules/permissions/trusted.c --- Diff: https://github.com/kamailio/kamailio/commit/4f635fadff53ef54d152d9690e080eb… Patch: https://github.com/kamailio/kamailio/commit/4f635fadff53ef54d152d9690e080eb…

1 0

git:master:81243627: permissions: README regenerated
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 81243627ce07cd32804a6a1e15e0dc407f56f887 URL: https://github.com/kamailio/kamailio/commit/81243627ce07cd32804a6a1e15e0dc4… Author: Emmanuel Schmidbauer <eschmidbauer(a)voipxswitch.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:18:00+02:00 permissions: README regenerated --- Modified: modules/permissions/README --- Diff: https://github.com/kamailio/kamailio/commit/81243627ce07cd32804a6a1e15e0dc4… Patch: https://github.com/kamailio/kamailio/commit/81243627ce07cd32804a6a1e15e0dc4…

1 0

git:master:15091551: permissions: updated docs with parameters for new columns of trusted table
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 15091551cdfddc6f85db4dec8b47b4f5401399d2 URL: https://github.com/kamailio/kamailio/commit/15091551cdfddc6f85db4dec8b47b4f… Author: Emmanuel Schmidbauer <eschmidbauer(a)voipxswitch.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:17:07+02:00 permissions: updated docs with parameters for new columns of trusted table - used for setting priority and regexp matching over r-uri --- Modified: modules/permissions/doc/permissions.xml Modified: modules/permissions/doc/permissions_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/15091551cdfddc6f85db4dec8b47b4f… Patch: https://github.com/kamailio/kamailio/commit/15091551cdfddc6f85db4dec8b47b4f… --- diff --git a/modules/permissions/doc/permissions.xml b/modules/permissions/doc/permissions.xml index 9da70ee..482b5cf 100644 --- a/modules/permissions/doc/permissions.xml +++ b/modules/permissions/doc/permissions.xml @@ -41,6 +41,13 @@ <email>jh(a)tutpro.com</email> </address> </editor> + <editor> + <firstname>Emmanuel</firstname> + <surname>Schmidbauer</surname> + <address> + <email>eschmidbauer(a)voipxswitch.com</email> + </address> + </editor> </authorgroup> <copyright> <year>2003</year> diff --git a/modules/permissions/doc/permissions_admin.xml b/modules/permissions/doc/permissions_admin.xml index 82785d5..ce93321 100644 --- a/modules/permissions/doc/permissions_admin.xml +++ b/modules/permissions/doc/permissions_admin.xml @@ -664,6 +664,26 @@ modparam("permissions", "from_col", "regexp") </programlisting> </example> </section> + <section id ="permissions.p.ruri_col"> + <title><varname>ruri_col</varname> (string)</title> + <para> + Name of the column trusted table containing a regular + expression that is matched against the Request URI. + </para> + <para> + <emphasis> + Default value is <quote>ruri_pattern</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>ruri_col</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("permissions", "ruri_col", "regexp") +... +</programlisting> + </example> + </section> <section id ="permissions.p.tag_col"> <title><varname>tag_col</varname> (string)</title> <para> @@ -686,6 +706,26 @@ modparam("permissions", "tag_col", "peer_tag") </programlisting> </example> </section> + <section id ="permissions.p.priority_col"> + <title><varname>priority_col</varname> (integer)</title> + <para> + The column name used to store the priority of the corresponding rule from the database + row. + </para> + <para> + <emphasis> + Default value is <quote>priority</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>priority_col</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("permissions", "priority_col", "column_name") +... +</programlisting> + </example> + </section> <section id ="permissions.p.peer_tag_avp"> <title><varname>peer_tag_avp</varname> (AVP string)</title> <para>

1 0

git:master:8a9d7df5: utils: fixed indentation
by Daniel-Constantin Mierla 17 Jun '15

17 Jun '15

Module: kamailio Branch: master Commit: 8a9d7df57e0ac83bb8fb6f97c71b01ec96184ba0 URL: https://github.com/kamailio/kamailio/commit/8a9d7df57e0ac83bb8fb6f97c71b01e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-06-17T16:12:44+02:00 utils: fixed indentation --- Modified: modules/utils/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/8a9d7df57e0ac83bb8fb6f97c71b01e… Patch: https://github.com/kamailio/kamailio/commit/8a9d7df57e0ac83bb8fb6f97c71b01e…

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2015