sr-dev July 2015

sr-dev@lists.kamailio.org

26 participants
301 discussions

git:master:6656d445: acc: note about setting acc flag for ACKs that should be recorded

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6656d4459f0c7d4c1b7cb5d2b214201c5a587c5c URL: https://github.com/kamailio/kamailio/commit/6656d4459f0c7d4c1b7cb5d2b214201… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T18:24:09+02:00 acc: note about setting acc flag for ACKs that should be recorded --- Modified: modules/acc/README Modified: modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6656d4459f0c7d4c1b7cb5d2b214201… Patch: https://github.com/kamailio/kamailio/commit/6656d4459f0c7d4c1b7cb5d2b214201… --- diff --git a/modules/acc/README b/modules/acc/README index 2c742ee..a019b0e 100644 --- a/modules/acc/README +++ b/modules/acc/README @@ -767,7 +767,8 @@ modparam("acc", "failed_filter", "404,407") Shall acc attempt to account e2e ACKs too ? Note that this is really only an attempt, as e2e ACKs may take a different path (unless RR enabled) and mismatch original INVITE (e2e ACKs are a separate - transaction). + transaction). The flag for accounting has to be set for each ACK as + well. Default value is 0 (no). diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index 820f480..fbe7dc3 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -559,7 +559,8 @@ modparam("acc", "failed_filter", "404,407") Shall acc attempt to account e2e ACKs too ? Note that this is really only an attempt, as e2e ACKs may take a different path (unless RR enabled) and mismatch original INVITE (e2e ACKs are - a separate transaction). + a separate transaction). The flag for accounting has to be set + for each ACK as well. </para> <para> Default value is 0 (no).

9 years, 4 months

git:4.3:e5f8d628: uac: reset ongoing registration state if retry interval is exceeded

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: e5f8d6282eefbe4c8ad0b0309ac06ab468e9b1f2 URL: https://github.com/kamailio/kamailio/commit/e5f8d6282eefbe4c8ad0b0309ac06ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T15:09:31+02:00 uac: reset ongoing registration state if retry interval is exceeded - cover the case of remote registration process stuck in ongoing state for long time - reported by Andy J Robinson, GH #255 (cherry picked from commit cfa6831f9a81988dc1844ba3e4e6048c12841606) --- Modified: modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/e5f8d6282eefbe4c8ad0b0309ac06ab… Patch: https://github.com/kamailio/kamailio/commit/e5f8d6282eefbe4c8ad0b0309ac06ab… --- diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c index 0cff689..7b7d2de 100644 --- a/modules/uac/uac_reg.c +++ b/modules/uac/uac_reg.c @@ -928,8 +928,13 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) return -1; if(reg->expires==0) return 1; - if(reg->flags&UAC_REG_ONGOING) - return 2; + if(reg->flags&UAC_REG_ONGOING) { + if (reg->timer_expires > tn - reg_retry_interval) + return 2; + LM_DBG("record marked as ongoing registration (%d) - resetting\n", + (int)reg->flags); + reg->flags &= ~(UAC_REG_ONLINE|UAC_REG_AUTHSENT); + } if(reg->flags&UAC_REG_DISABLED) return 4; if(reg->timer_expires > tn + reg_timer_interval + 3)

9 years, 4 months

git:4.3:aa91d8ba: tm: more verbose debug message when local transaction is completed

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: aa91d8ba178624c08ffcbb6af55efa777f6ca640 URL: https://github.com/kamailio/kamailio/commit/aa91d8ba178624c08ffcbb6af55efa7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T15:09:23+02:00 tm: more verbose debug message when local transaction is completed (cherry picked from commit 54fea03a078f8258d124a83443617c54bdbc2574) --- Modified: modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/aa91d8ba178624c08ffcbb6af55efa7… Patch: https://github.com/kamailio/kamailio/commit/aa91d8ba178624c08ffcbb6af55efa7… --- diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index d14ed1c..b2e6e53 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -2050,7 +2050,8 @@ enum rps local_reply( struct cell *t, struct sip_msg *p_msg, int branch, } if (local_winner>=0 && winning_code>=200 ) { - DBG("DEBUG: local transaction completed\n"); + DBG("DEBUG: local transaction completed %d/%d (totag retr: %d/%d)\n", + winning_code, local_winner, totag_retr, t->tmcb_hl.reg_types); if (!totag_retr) { if (unlikely(has_tran_tmcbs(t,TMCB_LOCAL_COMPLETED) )) run_trans_callbacks( TMCB_LOCAL_COMPLETED, t, 0,

9 years, 4 months

git:master:646d229b: ims_registrar_pcscf: Generated README + typo in Docbook

by Carsten Bock

Module: kamailio Branch: master Commit: 646d229b0ba471d327a03f710c3347a545698297 URL: https://github.com/kamailio/kamailio/commit/646d229b0ba471d327a03f710c3347a… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-07-27T15:39:22+02:00 ims_registrar_pcscf: Generated README + typo in Docbook --- Added: modules/ims_registrar_pcscf/README Modified: modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/646d229b0ba471d327a03f710c3347a… Patch: https://github.com/kamailio/kamailio/commit/646d229b0ba471d327a03f710c3347a…

9 years, 4 months

git:master:b859f8ca: ims_registrar_pcscf: Added functionality to unREGISTER a contact, eg. based on a failed network ping

by Carsten Bock

Module: kamailio Branch: master Commit: b859f8ca2082022e04d50a90d25fe8de17522b08 URL: https://github.com/kamailio/kamailio/commit/b859f8ca2082022e04d50a90d25fe8d… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-07-27T15:34:37+02:00 ims_registrar_pcscf: Added functionality to unREGISTER a contact, eg. based on a failed network ping --- Modified: modules/ims_registrar_pcscf/reg_mod.c Modified: modules/ims_registrar_pcscf/save.h Modified: modules/ims_registrar_pcscf/service_routes.c Modified: modules/ims_registrar_pcscf/service_routes.h --- Diff: https://github.com/kamailio/kamailio/commit/b859f8ca2082022e04d50a90d25fe8d… Patch: https://github.com/kamailio/kamailio/commit/b859f8ca2082022e04d50a90d25fe8d…

9 years, 4 months

git:master:fb5d38b1: ims_registrar_pcscf: Initial Documentation on module

by Carsten Bock

Module: kamailio Branch: master Commit: fb5d38b12efb456edd9e2d5a31fe7b31d3bb9e90 URL: https://github.com/kamailio/kamailio/commit/fb5d38b12efb456edd9e2d5a31fe7b3… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-07-27T15:34:37+02:00 ims_registrar_pcscf: Initial Documentation on module --- Added: modules/ims_registrar_pcscf/doc/Makefile Added: modules/ims_registrar_pcscf/doc/ims_registrar_pcscf.xml Added: modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fb5d38b12efb456edd9e2d5a31fe7b3… Patch: https://github.com/kamailio/kamailio/commit/fb5d38b12efb456edd9e2d5a31fe7b3…

9 years, 4 months

git:master:cfa6831f: uac: reset ongoing registration state if retry interval is exceeded

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: cfa6831f9a81988dc1844ba3e4e6048c12841606 URL: https://github.com/kamailio/kamailio/commit/cfa6831f9a81988dc1844ba3e4e6048… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T15:04:30+02:00 uac: reset ongoing registration state if retry interval is exceeded - cover the case of remote registration process stuck in ongoing state for long time - reported by Andy J Robinson, GH #255 --- Modified: modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/cfa6831f9a81988dc1844ba3e4e6048… Patch: https://github.com/kamailio/kamailio/commit/cfa6831f9a81988dc1844ba3e4e6048… --- diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c index 0cff689..7b7d2de 100644 --- a/modules/uac/uac_reg.c +++ b/modules/uac/uac_reg.c @@ -928,8 +928,13 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) return -1; if(reg->expires==0) return 1; - if(reg->flags&UAC_REG_ONGOING) - return 2; + if(reg->flags&UAC_REG_ONGOING) { + if (reg->timer_expires > tn - reg_retry_interval) + return 2; + LM_DBG("record marked as ongoing registration (%d) - resetting\n", + (int)reg->flags); + reg->flags &= ~(UAC_REG_ONLINE|UAC_REG_AUTHSENT); + } if(reg->flags&UAC_REG_DISABLED) return 4; if(reg->timer_expires > tn + reg_timer_interval + 3)

9 years, 4 months

git:master:54fea03a: tm: more verbose debug message when local transaction is completed

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 54fea03a078f8258d124a83443617c54bdbc2574 URL: https://github.com/kamailio/kamailio/commit/54fea03a078f8258d124a83443617c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T15:03:21+02:00 tm: more verbose debug message when local transaction is completed --- Modified: modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/54fea03a078f8258d124a83443617c5… Patch: https://github.com/kamailio/kamailio/commit/54fea03a078f8258d124a83443617c5… --- diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index d14ed1c..b2e6e53 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -2050,7 +2050,8 @@ enum rps local_reply( struct cell *t, struct sip_msg *p_msg, int branch, } if (local_winner>=0 && winning_code>=200 ) { - DBG("DEBUG: local transaction completed\n"); + DBG("DEBUG: local transaction completed %d/%d (totag retr: %d/%d)\n", + winning_code, local_winner, totag_retr, t->tmcb_hl.reg_types); if (!totag_retr) { if (unlikely(has_tran_tmcbs(t,TMCB_LOCAL_COMPLETED) )) run_trans_callbacks( TMCB_LOCAL_COMPLETED, t, 0,

9 years, 4 months

git:4.2:190d994f: acc: use proper ack message struct for external engine accounting of ACK

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: 190d994fcab3b79b06132029dd288fc9c0c4cf33 URL: https://github.com/kamailio/kamailio/commit/190d994fcab3b79b06132029dd288fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T13:45:04+02:00 acc: use proper ack message struct for external engine accounting of ACK - reported by Yasin Caner - GH #266 (cherry picked from commit 58acd28f620c4a4e6b9abb1b9a2dfa2d8556708c) (cherry picked from commit a18915e019ebcfa35805d3985383705028fbc00c) --- Modified: modules/acc/acc_logic.c --- Diff: https://github.com/kamailio/kamailio/commit/190d994fcab3b79b06132029dd288fc… Patch: https://github.com/kamailio/kamailio/commit/190d994fcab3b79b06132029dd288fc… --- diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index bd3f1cc..16a97e5 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -615,7 +615,7 @@ static inline void acc_onack( struct cell* t, struct sip_msg *req, #endif /* run extra acc engines */ - acc_run_engines(req, 0, NULL); + acc_run_engines(ack, 0, NULL); }

9 years, 4 months

git:4.3:a18915e0: acc: use proper ack message struct for external engine accounting of ACK

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: a18915e019ebcfa35805d3985383705028fbc00c URL: https://github.com/kamailio/kamailio/commit/a18915e019ebcfa35805d3985383705… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T13:44:31+02:00 acc: use proper ack message struct for external engine accounting of ACK - reported by Yasin Caner - GH #266 (cherry picked from commit 58acd28f620c4a4e6b9abb1b9a2dfa2d8556708c) --- Modified: modules/acc/acc_logic.c --- Diff: https://github.com/kamailio/kamailio/commit/a18915e019ebcfa35805d3985383705… Patch: https://github.com/kamailio/kamailio/commit/a18915e019ebcfa35805d3985383705… --- diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index bd3f1cc..16a97e5 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -615,7 +615,7 @@ static inline void acc_onack( struct cell* t, struct sip_msg *req, #endif /* run extra acc engines */ - acc_run_engines(req, 0, NULL); + acc_run_engines(ack, 0, NULL); }

9 years, 4 months

← Newer
1
...
9
10
11
12
13
14
15
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2015