sr-dev August 2015

sr-dev@lists.kamailio.org

30 participants
191 discussions

by Torge Szczepanek

Hi! We are using the t_uac_dlg function through a UDP MI Datagram to create local SIP/TCP requests. We are seeing a memory leak of increasing shared Memory usage, which is increasing at the same rate as tcp connections are created (tested under 4.0.1 and 4.3.1). /usr/sbin/kamailio[25407]: NOTICE: fm_status: count= 71943 size= 14126536 bytes from mi_datagram: datagram_fnc.c: build_async_handler(387) After looking at the memory dump and investigating the source, I guess that the memory leak is created, when the MI_ASYNC_RPL_FLAG is set. This seems to be set by: modules/tmx/tmx_mod.c: {MI_TM_UAC, mi_tm_uac_dlg, MI_ASYNC_RPL_FLAG, 0, 0 }, only, which we are using heavily. Can someone please give me a hint, where to search for the memory leak. My guess is that: modules/mi_datagram/datagram_fnc.c:489 if (f->flags&MI_ASYNC_RPL_FLAG) { hdl = build_async_handler(mi_socket_domain, (struct sockaddr* )&reply_addr, reply_addr_len); the handler is not correctly freed up in the async reply case. Thank you! Greetings Torge Szczepanek

9 years, 3 months

git:master:a6609f5f: usrloc: New matching mode: CALLID_ONLY

by Carsten Bock

Module: kamailio Branch: master Commit: a6609f5fb3a66c89936dc0f929dbe23dad59b503 URL: https://github.com/kamailio/kamailio/commit/a6609f5fb3a66c89936dc0f929dbe23… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-08-20T10:48:55+02:00 usrloc: New matching mode: CALLID_ONLY --- Modified: modules/usrloc/README Modified: modules/usrloc/doc/usrloc.xml Modified: modules/usrloc/doc/usrloc_admin.xml Modified: modules/usrloc/ul_mod.c Modified: modules/usrloc/ul_mod.h Modified: modules/usrloc/urecord.c --- Diff: https://github.com/kamailio/kamailio/commit/a6609f5fb3a66c89936dc0f929dbe23… Patch: https://github.com/kamailio/kamailio/commit/a6609f5fb3a66c89936dc0f929dbe23…

9 years, 3 months

(no subject)

by Luis Azedo

Hi, i propose to add a change to registrar module so that it updates sip_msg.ruid on successfull save. this will allow to get $ruid after save to forward the $ruid to other places. thoughts ?

9 years, 3 months

CRITICAL log on kamailio startup

by Nuno Reis

Hi guys. I've noticed this CRITICAL log line on kamailio startup: CRITICAL: dialog [dlg_cb.c:137]: register_dlgcb(): DLGCB_CREATED type registered after shutdown!?! This line started to show up after upgrade from 4.2.x to 4.3 and now to 4.3.1. Everything seems to be working fine and a really don't see any harm anywhere. Could you please comment on this? Cheers, -- *Nuno Miguel Reis* | *Unified Communication** Systems* M. +351 913907481 | nreis(a)wavecom.pt WAVECOM-Soluções Rádio, S.A. Cacia Park | Rua do Progresso, Lote 15 3800-639 AVEIRO | Portugal T. +351 309 700 225 | F. +351 234 919 191 *GPS <http://maps.google.com/maps/ms?msa=0&msid=202333747613191340808.0004b4b227a…> | www.wavecom.pt <http://www.wavecom.pt/>** <http://www.wavecom.pt/>* <http://www.wavecom.pt/> <http://www.wavecom.pt/pt/>

9 years, 3 months

git:master:0868ed0e: auth: modify doc to reflect current implementation

by Camille Oudot

Module: kamailio Branch: master Commit: 0868ed0ef12e65c7790beeccf139b5fdc245efdb URL: https://github.com/kamailio/kamailio/commit/0868ed0ef12e65c7790beeccf139b5f… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: 2015-08-12T17:33:00+02:00 auth: modify doc to reflect current implementation --- Modified: modules/auth/doc/auth_functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/0868ed0ef12e65c7790beeccf139b5f… Patch: https://github.com/kamailio/kamailio/commit/0868ed0ef12e65c7790beeccf139b5f… --- diff --git a/modules/auth/doc/auth_functions.xml b/modules/auth/doc/auth_functions.xml index ec33324..225dbb3 100644 --- a/modules/auth/doc/auth_functions.xml +++ b/modules/auth/doc/auth_functions.xml @@ -204,10 +204,6 @@ if (!auth_check("$fd", "subscriber", "1")) { <emphasis>-2 (invalid password)</emphasis> - wrong password </para></listitem> <listitem><para> - <emphasis>-3 (invalid user)</emphasis> - authentication user does - not exist - </para></listitem> - <listitem><para> <emphasis>-4 (nonce expired)</emphasis> - the nonce has expired </para></listitem> <listitem><para> @@ -218,10 +214,6 @@ if (!auth_check("$fd", "subscriber", "1")) { <emphasis>-6 (nonce reused)</emphasis> - the nonce has already been used to authenticate a previous request </para></listitem> - <listitem><para> - <emphasis>-8 (auth user mismatch)</emphasis> - the auth user is different - then the From/To user - </para></listitem> </itemizedlist> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -357,6 +349,13 @@ if (!pv_proxy_authenticate("$fd", "$avp(password)", "0")) { request or not. The parameter may be a pseudo variable. </para> <para> + The set of possible return codes is the same than pv_{www,proxy}_authenticate, with + one more possible value: + <para><emphasis>-8 (auth user mismatch)</emphasis> - the auth user is different + than the From/To user + </para> + </para> + <para> This function can be used from REQUEST_ROUTE. </para> <example>

9 years, 3 months

git:master:eb9da343: app_lua: Export more sdpops functions to LUA

by Hugh Waite

Module: kamailio Branch: master Commit: eb9da34377130db968913fcda139070d47053d88 URL: https://github.com/kamailio/kamailio/commit/eb9da34377130db968913fcda139070… Author: Hugh Waite <hugh.waite(a)acision.com> Committer: Hugh Waite <hugh.waite(a)acision.com> Date: 2015-08-12T17:51:25+01:00 app_lua: Export more sdpops functions to LUA - sdp_with_active_media - sdp_with_transport - sdp_with_codecs_by_id - sdp_with_codecs_by_name - sdp_with_ice - sdp_keep_codecs_by_id - sdp_keep_codecs_by_name - sdp_remove_media - sdp_remove_transport - sdp_remove_line_by_prefix - sdp_remove_codecs_by_id - sdp_remove_codecs_by_name --- Modified: modules/app_lua/app_lua_exp.c --- Diff: https://github.com/kamailio/kamailio/commit/eb9da34377130db968913fcda139070… Patch: https://github.com/kamailio/kamailio/commit/eb9da34377130db968913fcda139070…

9 years, 3 months

git:master:56b17076: sdpops: Export more sdpops functions

by Hugh Waite

Module: kamailio Branch: master Commit: 56b17076be90db99058bec51ad73a5e84d6616ad URL: https://github.com/kamailio/kamailio/commit/56b17076be90db99058bec51ad73a5e… Author: Hugh Waite <hugh.waite(a)acision.com> Committer: Hugh Waite <hugh.waite(a)acision.com> Date: 2015-08-12T17:48:05+01:00 sdpops: Export more sdpops functions - sdp_with_active_media - sdp_with_transport - sdp_with_codecs_by_id - sdp_with_codecs_by_name - sdp_with_ice - sdp_keep_codecs_by_id - sdp_keep_codecs_by_name - sdp_remove_media - sdp_remove_transport - sdp_remove_line_by_prefix - sdp_remove_codecs_by_id - sdp_remove_codecs_by_name --- Modified: modules/sdpops/api.h Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/56b17076be90db99058bec51ad73a5e… Patch: https://github.com/kamailio/kamailio/commit/56b17076be90db99058bec51ad73a5e…

9 years, 3 months

git:4.3:48d78ce8: auth: modify doc to reflect current implementation

by Camille Oudot

Module: kamailio Branch: 4.3 Commit: 48d78ce87e2f42bdc77e688a0f45ff725ea97de5 URL: https://github.com/kamailio/kamailio/commit/48d78ce87e2f42bdc77e688a0f45ff7… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: 2015-08-12T17:40:24+02:00 auth: modify doc to reflect current implementation (cherry picked from commit 0868ed0ef12e65c7790beeccf139b5fdc245efdb) --- Modified: modules/auth/doc/auth_functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/48d78ce87e2f42bdc77e688a0f45ff7… Patch: https://github.com/kamailio/kamailio/commit/48d78ce87e2f42bdc77e688a0f45ff7… --- diff --git a/modules/auth/doc/auth_functions.xml b/modules/auth/doc/auth_functions.xml index ec33324..225dbb3 100644 --- a/modules/auth/doc/auth_functions.xml +++ b/modules/auth/doc/auth_functions.xml @@ -204,10 +204,6 @@ if (!auth_check("$fd", "subscriber", "1")) { <emphasis>-2 (invalid password)</emphasis> - wrong password </para></listitem> <listitem><para> - <emphasis>-3 (invalid user)</emphasis> - authentication user does - not exist - </para></listitem> - <listitem><para> <emphasis>-4 (nonce expired)</emphasis> - the nonce has expired </para></listitem> <listitem><para> @@ -218,10 +214,6 @@ if (!auth_check("$fd", "subscriber", "1")) { <emphasis>-6 (nonce reused)</emphasis> - the nonce has already been used to authenticate a previous request </para></listitem> - <listitem><para> - <emphasis>-8 (auth user mismatch)</emphasis> - the auth user is different - then the From/To user - </para></listitem> </itemizedlist> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -357,6 +349,13 @@ if (!pv_proxy_authenticate("$fd", "$avp(password)", "0")) { request or not. The parameter may be a pseudo variable. </para> <para> + The set of possible return codes is the same than pv_{www,proxy}_authenticate, with + one more possible value: + <para><emphasis>-8 (auth user mismatch)</emphasis> - the auth user is different + than the From/To user + </para> + </para> + <para> This function can be used from REQUEST_ROUTE. </para> <example>

9 years, 3 months

git:master:82f13f5d: Merge pull request #284 from jnewmano/master

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 82f13f5d020ebd0ce4ff4c692a4e6d6567f5f5b7 URL: https://github.com/kamailio/kamailio/commit/82f13f5d020ebd0ce4ff4c692a4e6d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-08-12T11:17:53+02:00 Merge pull request #284 from jnewmano/master janssonrpc-c: allow null json error property in rpc response --- Modified: modules/janssonrpc-c/janssonrpc_io.c --- Diff: https://github.com/kamailio/kamailio/commit/82f13f5d020ebd0ce4ff4c692a4e6d6… Patch: https://github.com/kamailio/kamailio/commit/82f13f5d020ebd0ce4ff4c692a4e6d6… --- diff --git a/modules/janssonrpc-c/janssonrpc_io.c b/modules/janssonrpc-c/janssonrpc_io.c index ffcc247..1e1a82b 100644 --- a/modules/janssonrpc-c/janssonrpc_io.c +++ b/modules/janssonrpc-c/janssonrpc_io.c @@ -587,9 +587,12 @@ int handle_response(json_t* response) return_obj = json_object(); json_t* error = json_object_get(response, "error"); + // if the error value is null, we don't care + bool _error = error && (json_typeof(error) != JSON_NULL); + json_t* result = json_object_get(response, "result"); - if(error) { + if(_error) { json_object_set(return_obj, "error", error); } @@ -597,7 +600,7 @@ int handle_response(json_t* response) json_object_set(return_obj, "result", result); } - if ((!result && !error) || (result && error)) { + if ((!result && !_error) || (result && _error)) { WARN("bad response\n"); internal = internal_error(JRPC_ERR_BAD_RESP, req->payload); json_object_update(return_obj, internal); @@ -621,7 +624,7 @@ int handle_response(json_t* response) goto free_and_end; } - if(error) { + if(_error) { // get code from error json_t* _code = json_object_get(error, "code"); if(_code) {

9 years, 3 months

git:master:92ba30d6: janssonrpc-c: allow null json error property in rpc response

by Jason Newman

Module: kamailio Branch: master Commit: 92ba30d66e9e6bb686410f362f2b6e8d669ed295 URL: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… Author: Jason Newman <jason(a)getweave.com> Committer: Jason Newman <jason(a)getweave.com> Date: 2015-08-11T14:30:31-06:00 janssonrpc-c: allow null json error property in rpc response If the JSON RPC response contains an error property, check to see if it is a json_null or not before flagging the response as an error. --- Modified: modules/janssonrpc-c/janssonrpc_io.c --- Diff: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… Patch: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… --- diff --git a/modules/janssonrpc-c/janssonrpc_io.c b/modules/janssonrpc-c/janssonrpc_io.c index ffcc247..1e1a82b 100644 --- a/modules/janssonrpc-c/janssonrpc_io.c +++ b/modules/janssonrpc-c/janssonrpc_io.c @@ -587,9 +587,12 @@ int handle_response(json_t* response) return_obj = json_object(); json_t* error = json_object_get(response, "error"); + // if the error value is null, we don't care + bool _error = error && (json_typeof(error) != JSON_NULL); + json_t* result = json_object_get(response, "result"); - if(error) { + if(_error) { json_object_set(return_obj, "error", error); } @@ -597,7 +600,7 @@ int handle_response(json_t* response) json_object_set(return_obj, "result", result); } - if ((!result && !error) || (result && error)) { + if ((!result && !_error) || (result && _error)) { WARN("bad response\n"); internal = internal_error(JRPC_ERR_BAD_RESP, req->payload); json_object_update(return_obj, internal); @@ -621,7 +624,7 @@ int handle_response(json_t* response) goto free_and_end; } - if(error) { + if(_error) { // get code from error json_t* _code = json_object_get(error, "code"); if(_code) {

9 years, 3 months

← Newer
1
...
11
12
13
14
15
16
17
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2015