sr-dev September 2015

sr-dev@lists.kamailio.org

37 participants
387 discussions

git:master:e9c2022b: Merge pull request #338 from doublec/htable_overrun
by Daniel-Constantin Mierla 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: e9c2022b57be87403bb2aa703f74b5d218456aeb URL: https://github.com/kamailio/kamailio/commit/e9c2022b57be87403bb2aa703f74b5d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-23T14:41:56+02:00 Merge pull request #338 from doublec/htable_overrun htable: Fix buffer overrun in htable_rpc_list --- Modified: modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/e9c2022b57be87403bb2aa703f74b5d… Patch: https://github.com/kamailio/kamailio/commit/e9c2022b57be87403bb2aa703f74b5d… --- diff --git a/modules/htable/htable.c b/modules/htable/htable.c index c6e2250..8339e41 100644 --- a/modules/htable/htable.c +++ b/modules/htable/htable.c @@ -1044,7 +1044,7 @@ static void htable_rpc_list(rpc_t* rpc, void* c) if (ht->dbtable.len > 0) { len = ht->dbtable.len > 127 ? 127 : ht->dbtable.len; memcpy(dbname, ht->dbtable.s, len); - dbname[ht->dbtable.len] = '\0'; + dbname[len] = '\0'; } else { dbname[0] = '\0'; }

1 0

git:master:1c164473: htable: Fix buffer overrun in htable_rpc_list
by Chris Double 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: 1c164473c6fd78318236254827a4cadbe8271463 URL: https://github.com/kamailio/kamailio/commit/1c164473c6fd78318236254827a4cad… Author: Chris Double <chris.double(a)double.co.nz> Committer: Chris Double <chris.double(a)double.co.nz> Date: 2015-09-23T22:03:47+12:00 htable: Fix buffer overrun in htable_rpc_list - Fix for using wrong len variable in htable_rpc_list if ht->dbtable.len is greater than 127, causing an out of bounds write. --- Modified: modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/1c164473c6fd78318236254827a4cad… Patch: https://github.com/kamailio/kamailio/commit/1c164473c6fd78318236254827a4cad… --- diff --git a/modules/htable/htable.c b/modules/htable/htable.c index c6e2250..8339e41 100644 --- a/modules/htable/htable.c +++ b/modules/htable/htable.c @@ -1044,7 +1044,7 @@ static void htable_rpc_list(rpc_t* rpc, void* c) if (ht->dbtable.len > 0) { len = ht->dbtable.len > 127 ? 127 : ht->dbtable.len; memcpy(dbname, ht->dbtable.s, len); - dbname[ht->dbtable.len] = '\0'; + dbname[len] = '\0'; } else { dbname[0] = '\0'; }

1 0

[kamailio] htable: Fix buffer overrun in htable_rpc_list (#338)
by Chris Double 23 Sep '15

23 Sep '15

- Fix for using wrong len variable in htable_rpc_list if ht->dbtable.len is greater than 127, causing an out of bounds write. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/338 -- Commit Summary -- * htable: Fix buffer overrun in htable_rpc_list -- File Changes -- M modules/htable/htable.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/338.patch https://github.com/kamailio/kamailio/pull/338.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/338

2 1

git:master:0678f51d: Merge pull request #337 from doublec/textops_null_dereference
by Daniel-Constantin Mierla 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: 0678f51d227377edee3cf3ecad7b410638bff0df URL: https://github.com/kamailio/kamailio/commit/0678f51d227377edee3cf3ecad7b410… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-23T14:41:07+02:00 Merge pull request #337 from doublec/textops_null_dereference textops: prevent null dereference on tr_txt_eval_re error --- Modified: modules/textops/txt_var.c --- Diff: https://github.com/kamailio/kamailio/commit/0678f51d227377edee3cf3ecad7b410… Patch: https://github.com/kamailio/kamailio/commit/0678f51d227377edee3cf3ecad7b410… --- diff --git a/modules/textops/txt_var.c b/modules/textops/txt_var.c index 0f704e3..41201f7 100644 --- a/modules/textops/txt_var.c +++ b/modules/textops/txt_var.c @@ -124,7 +124,7 @@ int tr_txt_eval_re(struct sip_msg *msg, tr_param_t *tp, int subtype, return 0; error: - if (tp->type == TR_PARAM_SPEC) { + if (tp->type == TR_PARAM_SPEC && se!=NULL) { subst_expr_free(se); } return -1;

1 0

git:master:5aa2ed26: textops: prevent null dereference on tr_txt_eval_re error
by Chris Double 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: 5aa2ed265f80664f57073213b17c83b1dac42ab4 URL: https://github.com/kamailio/kamailio/commit/5aa2ed265f80664f57073213b17c83b… Author: Chris Double <chris.double(a)double.co.nz> Committer: Chris Double <chris.double(a)double.co.nz> Date: 2015-09-23T20:48:56+12:00 textops: prevent null dereference on tr_txt_eval_re error - Check for NULL pointer before calling subst_expr_free to prevent NULL pointer dereference when there is an unknown subtype error. --- Modified: modules/textops/txt_var.c --- Diff: https://github.com/kamailio/kamailio/commit/5aa2ed265f80664f57073213b17c83b… Patch: https://github.com/kamailio/kamailio/commit/5aa2ed265f80664f57073213b17c83b… --- diff --git a/modules/textops/txt_var.c b/modules/textops/txt_var.c index 0f704e3..41201f7 100644 --- a/modules/textops/txt_var.c +++ b/modules/textops/txt_var.c @@ -124,7 +124,7 @@ int tr_txt_eval_re(struct sip_msg *msg, tr_param_t *tp, int subtype, return 0; error: - if (tp->type == TR_PARAM_SPEC) { + if (tp->type == TR_PARAM_SPEC && se!=NULL) { subst_expr_free(se); } return -1;

1 0

[kamailio] textops: prevent null dereference on tr_txt_eval_re error (#337)
by Chris Double 23 Sep '15

23 Sep '15

- Check for NULL pointer before calling subst_expr_free to prevent NULL pointer dereference when there is an unknown subtype error. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/337 -- Commit Summary -- * textops: prevent null dereference on tr_txt_eval_re error -- File Changes -- M modules/textops/txt_var.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/337.patch https://github.com/kamailio/kamailio/pull/337.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/337

2 1

a new master crash in tm module
by Juha Heinanen 23 Sep '15

23 Sep '15

after the domain module fix, my proxy started, but after handling a few messages, it crashed like this: (gdb) where #0 0x00007f916bcd8b92 in relay_reply (t=0x7f9166c6af98, p_msg=0xffffffffffffffff, branch=0, msg_status=408, cancel_data=0x7fff4a6b44a0, do_put_on_wait=0) at t_reply.c:1786 #1 0x00007f916bd0aa50 in fake_reply (t=0x7f9166c6af98, branch=0, code=408) at timer.c:328 #2 0x00007f916bd0aeeb in final_response_handler (r_buf=0x7f9166c6b1b0, t=0x7f9166c6af98) at timer.c:500 #3 0x00007f916bd0af94 in retr_buf_handler (ticks=1738640990, tl=0x7f9166c6b1d0, p=0xfffffffe) at timer.c:558 #4 0x00000000004ac2d0 in slow_timer_main () at timer.c:1130 #5 0x000000000052f397 in main_loop () at main.c:1634 #6 0x00000000005354e8 in main (argc=17, argv=0x7fff4a6b4968) at main.c:2566 -- juha

3 17

git:master:c379188e: Merge pull request #336 from doublec/tsilo_null_ptr_dereference
by Federico Cabiddu 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: c379188e0f2b7377afae41ee618444c69a8d39e3 URL: https://github.com/kamailio/kamailio/commit/c379188e0f2b7377afae41ee618444c… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-09-23T14:22:32+02:00 Merge pull request #336 from doublec/tsilo_null_ptr_dereference tsilo: Call LM_DBG with correct transaction information --- Modified: modules/tsilo/ts_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/c379188e0f2b7377afae41ee618444c… Patch: https://github.com/kamailio/kamailio/commit/c379188e0f2b7377afae41ee618444c… --- diff --git a/modules/tsilo/ts_handlers.c b/modules/tsilo/ts_handlers.c index 0df6358..c04ec36 100644 --- a/modules/tsilo/ts_handlers.c +++ b/modules/tsilo/ts_handlers.c @@ -86,7 +86,7 @@ void ts_onreply(struct cell* t, int type, struct tmcb_params *param) } ptr = ptr->next; } - LM_DBG("transaction %u:%u not found\n",ptr->tindex, ptr->tlabel); + LM_DBG("transaction %u:%u not found\n",cb_ptr->tindex, cb_ptr->tlabel); unlock_entry(_e); } else { LM_DBG("called with uknown type %d\n", type);

1 0

git:master:03f6a491: tsilo: Call LM_DBG with correct transaction information
by Chris Double 23 Sep '15

23 Sep '15

Module: kamailio Branch: master Commit: 03f6a49146980338d7e31aec60da551f8b6e7595 URL: https://github.com/kamailio/kamailio/commit/03f6a49146980338d7e31aec60da551… Author: Chris Double <chris.double(a)double.co.nz> Committer: Chris Double <chris.double(a)double.co.nz> Date: 2015-09-23T23:39:15+12:00 tsilo: Call LM_DBG with correct transaction information - Use cb_ptr in ts_onreply LM_DBG call as the ptr variable is NULL at that call point and cb_ptr contains the transaction information being looked for. --- Modified: modules/tsilo/ts_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/03f6a49146980338d7e31aec60da551… Patch: https://github.com/kamailio/kamailio/commit/03f6a49146980338d7e31aec60da551… --- diff --git a/modules/tsilo/ts_handlers.c b/modules/tsilo/ts_handlers.c index 7cf7970..6a1828a 100644 --- a/modules/tsilo/ts_handlers.c +++ b/modules/tsilo/ts_handlers.c @@ -89,7 +89,7 @@ void ts_onreply(struct cell* t, int type, struct tmcb_params *param) } ptr = ptr->next; } - LM_DBG("transaction %u:%u not found\n",ptr->tindex, ptr->tlabel); + LM_DBG("transaction %u:%u not found\n",cb_ptr->tindex, cb_ptr->tlabel); unlock_entry(_e); } else { LM_DBG("called with uknown type %d\n", type);

1 0

[kamailio] tsilo: Call LM_DBG with correct transaction information (#336)
by Chris Double 23 Sep '15

23 Sep '15

- Use cb_ptr in ts_onreply LM_DBG call as the ptr variable is NULL at that call point and cb_ptr contains the transaction information being looked for. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/336 -- Commit Summary -- * tsilo: Call LM_DBG with correct transaction information -- File Changes -- M modules/tsilo/ts_handlers.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/336.patch https://github.com/kamailio/kamailio/pull/336.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/336

2 1

← Newer
1
...
7
8
9
10
11
12
13
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2015