sr-dev September 2015

sr-dev@lists.kamailio.org

37 participants
388 discussions

compile tests - travis-ci
by Daniel-Constantin Mierla 16 Sep '15

16 Sep '15

Hello, following the IRC devel meeting that just ended, I am trying to identify the compile time options that are relevant to build for. The goal is to detect if changes that compile fine with some of those options, don't break the compilation when options are different. In my mind comes only those related to memory debugging. So the builds should be: A) Using PKG malloc 1) memory debugging turned off MEMDBG=0 make ... 2) memory debugging turned on MEMDBG=1 make B) compile with system malloc instead of pkg malloc -DPKG_MALLOC needs to be removed from Makefile.defs Not really relevant here, -DDBG_SYS_MALLOC can be added to compile flags as a second time compile. I will try to simplify setting this options, so for now A would be good to have. Besides these, I wonder if people here use other compile flags that the default one, in order to identify what other combination of flags should be used for testing that compilation is done ok. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com Kamailio Advanced Training, Sep 28-30, 2015, in Berlin - http://asipto.com/u/kat

2 1

git:master:b831f7bd: test/travis: build with MEMDBG=0 and MEMDBG=1
by Victor Seva 16 Sep '15

16 Sep '15

Module: kamailio Branch: master Commit: b831f7bd9c91cf4d75ec299d250cd463ab96e7c9 URL: https://github.com/kamailio/kamailio/commit/b831f7bd9c91cf4d75ec299d250cd46… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-09-16T18:44:34+02:00 test/travis: build with MEMDBG=0 and MEMDBG=1 --- Modified: test/travis/build_travis.sh --- Diff: https://github.com/kamailio/kamailio/commit/b831f7bd9c91cf4d75ec299d250cd46… Patch: https://github.com/kamailio/kamailio/commit/b831f7bd9c91cf4d75ec299d250cd46… --- diff --git a/test/travis/build_travis.sh b/test/travis/build_travis.sh index 04b4b2c..6b7c3a8 100755 --- a/test/travis/build_travis.sh +++ b/test/travis/build_travis.sh @@ -11,19 +11,34 @@ PACKAGE_GROUPS="mysql postgres berkeley unixodbc radius presence ldap xml perl u sqlite json mono ims sctp java \ purple tls outbound websocket autheph" export TESTS_EXCLUDE="3 12 17 19 20 23 25 26 30 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 50" -echo "make cfg" -make FLAVOUR=kamailio cfg \ - skip_modules="${EXCLUDED_MODULES} ${EXTRA_EXCLUDED_MODULES}" \ - group_include="kstandard" -echo "make all" -make all -echo "make groups" -for grp in ${PACKAGE_GROUPS}; do - make every-module group_include="k${grp}" -done + +function build { + echo "make distclean" + make distclean + echo "make cfg" + make FLAVOUR=kamailio cfg \ + skip_modules="${EXCLUDED_MODULES} ${EXTRA_EXCLUDED_MODULES}" \ + group_include="kstandard" + echo "make all" + make all + echo "make groups" + for grp in ${PACKAGE_GROUPS}; do + make every-module group_include="k${grp}" + done +} + +# build flags +export MEMDBG=0 +echo "build with MEMDBG=0" +build + +export MEMDBG=1 +echo "build with MEMDBG=1" +build + #echo "unit tests" #make -C test/unit -if [[ "$CC" =~ "gcc" ]] ; then +if [[ "$CC" =~ gcc ]] ; then echo "make install" sudo make install else

1 0

Next IRC Devel Meeting - Sep 16, 2015
by Daniel-Constantin Mierla 16 Sep '15

16 Sep '15

Hello, I would like to propose organizing the next IRC devel meeting to sync on the plans for Kamailio short term evolution. A wiki page has been created to keep track of what should be discussed there. Feel free to add your suggestions there: * http://www.kamailio.org/wiki/devel/irc-meetings/2015b First proposed date is next week on Wednesday, September 16, at 14:00 UTC (15:00 London, 16:00 Berlin, ...). The date can be changed based on availability of people willing to attend -- add your preferred date and time there. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com Kamailio Advanced Training, Sep 28-30, 2015, in Berlin - http://asipto.com/u/kat

1 2

[kamailio] kamailio 4.3 db write-back (db_mode=2) loads non-local contacts without socket in AoR (#325)
by mading087 16 Sep '15

16 Sep '15

Hi, We're trying to build a db replication based kamailio server redundancy solution. In recent tests, it seems to make more sense to change the db_mode to 2 (write-back) instead of using db only mode, as in db only mode, a lot of commands and stats don't work anymore. At this point, we're very close to make this work. However, there is a potential issue I just discovered. When db replicates users/clients registered with other servers in the cluster, although the lookup("location") function can correctly identify the remote users (registered with other servers in the cluster), the db write-back seems to still include those users when loading users/contacts to AoRs in memory. It is just that the remote contacts don't have "socket" information in AoR. Just wonder why the remote users need to be loaded back to memory AoR at all. Should the db write-back be consistent with the lookup function in that the non-local users be filtered out from the AoR? So far, even with remote contacts in AoR we can still make this work, but it seems a waste of memory to load remote contacts without sockets on each server. Hope I didn't miss any design decision/principle that calls for AoR for both local and non-local users. Thanks, --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/325

2 2

git:master:e0a76892: modules/ims_registrar_pcscf: set received host, proto and port when searching for pcontact
by jaybeepee 16 Sep '15

16 Sep '15

Module: kamailio Branch: master Commit: e0a76892f8c89cb3ceb224246e7c635778ec0719 URL: https://github.com/kamailio/kamailio/commit/e0a76892f8c89cb3ceb224246e7c635… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-09-16T11:31:46+02:00 modules/ims_registrar_pcscf: set received host, proto and port when searching for pcontact --- Modified: modules/ims_registrar_pcscf/service_routes.c --- Diff: https://github.com/kamailio/kamailio/commit/e0a76892f8c89cb3ceb224246e7c635… Patch: https://github.com/kamailio/kamailio/commit/e0a76892f8c89cb3ceb224246e7c635… --- diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c index cd75a74..bb15436 100644 --- a/modules/ims_registrar_pcscf/service_routes.c +++ b/modules/ims_registrar_pcscf/service_routes.c @@ -214,10 +214,10 @@ pcontact_t * getContactP(struct sip_msg* _m, udomain_t* _d) { // if (_m->id != current_msg_id) { current_msg_id = _m->id; c = NULL; - search_ci.received_host.s = 0; - search_ci.received_host.len = 0; - search_ci.received_port = 0; - search_ci.received_proto = 0; + search_ci.received_host.s = received_host.s; + search_ci.received_host.len = received_host.len; + search_ci.received_port = _m->rcv.src_port; + search_ci.received_proto = _m->rcv.proto; search_ci.searchflag = SEARCH_NORMAL; search_ci.via_host = host; search_ci.via_port = port;

1 0

git:master:d46d008e: auth_db: more log messages when username checks failed
by Daniel-Constantin Mierla 16 Sep '15

16 Sep '15

Module: kamailio Branch: master Commit: d46d008e0936a01229872df71ac26afb43122f4b URL: https://github.com/kamailio/kamailio/commit/d46d008e0936a01229872df71ac26af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-16T11:21:08+02:00 auth_db: more log messages when username checks failed --- Modified: modules/auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/d46d008e0936a01229872df71ac26af… Patch: https://github.com/kamailio/kamailio/commit/d46d008e0936a01229872df71ac26af… --- diff --git a/modules/auth_db/authorize.c b/modules/auth_db/authorize.c index 6d582c2..86e1cb7 100644 --- a/modules/auth_db/authorize.c +++ b/modules/auth_db/authorize.c @@ -512,30 +512,40 @@ int auth_check(struct sip_msg* _m, char* _realm, char* _table, char *_flags) || _m->REQ_METHOD==METHOD_PRACK || _m->REQ_METHOD==METHOD_UPDATE || _m->REQ_METHOD==METHOD_MESSAGE))) { if(srealm.len!=uri->user.len - || strncmp(srealm.s, uri->user.s, srealm.len)!=0) + || strncmp(srealm.s, uri->user.s, srealm.len)!=0) { + LM_DBG("authentication username mismatch with from/to username\n"); return AUTH_USER_MISMATCH; + } } if(_m->REQ_METHOD==METHOD_REGISTER || _m->REQ_METHOD==METHOD_PUBLISH) { /* check from==to */ if(furi->user.len!=turi->user.len - || strncmp(furi->user.s, turi->user.s, furi->user.len)!=0) + || strncmp(furi->user.s, turi->user.s, furi->user.len)!=0) { + LM_DBG("from username mismatch with to username\n"); return AUTH_USER_MISMATCH; + } if(use_domain!=0 && (furi->host.len!=turi->host.len - || strncmp(furi->host.s, turi->host.s, furi->host.len)!=0)) + || strncmp(furi->host.s, turi->host.s, furi->host.len)!=0)) { + LM_DBG("from domain mismatch with to domain\n"); return AUTH_USER_MISMATCH; + } /* check r-uri==from for publish */ if(_m->REQ_METHOD==METHOD_PUBLISH) { if(parse_sip_msg_uri(_m)<0) return AUTH_ERROR; uri = &_m->parsed_uri; if(furi->user.len!=uri->user.len - || strncmp(furi->user.s, uri->user.s, furi->user.len)!=0) + || strncmp(furi->user.s, uri->user.s, furi->user.len)!=0) { + LM_DBG("from username mismatch with r-uri username\n"); return AUTH_USER_MISMATCH; + } if(use_domain!=0 && (furi->host.len!=uri->host.len - || strncmp(furi->host.s, uri->host.s, furi->host.len)!=0)) + || strncmp(furi->host.s, uri->host.s, furi->host.len)!=0)) { + LM_DBG("from domain mismatch with r-uri domain\n"); return AUTH_USER_MISMATCH; } + } } return AUTH_OK; }

1 0

git:master:5cd019ae: ims_usrloc_pcscf: do not updated received info should be write once info
by jaybeepee 16 Sep '15

16 Sep '15

Module: kamailio Branch: master Commit: 5cd019ae1491adc79e8768503787ab59cb5fef65 URL: https://github.com/kamailio/kamailio/commit/5cd019ae1491adc79e8768503787ab5… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-09-16T11:14:02+02:00 ims_usrloc_pcscf: do not updated received info should be write once info - also fixes memory corruption after pcontact structure optimised to use placement --- Modified: modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/5cd019ae1491adc79e8768503787ab5… Patch: https://github.com/kamailio/kamailio/commit/5cd019ae1491adc79e8768503787ab5… --- diff --git a/modules/ims_usrloc_pcscf/udomain.c b/modules/ims_usrloc_pcscf/udomain.c index 0494699..e1f2ef5 100644 --- a/modules/ims_usrloc_pcscf/udomain.c +++ b/modules/ims_usrloc_pcscf/udomain.c @@ -390,15 +390,6 @@ int update_pcontact(struct udomain* _d, struct pcontact_info* _ci, struct pconta } } - // update received info (if info is available): - if (_ci->received_host.len > 0) { - if (_c->received_host.s) - shm_free(_c->received_host.s); - STR_SHM_DUP(_c->received_host, _ci->received_host, "update_pcontact"); - } - if (_ci->received_port > 0) _c->received_port = _ci->received_port; - if (_ci->received_proto > 0) _c->received_proto = _ci->received_proto; - //update Rx reg session information if (_ci->rx_regsession_id && _ci->rx_regsession_id->len>0 && _ci->rx_regsession_id->s) { if (_c->rx_session_id.len > 0 && _c->rx_session_id.s) {

1 0

git:master:667e181a: mem: f_malloc summary function for mememory degging off mode
by Daniel-Constantin Mierla 15 Sep '15

15 Sep '15

Module: kamailio Branch: master Commit: 667e181a4cc5bf88daac59f9d0e8127bc5313644 URL: https://github.com/kamailio/kamailio/commit/667e181a4cc5bf88daac59f9d0e8127… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-16T00:52:15+02:00 mem: f_malloc summary function for mememory degging off mode --- Modified: mem/f_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/667e181a4cc5bf88daac59f9d0e8127… Patch: https://github.com/kamailio/kamailio/commit/667e181a4cc5bf88daac59f9d0e8127… --- diff --git a/mem/f_malloc.c b/mem/f_malloc.c index bda7f48..90efda2 100644 --- a/mem/f_malloc.c +++ b/mem/f_malloc.c @@ -948,9 +948,11 @@ void fm_sums(void* qmp) void fm_sums(void* qmp) { struct fm_block* qm; + int memlog; qm = (struct fm_block*)qmp; - LOG_(DEFAULT_FACILITY, memlog, "fm_sums not available (%p)\n", qm); + memlog=cfg_get(core, core_cfg, memlog); + LOG_(DEFAULT_FACILITY, memlog, "fm_sums: ", "not available (%p)\n", qm); return; } #endif /* DBG_F_MALLOC */

1 0

git:master:de12775e: mem: proper field name for shm malloc unsafe define when memory debugging is off
by Daniel-Constantin Mierla 15 Sep '15

15 Sep '15

Module: kamailio Branch: master Commit: de12775edca2d4a2116ee277f3145c2f439a9af3 URL: https://github.com/kamailio/kamailio/commit/de12775edca2d4a2116ee277f3145c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-16T00:51:29+02:00 mem: proper field name for shm malloc unsafe define when memory debugging is off - reported by Juha Heinanen --- Modified: mem/shm.h --- Diff: https://github.com/kamailio/kamailio/commit/de12775edca2d4a2116ee277f3145c2… Patch: https://github.com/kamailio/kamailio/commit/de12775edca2d4a2116ee277f3145c2… --- diff --git a/mem/shm.h b/mem/shm.h index 2da1bf2..47d11df 100644 --- a/mem/shm.h +++ b/mem/shm.h @@ -62,7 +62,7 @@ extern sr_shm_api_t _shm_root; _SRC_FUNCTION_, _SRC_LINE_) #else # define shm_malloc(s) _shm_root.xmalloc(_shm_root.mem_block, (s)) -# define shm_malloc_unsafe(s) _shm_root.xmalloc_safe(_shm_root.mem_block, (s)) +# define shm_malloc_unsafe(s) _shm_root.xmalloc_unsafe(_shm_root.mem_block, (s)) # define shm_realloc(p, s) _shm_root.xrealloc(_shm_root.mem_block, (p), (s)) # define shm_resize(p, s) _shm_root.xresize(_shm_root.mem_block, (p), (s)) # define shm_free(p) _shm_root.xfree(_shm_root.mem_block, (p))

1 0

[kamailio] ipops Documentation Error (#327)
by rdboisvert 15 Sep '15

15 Sep '15

There is a small error in the [srv_query ()](http://kamailio.org/docs/modules/4.3.x/modules/ipops.html#ipops.f.srv_query) documentation. The xlog statements put the closing quotes in the wrong location. They should be as shown below. xlog ("port[$var(i)] $srvquery(udp=>port[$var(i)])\n"); xlog ("priority[$var(i)] $srvquery(udp=>priority[$var(i)])\n"); xlog ("target[$var(i)] $srvquery(udp=>target[$var(i)])\n"); xlog ("weight[$var(i)] $srvquery(udp=>weight[$var(i)])\n"); --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/327

2 2

← Newer
1
...
20
21
22
23
24
25
26
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2015