Module: kamailio
Branch: 4.3
Commit: 262d3574790ea3a10c82cb8bc0e4a65429f25540
URL: https://github.com/kamailio/kamailio/commit/262d3574790ea3a10c82cb8bc0e4a65…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T17:40:31+02:00
parser: fix start of search for long header names
- in parse_hname2_short(), used only for mod fixups, in the case header
name given as function param was greater than 250 chars
…
[View More]
(cherry picked from commit de8ba3900d6fef42e99ca9568044c7aefa44a5ea)
---
Modified: parser/parse_hname2.c
---
Diff: https://github.com/kamailio/kamailio/commit/262d3574790ea3a10c82cb8bc0e4a65…
Patch: https://github.com/kamailio/kamailio/commit/262d3574790ea3a10c82cb8bc0e4a65…
---
diff --git a/parser/parse_hname2.c b/parser/parse_hname2.c
index e4188a0..ff273d0 100644
--- a/parser/parse_hname2.c
+++ b/parser/parse_hname2.c
@@ -270,7 +270,7 @@ char* parse_hname2_short(char* const begin, const char* const end, struct hdr_fi
char *p;
if(end-begin>=HBUF_MAX_SIZE-4) {
- p = q_memchr(p, ':', end - begin);
+ p = q_memchr(begin, ':', end - begin);
if(p && p-4> begin) {
/* header name termination char found and enough space in buffer after it */
return parse_hname2(begin, end, hdr);
[View Less]
Module: kamailio
Branch: master
Commit: de8ba3900d6fef42e99ca9568044c7aefa44a5ea
URL: https://github.com/kamailio/kamailio/commit/de8ba3900d6fef42e99ca9568044c7a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T17:28:40+02:00
parser: fix start of search for long header names
- in parse_hname2_short(), used only for mod fixups, in the case header
name given as function param was greater than 250 …
[View More]chars
---
Modified: parser/parse_hname2.c
---
Diff: https://github.com/kamailio/kamailio/commit/de8ba3900d6fef42e99ca9568044c7a…
Patch: https://github.com/kamailio/kamailio/commit/de8ba3900d6fef42e99ca9568044c7a…
---
diff --git a/parser/parse_hname2.c b/parser/parse_hname2.c
index e4188a0..ff273d0 100644
--- a/parser/parse_hname2.c
+++ b/parser/parse_hname2.c
@@ -270,7 +270,7 @@ char* parse_hname2_short(char* const begin, const char* const end, struct hdr_fi
char *p;
if(end-begin>=HBUF_MAX_SIZE-4) {
- p = q_memchr(p, ':', end - begin);
+ p = q_memchr(begin, ':', end - begin);
if(p && p-4> begin) {
/* header name termination char found and enough space in buffer after it */
return parse_hname2(begin, end, hdr);
[View Less]
Module: kamailio
Branch: master
Commit: 6cd8cdc80e5037b90f7e636c360c88eed1dcdcec
URL: https://github.com/kamailio/kamailio/commit/6cd8cdc80e5037b90f7e636c360c88e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:10:04+02:00
auth: fixed improper whitespacing
(cherry picked from commit 20231f4936b5f79bcb2e3f64985953888391e570)
---
Modified: modules/auth/nonce.c
---
Diff: https://github.com/…
[View More]kamailio/kamailio/commit/6cd8cdc80e5037b90f7e636c360c88e…
Patch: https://github.com/kamailio/kamailio/commit/6cd8cdc80e5037b90f7e636c360c88e…
---
diff --git a/modules/auth/nonce.c b/modules/auth/nonce.c
index 025d0d7..d65d9cd 100644
--- a/modules/auth/nonce.c
+++ b/modules/auth/nonce.c
@@ -357,10 +357,10 @@ int check_nonce(auth_body_t* auth, str* secret1, str* secret2,
different length (for example because of different auth.
checks).. Therefore we force credentials to be rebuilt by UAC
without prompting for password */
- /* if current time is less than start time, reset the start time
- (e.g., after start, the system clock was set in the past) */
- t=time(0);
- if (t < up_since)
+ /* if current time is less than start time, reset the start time
+ * (e.g., after start, the system clock was set in the past) */
+ t=time(0);
+ if (t < up_since)
up_since = t;
if (since < t)
return 4;
[View Less]
- URL: https://github.com/kamailio/kamailio/commit/d13e418a34cae70e68c3bb50ee0cef6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:45:57+02:00
lib/srdb1: dummy string for null values pointed to static buffer
- allow editing in upper layers, avoiding innaproriate access to a constant
(cherry picked from commit d83fee0a31f292af731269cbd361db39be0a4b9b)
- URL: https://github.com/kamailio/kamailio/commit/3742fe74e34eaed12c88107aad5d323…
Author: Victor Seva …
[View More]<linuxmaniac(a)torreviejawireless.org>
Date: 2015-09-08T14:47:11+02:00
jsonrpc-c: fix crash at reconnect_cb if server was never connected
(cherry picked from commit 0588a7bc5f57c012b6c8d188860251f402af9be7)
- URL: https://github.com/kamailio/kamailio/commit/da64e01eb401e3dd57fc4c7bc8161d9…
Author: lazedo <luis.azedo(a)factorlusitano.com>
Date: 2015-09-08T14:48:17+02:00
htable : fix $shtrecord(value) returned value
$shtrecord(value) does not return correct value when it is an integer
(cherry picked from commit c446840e0004f8cb9208c2a6f68774c4c788e5a8)
- URL: https://github.com/kamailio/kamailio/commit/d88f52cadb2bf6764518c89be852b05…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:48:36+02:00
pua: fix typo in matching presence.winfo
- patch by foucse, GH #270
(cherry picked from commit 48f89ed0390a80cc760da5a7ed41dd9c5c5ffc4d)
- URL: https://github.com/kamailio/kamailio/commit/0b04d1526dfdf9490f407b8a00ab42a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:49:25+02:00
registrar: allow registered() in any route
- if used for a sip reply and URI is not provided, then To URI is used
(cherry picked from commit c3755580f8e2763e33be03b0370630d04af3a019)
- URL: https://github.com/kamailio/kamailio/commit/c2595a2e5b8818fa7cddc916ef91b6b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:49:33+02:00
registrar: updated the docs for registered(...) function
(cherry picked from commit b0a776b31220fc5e8599288b14ddb9ffccb24c0f)
- URL: https://github.com/kamailio/kamailio/commit/1090e83918c78c5c81b3d6c5d080e3b…
Author: qxork <fred(a)qxork.com>
Date: 2015-09-08T14:49:58+02:00
etc: simple typo fixes in kamailio.cfg
- fixed small typos within comments of default kamailio config
(cherry picked from commit 49420bac12faf27ce4b7ae6a869741f41e6a6553)
- URL: https://github.com/kamailio/kamailio/commit/fb9a01616b407065c318ba204889507…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:50:19+02:00
drouting: fixed typo in reload cmd response
- reported by GH#275
(cherry picked from commit 6b15a51b016c232fab6665fc03ed01dad09ac8b5)
- URL: https://github.com/kamailio/kamailio/commit/23bca854d7e703efcc6f18ab1bd46c6…
Author: Jason Newman <jason(a)getweave.com>
Date: 2015-09-08T14:50:51+02:00
janssonrpc-c: correct jansson_get parameter order in examples
parameter order should be jansson_get(key/path, src, dst) and not jansson_get(src, key/path, dst)
(cherry picked from commit 3cefc76ade4046962962f112beafe939d5ff2ed0)
- URL: https://github.com/kamailio/kamailio/commit/50567658b491d70a95da50c428bbb73…
Author: Jason Newman <jason(a)getweave.com>
Date: 2015-09-08T14:51:37+02:00
janssonrpc-c: allow null json error property in rpc response
If the JSON RPC response contains an error property, check to see if it is a json_null or not before flagging the response as an error.
(cherry picked from commit 92ba30d66e9e6bb686410f362f2b6e8d669ed295)
- URL: https://github.com/kamailio/kamailio/commit/4d8a2b62928d1d974cdcded29458817…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2015-09-08T14:51:52+02:00
kamcmd: support VERSION_NODATE and VERSION_DATE for reproducible builds
support added e03d1279f49709e0d320478fa1ff7c27161c30ed
Related: #60
(cherry picked from commit 19359772acf1cbd9dedb244c1fe327ec47b7dc9c)
- URL: https://github.com/kamailio/kamailio/commit/60b2e3e3e66320446541ba92de239fc…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:53:00+02:00
sanity: commented priting require header on error level
(cherry picked from commit 9902ca145178498ff47092f0ecdd3bca6650c97c)
- URL: https://github.com/kamailio/kamailio/commit/65d4dae702ccd16654fa22c66522516…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:53:12+02:00
db_postgres: memset vars to 0 to avoid using invalid values inside db_postgres_new_connection()
- reported by mading087, GH#292
(cherry picked from commit a16c6108e1f6d1a3f6b6c962bbaaedf37e57a8d2)
- URL: https://github.com/kamailio/kamailio/commit/fea0d0801a09aa7faac8efa6ae19de4…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:53:37+02:00
evapi: do cfg framework update on i/o events
(cherry picked from commit 4404f75cf194e8fd727c2ffaeeea41d2193decf6)
- URL: https://github.com/kamailio/kamailio/commit/a8c2c53b1175af7bd3c6020cc01e951…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:53:48+02:00
sanity: adjusted log messages for check_proxy_require()
(cherry picked from commit 0f479b5366fae4c5ad0c78e4c91661b7a421d5e8)
- URL: https://github.com/kamailio/kamailio/commit/063a9b2a7f6ba6fe60797faa1ebf9f9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:54:47+02:00
dialog: set dlg var table as static and rename to avoid name conflicts
(cherry picked from commit cbc0c720e1c239296ff3842d701f75663bead6d9)
- URL: https://github.com/kamailio/kamailio/commit/3ce973b0c20be7230baaf2cb8d8713e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:54:56+02:00
dialog: dlg var value stored as zero terminated string
- easier to use in std lib operations
(cherry picked from commit 0d9e4adb328dabaf2a34d926bc80e022bee65079)
- URL: https://github.com/kamailio/kamailio/commit/bb0194aa9f0963cb77bb1275b8e0a4c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:55:28+02:00
jsonrpc-c: free pipe cmd for notifications
- fixes leak reported by GH#296
(cherry picked from commit 79459d3f87731309641794a2b881ee1cacc5e1f2)
- URL: https://github.com/kamailio/kamailio/commit/9e97b80abbfa78c78f7c5359cc9af37…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:56:06+02:00
core: keep info about aor being considered case sensitive or not
(cherry picked from commit 06e36989b2c5332b3ca377ec8098d8f2d953a5b6)
- URL: https://github.com/kamailio/kamailio/commit/eebcd2be7332331894ef5b9d32a4a9e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:56:15+02:00
registrar: propagate value of case_sensitive for aor to core
(cherry picked from commit acf0432cafdaa4b464f1069996e46d54ab0c22e4)
- URL: https://github.com/kamailio/kamailio/commit/ab950f753de8c0baecc51f66e2be001…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:56:27+02:00
usrloc: take in consideration aor case sensitive value for rpc commands
- reported by GH#264
(cherry picked from commit e319a22f80d425f39611857fddc1e948e76ebe87)
- URL: https://github.com/kamailio/kamailio/commit/ee3048e8685f54c35daff699ad64ce9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:56:39+02:00
kamcmd: updated default server name references
(cherry picked from commit 8db5eb2b53320d84ded36c531a00f6dfbec27a75)
- URL: https://github.com/kamailio/kamailio/commit/05242f6db6edcf32705722dcd0d9d3e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:56:47+02:00
kamcmd: lower max size for socket name
- was set to 108 which is common for linux, but mac os x has it 104
- set to 100 now
(cherry picked from commit 3f4c63802194cb83ffb8124e5ae38f85ee315c28)
- URL: https://github.com/kamailio/kamailio/commit/4e8935a2c3bbf2acdf6c4ffef84d593…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:57:08+02:00
ctl: internal mode to allow non-strict reading binrpc packets
- allow handling structs with simple values inside, some rpc responses
are not strictly build as per xmlrpc/jsonrpc specs
(cherry picked from commit 39ab16e4f0d24d70b7d1414df48af023b2018cf6)
- URL: https://github.com/kamailio/kamailio/commit/23745567b8d640dfb9778f71e5a064c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:57:16+02:00
lib/binrpc: updated code for the new prototype of binrpc read function
(cherry picked from commit 9c105b13436c9eb3e61568e6f08050423da3e569)
- URL: https://github.com/kamailio/kamailio/commit/9d6e5aae27954065f0e61e1995993c3…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:57:27+02:00
kamcmd: do binrpc read in non-strict mode
- reported by Dmitri Savolainen, GH#145
(cherry picked from commit 6b73ca89832e034239d6f17d41b825cfdc52424d)
- URL: https://github.com/kamailio/kamailio/commit/de7eb56737ca57429dd6ffcb01907b1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:58:18+02:00
mem: safety prev free checks for f_malloc extract operation
- following a report by Alex Balashov
(cherry picked from commit a620bfec37cdcdc5c5debcdfb5219b09464065fe)
- URL: https://github.com/kamailio/kamailio/commit/3beb4e9f524956883e2260450ea3593…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:58:26+02:00
jsonrpc-c: proper error handling for pipe cmd callback
- credits to Hugh Waite for spotting missing return
- free vars if already set when error handling is done
(cherry picked from commit ec0ba37b9f2b6c60303227ea0527d69896f2930e)
- URL: https://github.com/kamailio/kamailio/commit/b5e95cb1e528cf619c467c58cefd851…
Author: Matthias Wimmer <m(a)tthias.eu>
Date: 2015-09-08T14:58:57+02:00
Small typo fix in config.
(cherry picked from commit aef62d8277be4699b9e79ef49542865a44857999)
- URL: https://github.com/kamailio/kamailio/commit/c979b991450052f6a77238aef391dd8…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:59:08+02:00
tmrec: more details about duration format for time recurrences
(cherry picked from commit 81006ee1246b8f700ce9ce20814d4522780d7ceb)
- URL: https://github.com/kamailio/kamailio/commit/46af0cfb7cc1fffb22e43ebd41f07fc…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:59:33+02:00
drouting: notes about the format of duration attribute
(cherry picked from commit 711144a1fa3e1dfa540cc7ccd0ce1c14faeba42f)
- URL: https://github.com/kamailio/kamailio/commit/b7aab8f4a019e21f03b3e3323af592b…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:59:48+02:00
tmx: err level replaced with info when getting t reply code pv
(cherry picked from commit aad248fc39279f84879929772e9306fc01473860)
- URL: https://github.com/kamailio/kamailio/commit/742f6fbba5b0d5d308ea0434311d811…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T14:59:59+02:00
parser: safer function to parse header name stored in short buffer
(cherry picked from commit cbc5034b26189371c2ffb80424414aa8b1b8dea5)
- URL: https://github.com/kamailio/kamailio/commit/5425c257ff0726a310aced28282821a…
Author: Chris Double <chris.double(a)double.co.nz>
Date: 2015-09-08T15:00:08+02:00
parser: fix overflow access when parsing Reason header stored in short buffer
- it can happen for fixup functions from textops module having header
name as a parameter, with critical impact when using system malloc,
the internal pkg malloc does a roundup of the allocated space
- the issue is caused by the word (4 bytes) read step performed by
parse_hname2() - second 4-byte read in buffer "Reason:" exceeds the
size by 1
- added a safe read macro that reads 1, 2 or 3 bytes if the size of the
buffer is not big enough for a 4 bytes read
(cherry picked from commit 964ed0a5083413eb0a70bd8a952d5a91ee9e9883)
- URL: https://github.com/kamailio/kamailio/commit/db279576832664b5dee2c432c350300…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:00:20+02:00
parser: fixed the name for the new parse_hname2_short() function
(cherry picked from commit ac27d053ce0d9d9295f3ca8052a320e0c0b01699)
- URL: https://github.com/kamailio/kamailio/commit/5cc4184e64f300319a65ce7f9515102…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:00:28+02:00
core: select framework - use safer function to parse header name in short buffer
(cherry picked from commit baf90dba5c12158386e501e73daa266321d9de38)
- URL: https://github.com/kamailio/kamailio/commit/5d97276a2586c8c312b6c56542e9b44…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:00:38+02:00
pv: use safer function to parse header name in short buffer
(cherry picked from commit a9dc0f738f448676b8a92818d442ca7142147f9b)
- URL: https://github.com/kamailio/kamailio/commit/036c1d134e6c20e9e5e394b790abb6f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:00:46+02:00
textops: use safer function to parse header name in short buffer
(cherry picked from commit b62492e2e25984528e4cda7f96d7afee1425ceb3)
- URL: https://github.com/kamailio/kamailio/commit/5f02824b9dd195a1a94ae0038d4c73a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:00:55+02:00
textopsx: use safer function to parse header name in short buffer
(cherry picked from commit 2aa013d5fb992be98fc1ec90abdf0d67625ab724)
- URL: https://github.com/kamailio/kamailio/commit/f02215971667f54c553e10593e370db…
Author: vance-od <vance(a)ukr.net>
Date: 2015-09-08T15:01:37+02:00
Update nonce.c
auth: fixed issue when during registration nonce expired, after backwards time shift
(cherry picked from commit 063e32a8fe81b2cfbaac0386e6b51446586e619a)
- URL: https://github.com/kamailio/kamailio/commit/20231f4936b5f79bcb2e3f649859538…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:02:45+02:00
auth: fixed improper whitespacing
- URL: https://github.com/kamailio/kamailio/commit/44948a6c7618639f1864de140e5afd4…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:04:21+02:00
usrloc: mi commands with aor caseness
- reported in GH#264
(cherry picked from commit a10d8b133edef697ec3bd40e5babd76dc881b2cb)
- URL: https://github.com/kamailio/kamailio/commit/08bd04db6a71a1111e04adbbb856715…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:04:38+02:00
corex: log messages for memory status/summary rpc commands
(cherry picked from commit 014a62f7546675ffc198d1c169f6bd12b3bdd87d)
- URL: https://github.com/kamailio/kamailio/commit/970ef5b844c195ad07cda15027ba995…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:05:07+02:00
dialog: more debug when storing vars in database
(cherry picked from commit 2962852bf706692bdbc9b51419dbdc2012f34e1b)
- URL: https://github.com/kamailio/kamailio/commit/dca8ff16753639b1f84cd60286142fb…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:05:29+02:00
tm: store last received response code before running onreply_route
- otherwise an innapropriate cancel can happen if the current branch got
before an 1xx response, and the script writer enforces another reply
code with t_reply()
- reported by Thomas Sevestre, GH#315
(cherry picked from commit b7c588dff06030a82f305b210573be5bbc961cec)
- URL: https://github.com/kamailio/kamailio/commit/ed292c774f93a14123521094fcab4cf…
Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro>
Date: 2015-09-08T15:05:49+02:00
tm: execute the onsend_route for responses forwarded by tm module
- not executed for local generated sip responses
(cherry picked from commit 2690a8c314d23406649dceaadce7032690500a6e)
- URL: https://github.com/kamailio/kamailio/commit/c46d065a9ef9f63207811e629120ef5…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:05:59+02:00
tm: enable drop in onsend_route for tm replies
- skip sending out the reply by resetting the send_socket
(cherry picked from commit 4b2d6dd7ce1a61c964f7d996c2db4428010dd478)
- URL: https://github.com/kamailio/kamailio/commit/e8bec39d2650c7867ec325e80e7f2d1…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2015-09-08T15:09:13+02:00
modules: refreshed several readme files
[View Less]
Hi Daniel,
I must admit this run_onsend() patch for stateful replies creation was
not quite a success story. However, I think it serves a practical
purpose, for example in Homer tracing and could be useful for the
community. Again, I propose my past solution, with some questions:
1. I am unsure if the place I introduced the run_onsend call is
appropriate since the buf used for msg_send is constructed
build_res_buf_from_sip_req and build_res_buf_from_sip_res calls.
2. Also, we can maybe …
[View More]unite these if call branches I created:
send_res = msg_send(&uas_rb->dst, buf, res_len);
send_res = SEND_PR_BUFFER( uas_rb, buf, res_len );
3. Do you think a get_send_socket snippet as follows should be inserted
before the /*if (onsend_route_enabled(SIP_REPLY)){*/ :
if(dst.send_sock == NULL) {
dst.send_sock=get_send_socket(msg, &dst.to, dst.proto);
if (dst.send_sock==0){
LM_ERR("cannot forward reply\n");
}
}
Thank you,
Lucian
On 10/29/2014 02:15 PM, Daniel-Constantin Mierla wrote:
> Hello Lucian,
>
> I applied your patch with some fixes.
>
> I haven't checked with stateful replies, at some point a function from
> core should be used. You can go ahead and see if it works, if not, let
> me know and I can look into it as well. You can follow the callbacks
> for TMCB_RESPONSE_OUT or TMCB_RESPONSE_FWDED inside tm code, they
> should lead to the place where a sip response is going to be sent out.
>
> Cheers,
> Daniel
>
> On 27/10/14 12:51, Lucian Balaceanu wrote:
>> Hello Daniel,
>>
>> I must admit I only saw your mail last Friday. Until the 10th of
>> October I was also on vacation. I know that you actually committed
>> some of the changes together with your comments on the 12th this month.
>>
>> I don't know if we can consider the topic of the patch closed. As far
>> as I understand, the state-full replies have not been addressed,
>> right? (There should be a change in the t_reply.c) I followed the
>> code to the relay_reply but I did not yet come to find the send
>> function. Should I pursue further?
>>
>> Thank you,
>> Lucian Balaceanu
>>
>>> Hi Lucian,
>>>
>>> somehow I forgot to follow up on this. But we need to get sorted out
>>> soon, before we release, so it works as expected with the new
>>> version. See more comments inline.
>>>
>>>
>>> On 17/09/14 18:09, Lucian Balaceanu wrote:
>>>> Hi Daniel,
>>>>
>>>> Please forgive me for my delay in responding to your mail.
>>>> Please find attached a second version of the onsend_route_reply
>>>> patch (which again has some problems). As per your previous
>>>> indications I did the following:
>>>>
>>>> *Issue1*
>>>>> From performances point of view, there can be added a config
>>>>> parameter to enable running of onsend_route for replies:
>>>>>
>>>>> onsend_route_reply = 0|1
>>>>
>>>> Following
>>>> http://www.asipto.com/pub/kamailio-devel-guide/#c08add_parameters I
>>>> have tried to add onsend_route_reply parameter. The code compiles,
>>>> but when trying to start kamailio with this parameter inside, the
>>>> parsing fails with syntax errors signaling:
>>>>
>>>> / 0(1321) :<core> [cfg.y:3423]: yyerror_at(): parse error in config
>>>> file kamailio-basic.cfg.4.1, from line 107, column 1 to line 108,
>>>> column 0: syntax error
>>>> 0(1321) : <core> [cfg.y:3423]: yyerror_at(): parse error in config
>>>> file kamailio-basic.cfg.4.1, from line 107, column 1 to line 108,
>>>> column 0:
>>>> ERROR: bad config file (2 errors)/
>>>
>>> The issue is:
>>>
>>> +<INITIAL>{ONSEND_RT_REPLY} { yylval.intval=atoi(yytext);
>>> + yy_number_str=yytext; return NUMBER; }
>>>
>>> It should be:
>>>
>>> +<INITIAL>{ONSEND_RT_REPLY} { yylval.intval=atoi(yytext);
>>> + yy_number_str=yytext; return ONSEND_RT_REPLY; }
>>>
>>>>
>>>> *Issue2*
>>>>> #define onsend_enabled(rtype)
>>>>> (onsend_rt.rlist[DEFAULT_RT]?((rtype==SIP_REPLY)?onsend_route_reply:1):0)
>>>> That is to say you see it best to take the chek for
>>>> onsend_rt.list[DEFAULT_RT] from inside run_onsend() function and
>>>> call this onsend_enabled(...) before the run_onsend()?
>>>
>>> This is to detect whether the onsend_route should be executed for
>>> SIP replies. The condition being:
>>>
>>> - if is a sip reply and onsend_route is set and the
>>> onsend_route_reply parameter is 1
>>>>
>>>> *Issue3*
>>>>> On the other hand, is onsend_route also executed for local
>>>>> requests? I had in mind it is only for received requests that are
>>>>> forwarded ... Iirc, on onsend_route, the sip message is the one
>>>>> received, the outgoing content being accessible via $snd(buf).
>>>>>
>>>> I agree with you with taking out the locally generated requests and
>>>> only left the run_onsend call in do_forward_reply function (inside
>>>> forward.c).
>>>> Could you point me to the reply relaying function that is called
>>>> for state-full processing?
>>> Stateful processing for replies is mainly done in t_reply.c from tm
>>> module. At some point there should be a send buffer function call.
>>>
>>> Cheers,
>>> Daniel
>>>>
>>>> Thank you and sorry again for my late answer,
>>>> Lucian
>>>
>>> --
>>> Daniel-Constantin Mierla
>>> http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
>>>
>>>
>>
>
> --
> Daniel-Constantin Mierla
> http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
[View Less]
Differentiate the cases where AAR is not sent because
of an error and the cases where AAR is not sent because it is logically wrong to sent them at that point of the transaction. In this way, in the routing script it is possible to distinguish between an error and (for example) send back an error to the UE and when AAR is not generated because (for example) the answer does not contain an SDP or you are not in a SIP reply. In this case, you should not send back an error but go ahead with your …
[View More]transaction.
I noticed that CSCF_RETURN_FALSE (-1) is never used in the function, so it can be suitable to be returned in the cases just explained
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/314
-- Commit Summary --
* Return CSCF_RETURN_FALSE if AAR is not generated
-- File Changes --
M modules/ims_qos/mod.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/314.patchhttps://github.com/kamailio/kamailio/pull/314.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/314
[View Less]