sr-dev January 2016

sr-dev@lists.kamailio.org

34 participants
296 discussions

[kamailio] debugger: kamailio freezes when dynamically setting module level(using fifo/rpc), if the module level is not previously set in config file: ```modparam("debugger", "mod_level", "core=2")``` (#463)
by Stefan Mititelu 07 Jan '16

07 Jan '16

This **is not** happening when setting the module facility, for the above, same conditions. This **is** happening also before pull-request [1] using "kamcmd dbg.mod_level core 1". After some debugging I've noticed that this **is** happening when trying to set a level for a module name whose ```idx = hid&(_dbg_mod_table_size-1);``` is even number?! (i.e. module name "core" reduces to an even index); the idx is always in the range ```_dbg_mod_table_size-1``` as it should be. Trying to solve this, I commented the lock_get/release in ```dbg_set_mod_debug_level()``` and saw it's working; kamailio doesn't freeze anymore. Thus, I tried to refactor the locks in ```struct _dbg_mod_slot``` to be dynamically allocated/deallocated using lock_alloc()/destroy() without success. I'm out of ideas. Do you have any idea what might lead to this strange deadlock? [1] https://github.com/kamailio/kamailio/pull/462 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/463

2 7

[kamailio] dmq_usrloc/usrloc core dumping (#440)
by 00Asgaroth00 07 Jan '16

07 Jan '16

I have 3 kamailio 434 registrars replicating between each other using dmq usrloc module I have recently noticed that all of the registrars crash at random intervals over the course of the day, they all dont crash at the same time, but randomly, independantly of each other I cannot see any unusual traffic arriving at the systems that may be a cause for the crash I'd appreciate assistance trying to get to the bottom of the issue Kamailio Version: ``` # /usr/sbin/kamailio -V version: kamailio 434 (x86_64/linux) 0ec860 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select id: 0ec860 compiled on 17:42:12 Nov 25 2015 with gcc 447 ``` Message in the log file when the kamailio application crashes: ``` Dec 14 01:46:54 /usr/sbin/kamailio[16205]: ALERT: <core> [mainc:728]: handle_sigs(): child process 16234 exited by a signal 11 Dec 14 01:46:54 /usr/sbin/kamailio[16205]: ALERT: <core> [mainc:731]: handle_sigs(): core was generated Dec 14 01:46:54 /usr/sbin/kamailio[16205]: INFO: <core> [mainc:743]: handle_sigs(): terminating due to SIGCHLD Dec 14 01:46:54 /usr/sbin/kamailio[16246]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16244]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16232]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16243]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16242]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16228]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16245]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16241]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16235]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16240]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16225]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16236]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16233]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16220]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16221]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16230]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16237]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16231]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16217]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16229]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16218]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16219]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16226]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16215]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16216]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16239]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16212]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16223]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16214]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16213]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16208]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16207]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16211]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16238]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16222]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16210]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16227]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16224]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16206]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16209]: INFO: <core> [mainc:798]: sig_usr(): signal 15 received Dec 14 01:46:54 /usr/sbin/kamailio[16205]: WARNING: tm [h_tablec:130]: free_cell_helper(): removed cell 0x7f5a40a084f8 is still linked in hash table (h_tablec:440) Dec 14 01:46:54 /usr/sbin/kamailio[16205]: WARNING: tm [h_tablec:130]: free_cell_helper(): removed cell 0x7f5a40a12390 is still linked in hash table (h_tablec:440) ``` Core file synopsis is: ``` Core was generated by `/usr/sbin/kamailio -P /var/run/kamailiopid -m 1024 -M 64 -u root -g root' Program terminated with signal 11, Segmentation fault #0 0x00007f5a82f68985 in mem_insert_ucontact (_r=0x7f5a409ec948, _c=0x7ffcc26f3140, _ci=0x7f5a81418500) at urecordc:152 152 if_update_stat( _r->slot, _r->slot->d->contacts, 1); ``` I still have the core file, however, it contains some sensitive info, so I can send backtraces directly to you if required Please let me know if you require any additional info Thanks --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/440

2 14

git:4.1:9e57273d: debugger: fix issue #463
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: 4.1 Commit: 9e57273df9b33a14f258e0c04b699d34655d7fec URL: https://github.com/kamailio/kamailio/commit/9e57273df9b33a14f258e0c04b699d3… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T11:50:40+02:00 debugger: fix issue #463 Don't shm_malloc() while the lock is taken. (cherry picked from commit 3668618369a8a1db8cb3410c0a7f50ce74150cd2) --- Modified: modules/debugger/debugger_api.c --- Diff: https://github.com/kamailio/kamailio/commit/9e57273df9b33a14f258e0c04b699d3… Patch: https://github.com/kamailio/kamailio/commit/9e57273df9b33a14f258e0c04b699d3… --- diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 90ba11f..3f30cb5 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1145,15 +1145,14 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock); /* not found - add */ if(mlevel==NULL) { - lock_release(&_dbg_mod_table[idx].lock); return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock); return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1164,6 +1163,7 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first; _dbg_mod_table[idx].first = itn;

1 0

git:4.2:e3197e00: debugger: fix issue #463
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: 4.2 Commit: e3197e00458bae2556d38385a45c6132a0393f7a URL: https://github.com/kamailio/kamailio/commit/e3197e00458bae2556d38385a45c613… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T11:49:25+02:00 debugger: fix issue #463 Don't shm_malloc() while the lock is taken. (cherry picked from commit 3668618369a8a1db8cb3410c0a7f50ce74150cd2) --- Modified: modules/debugger/debugger_api.c --- Diff: https://github.com/kamailio/kamailio/commit/e3197e00458bae2556d38385a45c613… Patch: https://github.com/kamailio/kamailio/commit/e3197e00458bae2556d38385a45c613… --- diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 0f5f65d..19d13c1 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1178,15 +1178,14 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock); /* not found - add */ if(mlevel==NULL) { - lock_release(&_dbg_mod_table[idx].lock); return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock); return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1197,6 +1196,7 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first; _dbg_mod_table[idx].first = itn;

1 0

git:4.3:a4537849: debugger: fix issue #463
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: 4.3 Commit: a45378496c5a1da347e569f7a58b78cfea8004e8 URL: https://github.com/kamailio/kamailio/commit/a45378496c5a1da347e569f7a58b78c… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T11:41:17+02:00 debugger: fix issue #463 Don't shm_malloc() while the lock is taken. (cherry picked from commit 3668618369a8a1db8cb3410c0a7f50ce74150cd2) --- Modified: modules/debugger/debugger_api.c --- Diff: https://github.com/kamailio/kamailio/commit/a45378496c5a1da347e569f7a58b78c… Patch: https://github.com/kamailio/kamailio/commit/a45378496c5a1da347e569f7a58b78c… --- diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 0f5f65d..19d13c1 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1178,15 +1178,14 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock); /* not found - add */ if(mlevel==NULL) { - lock_release(&_dbg_mod_table[idx].lock); return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock); return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1197,6 +1196,7 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first; _dbg_mod_table[idx].first = itn;

1 0

git:master:0d0c8d57: Merge pull request #469 from smititelu/master
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: master Commit: 0d0c8d570b58c2a622a615b1c312acca4994d720 URL: https://github.com/kamailio/kamailio/commit/0d0c8d570b58c2a622a615b1c312acc… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T11:37:37+02:00 Merge pull request #469 from smititelu/master fix issue #463 --- Modified: modules/debugger/debugger_api.c Modified: modules/debugger/doc/debugger_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0d0c8d570b58c2a622a615b1c312acc… Patch: https://github.com/kamailio/kamailio/commit/0d0c8d570b58c2a622a615b1c312acc… --- diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 566be68..cb57df3 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1344,15 +1344,14 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock); /* not found - add */ if(mlevel==NULL) { - lock_release(&_dbg_mod_table[idx].lock); return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock); return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1363,6 +1362,7 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first; _dbg_mod_table[idx].first = itn; @@ -1420,15 +1420,14 @@ int dbg_set_mod_debug_facility(char *mname, int mnlen, int *mfacility) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock_ft); /* not found - add */ if(mfacility==NULL) { - lock_release(&_dbg_mod_table[idx].lock_ft); return 0; } itn = (dbg_mod_facility_t*)shm_malloc(sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock_ft); return -1; } memset(itn, 0, sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); @@ -1439,6 +1438,7 @@ int dbg_set_mod_debug_facility(char *mname, int mnlen, int *mfacility) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock_ft); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first_ft; _dbg_mod_table[idx].first_ft = itn; diff --git a/modules/debugger/doc/debugger_admin.xml b/modules/debugger/doc/debugger_admin.xml index 04ba4ee..d0f3511 100644 --- a/modules/debugger/doc/debugger_admin.xml +++ b/modules/debugger/doc/debugger_admin.xml @@ -918,7 +918,7 @@ $ &ctltool; fifo get_dbg_mod_facility debugger </title> <para> Get the module log level. - If module does not exist in kamailio, the entry in the level hashtable is still added for the bogus module. + If mod_name does not exist in the level hashtable, returns the config file value. </para> <para> Name: <emphasis>dbg.get_mod_level</emphasis> @@ -937,7 +937,7 @@ $ &ctltool; fifo get_dbg_mod_facility debugger </title> <para> Get the module log facility. - If module does not exist in kamailio, the entry in the facility hashtable is still added for the bogus module. + If mod_name does not exist in the facility hashtable, returns the config file value. </para> <para> Name: <emphasis>dbg.get_mod_facility</emphasis>

1 0

git:master:a372f861: debugger: doku dbg.get_mod_*
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: master Commit: a372f861f04b04f08d68f28a95f12a13776be891 URL: https://github.com/kamailio/kamailio/commit/a372f861f04b04f08d68f28a95f12a1… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T11:11:35+02:00 debugger: doku dbg.get_mod_* Overlooked due to copy/paste. --- Modified: modules/debugger/doc/debugger_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a372f861f04b04f08d68f28a95f12a1… Patch: https://github.com/kamailio/kamailio/commit/a372f861f04b04f08d68f28a95f12a1… --- diff --git a/modules/debugger/doc/debugger_admin.xml b/modules/debugger/doc/debugger_admin.xml index 04ba4ee..d0f3511 100644 --- a/modules/debugger/doc/debugger_admin.xml +++ b/modules/debugger/doc/debugger_admin.xml @@ -918,7 +918,7 @@ $ &ctltool; fifo get_dbg_mod_facility debugger </title> <para> Get the module log level. - If module does not exist in kamailio, the entry in the level hashtable is still added for the bogus module. + If mod_name does not exist in the level hashtable, returns the config file value. </para> <para> Name: <emphasis>dbg.get_mod_level</emphasis> @@ -937,7 +937,7 @@ $ &ctltool; fifo get_dbg_mod_facility debugger </title> <para> Get the module log facility. - If module does not exist in kamailio, the entry in the facility hashtable is still added for the bogus module. + If mod_name does not exist in the facility hashtable, returns the config file value. </para> <para> Name: <emphasis>dbg.get_mod_facility</emphasis>

1 0

git:master:36686183: debugger: fix issue #463
by Stefan Mititelu 07 Jan '16

07 Jan '16

Module: kamailio Branch: master Commit: 3668618369a8a1db8cb3410c0a7f50ce74150cd2 URL: https://github.com/kamailio/kamailio/commit/3668618369a8a1db8cb3410c0a7f50c… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-07T09:58:42+02:00 debugger: fix issue #463 Don't shm_malloc() while the lock is taken. --- Modified: modules/debugger/debugger_api.c --- Diff: https://github.com/kamailio/kamailio/commit/3668618369a8a1db8cb3410c0a7f50c… Patch: https://github.com/kamailio/kamailio/commit/3668618369a8a1db8cb3410c0a7f50c… --- diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 566be68..cb57df3 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1344,15 +1344,14 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock); /* not found - add */ if(mlevel==NULL) { - lock_release(&_dbg_mod_table[idx].lock); return 0; } itn = (dbg_mod_level_t*)shm_malloc(sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock); return -1; } memset(itn, 0, sizeof(dbg_mod_level_t) + (mnlen+1)*sizeof(char)); @@ -1363,6 +1362,7 @@ int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first; _dbg_mod_table[idx].first = itn; @@ -1420,15 +1420,14 @@ int dbg_set_mod_debug_facility(char *mname, int mnlen, int *mfacility) itp = it; it = it->next; } + lock_release(&_dbg_mod_table[idx].lock_ft); /* not found - add */ if(mfacility==NULL) { - lock_release(&_dbg_mod_table[idx].lock_ft); return 0; } itn = (dbg_mod_facility_t*)shm_malloc(sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); if(itn==NULL) { LM_ERR("no more shm\n"); - lock_release(&_dbg_mod_table[idx].lock_ft); return -1; } memset(itn, 0, sizeof(dbg_mod_facility_t) + (mnlen+1)*sizeof(char)); @@ -1439,6 +1438,7 @@ int dbg_set_mod_debug_facility(char *mname, int mnlen, int *mfacility) strncpy(itn->name.s, mname, mnlen); itn->name.s[itn->name.len] = '\0'; + lock_get(&_dbg_mod_table[idx].lock_ft); if(itp==NULL) { itn->next = _dbg_mod_table[idx].first_ft; _dbg_mod_table[idx].first_ft = itn;

1 0

[kamailio] fix issue #463 (#469)
by Stefan Mititelu 07 Jan '16

07 Jan '16

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/469 -- Commit Summary -- * debugger: fix issue #463 * debugger: doku dbg.get_mod_* -- File Changes -- M modules/debugger/debugger_api.c (8) M modules/debugger/doc/debugger_admin.xml (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/469.patch https://github.com/kamailio/kamailio/pull/469.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/469

1 1

[kamailio] Merge pull request #1 from kamailio/master (#465)
by Tristan Mahé 07 Jan '16

07 Jan '16

merge upstream You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/465 -- Commit Summary -- * Merge pull request #1 from kamailio/master -- File Changes -- -- Patch Links -- https://github.com/kamailio/kamailio/pull/465.patch https://github.com/kamailio/kamailio/pull/465.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/465

1 1

← Newer
1
...
23
24
25
26
27
28
29
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2016