sr-dev October 2016

sr-dev@lists.kamailio.org

28 participants
234 discussions

[kamailio/kamailio] sca: add "server_address" parameter (#812)

by Victor Seva

* server address (sip:<host>[:port]) which will become the value of Contact header filed for NOTIFY messages. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/812 -- Commit Summary -- * sca: add "server_address" parameter -- File Changes -- M modules/sca/doc/sca_admin.xml (21) M modules/sca/sca.c (6) M modules/sca/sca.h (1) M modules/sca/sca_notify.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/812.patch https://github.com/kamailio/kamailio/pull/812.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/812

8 years, 1 month

Re: [sr-dev] $fU pv Assign New Value Isnt Rewrite old value sr-dev Digest, Vol 96, Issue 3

by Cléviton Mendes de Araújo

Daniel, thank you in advance, by his answer quick. But pay attention to the second assignment, the new value is append to the end of the previous content of $fU variable and isn't overwriting the $fU variable with the new value. This behaviour is what one I expected. That behaviour is Design definition? Beforehand, let me I join the Kamailio development community. Best Regards CMA > Date: Tue, 4 Oct 2016 08:07:03 +0200 > From: Daniel-Constantin Mierla <miconda(a)gmail.com> > To: "Kamailio (SER) - Development Mailing List" > <sr-dev(a)lists.sip-router.org> > Subject: Re: [sr-dev] $fU pv Assign New Value Isnt Rewrite old value > Message-ID: <6366e966-fb9d-28d9-b002-cbb5f143c24b(a)gmail.com> > Content-Type: text/plain; charset="utf-8" > > Hello, > > it is by design -- $fU is an operation over a sip header, which is done > in a special way for performance considerations -- for more details and > how to deal with multiple changes see: > > - > https://www.kamailio.org/wiki/tutorials/faq/main#why_changes_made_to_header… > > Cheers, > Daniel > > On 04/10/16 01:13, Cléviton Mendes de Araújo wrote: > > Hi,Kamailio Community > > > > > > > > Is there a bug when we assign new value to $fU pseudo-variable multi time? > > > > My scenery is according below: > > > > > > > > In a point on config file, let us that $fU value is: 7777. When I do > > assign: > > > > ..... > > $fU = "5555" + $fU; ### Here $fU = 55557777 > > ..... > > > > In another point, let us that value $sht(htble=>$var(nnnn)) hold is: > > 44444444. And I do: > > > > ..... > > $fU = $sht(htble=>$var(nnnn)); #### Here, it seems that this is > > happening $fU = 5555777744444444 > > ..... > > > > When I turn on ngrep analysis, I catch From header: > > > > ................. > > ................. > > From: "User Name" <sip:5555777744444444@IP-Address> > > ................. > > ................. > > > > > > This two assignments are realizing on same route block. > > > > So, it seems to be a bug. > > > > > > > > Best Regards, > > CMA > > > >

8 years, 1 month

git:master:44b80def: modules/ims_charging: cleaned up ref/unrefs and added filename and line num to debugs

by jaybeepee

Module: kamailio Branch: master Commit: 44b80def0cf5270167086d51c552f5b5e35e0d9c URL: https://github.com/kamailio/kamailio/commit/44b80def0cf5270167086d51c552f5b… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-10-03T16:16:59+02:00 modules/ims_charging: cleaned up ref/unrefs and added filename and line num to debugs --- Modified: modules/ims_charging/dialog.c Modified: modules/ims_charging/ims_ro.c Modified: modules/ims_charging/mod.c Modified: modules/ims_charging/ro_session_hash.c Modified: modules/ims_charging/ro_session_hash.h Modified: modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/44b80def0cf5270167086d51c552f5b… Patch: https://github.com/kamailio/kamailio/commit/44b80def0cf5270167086d51c552f5b…

8 years, 1 month

git:master:39fee94e: modules/ims_registrar_scscf: prevent possible segfault on contact param with no name

by jaybeepee

Module: kamailio Branch: master Commit: 39fee94eb6fd6c0c52e2f88776bfd2ca61825300 URL: https://github.com/kamailio/kamailio/commit/39fee94eb6fd6c0c52e2f88776bfd2c… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-10-03T15:50:34+02:00 modules/ims_registrar_scscf: prevent possible segfault on contact param with no name --- Modified: modules/ims_registrar_scscf/reply.c --- Diff: https://github.com/kamailio/kamailio/commit/39fee94eb6fd6c0c52e2f88776bfd2c… Patch: https://github.com/kamailio/kamailio/commit/39fee94eb6fd6c0c52e2f88776bfd2c… --- diff --git a/modules/ims_registrar_scscf/reply.c b/modules/ims_registrar_scscf/reply.c index c52334f..d86887f 100644 --- a/modules/ims_registrar_scscf/reply.c +++ b/modules/ims_registrar_scscf/reply.c @@ -115,19 +115,21 @@ static inline unsigned int calc_buf_len(impurecord_t* impurec) { } tmp = c->params; while (tmp) { - if ((tmp->name.s[0] == 'R' || tmp->name.s[0]=='r') && tmp->name.len == 8 && !memcmp(tmp->name.s+1, "eceived", 7)) { - tmp = tmp->next; - continue; - } - if ((tmp->name.s[0] == 'Q' || tmp->name.s[0]=='q') && tmp->name.len == 1) { - tmp = tmp->next; - continue; - } - if ((tmp->name.s[0] == 'E' || tmp->name.s[0] == 'e') && tmp->name.len == 7 && !memcmp(tmp->name.s + 1, "xpires", 6)) { - tmp = tmp->next; - continue; - } - len += tmp->name.len; + if (tmp->name.len > 0 && tmp->name.s) { + if ((tmp->name.s[0] == 'R' || tmp->name.s[0]=='r') && tmp->name.len == 8 && !memcmp(tmp->name.s+1, "eceived", 7)) { + tmp = tmp->next; + continue; + } + if ((tmp->name.s[0] == 'Q' || tmp->name.s[0]=='q') && tmp->name.len == 1) { + tmp = tmp->next; + continue; + } + if ((tmp->name.s[0] == 'E' || tmp->name.s[0] == 'e') && tmp->name.len == 7 && !memcmp(tmp->name.s + 1, "xpires", 6)) { + tmp = tmp->next; + continue; + } + len += tmp->name.len + 1 /*separator ; */; + } if (tmp->body.len > 0) { len = len + 1/*=*/ + 2/*2 x "*/; len += tmp->body.len; @@ -437,6 +439,7 @@ int build_contact(impurecord_t* impurec, contact_for_header_t** contact_header) tmp_contact_header->data_len = calc_buf_len(impurec); tmp_contact_header->buf = (char*)shm_malloc(tmp_contact_header->data_len); + memset(tmp_contact_header->buf, 0, tmp_contact_header->data_len); if (tmp_contact_header->data_len) { p = tmp_contact_header->buf; @@ -496,21 +499,24 @@ int build_contact(impurecord_t* impurec, contact_for_header_t** contact_header) /* put in the rest of the params except Q and received */ tmp = c->params; while (tmp) { - if ((tmp->name.s[0] == 'R' || tmp->name.s[0]=='r') && tmp->name.len == 8 && !memcmp(tmp->name.s+1, "eceived", 7)) { - tmp = tmp->next; - continue; - } - if ((tmp->name.s[0] == 'Q' || tmp->name.s[0]=='q') && tmp->name.len == 1) { - tmp = tmp->next; - continue; - } - if ((tmp->name.s[0] == 'E' || tmp->name.s[0]=='e') && tmp->name.len == 7 && !memcmp(tmp->name.s+1, "xpires", 6)) { - tmp = tmp->next; - continue; - } - *p++ = ';'; - memcpy(p, tmp->name.s, tmp->name.len); - p += tmp->name.len; + if (tmp->name.len>0 && tmp->name.s) { + if ((tmp->name.s[0] == 'R' || tmp->name.s[0]=='r') && tmp->name.len == 8 && !memcmp(tmp->name.s+1, "eceived", 7)) { + tmp = tmp->next; + continue; + } + if ((tmp->name.s[0] == 'Q' || tmp->name.s[0]=='q') && tmp->name.len == 1) { + tmp = tmp->next; + continue; + } + if ((tmp->name.s[0] == 'E' || tmp->name.s[0]=='e') && tmp->name.len == 7 && !memcmp(tmp->name.s+1, "xpires", 6)) { + tmp = tmp->next; + continue; + } + *p++ = ';'; + memcpy(p, tmp->name.s, tmp->name.len); + p += tmp->name.len; + } + if (tmp->body.len > 0) { *p++ = '='; *p++ = '\"';

8 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2016