sr-dev November 2016

sr-dev@lists.kamailio.org

27 participants
289 discussions

git:4.4:e292e044: pua_dialoginfo: safety check of paramters for __dialog_sendpublish()

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.4 Commit: e292e044800611eb3f27a17193af6a3ec66fdd83 URL: https://github.com/kamailio/kamailio/commit/e292e044800611eb3f27a17193af6a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-28T20:42:16+01:00 pua_dialoginfo: safety check of paramters for __dialog_sendpublish() - reported by Davy Van De Moere, GH #865 (cherry picked from commit 1d1d2246c8f89aa6eda52bda479014be0a10b937) --- Modified: modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/e292e044800611eb3f27a17193af6a3… Patch: https://github.com/kamailio/kamailio/commit/e292e044800611eb3f27a17193af6a3… --- diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c index 2e050d3..085d265 100644 --- a/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/modules/pua_dialoginfo/pua_dialoginfo.c @@ -254,10 +254,15 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para str tag = {0,0}; str uri = {0,0}; str target = {0,0}; + struct dlginfo_cell *dlginfo = NULL; + dlginfo = (struct dlginfo_cell*)*_params->param; - struct dlginfo_cell *dlginfo = (struct dlginfo_cell*)*_params->param; - + if(dlg==NULL || dlginfo==NULL) { + LM_WARN("execution with null parameters - type %d, dlg %p, info %p\n", + type, dlg, dlginfo); + return; + } if(include_req_uri) { uri = dlginfo->req_uri; } else {

7 years, 11 months

git:master:1d1d2246: pua_dialoginfo: safety check of paramters for __dialog_sendpublish()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1d1d2246c8f89aa6eda52bda479014be0a10b937 URL: https://github.com/kamailio/kamailio/commit/1d1d2246c8f89aa6eda52bda479014b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-28T19:09:03+01:00 pua_dialoginfo: safety check of paramters for __dialog_sendpublish() - reported by Davy Van De Moere, GH #865 --- Modified: modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/1d1d2246c8f89aa6eda52bda479014b… Patch: https://github.com/kamailio/kamailio/commit/1d1d2246c8f89aa6eda52bda479014b… --- diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c index 2e050d3..085d265 100644 --- a/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/modules/pua_dialoginfo/pua_dialoginfo.c @@ -254,10 +254,15 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para str tag = {0,0}; str uri = {0,0}; str target = {0,0}; + struct dlginfo_cell *dlginfo = NULL; + dlginfo = (struct dlginfo_cell*)*_params->param; - struct dlginfo_cell *dlginfo = (struct dlginfo_cell*)*_params->param; - + if(dlg==NULL || dlginfo==NULL) { + LM_WARN("execution with null parameters - type %d, dlg %p, info %p\n", + type, dlg, dlginfo); + return; + } if(include_req_uri) { uri = dlginfo->req_uri; } else {

7 years, 11 months

Passed: kamailio/kamailio#3235 (vseva/travis-3cdfb23b - 3cdfb23)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #3235 Status: Passed Duration: 3 minutes and 55 seconds Commit: 3cdfb23 (vseva/travis-3cdfb23b) Author: Victor Seva Message: pkg/kamailio: Initial Travis CI configuration View the changeset: https://github.com/kamailio/kamailio/compare/vseva/travis-3cdfb23b View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/179430655 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 11 months

git:master:75c25a85: kamctl: regenerated db creation script to update default datetime value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 75c25a857a1d95ef4810d862044957e1769834c7 URL: https://github.com/kamailio/kamailio/commit/75c25a857a1d95ef4810d862044957e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-27T15:40:02+01:00 kamctl: regenerated db creation script to update default datetime value --- Modified: utils/kamctl/db_berkeley/kamailio/aliases Modified: utils/kamctl/db_berkeley/kamailio/domain Modified: utils/kamctl/db_berkeley/kamailio/domain_attrs Modified: utils/kamctl/db_berkeley/kamailio/grp Modified: utils/kamctl/db_berkeley/kamailio/location Modified: utils/kamctl/db_berkeley/kamailio/location_attrs Modified: utils/kamctl/db_berkeley/kamailio/sip_trace Modified: utils/kamctl/db_berkeley/kamailio/uri Modified: utils/kamctl/db_berkeley/kamailio/usr_preferences Modified: utils/kamctl/db_sqlite/avpops-create.sql Modified: utils/kamctl/db_sqlite/domain-create.sql Modified: utils/kamctl/db_sqlite/group-create.sql Modified: utils/kamctl/db_sqlite/registrar-create.sql Modified: utils/kamctl/db_sqlite/siptrace-create.sql Modified: utils/kamctl/db_sqlite/uri_db-create.sql Modified: utils/kamctl/db_sqlite/usrloc-create.sql Modified: utils/kamctl/mysql/avpops-create.sql Modified: utils/kamctl/mysql/domain-create.sql Modified: utils/kamctl/mysql/group-create.sql Modified: utils/kamctl/mysql/registrar-create.sql Modified: utils/kamctl/mysql/siptrace-create.sql Modified: utils/kamctl/mysql/uri_db-create.sql Modified: utils/kamctl/mysql/usrloc-create.sql Modified: utils/kamctl/oracle/avpops-create.sql Modified: utils/kamctl/oracle/domain-create.sql Modified: utils/kamctl/oracle/group-create.sql Modified: utils/kamctl/oracle/registrar-create.sql Modified: utils/kamctl/oracle/siptrace-create.sql Modified: utils/kamctl/oracle/uri_db-create.sql Modified: utils/kamctl/oracle/usrloc-create.sql Modified: utils/kamctl/postgres/avpops-create.sql Modified: utils/kamctl/postgres/domain-create.sql Modified: utils/kamctl/postgres/group-create.sql Modified: utils/kamctl/postgres/registrar-create.sql Modified: utils/kamctl/postgres/siptrace-create.sql Modified: utils/kamctl/postgres/uri_db-create.sql Modified: utils/kamctl/postgres/usrloc-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/75c25a857a1d95ef4810d862044957e… Patch: https://github.com/kamailio/kamailio/commit/75c25a857a1d95ef4810d862044957e…

7 years, 12 months

git:master:3efa32c9: lib/srdb1 - set default datetime value to 2000-01-01

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3efa32c9cdfc7a7bdc913724fba92f7b7a76434c URL: https://github.com/kamailio/kamailio/commit/3efa32c9cdfc7a7bdc913724fba92f7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-27T15:38:56+01:00 lib/srdb1 - set default datetime value to 2000-01-01 - 1900 is before the start of epoch and can result in unexpected behaviour with some time related functions --- Modified: lib/srdb1/schema/entities.xml --- Diff: https://github.com/kamailio/kamailio/commit/3efa32c9cdfc7a7bdc913724fba92f7… Patch: https://github.com/kamailio/kamailio/commit/3efa32c9cdfc7a7bdc913724fba92f7… --- diff --git a/lib/srdb1/schema/entities.xml b/lib/srdb1/schema/entities.xml index c14a801..b63d5ed 100644 --- a/lib/srdb1/schema/entities.xml +++ b/lib/srdb1/schema/entities.xml @@ -28,6 +28,6 @@ <!ENTITY DEFAULT_Q "1.0"> <!ENTITY DEFAULT_CALLID "Default-Call-ID"> <!ENTITY DEFAULT_CSEQ "1"> -<!ENTITY DEFAULT_DATETIME "1900-01-01 00:00:01">  +<!ENTITY DEFAULT_DATETIME "2000-01-01 00:00:01">  <!ENTITY DEFAULT_FLAGS "0"> <!ENTITY KAMAILIO_MOD_DOC "http://www.kamailio.org/docs/modules/devel/">

7 years, 12 months

kamailio core dumps once every few days

by davy van de moere

Gents, On a not really loaded kamailio (less than 50 users at the moment), I'm getting a core dump every few days. I've tried multiple verisons of Kamailio, 4.4.x , 4.3.x and also on 5.0.0-dev7 . I can't reproduce it adhoc, but every few days it happens... Is that something someone wants to jump in? grtz, davy Version: version: kamailio 5.0.0-dev7 (x86_64/linux) 7360b0 [New LWP 29728] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/local/sbin/kamailio -P /var/run/kamailio.pid -f /usr/local/etc/kamailio//k'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f92c5a0be98 in __dialog_sendpublish (dlg=0x7f92c0e3a6c0, type=64, _params=0x7f92c0423500 <params>) at pua_dialoginfo.c:264 264 uri = dlginfo->to_uri; (gdb) backtrace #0 0x00007f92c5a0be98 in __dialog_sendpublish (dlg=0x7f92c0e3a6c0, type=64, _params=0x7f92c0423500 <params>) at pua_dialoginfo.c:264 #1 0x00007f92c01e2563 in run_dlg_callbacks (type=64, dlg=0x7f92c0e3a6c0, req=0x7f92cc6d5db8, rpl=0x0, dir=1, dlg_data=0x0) at dlg_cb.c:256 #2 0x00007f92c01a92b1 in dlg_terminated (req=0x7f92cc6d5db8, dlg=0x7f92c0e3a6c0, dir=1) at dlg_handlers.c:366 #3 0x00007f92c01b610f in dlg_onroute (req=0x7f92cc6d5db8, route_params=0x7ffc7de27ba0, param=0x0) at dlg_handlers.c:1409 #4 0x00007f92c9292171 in run_rr_callbacks (req=0x7f92cc6d5db8, rr_param=0x7ffc7de27c20) at rr_cb.c:96 #5 0x00007f92c9287ac2 in after_loose (_m=0x7f92cc6d5db8, preloaded=0) at loose.c:928 #6 0x00007f92c9288168 in loose_route (_m=0x7f92cc6d5db8) at loose.c:962 #7 0x00007f92c928b7ee in w_loose_route (msg=0x7f92cc6d5db8, p1=0x0, p2=0x0) at rr_mod.c:266 #8 0x000000000041f5d9 in do_action (h=0x7ffc7de285b0, a=0x7f92cc5f7a70, msg=0x7f92cc6d5db8) at action.c:1054 #9 0x000000000042bcde in run_actions (h=0x7ffc7de285b0, a=0x7f92cc5f7a70, msg=0x7f92cc6d5db8) at action.c:1552 #10 0x000000000042c383 in run_actions_safe (h=0x7ffc7de29c60, a=0x7f92cc5f7a70, msg=0x7f92cc6d5db8) at action.c:1620 #11 0x000000000061fe86 in rval_get_int (h=0x7ffc7de29c60, msg=0x7f92cc6d5db8, i=0x7ffc7de28cc0, rv=0x7f92cc5f7bc8, cache=0x0) at rvalue.c:912 #12 0x00000000006243c3 in rval_expr_eval_int (h=0x7ffc7de29c60, msg=0x7f92cc6d5db8, res=0x7ffc7de28cc0, rve=0x7f92cc5f7bc0) at rvalue.c:1910 #13 0x000000000041f0d1 in do_action (h=0x7ffc7de29c60, a=0x7f92cc600430, msg=0x7f92cc6d5db8) at action.c:1030 #14 0x000000000042bcde in run_actions (h=0x7ffc7de29c60, a=0x7f92cc600430, msg=0x7f92cc6d5db8) at action.c:1552 #15 0x000000000041f548 in do_action (h=0x7ffc7de29c60, a=0x7f92cc6006d0, msg=0x7f92cc6d5db8) at action.c:1045 #16 0x000000000042bcde in run_actions (h=0x7ffc7de29c60, a=0x7f92cc6006d0, msg=0x7f92cc6d5db8) at action.c:1552 #17 0x000000000041c0fb in do_action (h=0x7ffc7de29c60, a=0x7f92cc545730, msg=0x7f92cc6d5db8) at action.c:678 #18 0x000000000042bcde in run_actions (h=0x7ffc7de29c60, a=0x7f92cc537760, msg=0x7f92cc6d5db8) at action.c:1552 #19 0x000000000042c44b in run_top_route (a=0x7f92cc537760, msg=0x7f92cc6d5db8, c=0x0) at action.c:1641 #20 0x00000000005726a2 in receive_msg ( buf=0xa1c200 <buf> "BYE sip:echo@123.48.11.215:5070;transport=udp SIP/2.0\r\nVia: SIP/2.0/UDP 0.0.0.0:5060;rport;branch=z9hG4bKPj26b505ba-7ede-4198-a917-bde966b6d8b6\r\nMax-Forwards: 69\r\nFrom: sip:192.168.60.1;tag=9a10d8ab-"..., len=462, rcv_info=0x7ffc7de29fb0) at receive.c:264 #21 0x000000000047bcdc in udp_rcv_loop () at udp_server.c:507 #22 0x0000000000509de1 in main_loop () at main.c:1618 #23 0x00000000005112de in main (argc=5, argv=0x7ffc7de2a478) at main.c:2639 (gdb)

7 years, 12 months

git:master:88ef3f0b: modules/ims_qos: new mod_param to add RTCP flow description for media flow

by Richard Good

Module: kamailio Branch: master Commit: 88ef3f0bc54f3858f80d0441bb06b056f50d4ca1 URL: https://github.com/kamailio/kamailio/commit/88ef3f0bc54f3858f80d0441bb06b05… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: 2016-11-25T16:48:27+02:00 modules/ims_qos: new mod_param to add RTCP flow description for media flow New parameter include_rtcp_fd that if set adds additional flow description to AAR for RTCP --- Modified: modules/ims_qos/doc/ims_qos_admin.xml Modified: modules/ims_qos/mod.c Modified: modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/88ef3f0bc54f3858f80d0441bb06b05… Patch: https://github.com/kamailio/kamailio/commit/88ef3f0bc54f3858f80d0441bb06b05…

7 years, 12 months

dialplan.translate error

by Victor V. Kustov

When "kamcmd dialplan.translate" calling it wait 2 parameters with type autodetection. In documentation: kamcmd dp_translate 1 "abcdxyz" But if second parameter contains only numbers, we had error: kamcmd dialplan.translate 3 111222 error: 500 - Invalid parameters or with kamcmd dialplan.translate 3 "111222" It's incorrect. Correct: kamcmd dialplan.translate 3 s:111222 Please fix documentation. -- WBR, Victor

7 years, 12 months

git:master:3cfc8d9c: kamctl: refreshed the db creation scripts for topos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3cfc8d9c54ac4e566134889800e9eeb318274b75 URL: https://github.com/kamailio/kamailio/commit/3cfc8d9c54ac4e566134889800e9eeb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-24T17:49:28+01:00 kamctl: refreshed the db creation scripts for topos --- Modified: utils/kamctl/db_berkeley/kamailio/topos_d Modified: utils/kamctl/db_berkeley/kamailio/topos_t Modified: utils/kamctl/db_sqlite/topos-create.sql Modified: utils/kamctl/dbtext/kamailio/topos_d Modified: utils/kamctl/dbtext/kamailio/topos_t Modified: utils/kamctl/mysql/topos-create.sql Modified: utils/kamctl/oracle/topos-create.sql Modified: utils/kamctl/postgres/topos-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/3cfc8d9c54ac4e566134889800e9eeb… Patch: https://github.com/kamailio/kamailio/commit/3cfc8d9c54ac4e566134889800e9eeb…

7 years, 12 months

git:master:0eea31b4: lib/srdb1: schema - don't set default value for text/blob columns of topos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0eea31b4b934de45e8bc5091f7ba5a9d486dd16f URL: https://github.com/kamailio/kamailio/commit/0eea31b4b934de45e8bc5091f7ba5a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-24T17:49:28+01:00 lib/srdb1: schema - don't set default value for text/blob columns of topos - not allowed by newer versions of mysql --- Modified: lib/srdb1/schema/topos_d.xml Modified: lib/srdb1/schema/topos_t.xml --- Diff: https://github.com/kamailio/kamailio/commit/0eea31b4b934de45e8bc5091f7ba5a9… Patch: https://github.com/kamailio/kamailio/commit/0eea31b4b934de45e8bc5091f7ba5a9… --- diff --git a/lib/srdb1/schema/topos_d.xml b/lib/srdb1/schema/topos_d.xml index cf62889..1f7fd35 100644 --- a/lib/srdb1/schema/topos_d.xml +++ b/lib/srdb1/schema/topos_d.xml @@ -128,21 +128,21 @@ <column id="a_rr"> <name>a_rr</name> <type>largetext</type> - <default/> + <null/> <description>Record route - A side</description> </column> <column id="b_rr"> <name>b_rr</name> <type>largetext</type> - <default/> + <null/> <description>Record route - B side</description> </column> <column id="s_rr"> <name>s_rr</name> <type>largetext</type> - <default/> + <null/> <description>Record route - S side</description> </column> diff --git a/lib/srdb1/schema/topos_t.xml b/lib/srdb1/schema/topos_t.xml index 86fcb2f..e3978f0 100644 --- a/lib/srdb1/schema/topos_t.xml +++ b/lib/srdb1/schema/topos_t.xml @@ -88,7 +88,7 @@ <column id="x_via"> <name>x_via</name> <type>largetext</type> - <default/> + <null/> <description>Via stack - A or B side</description> </column> @@ -104,21 +104,21 @@ <column id="x_rr"> <name>x_rr</name> <type>largetext</type> - <default/> + <null/> <description>RR stack - incoming A or B side</description> </column> <column id="y_rr"> <name>y_rr</name> <type>largetext</type> - <default/> + <null/> <description>RR stack - the other A or B side</description> </column> <column id="s_rr"> <name>s_rr</name> <type>largetext</type> - <default/> + <null/> <description>RR stack - the S side</description> </column>

7 years, 12 months

← Newer
1
...
5
6
7
8
9
10
11
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2016