sr-dev February 2016

sr-dev@lists.kamailio.org

28 participants
303 discussions

git:master:1f8c8ef2: Revert "modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)"
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 1f8c8ef2a68a380724b12d035b1d73705546dc8f URL: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:13:59+02:00 Revert "modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)" This reverts commit 574b8d6c2d0897ba69c5eec14775350508ad0778. --- Modified: modules/ims_registrar_scscf/registrar_notify.h --- Diff: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… Patch: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… --- diff --git a/modules/ims_registrar_scscf/registrar_notify.h b/modules/ims_registrar_scscf/registrar_notify.h index 1d83286..f3d5ac1 100644 --- a/modules/ims_registrar_scscf/registrar_notify.h +++ b/modules/ims_registrar_scscf/registrar_notify.h @@ -72,14 +72,12 @@ typedef struct _reg_notification { int num_impus; unsigned int local_cseq; - unsigned int reginfo_s_version; str call_id; str from_tag; str to_tag; str record_route; str sockinfo_str; - struct _reg_notification *next; /**< next notification in the list */ struct _reg_notification *prev; /**< previous notification in the list */ } reg_notification; @@ -134,7 +132,7 @@ str generate_reginfo_full(udomain_t* _t, str* impu_list, int new_subscription); str get_reginfo_partial(impurecord_t *r, ucontact_t *c, int event_type); -void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str* impus, int num_impus, int event_type); +void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str** impus, int num_impus, int event_type); void notification_event_process();

1 0

git:master:69011822: modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 69011822286acd4f051c43d502972e4e5ff35195 URL: https://github.com/kamailio/kamailio/commit/69011822286acd4f051c43d502972e4… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:12:21+02:00 modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type) - useful if looking for a specific type of UE ie VoLTE vs SIP for example --- Modified: modules/ims_registrar_scscf/lookup.c Modified: modules/ims_registrar_scscf/lookup.h Modified: modules/ims_registrar_scscf/reg_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/69011822286acd4f051c43d502972e4… Patch: https://github.com/kamailio/kamailio/commit/69011822286acd4f051c43d502972e4…

1 0

git:master:574b8d6c: modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 574b8d6c2d0897ba69c5eec14775350508ad0778 URL: https://github.com/kamailio/kamailio/commit/574b8d6c2d0897ba69c5eec14775350… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:11:19+02:00 modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type) - useful if looking for a specific type of UE ie VoLTE vs SIP for example --- Modified: modules/ims_registrar_scscf/registrar_notify.h --- Diff: https://github.com/kamailio/kamailio/commit/574b8d6c2d0897ba69c5eec14775350… Patch: https://github.com/kamailio/kamailio/commit/574b8d6c2d0897ba69c5eec14775350… --- diff --git a/modules/ims_registrar_scscf/registrar_notify.h b/modules/ims_registrar_scscf/registrar_notify.h index f3d5ac1..1d83286 100644 --- a/modules/ims_registrar_scscf/registrar_notify.h +++ b/modules/ims_registrar_scscf/registrar_notify.h @@ -72,12 +72,14 @@ typedef struct _reg_notification { int num_impus; unsigned int local_cseq; + unsigned int reginfo_s_version; str call_id; str from_tag; str to_tag; str record_route; str sockinfo_str; + struct _reg_notification *next; /**< next notification in the list */ struct _reg_notification *prev; /**< previous notification in the list */ } reg_notification; @@ -132,7 +134,7 @@ str generate_reginfo_full(udomain_t* _t, str* impu_list, int new_subscription); str get_reginfo_partial(impurecord_t *r, ucontact_t *c, int event_type); -void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str** impus, int num_impus, int event_type); +void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str* impus, int num_impus, int event_type); void notification_event_process();

1 0

git:master:0a8062df: modules/ims_dialog: release lock on error condition
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 0a8062dfa0f0b1cc13825b75fea688548409c9c3 URL: https://github.com/kamailio/kamailio/commit/0a8062dfa0f0b1cc13825b75fea6885… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:04:44+02:00 modules/ims_dialog: release lock on error condition --- Modified: modules/ims_dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/0a8062dfa0f0b1cc13825b75fea6885… Patch: https://github.com/kamailio/kamailio/commit/0a8062dfa0f0b1cc13825b75fea6885… --- diff --git a/modules/ims_dialog/dlg_hash.c b/modules/ims_dialog/dlg_hash.c index 230e1f4..5860df4 100644 --- a/modules/ims_dialog/dlg_hash.c +++ b/modules/ims_dialog/dlg_hash.c @@ -452,6 +452,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, dlg_out->callee_route_set.s = (char*) shm_malloc(rr->len); if (!dlg_out->callee_route_set.s) { LM_ERR("no more shm mem\n"); + lock_release(dlg->dlg_out_entries_lock); return -1; //if we're out of mem we dont really care about cleaning up - prob going to crash anyway } dlg_out->callee_route_set.len = rr->len;

1 0

git:master:b4a44236: modules/ims_dialog: pass reason to terminate function
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: b4a4423695eab8087de4f3ed68e21145ac1fd5d5 URL: https://github.com/kamailio/kamailio/commit/b4a4423695eab8087de4f3ed68e2114… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:03:57+02:00 modules/ims_dialog: pass reason to terminate function --- Modified: modules/ims_dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b4a4423695eab8087de4f3ed68e2114… Patch: https://github.com/kamailio/kamailio/commit/b4a4423695eab8087de4f3ed68e2114… --- diff --git a/modules/ims_dialog/dlg_req_within.c b/modules/ims_dialog/dlg_req_within.c index 902fbe6..2de823d 100644 --- a/modules/ims_dialog/dlg_req_within.c +++ b/modules/ims_dialog/dlg_req_within.c @@ -507,7 +507,7 @@ int w_api_terminate_dlg(str *callid, str *ftag, str *ttag, str *hdrs, str* reaso unref_dlg(dlg, 1); - return dlg_terminate(dlg, NULL, NULL/*reason*/, 2, hdrs); + return dlg_terminate(dlg, NULL, reason, 2, hdrs); }

1 0

git:master:51ba40fe: modules/ims_dialog: release lock in error conditions
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 51ba40fe5707bcadfa84ac99138537132ee7c0cb URL: https://github.com/kamailio/kamailio/commit/51ba40fe5707bcadfa84ac991385371… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:03:00+02:00 modules/ims_dialog: release lock in error conditions --- Modified: modules/ims_dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/51ba40fe5707bcadfa84ac991385371… Patch: https://github.com/kamailio/kamailio/commit/51ba40fe5707bcadfa84ac991385371… --- diff --git a/modules/ims_dialog/dlg_hash.c b/modules/ims_dialog/dlg_hash.c index 4de3b32..230e1f4 100644 --- a/modules/ims_dialog/dlg_hash.c +++ b/modules/ims_dialog/dlg_hash.c @@ -442,6 +442,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, dlg_out->callee_contact.s = (char*) shm_malloc(contact->len); if (!dlg_out->callee_contact.s) { LM_ERR("no more shm mem\n"); + lock_release(dlg->dlg_out_entries_lock); return -1; //if we're out of mem we dont really care about cleaning up - prob going to crash anyway } dlg_out->callee_contact.len = contact->len; @@ -461,6 +462,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, dlg_out->caller_cseq.s = (char*) shm_malloc(cseq->len); if (!dlg_out->callee_cseq.s || !dlg_out->caller_cseq.s) { LM_ERR("no more shm mem\n"); + lock_release(dlg->dlg_out_entries_lock); return -1; //if we're out of mem we dont really care about cleaning up - prob going to crash anyway } dlg_out->caller_cseq.len = cseq->len;

1 0

git:master:6b80de3f: modules/ims_dialog: changed log line from ERR to DBG
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 6b80de3f9d4a69979ee1a3f2e7f8bbd72191d915 URL: https://github.com/kamailio/kamailio/commit/6b80de3f9d4a69979ee1a3f2e7f8bbd… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:01:54+02:00 modules/ims_dialog: changed log line from ERR to DBG --- Modified: modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/6b80de3f9d4a69979ee1a3f2e7f8bbd… Patch: https://github.com/kamailio/kamailio/commit/6b80de3f9d4a69979ee1a3f2e7f8bbd… --- diff --git a/modules/ims_dialog/dlg_handlers.c b/modules/ims_dialog/dlg_handlers.c index 323b7c9..ba38de8 100644 --- a/modules/ims_dialog/dlg_handlers.c +++ b/modules/ims_dialog/dlg_handlers.c @@ -1280,7 +1280,7 @@ void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) { to_tag = get_to(rpl)->tag_value; if (to_tag.s == 0 || to_tag.len == 0) { - LM_ERR("missing TAG param in TO hdr :-/\n"); + LM_DBG("missing TAG param in TO hdr :-/ - probably a failure response\n"); to_tag.s = 0; to_tag.len = 0; //Here we assume that the transaction module timer will remove any early dialogs

1 0

git:master:f39c41fb: modules/ims_dialog: fixed dialog stats
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: f39c41fb02e8c1617910f9f42fdfceb9b0721967 URL: https://github.com/kamailio/kamailio/commit/f39c41fb02e8c1617910f9f42fdfceb… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:00:21+02:00 modules/ims_dialog: fixed dialog stats --- Modified: modules/ims_dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/f39c41fb02e8c1617910f9f42fdfceb… Patch: https://github.com/kamailio/kamailio/commit/f39c41fb02e8c1617910f9f42fdfceb… --- diff --git a/modules/ims_dialog/dlg_req_within.c b/modules/ims_dialog/dlg_req_within.c index 44e1856..902fbe6 100644 --- a/modules/ims_dialog/dlg_req_within.c +++ b/modules/ims_dialog/dlg_req_within.c @@ -44,12 +44,14 @@ #include "dlg_hash.h" #include "dlg_req_within.h" #include "dlg_db_handler.h" +#include "dlg_ng_stats.h" #define MAX_FWD_HDR "Max-Forwards: " MAX_FWD CRLF #define MAX_FWD_HDR_LEN (sizeof(MAX_FWD_HDR) - 1) extern str dlg_extra_hdrs; extern int dlg_db_mode; +extern struct dialog_ng_counters_h dialog_ng_cnts_h; int free_tm_dlg(dlg_t *td) { if (td) { @@ -203,6 +205,9 @@ void bye_reply_cb(struct cell* t, int type, struct tmcb_params* ps) { } else { unref++; } + + counter_add(dialog_ng_cnts_h.active, -1); + /* dialog terminated (BYE) */ run_dlg_callbacks(DLGCB_TERMINATED, dlg, ps->req, ps->rpl, DLG_DIR_NONE, 0);

1 0

git:master:ff9dd831: modules/ims_dialog: added extra info to log line - transaction ptr
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: ff9dd83111fcaee8d9ef34d49cf9cd56ecdbacd9 URL: https://github.com/kamailio/kamailio/commit/ff9dd83111fcaee8d9ef34d49cf9cd5… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T19:55:52+02:00 modules/ims_dialog: added extra info to log line - transaction ptr --- Modified: modules/ims_dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/ff9dd83111fcaee8d9ef34d49cf9cd5… Patch: https://github.com/kamailio/kamailio/commit/ff9dd83111fcaee8d9ef34d49cf9cd5… --- diff --git a/modules/ims_dialog/dlg_req_within.c b/modules/ims_dialog/dlg_req_within.c index 68fdb2a..44e1856 100644 --- a/modules/ims_dialog/dlg_req_within.c +++ b/modules/ims_dialog/dlg_req_within.c @@ -345,8 +345,8 @@ int dlg_terminate(struct dlg_cell *dlg, struct sip_msg *msg, str *reason, int si return -1; } if (dlg->transaction) { - LM_DBG("terminating early dialog with %d outbound forks\n", - dlg->transaction->nr_of_outgoings); + LM_DBG("terminating early dialog with %d outbound forks on transaction %p\n", + dlg->transaction->nr_of_outgoings, dlg->transaction); t = dlg->transaction;

1 0

git:master:57e5a8e3: modules/cdp: update last used time when sending diameter message to peer
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 57e5a8e33d5fd9fb51a4d88f0bf131ea1c34a4c7 URL: https://github.com/kamailio/kamailio/commit/57e5a8e33d5fd9fb51a4d88f0bf131e… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T19:48:15+02:00 modules/cdp: update last used time when sending diameter message to peer --- Modified: modules/cdp/peerstatemachine.c --- Diff: https://github.com/kamailio/kamailio/commit/57e5a8e33d5fd9fb51a4d88f0bf131e… Patch: https://github.com/kamailio/kamailio/commit/57e5a8e33d5fd9fb51a4d88f0bf131e… --- diff --git a/modules/cdp/peerstatemachine.c b/modules/cdp/peerstatemachine.c index 3f26088..495283f 100644 --- a/modules/cdp/peerstatemachine.c +++ b/modules/cdp/peerstatemachine.c @@ -1141,7 +1141,6 @@ void Snd_Message(peer *p, AAAMessage *msg) int send_message_before_session_sm=0; LM_DBG("Snd_Message called to peer [%.*s] for %s with code %d \n", p->fqdn.len,p->fqdn.s,is_req(msg)?"request":"response",msg->commandCode); - touch_peer(p); if (msg->sessionId) session = cdp_get_session(msg->sessionId->data); if (session){

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2016