Hi,
we renamed the module and functions according to the discussed guidelines.
If you are fine I can merge the module. Do you prefer a squashed commit?
Cheers,
Federico
This new module, based on libevent and cURL multi interface, implements non blocking HTTP queries.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/480
-- Commit Summary --
* pv: expose some PV API function
* async_http: non-blocking HTTP client module
-- File Changes --
A modules/async_http/Makefile (32)
A modules/async_http/README (423)
A modules/async_http/async_http.c (326)
A modules/async_http/async_http.h (131)
A modules/async_http/async_http_mod.c (636)
A modules/async_http/doc/Makefile (4)
A modules/async_http/doc/async_http.xml (51)
A modules/async_http/doc/async_http_admin.xml (437)
A modules/async_http/hm_hash.c (186)
A modules/async_http/hm_hash.h (134)
A modules/async_http/http_multi.c (591)
A modules/async_http/http_multi.h (65)
M modules/pv/pv.c (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/480.patchhttps://github.com/kamailio/kamailio/pull/480.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/480
Module: kamailio
Branch: master
Commit: ff90dbd17fd041bf85d0cb7c3590b0493e8dba15
URL: https://github.com/kamailio/kamailio/commit/ff90dbd17fd041bf85d0cb7c3590b04…
Author: Olle E. Johansson <oej(a)edvina.net>
Committer: Olle E. Johansson <oej(a)edvina.net>
Date: 2016-02-03T13:11:11+01:00
http_client Update Todo
---
Modified: modules/http_client/TODO.txt
---
Diff: https://github.com/kamailio/kamailio/commit/ff90dbd17fd041bf85d0cb7c3590b04…
Patch: https://github.com/kamailio/kamailio/commit/ff90dbd17fd041bf85d0cb7c3590b04…
---
diff --git a/modules/http_client/TODO.txt b/modules/http_client/TODO.txt
index 8d8f347..bb66e9c 100644
--- a/modules/http_client/TODO.txt
+++ b/modules/http_client/TODO.txt
@@ -5,7 +5,7 @@ The http_client module - todo
timeout=x - DONE
read=line/all - Implemented in API, but not in parameter
tlsverify=on/off
- failover=curlcon Other curlcon that can be used for failover in case of 5xx response or timeout
+ failover=httpcon Other httpcon that can be used for failover in case of 5xx response or timeout
httpredirect - DONE
useragent - DONE
@@ -21,9 +21,9 @@ The http_client module - todo
- save fingerprint of cert for trust-on-first-use procedure
-- status for curlcon-object, needs to be object in process memory, so child_init
+- status for httpcon-object, needs to be object in process memory, so child_init
- if 5xx response or timeout set flag
- - function in dialplan - curlcon_exist(object)
+ - function in dialplan - httpcon_exists(object)
- pv $curlstatus(object) ??
- this is per process !!!
I am about to rename functions with the “curl” prefix as well as the connection defintions.
Since the old function in utils use “http” as a prefix we need something else.
“http_client” seems too long
“hc” and “hac” for sync and async functions may work. “httpcon” instead of “curlcon”.
Any better ideas?
/O