sr-dev February 2016

sr-dev@lists.kamailio.org

28 participants
302 discussions

git:master:1e4a2316: modules/ims_usrloc_pcscf, ims_usrloc_scscf, ims_qos: pass contact state into search requests
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: 1e4a2316ec64f666ffa8fe865294fadcb06ebdac URL: https://github.com/kamailio/kamailio/commit/1e4a2316ec64f666ffa8fe865294fad… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T14:09:14+02:00 modules/ims_usrloc_pcscf, ims_usrloc_scscf, ims_qos: pass contact state into search requests - more flexibility on state of contact to search for --- Modified: modules/ims_qos/cdpeventprocessor.c Modified: modules/ims_qos/mod.c Modified: modules/ims_qos/rx_aar.c Modified: modules/ims_registrar_pcscf/save.c Modified: modules/ims_registrar_pcscf/service_routes.c Modified: modules/ims_usrloc_pcscf/udomain.c Modified: modules/ims_usrloc_pcscf/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/1e4a2316ec64f666ffa8fe865294fad… Patch: https://github.com/kamailio/kamailio/commit/1e4a2316ec64f666ffa8fe865294fad…

1 0

git:master:ce86851d: modules/ims_charging: add reason header for out-of-credit timeouts
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: ce86851ded64a094bd62cc205ce19f0b7bfa2f20 URL: https://github.com/kamailio/kamailio/commit/ce86851ded64a094bd62cc205ce19f0… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T14:08:00+02:00 modules/ims_charging: add reason header for out-of-credit timeouts --- Modified: modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/ce86851ded64a094bd62cc205ce19f0… Patch: https://github.com/kamailio/kamailio/commit/ce86851ded64a094bd62cc205ce19f0… --- diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c index ade2614..97e292d 100644 --- a/modules/ims_charging/ro_timer.c +++ b/modules/ims_charging/ro_timer.c @@ -380,7 +380,8 @@ void resume_ro_session_ontimeout(struct interim_ccr *i_req) { void ro_session_ontimeout(struct ro_tl *tl) { time_t now, call_time; long used_secs; - int adjustment; + int adjustment; + str default_out_of_credit_hdrs = {"Reason: outofcredit\r\n", 21}; LM_DBG("We have a fired timer [p=%p] and tl=[%i].\n", tl, tl->timeout); @@ -484,7 +485,7 @@ void ro_session_ontimeout(struct ro_tl *tl) { counter_inc(ims_charging_cnts_h.killed_calls); - dlgb.lookup_terminate_dlg(ro_session->dlg_h_entry, ro_session->dlg_h_id, NULL); + dlgb.lookup_terminate_dlg(ro_session->dlg_h_entry, ro_session->dlg_h_id, &default_out_of_credit_hdrs); return; }

1 0

git:master:86483813: modules/ims_charging: release dialog reference on Ro failure conditions
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: 86483813ac8ab78aba07496c63009b77f4dbe739 URL: https://github.com/kamailio/kamailio/commit/86483813ac8ab78aba07496c63009b7… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T14:06:33+02:00 modules/ims_charging: release dialog reference on Ro failure conditions --- Modified: modules/ims_charging/mod.c --- Diff: https://github.com/kamailio/kamailio/commit/86483813ac8ab78aba07496c63009b7… Patch: https://github.com/kamailio/kamailio/commit/86483813ac8ab78aba07496c63009b7… --- diff --git a/modules/ims_charging/mod.c b/modules/ims_charging/mod.c index 6242aad..ecc6d4b 100644 --- a/modules/ims_charging/mod.c +++ b/modules/ims_charging/mod.c @@ -371,16 +371,19 @@ static int w_ro_ccr_stop(struct sip_msg *msg, char* c_direction, char* _code, ch if (get_str_fparam(&s_code, msg, (fparam_t*) _code) < 0) { LM_ERR("failed to get code\n"); + dlgb.release_dlg(dlg); return RO_RETURN_ERROR; } LM_DBG("Code is [%.*s]\n", s_code.len, s_code.s); if (get_str_fparam(&s_reason, msg, (fparam_t*) _reason) < 0) { LM_ERR("failed to get reason\n"); + dlgb.release_dlg(dlg); return RO_RETURN_ERROR; } if (str2int(&s_code, &code) != 0) { LM_ERR("Bad response code: [%.*s]\n", s_code.len, s_code.s); + dlgb.release_dlg(dlg); return RO_RETURN_FALSE; } @@ -405,6 +408,7 @@ static int w_ro_ccr_stop(struct sip_msg *msg, char* c_direction, char* _code, ch ro_session = lookup_ro_session(dlg->h_entry, &dlg->callid, dir, 0); if (ro_session == NULL) { LM_DBG("no ro_session - ignoring\n"); + dlgb.release_dlg(dlg); return RO_RETURN_TRUE; } h_entry = ro_session->h_entry; @@ -425,6 +429,7 @@ static int w_ro_ccr_stop(struct sip_msg *msg, char* c_direction, char* _code, ch done: unref_ro_session_unsafe(ro_session, 1, ro_session_entry); ro_session_unlock(ro_session_table, ro_session_entry); + dlgb.release_dlg(dlg); return RO_RETURN_TRUE; }

1 0

git:master:327a4f0a: modules/ims_charging: print error on failed CCR resultcode
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: 327a4f0a6ce978ef61f5bee3b6107b541e00f702 URL: https://github.com/kamailio/kamailio/commit/327a4f0a6ce978ef61f5bee3b6107b5… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T14:05:55+02:00 modules/ims_charging: print error on failed CCR resultcode --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/327a4f0a6ce978ef61f5bee3b6107b5… Patch: https://github.com/kamailio/kamailio/commit/327a4f0a6ce978ef61f5bee3b6107b5… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 08565bc..bbb8c07 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -1302,7 +1302,8 @@ static void resume_on_initial_ccr(int is_timeout, void *param, AAAMessage *cca, } create_cca_result_code((int)ro_cca_data->resultcode); if (ro_cca_data->resultcode != 2001) { - LM_ERR("Got bad CCA result code - reservation failed"); + if (ro_cca_data->resultcode != 4012) + LM_ERR("Got bad CCA result code [%d] - reservation failed\n", (int)ro_cca_data->resultcode); error_code = RO_RETURN_FALSE; goto error1; }

1 0

git:master:7ac16452: modules/ims_charging: check msg for reason header and include in Ro CCR if present
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: 7ac16452539875db390a5fbc6493fd11c9263880 URL: https://github.com/kamailio/kamailio/commit/7ac16452539875db390a5fbc6493fd1… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T14:03:54+02:00 modules/ims_charging: check msg for reason header and include in Ro CCR if present --- Modified: modules/ims_charging/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/7ac16452539875db390a5fbc6493fd1… Patch: https://github.com/kamailio/kamailio/commit/7ac16452539875db390a5fbc6493fd1… --- diff --git a/modules/ims_charging/dialog.c b/modules/ims_charging/dialog.c index 248f4eb..4596749 100644 --- a/modules/ims_charging/dialog.c +++ b/modules/ims_charging/dialog.c @@ -3,6 +3,7 @@ #include "ro_session_hash.h" #include "ro_db_handler.h" #include "ims_charging_stats.h" +#include "../../parser/hf.h" struct cdp_binds cdpb; @@ -145,6 +146,12 @@ void dlg_terminated(struct dlg_cell *dlg, int type, unsigned int termcode, char* } else { LM_DBG("Request is %.*s\n", _params->req->first_line.u.request.method.len, _params->req->first_line.u.request.method.s); } + + struct hdr_field* h = get_hdr_by_name(_params->req, "Reason", 6); + if(h!=NULL){ + LM_DBG("reason header is [%.*s]\n", h->body.len, h->body.s); + s_reason = h->body; + } } else if (_params->rpl) { LM_DBG("Reply is [%d - %.*s]", _params->rpl->first_line.u.reply.statuscode, _params->rpl->first_line.u.reply.reason.len, _params->rpl->first_line.u.reply.reason.s); }

1 0

git:master:8194032b: modules/ims_usrloc_pcscf, ims_usrloc_scscf, ims_qos: pass contact state into search requests
by jaybeepee 29 Feb '16

29 Feb '16

Module: kamailio Branch: master Commit: 8194032b0e1c954c2dd61e81528361b457344be6 URL: https://github.com/kamailio/kamailio/commit/8194032b0e1c954c2dd61e81528361b… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-29T13:59:37+02:00 modules/ims_usrloc_pcscf, ims_usrloc_scscf, ims_qos: pass contact state into search requests - more flexibility on state of contact to search for --- Modified: modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/8194032b0e1c954c2dd61e81528361b… Patch: https://github.com/kamailio/kamailio/commit/8194032b0e1c954c2dd61e81528361b…

1 0

[kamailio] Makefile System hangs the computer (#479)
by tanton81 29 Feb '16

29 Feb '16

Hello everyone, I will try to describe a problem that I encountered recently while I was recompiling Kamailio 431 Probably the problem has been already mentioned by someone at the bug tracker but I couldn't find such a topic So, I had an installed and already configured and working Kamailio I decided simply to add a new module to it, for that I made the following instructions: 'make proper' -> result OK 'make include_modules="the list of needed modules" cfg' -> slows the whole OS (Linux SLED 12), I had a constant disk activity during the time I was waiting to see how the things will finish After that I tried the same on a different machine, which is the same (virtual machine) , unfortunately the result was the same After several retries I found that it is impossible to do: make proper make include_modules="" cfg I found that I had to type a 'make cfg' after the 'make proper': make proper make cfg make include_modules="" cfg make all I hadn't the time to find out why there is a such problem but I suppose that when you do a 'make proper' your configuration file is deleted Than 'make cfg' creates this config file again and finally 'make include_modules' looks for this configuration file and fills it with the complementary modules Without this configuration file the 'make include_modules="" cfg probably enters to an infinite loop which as result makes your OS not respond Can anyone confirm the problem ? Best regards, Anton --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/479

3 9

[kamailio] Fix node selection when rtpengine_delete(), for branching scenarios (#505)
by Stefan Mititelu 26 Feb '16

26 Feb '16

Reported by @juha-h You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/505 -- Commit Summary -- * rtpengine: Fix node selection for branching cases * rtpengine: LM_NOTICE to LM_DBG -- File Changes -- M modules/rtpengine/rtpengine.c (27) M modules/rtpengine/rtpengine.h (10) M modules/rtpengine/rtpengine_hash.c (23) M modules/rtpengine/rtpengine_hash.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/505.patch https://github.com/kamailio/kamailio/pull/505.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/505

4 11

Help
by Kevin Farrell-Pelletier 26 Feb '16

26 Feb '16

Hi, I work for a VOIP service provider, and have been tasked with optimizing our infrastructure. We have been providing VOIP services to our clients via Asterisk VMs (PIAF) in an ESXi environment, hosted in a datacenter. We are looking for some kind of SIP Router, which would authenticate clients and route their SIP traffic to the appropriate server. By doing so, we are hoping to further secure our infrastructure and to possibly have only one Public IP (which would resolve to the Private IP of the SIP router). The Asterisk servers serve IVR/RINGGROUPS/OUTBOUNDTRUNKS/INBOUNDROUTES/OUTBOUNDROUTES. The Sip Router would therefore route all SIP traffic between the phones and the Asterisk servers, ad the phones would register to the SIP Router. I have tried many solutions (Kamailio, OpenSER, siproxd, Brekeke), but have not been able to configure these services to work the way we want them to. I am including a chart along with this email to outline what we would like to accomplish. Any suggestions or guides would be immensely appreciated. Thank you all for your time. Kevin Farrell Pelletier - Technicien informatique TI // Réseautique // Téléphonie IP // Programmation IT // Networking // VoIP // Application development 9060, boul Parkway, Anjou, Québec, Canada H1J1N5 Téléphone / Phone : 514.907.2000 Ext.203 F : 1.888.582.4001 - SF/TF : 1.855.907.2001 Web : <http://www.connextek.ca/> www.connextek.ca Pensez ENVIRONNEMENT, c'est important: n'imprimez que si nécessaire Consider the ENVIRONMENT before printing

1 0

git:master:1a27121e: siputils: Fixes & safety improvements for sip_p_charging_vector()
by Carsten Bock 26 Feb '16

26 Feb '16

Module: kamailio Branch: master Commit: 1a27121e139f88cf397d028a4092d570ceae2ec8 URL: https://github.com/kamailio/kamailio/commit/1a27121e139f88cf397d028a4092d57… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2016-02-26T17:54:29+01:00 siputils: Fixes & safety improvements for sip_p_charging_vector() --- Modified: modules/siputils/chargingvector.c --- Diff: https://github.com/kamailio/kamailio/commit/1a27121e139f88cf397d028a4092d57… Patch: https://github.com/kamailio/kamailio/commit/1a27121e139f88cf397d028a4092d57… --- diff --git a/modules/siputils/chargingvector.c b/modules/siputils/chargingvector.c index 5133054..b314e6c 100644 --- a/modules/siputils/chargingvector.c +++ b/modules/siputils/chargingvector.c @@ -33,7 +33,7 @@ #define P_CHARGING_VECTOR "P-Charging-Vector" #define LOOPBACK_IP 16777343 -#define PVC_BUF_SIZE 128 +#define PVC_BUF_SIZE 256 static char pcv_buf[PVC_BUF_SIZE]; static str pcv = { pcv_buf, 0 }; static str pcv_host = { NULL, 0 }; @@ -317,8 +317,6 @@ int sip_handle_pcv(struct sip_msg *msg, char *flags, char *str2) pcv.len = 0; pcv_status = PCV_NONE; - strcpy(pcv_buf, P_CHARGING_VECTOR); - strcat(pcv_buf, ": "); fixup_get_svalue(msg, (gparam_p)flags, &flag_str); @@ -366,8 +364,11 @@ int sip_handle_pcv(struct sip_msg *msg, char *flags, char *str2) */ if ( replace_pcv || (generate_pcv && pcv_status != PCV_GENERATED && pcv_status != PCV_PARSED ) ) { - char * pcv_body = pcv_buf + strlen(P_CHARGING_VECTOR) + 2; - char pcv_value[20]; + strcpy(pcv_buf, P_CHARGING_VECTOR); + strcat(pcv_buf, ": "); + + char * pcv_body = pcv_buf + 19; + char pcv_value[40]; /* We use the IP adress of the interface that received the message as generated-at */ if(msg->rcv.bind_address==NULL || msg->rcv.bind_address->address_str.s==NULL) @@ -378,17 +379,17 @@ int sip_handle_pcv(struct sip_msg *msg, char *flags, char *str2) sip_generate_charging_vector(pcv_value); - sprintf( pcv_body, "icid-value=%s; icid-generated-at=%.*s\r\n", pcv_value, + pcv.len = snprintf( pcv_body, PVC_BUF_SIZE - 19, "icid-value=%.*s; icid-generated-at=%.*s\r\n", 32, pcv_value, msg->rcv.bind_address->address_str.len, msg->rcv.bind_address->address_str.s ); + pcv.len += 19; - pcv.len = strlen(pcv_buf); pcv_status = PCV_GENERATED; /* if generated, reparse it */ - sip_parse_charging_vector( pcv_body, strlen(pcv_body) ); + sip_parse_charging_vector( pcv_body, pcv.len-19 ); /* if it was generated, we need to send it out as a header */ - LM_INFO("Generated PCV header %s.\n", pcv_buf ); + LM_INFO("Generated PCV header %.*s.\n", pcv.len, pcv_buf ); i = sip_add_charging_vector(msg); if (i <= 0) {

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2016