sr-dev April 2016

sr-dev@lists.kamailio.org

23 participants
430 discussions

git:master:21af57b5: tmx: coherent indentation and whitespacing
by Daniel-Constantin Mierla 23 Apr '16

23 Apr '16

Module: kamailio Branch: master Commit: 21af57b567533fbabd7899d83298d541197cd6b3 URL: https://github.com/kamailio/kamailio/commit/21af57b567533fbabd7899d83298d54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-23T08:21:18+02:00 tmx: coherent indentation and whitespacing --- Modified: modules/tmx/t_mi.c Modified: modules/tmx/t_mi.h Modified: modules/tmx/t_var.c Modified: modules/tmx/t_var.h Modified: modules/tmx/tmx_mod.c Modified: modules/tmx/tmx_mod.h Modified: modules/tmx/tmx_pretran.c Modified: modules/tmx/tmx_pretran.h --- Diff: https://github.com/kamailio/kamailio/commit/21af57b567533fbabd7899d83298d54… Patch: https://github.com/kamailio/kamailio/commit/21af57b567533fbabd7899d83298d54…

1 0

git:master:2089e149: rtpproxy: removed history and coherent indentation
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: 2089e149c97edead47401f4d9e1de7cbe6d2ee1d URL: https://github.com/kamailio/kamailio/commit/2089e149c97edead47401f4d9e1de7c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T23:00:25+02:00 rtpproxy: removed history and coherent indentation --- Modified: modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/2089e149c97edead47401f4d9e1de7c… Patch: https://github.com/kamailio/kamailio/commit/2089e149c97edead47401f4d9e1de7c…

1 0

git:master:11fd23b7: tmx: t_precheck_trans() exported to kemi
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: 11fd23b7712393691ef13428b9aa3426e878d754 URL: https://github.com/kamailio/kamailio/commit/11fd23b7712393691ef13428b9aa342… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T22:58:59+02:00 tmx: t_precheck_trans() exported to kemi --- Modified: modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/11fd23b7712393691ef13428b9aa342… Patch: https://github.com/kamailio/kamailio/commit/11fd23b7712393691ef13428b9aa342… --- diff --git a/modules/tmx/tmx_mod.c b/modules/tmx/tmx_mod.c index 41f9da2..e7f5d9f 100644 --- a/modules/tmx/tmx_mod.c +++ b/modules/tmx/tmx_mod.c @@ -36,6 +36,7 @@ #include "../../modules/tm/tm_load.h" #include "../../lib/kcore/kstats_wrapper.h" #include "../../dset.h" +#include "../../kemi.h" #include "t_var.h" #include "t_mi.h" @@ -723,7 +724,7 @@ static int fixup_t_continue(void** param, int param_no) /** * */ -static int w_t_precheck_trans(sip_msg_t *msg, char *p1, char *p2) +static int t_precheck_trans(sip_msg_t *msg) { int ret; @@ -736,6 +737,14 @@ static int w_t_precheck_trans(sip_msg_t *msg, char *p1, char *p2) /** * */ +static int w_t_precheck_trans(sip_msg_t *msg, char *p1, char *p2) +{ + return t_precheck_trans(msg); +} + +/** + * + */ static int tmx_cfg_callback(sip_msg_t *msg, unsigned int flags, void *cbp) { if(flags&POST_SCRIPT_CB) { @@ -855,3 +864,25 @@ unsigned long tmx_stats_rld_rcv_rpls(void) } #endif + +/** + * + */ +static sr_kemi_t sr_kemi_tmx_exports[] = { + { str_init("tmx"), str_init("t_precheck_trans"), + SR_KEMIP_INT, t_precheck_trans, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } +}; + +/** + * + */ +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_tmx_exports); + return 0; +}

1 0

git:master:ee2f24bc: nathelper: removed history comments
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: ee2f24bcae1761e8d3849db39f6e34bd20f8ef1b URL: https://github.com/kamailio/kamailio/commit/ee2f24bcae1761e8d3849db39f6e34b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T22:58:28+02:00 nathelper: removed history comments --- Modified: modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/ee2f24bcae1761e8d3849db39f6e34b… Patch: https://github.com/kamailio/kamailio/commit/ee2f24bcae1761e8d3849db39f6e34b…

1 0

Understanding the new interface (kemi) for embedded interpreters
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Hello, (cross-posting because the details are useful for both devels and users) Yesterday during the IRC meeting about Kamailio, one group of topics was about Kamailio 5.0, and the new feature of using embedded interpreters for external programming languages was highly debated. So I am trying to clarify some of its aspects. The new framework is referenced as kemi, chosen by me as an abbreviation for Kamaialio EMbedded Interface. We already had embedded interpreters for many years, respectively: - Lua via app_lua module (probably most developed and most used) - Perl via app_perl module (iirc, the oldest embedded interpreter) - Python via app_python (I discovered during the last days that it has quite a lot of features, just not documented -- never used it before) - Java via app_java (this one is a bit of a blackhole for me, never looked at it, don't know what it offers/how it is supposed to be used) - .NET group of languages via app_mono (e.g., C#, but also some variants of JavaScript, Python and maybe even Java) To clarify, an embedded interpreter means that Kamailio is linking to itself the interpreter of that language and kamailio becomes the interpreter of the language. It is not launching the standard interpreter for that language, therefore it is very fast at runtime. Moreover, kamailio is extending the language with new modules, giving access to Kamailio C functions. In other words, for example with Python, Kamailio becomes equivalent to the "python" application plus two extensions (modules) named Router (developed in the past inside app_python) and KSR (developed for kemi). At this moment, the kemi was implemented in app_lua and app_python modules. To understand what is all about, I am going to give an example with a function from maxfwd module. In default kamailio.cfg next statement is present: if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } mf_process_maxfwd_header("10") is the function exported by maxfwd: - https://www.kamailio.org/docs/modules/stable/modules/maxfwd.html#maxfwd.f.m… The parameter can be as a static number (like above) or a number provided via a variable, like next: $var(p) = 10; mf_process_maxfwd_header("$var(p)") The corresponding C code for this config function is: static int w_process_maxfwd_header(struct sip_msg* msg, char* str1, char* str2) { int mfval; if (get_int_fparam(&mfval, msg, (fparam_t*) str1) < 0) { LM_ERR("could not get param value\n"); return -1; } return process_maxfwd_header(msg, mfval); } The function get_int_fparam() is practically returning the int value of the parmeter, no matter it was a static value or a variable, then process_maxfwd_header(...) is executed with the int parameter. The msg is the SIP message structure present mostly everywhere in the C code related to the classic config interpreter. To be used inside the config file, the C function has to be exported via a cmd_export_t structure added to "struct module_exports exports", respectively: static cmd_export_t cmds[]={ ... {"mf_process_maxfwd_header", (cmd_function)w_process_maxfwd_header, 1, fixup_var_int_1, 0, REQUEST_ROUTE}, ... To get the same function in a kemi interpreter (Lua, Python at this moment), following C code was added: static sr_kemi_t sr_kemi_maxfwd_exports[] = { { str_init("maxfwd"), str_init("process_maxfwd"), SR_KEMIP_INT, process_maxfwd_header, { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_maxfwd_exports); return 0; } The structure sr_kemi_t sr_kemi_maxfwd_exports exports directly the existing function process_maxfwd_header(), which is also executed by the function from kamailio.cfg after resolving the parameter to an int value. In the case of kemi, the Lua or Python will give directly an integer value, so no need for resolving that with a fixup wrapper. The mod_register() function is something already existing, providing a way to execute code when a module was loaded (e.g., is used for many years by modules such as tls, mysql, etc.). In this case it was added, because maxfwd didn't need anything at load time before. Practically, no C code extension was written to maxfwd module from point of view of SIP routing. Just an existing function was exported. Now, what's actually the role of this kemi framework ... The app_lua already exported the kamailio.cfg function mf_process_maxfwd_header() as sr.process_maxfwd() since Kamailio v3.1, see its usage in the tutorial: - https://kb.asipto.com/kamailio:usage:k32-lua-routing#lua_script But a Lua specific wrapper had to be written: - https://github.com/kamailio/kamailio/blob/master/modules/app_lua/app_lua_ex… All the other embedded interpreters would have needed to get a wrapper as well to export this function. That's obviously costing time and maintenance resources. So kemi is a common framework to export C function to any of the embedded interpreters, meaning that once a function is exported from a module, it becomes available to all embedded interpreters, no longer being necessary to write a specif wrapper per interpreter. The app_* module needs a bit of coding to use the kemi exported functions (already done for Lua and Python), but then nothing needs to be done for new exported functions by modules. As a matter of fact, lots of functions can be just exported, as you could see in the example with maxfwd. In some cases, maybe some functions need to be split, so the fixup handling is done separately and then calls a common C function. So, what we had so far: [native kamailio cfg script] <===> [fixup framework for variables] <===> [C implementation of function] The above stays in place, no change to it. What we got extra: [embedded language script] <===> [kemi framework] <===> [C implementation of function] In addition, kemi allows to write the routing blocks all in embedded language. Core parameters, loading modules and modules' parameters stay like so far, but there is no need to write request_route{}, failure_route, etc.. blocks. Some functions with a specific names have to be written in the embedded language script, see more at: - https://www.kamailio.org/wiki/devel/config-engines In several days I expect to be possible to have routing blocks of kamailio-basic.cfg written via kemi interpreters. That will allow testing the performance impact. Right now Lua and Python use different mechanism of exporting Kamailio C functions, the one from Python should be faster, but relies on defining some C wrappers inside the module. Anyhow Lua might be faster as interpreter itself -- and at the end it can just get the same mechanism as Python. app_lua already supports reloading the routing script without restarting kamailio, one of the features asked from time to time. Besides that, of course, a big benefit is the access to a very large set of extensions already available as Lua/Python libraries. Also important, many peoples are already familiar with these languages and there is plenty of good documentation about those languages. The classic/native kamailio.cfg format (and the interpreter for it) stays there -- same common C functions are shared with kemi, so any addition in the future will be visible to everywhere. The native interpreter will remain the option for extreme optimizations for those that deal with enormous amount of SIP traffic (e.g., heavy load balancers), but I expect that at least Lua will be in pair of performances with a registrar deployment. I hope I could shed some light on various aspects of the new framework for embedded interpreters. Expect very soon news about ability to build full routing logic in Lua/Python, hopefully many of you will join to test the results and compare with native alternatives. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, Berlin, May 18-20, 2016 - http://www.kamailioworld.com

1 0

Is it possible to send SIP message from within the custom module?
by Cockhootec Yahrabee 22 Apr '16

22 Apr '16

I have found out that the UAC module can be used to send SIP messages from within the kamailio config file. http://www.kamailio.org/docs/modules/4.3.x/modules/uac.html#uac.f.uac_req_s… I am wondering if it is possible to use these functions from within my custom module which I am developing? I am not sure how can I create pseudo variables within the module. Thanks a lot for any help.

1 1

irc devel meeting summary
by Fred Posner 22 Apr '16

22 Apr '16

Greetings, Minutes from the recent devel meeting have been posted to the wiki: https://www.kamailio.org/wiki/devel/irc-meetings/2016a-minutes In summary, this was a 3+ hour meeting held on IRC #kamailio -- one of the longer meetings on record. No current "critical" issues were open, and the meeting moved to a discussion of for a testing framework and being able to load as many modules as possible in a running Kamailio system. Olle Johansson suggested a competition for Kamailio World: "The one with a kamailio with most loaded modules running at kamailio-world gets a beer." A discussion then occurred regarding the appropriateness of returning a 200 OK when no data exists during a xmlrpc request. The consensus seemed to side with how we currently return data with the suggestion of moving further discussion to the mailing list. The Kamailio team will be looking to both upgrading the Kamailio servers to Debian Jessie as well as utilizing a "responsive" template for the main website; making the site more mobile/user friendly. Kamailio 5 was discussed with a suggestion for a developers meeting in Stockholm, perhaps in June, to hammer out the framework. Daniel was thanked for moving forward with the Lua routing aspects of Kamailio 5 while ensuring that you will still be able to utilize the config file (as current) without Lua. Additional languages, such as python, will be coming. Daniel will be working on a tutorial for exporting the kamailio.cfg to an embedded interpreter in the future. As part of Kamailio 5, the source tree structure will be improved, most likely utilizing subdirectories to better organize the different elements of the software. There will also be a change in the method of checking the database schema for compatibility with the version of software running. This summary represents just an appetizer of the incredible meeting that took place. The minutes are available for you to read at your leisure and your participation is always encouraged through the mailing lists, IRC, as well as github. The meeting never ends... it just continues on the mailing lists. =) Best regards, Fred Posner http://www.palner.com

2 1

git:master:42b7878e: maxfwd: exported process_maxfwd() to kemi api
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: 42b7878ef9975413249d746be00ccda191e523ba URL: https://github.com/kamailio/kamailio/commit/42b7878ef9975413249d746be00ccda… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T13:49:03+02:00 maxfwd: exported process_maxfwd() to kemi api --- Modified: modules/maxfwd/maxfwd.c --- Diff: https://github.com/kamailio/kamailio/commit/42b7878ef9975413249d746be00ccda… Patch: https://github.com/kamailio/kamailio/commit/42b7878ef9975413249d746be00ccda… --- diff --git a/modules/maxfwd/maxfwd.c b/modules/maxfwd/maxfwd.c index eb7764c..3d61636 100644 --- a/modules/maxfwd/maxfwd.c +++ b/modules/maxfwd/maxfwd.c @@ -30,6 +30,7 @@ #include "../../dprint.h" #include "../../error.h" #include "../../ut.h" +#include "../../kemi.h" #include "../../mem/mem.h" #include "../../cfg/cfg.h" #include "mf_funcs.h" @@ -218,3 +219,25 @@ int bind_maxfwd(maxfwd_api_t *api) return 0; } + +/** + * + */ +static sr_kemi_t sr_kemi_maxfwd_exports[] = { + { str_init("maxfwd"), str_init("process_maxfwd"), + SR_KEMIP_INT, process_maxfwd_header, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } +}; + +/** + * + */ +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_maxfwd_exports); + return 0; +}

1 0

git:master:4914dda4: maxfwd: removed the history and fixed indentation
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: 4914dda4515096599734fed309d416b4da1e4b9a URL: https://github.com/kamailio/kamailio/commit/4914dda4515096599734fed309d416b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T13:45:55+02:00 maxfwd: removed the history and fixed indentation --- Modified: modules/maxfwd/api.h Modified: modules/maxfwd/maxfwd.c Modified: modules/maxfwd/mf_funcs.c Modified: modules/maxfwd/mf_funcs.h --- Diff: https://github.com/kamailio/kamailio/commit/4914dda4515096599734fed309d416b… Patch: https://github.com/kamailio/kamailio/commit/4914dda4515096599734fed309d416b…

1 0

git:master:e244c95c: auth_db: exported functions to kemi
by Daniel-Constantin Mierla 22 Apr '16

22 Apr '16

Module: kamailio Branch: master Commit: e244c95ca7bf52d2187af0b44c9b2a2fe614ebd6 URL: https://github.com/kamailio/kamailio/commit/e244c95ca7bf52d2187af0b44c9b2a2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-22T09:28:42+02:00 auth_db: exported functions to kemi - is_subscriber(...) - auth_check(...) --- Modified: modules/auth_db/auth_db_mod.c Modified: modules/auth_db/authorize.c Modified: modules/auth_db/authorize.h --- Diff: https://github.com/kamailio/kamailio/commit/e244c95ca7bf52d2187af0b44c9b2a2… Patch: https://github.com/kamailio/kamailio/commit/e244c95ca7bf52d2187af0b44c9b2a2…

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
43
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2016