sr-dev April 2016

sr-dev@lists.kamailio.org

23 participants
430 discussions

Kamailio Updates on VUC 588 - this week on Friday
by Daniel-Constantin Mierla 08 Apr '16

08 Apr '16

Hello, The weekly VoIP Users Conference (VUC) #588 moderated by Randy Resnick will host a session for Kamailio Updates. Everyone from community is invited to join and actively participate to discussions. There are many ways to connect, from SIP to classic PSTN dial in as well as listening or watching live streams on the web. The live session will start on Friday, April 8, at 18:00 Berlin timezone (17:00 London, 12:00EDT). More details about the session are available at: - https://www.kamailio.org/w/2016/04/vuc-588-kamailio-updates/ Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, Berlin, May 18-20, 2016 - http://www.kamailioworld.com

1 2

git:master:9bf13e03: htable Minor typo fixup
by Olle E. Johansson 08 Apr '16

08 Apr '16

Module: kamailio Branch: master Commit: 9bf13e03ee128bf436f75793b2bd6f0d087d50e2 URL: https://github.com/kamailio/kamailio/commit/9bf13e03ee128bf436f75793b2bd6f0… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-04-08T15:20:28+02:00 htable Minor typo fixup --- Modified: modules/htable/README Modified: modules/htable/doc/htable_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9bf13e03ee128bf436f75793b2bd6f0… Patch: https://github.com/kamailio/kamailio/commit/9bf13e03ee128bf436f75793b2bd6f0…

1 0

git:4.4:b21b9cd9: Makefile.defs: re-enable mem join define
by Daniel-Constantin Mierla 08 Apr '16

08 Apr '16

Module: kamailio Branch: 4.4 Commit: b21b9cd9cb6a08b9bfc9d025b4e6a64a12e50d65 URL: https://github.com/kamailio/kamailio/commit/b21b9cd9cb6a08b9bfc9d025b4e6a64… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-08T15:12:12+02:00 Makefile.defs: re-enable mem join define - lost when introduced the option to select the memory manager by command line parameter -x (cherry picked from commit 33c6aafcd46269ce283908f49fbf70b9d73624b1) --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/b21b9cd9cb6a08b9bfc9d025b4e6a64… Patch: https://github.com/kamailio/kamailio/commit/b21b9cd9cb6a08b9bfc9d025b4e6a64… --- diff --git a/Makefile.defs b/Makefile.defs index 26205e8..245f9b4 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -664,6 +664,7 @@ C_DEFS= $(extra_defs) \ # debugging symbols in all cases (-g). --andrei # memory managers and related debug mode +C_DEFS+= -DMEM_JOIN_FREE # enable f_malloc C_DEFS+= -DF_MALLOC # enable q_malloc

1 0

git:master:33c6aafc: Makefile.defs: re-enable mem join define
by Daniel-Constantin Mierla 08 Apr '16

08 Apr '16

Module: kamailio Branch: master Commit: 33c6aafcd46269ce283908f49fbf70b9d73624b1 URL: https://github.com/kamailio/kamailio/commit/33c6aafcd46269ce283908f49fbf70b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-08T15:11:45+02:00 Makefile.defs: re-enable mem join define - lost when introduced the option to select the memory manager by command line parameter -x --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/33c6aafcd46269ce283908f49fbf70b… Patch: https://github.com/kamailio/kamailio/commit/33c6aafcd46269ce283908f49fbf70b… --- diff --git a/Makefile.defs b/Makefile.defs index 3f3d830..7afc889 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -664,6 +664,7 @@ C_DEFS= $(extra_defs) \ # debugging symbols in all cases (-g). --andrei # memory managers and related debug mode +C_DEFS+= -DMEM_JOIN_FREE # enable f_malloc C_DEFS+= -DF_MALLOC # enable q_malloc

1 0

git:master:c5aa351c: rtpengine: Update doku for 'unidirectional' flag
by Stefan Mititelu 08 Apr '16

08 Apr '16

Module: kamailio Branch: master Commit: c5aa351c7082b7a8e5358bbb4f56cb00c9b4762d URL: https://github.com/kamailio/kamailio/commit/c5aa351c7082b7a8e5358bbb4f56cb0… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-04-08T13:48:17+03:00 rtpengine: Update doku for 'unidirectional' flag Added new 'unidirectional' flag in Sipwise rtpengine. --- Modified: modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c5aa351c7082b7a8e5358bbb4f56cb0… Patch: https://github.com/kamailio/kamailio/commit/c5aa351c7082b7a8e5358bbb4f56cb0… --- diff --git a/modules/rtpengine/doc/rtpengine_admin.xml b/modules/rtpengine/doc/rtpengine_admin.xml index 9f6e8c8..515e5ae 100644 --- a/modules/rtpengine/doc/rtpengine_admin.xml +++ b/modules/rtpengine/doc/rtpengine_admin.xml @@ -958,6 +958,11 @@ rtpengine_offer(); SDES-authenticated_srtp</emphasis> - the opposites of the flags above. Useful if accepting these parameters is not desired and they should be rejected instead. </para></listitem> + <listitem><para> + <emphasis>unidirectional</emphasis> - allows kernelization of one-way streams + in the Sipwise rtpengine proxy. This is especially useful when the first call leg is handled + by some rtpengine machine while the second call leg is handled by other rtpengine machine. + </para></listitem> </itemizedlist> </listitem> </itemizedlist>

1 0

Parse value from SIP message within custom module without affecting the SIP message
by Cockhootec Yahrabee 08 Apr '16

08 Apr '16

Hi guys! I am trying to parse Call-ID from received message within my custom kamailio module but every time I parse it and persist it within shared memory of my module the kamailio sends back (to UA) SIP message with `{Call-ID-hex-stream}0d` instead of `{Call-ID-hex-stream}00` So it seems that kamailio adds `CR` byte to Call-ID which I am parsing. This is how I am parsing and persisting the Call-ID (in my opinion it's without affecting the original message but yet it seems that I am wrong): First of all I parse Call-ID so I have `str` structure where the `call_id_str.s` is pointing to the begining of Call-ID within `sip_msg_t` structure and `call_id_str.len` has the length of that Call-ID. Secondly I am trying to copy the string from received SIP message into my own structure (I mean copy not just point to it since I need it also when the message is gone). I've prepared this function: int shm_copy_string(const char *original_string, int original_length, char **new_string) { // allocate shared memory for new string *new_string = (char *) shm_malloc(sizeof(char) * (original_length + 1)); if (*new_string == NULL) { ERR("cannot allocate shm memory"); return -1; } // copy original string to new string memcpy(new_string, &original_string, original_length); // end new string with null character (*new_string)[original_length] = '\0'; return 0; } I am calling this function within my module like this: shm_copy_string(call_id_str.s, call_id_str.len, &call_id); I don't manipulate with the pointer to original message in any way but still the message which kamailio sends back to my UA has that `CR` and it causes me big problems since UA cannot match the Call-ID. Also weird is that when I skip copying of the Call-ID on Registration message it is not affected so UA can register but then when I am trying to call from UA to UA I am getting as a response for my INVITE the `407 Proxy Authentication Required` with malformed Call-ID. Messages where I don't parse Call-ID are OK so the problem must be in this function. Has anyone came across this issue? How-come response SIP message is affected when I didn't add anything to the message? Thanks in advance for any help

1 1

git:master:c395ae00: core: common check for ifa->ifa_addr in add_intefaces
by Daniel-Constantin Mierla 07 Apr '16

07 Apr '16

Module: kamailio Branch: master Commit: c395ae00d7970be0a857265e9324a50bcb00f4d0 URL: https://github.com/kamailio/kamailio/commit/c395ae00d7970be0a857265e9324a50… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-06T19:22:58+02:00 core: common check for ifa->ifa_addr in add_intefaces - if no ip address associated with the network interface, it is not useful anyhow --- Modified: socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/c395ae00d7970be0a857265e9324a50… Patch: https://github.com/kamailio/kamailio/commit/c395ae00d7970be0a857265e9324a50… --- diff --git a/socket_info.c b/socket_info.c index 95c6ee6..aa8928a 100644 --- a/socket_info.c +++ b/socket_info.c @@ -1205,9 +1205,12 @@ int add_interfaces(char* if_name, int family, unsigned short port, for (ifa = ifap; ifa; ifa = ifa->ifa_next) { + /* skip if no IP addr associated with the interface */ + if (ifa->ifa_addr==0) + continue; #ifdef AF_PACKET /* skip AF_PACKET addr family since it is of no use later on */ - if (ifa->ifa_addr && ifa->ifa_addr->sa_family == AF_PACKET) + if (ifa->ifa_addr->sa_family == AF_PACKET) continue; #endif if (if_name && strcmp(if_name, ifa->ifa_name))

2 2

git:4.4:49ec5fa5: core: common check for ifa->ifa_addr in add_intefaces
by Daniel-Constantin Mierla 07 Apr '16

07 Apr '16

Module: kamailio Branch: 4.4 Commit: 49ec5fa5d9bb939b80ef3994b5f0c04e7525ab9f URL: https://github.com/kamailio/kamailio/commit/49ec5fa5d9bb939b80ef3994b5f0c04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-07T09:59:17+02:00 core: common check for ifa->ifa_addr in add_intefaces - if no ip address associated with the network interface, it is not useful anyhow (cherry picked from commit c395ae00d7970be0a857265e9324a50bcb00f4d0) --- Modified: socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/49ec5fa5d9bb939b80ef3994b5f0c04… Patch: https://github.com/kamailio/kamailio/commit/49ec5fa5d9bb939b80ef3994b5f0c04… --- diff --git a/socket_info.c b/socket_info.c index 95c6ee6..aa8928a 100644 --- a/socket_info.c +++ b/socket_info.c @@ -1205,9 +1205,12 @@ int add_interfaces(char* if_name, int family, unsigned short port, for (ifa = ifap; ifa; ifa = ifa->ifa_next) { + /* skip if no IP addr associated with the interface */ + if (ifa->ifa_addr==0) + continue; #ifdef AF_PACKET /* skip AF_PACKET addr family since it is of no use later on */ - if (ifa->ifa_addr && ifa->ifa_addr->sa_family == AF_PACKET) + if (ifa->ifa_addr->sa_family == AF_PACKET) continue; #endif if (if_name && strcmp(if_name, ifa->ifa_name))

1 0

git:4.4:6684be6b: core: check if ifa_addr field is set while trying to skip AF_PACKET interfaces
by Daniel-Constantin Mierla 07 Apr '16

07 Apr '16

Module: kamailio Branch: 4.4 Commit: 6684be6b4c405ab24dd6a5a19267ceef6aa95503 URL: https://github.com/kamailio/kamailio/commit/6684be6b4c405ab24dd6a5a19267cee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-07T09:59:04+02:00 core: check if ifa_addr field is set while trying to skip AF_PACKET interfaces - reported by Juha Heinanen (cherry picked from commit 1545b8de396e8e5d0ef24c9102beff18b3cf36e5) --- Modified: socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/6684be6b4c405ab24dd6a5a19267cee… Patch: https://github.com/kamailio/kamailio/commit/6684be6b4c405ab24dd6a5a19267cee… --- diff --git a/socket_info.c b/socket_info.c index cecfef9..95c6ee6 100644 --- a/socket_info.c +++ b/socket_info.c @@ -1207,7 +1207,7 @@ int add_interfaces(char* if_name, int family, unsigned short port, { #ifdef AF_PACKET /* skip AF_PACKET addr family since it is of no use later on */ - if (ifa->ifa_addr->sa_family == AF_PACKET) + if (ifa->ifa_addr && ifa->ifa_addr->sa_family == AF_PACKET) continue; #endif if (if_name && strcmp(if_name, ifa->ifa_name))

1 0

git:master:b36f7c9a: core: new global parameter log_prefix_mode
by Daniel-Constantin Mierla 07 Apr '16

07 Apr '16

Module: kamailio Branch: master Commit: b36f7c9aed3f5cebc457b26f40ca472665da4d00 URL: https://github.com/kamailio/kamailio/commit/b36f7c9aed3f5cebc457b26f40ca472… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-04-07T09:39:44+02:00 core: new global parameter log_prefix_mode - if set to 0 (default), then log_prefix is evaluated when the sip message is received and then reused (recommended if the log_prefix has only variables that have same value for same message). This is the current behaviour of log_prefix evaluation. - if set to 1, then the log prefix is evaluated before/after each config action (needs to be set when the log_prefix has variables that are different based on the context of config execution, e.g., $cfg(line)) --- Modified: action.c Modified: cfg.lex Modified: cfg.y Modified: dprint.c Modified: dprint.h --- Diff: https://github.com/kamailio/kamailio/commit/b36f7c9aed3f5cebc457b26f40ca472… Patch: https://github.com/kamailio/kamailio/commit/b36f7c9aed3f5cebc457b26f40ca472… --- diff --git a/action.c b/action.c index bef3ec6..9e9db97 100644 --- a/action.c +++ b/action.c @@ -1546,8 +1546,14 @@ int run_actions(struct run_act_ctx* h, struct action* a, struct sip_msg* msg) if(unlikely(cfg_get(core, core_cfg, latency_limit_action)>0)) ms = TICKS_TO_MS(get_ticks_raw()); _cfg_crt_action = t; + if(unlikely(log_prefix_mode==1)) { + log_prefix_set(msg); + } ret=do_action(h, t, msg); _cfg_crt_action = 0; + if(unlikely(log_prefix_mode==1)) { + log_prefix_set(msg); + } if(unlikely(cfg_get(core, core_cfg, latency_limit_action)>0)) { ms = TICKS_TO_MS(get_ticks_raw()) - ms; if(ms >= cfg_get(core, core_cfg, latency_limit_action)) { diff --git a/cfg.lex b/cfg.lex index 5aeadf0..1544e6e 100644 --- a/cfg.lex +++ b/cfg.lex @@ -290,6 +290,7 @@ LOGFACILITY log_facility LOGNAME log_name LOGCOLOR log_color LOGPREFIX log_prefix +LOGPREFIXMODE log_prefix_mode LOGENGINETYPE log_engine_type LOGENGINEDATA log_engine_data LISTEN listen @@ -673,6 +674,7 @@ IMPORTFILE "import_file" <INITIAL>{LOGNAME} { yylval.strval=yytext; return LOGNAME; } <INITIAL>{LOGCOLOR} { yylval.strval=yytext; return LOGCOLOR; } <INITIAL>{LOGPREFIX} { yylval.strval=yytext; return LOGPREFIX; } +<INITIAL>{LOGPREFIXMODE} { yylval.strval=yytext; return LOGPREFIXMODE; } <INITIAL>{LOGENGINETYPE} { yylval.strval=yytext; return LOGENGINETYPE; } <INITIAL>{LOGENGINEDATA} { yylval.strval=yytext; return LOGENGINEDATA; } <INITIAL>{LISTEN} { count(); yylval.strval=yytext; return LISTEN; } diff --git a/cfg.y b/cfg.y index aa9b0ca..24b2240 100644 --- a/cfg.y +++ b/cfg.y @@ -320,6 +320,7 @@ extern char *default_routename; %token LOGNAME %token LOGCOLOR %token LOGPREFIX +%token LOGPREFIXMODE %token LOGENGINETYPE %token LOGENGINEDATA %token LISTEN @@ -777,6 +778,8 @@ assign_stm: | LOGCOLOR EQUAL error { yyerror("boolean value expected"); } | LOGPREFIX EQUAL STRING { log_prefix_fmt=$3; } | LOGPREFIX EQUAL error { yyerror("string value expected"); } + | LOGPREFIXMODE EQUAL NUMBER { log_prefix_mode=$3; } + | LOGPREFIXMODE EQUAL error { yyerror("number expected"); } | LOGENGINETYPE EQUAL STRING { _km_log_engine_type=$3; } | LOGENGINETYPE EQUAL error { yyerror("string value expected"); } | LOGENGINEDATA EQUAL STRING { _km_log_engine_data=$3; } diff --git a/dprint.c b/dprint.c index 269dd83..46d69a1 100644 --- a/dprint.c +++ b/dprint.c @@ -432,6 +432,7 @@ void dprint_color_update(int level, char f, char b) /* log_prefix functionality */ str *log_prefix_val = NULL; +int log_prefix_mode = 0; static pv_elem_t *log_prefix_pvs = NULL; #define LOG_PREFIX_SIZE 1024 diff --git a/dprint.h b/dprint.h index 5f03445..69d2622 100644 --- a/dprint.h +++ b/dprint.h @@ -123,6 +123,7 @@ extern int log_stderr; extern int log_color; extern char *log_prefix_fmt; extern str *log_prefix_val; +extern int log_prefix_mode; extern char *_km_log_engine_type; extern char *_km_log_engine_data;

1 0

← Newer
1
...
30
31
32
33
34
35
36
...
43
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2016