sr-dev May 2016

sr-dev@lists.kamailio.org

28 participants
348 discussions

modules linked to db_flatstore cause core on db_check_table_version function call
by Eduardo Lejarreta 25 May '16

25 May '16

Good evening. INTRODUCTION: ------------- We've traced an error, in our case, db_flatstore and siptrace combination causes crash core. siptrace module tries to check siptrace table version on a DB which has no query capabilities and that causes the crash core. This happens from kamailio-4.3.0 where db_check_table_version function call is introduced on siptrace module. OUR CONFIGURATION: ------------------ kamailio.cfg -> ... #!define FLAT_DBURL "flatstore:/expert/siptrace-logs" loadmodule "db_flatstore.so" loadmodule "siptrace.so" modparam("siptrace", "db_url", FLAT_DBURL) modparam("siptrace", "trace_flag", 0) modparam("siptrace", "trace_on", 1) modparam("siptrace", "traced_user_avp", "$avp(s:user)") ... ERROR FLOW: ----------- siptrace.c -> if (db_check_table_version(&db_funcs, db_con, &siptrace_table, SIP_TRACE_TABLE_VERSION) < 0) db.c -> db_check_table_version -> db_table_version(dbf, dbh, table); -> dbf->query(connection, key, 0, val, col, 1, 1, 0, &res) From this last funtion call each thread never returns and remains blocked, and finally crashes with a nice core (it fullfills the entire disk) OUR SUGGESTION: ------------------ We can recommend developers not to call db_check_table_version if a prior query of capabilities doesn't return: DB_CAP_QUERY. We can do it for them on db_check_table_version function. Thanks and best regards Eduardo Lejarreta. -- Dpto. Sistemas SARENET Parque Tecnológico de Zamudio. Edif. 103 48170 Vizcaya Spain. www.sarenet.es Personal contact: IT Manager & VoIP Engineer. www.seeyouonnet.com

1 0

[kamailio/kamailio] ims_registar_scscf: Fix subscr data handling in SAA (#630)
by Tsvetomir Dimitrov 24 May '16

24 May '16

During re-registration, Diameter SAR message is sent to the HSS. It contains User-Data-Already-Available AVP, which by specification (TS 29.228, Table 6.1.2.1) instructs the HSS not to send subscription data. However when SAA is received without User-Data an error is generated. I think this behavior is not correct. This patch modifies SAA handling so it doesn't try to update local ims subscription information, for the case where there is none received from the HSS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/630 -- Commit Summary -- * ims_registar_scscf: Fix subscr data handling in SAA -- File Changes -- M modules/ims_registrar_scscf/cxdx_sar.c (23) -- Patch Links -- https://github.com/kamailio/kamailio/pull/630.patch https://github.com/kamailio/kamailio/pull/630.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/630

4 5

git:master:b0047530: snmpstats Improve README formatting of list of items in MIB
by Olle E. Johansson 24 May '16

24 May '16

Module: kamailio Branch: master Commit: b0047530b004c1a433477c16883952442511d6ff URL: https://github.com/kamailio/kamailio/commit/b0047530b004c1a433477c168839524… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-05-24T15:51:08+02:00 snmpstats Improve README formatting of list of items in MIB --- Modified: modules/snmpstats/README Modified: modules/snmpstats/doc/snmpstats_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b0047530b004c1a433477c168839524… Patch: https://github.com/kamailio/kamailio/commit/b0047530b004c1a433477c168839524…

1 0

git:master:0a149060: snmpstats Add improved explanation of memory usage
by Olle E. Johansson 24 May '16

24 May '16

Module: kamailio Branch: master Commit: 0a149060aa4a1dfce119a4907a4bb2b334079127 URL: https://github.com/kamailio/kamailio/commit/0a149060aa4a1dfce119a4907a4bb2b… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-05-24T15:18:24+02:00 snmpstats Add improved explanation of memory usage Issue #636 --- Modified: modules/snmpstats/README Modified: modules/snmpstats/doc/snmpstats_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0a149060aa4a1dfce119a4907a4bb2b… Patch: https://github.com/kamailio/kamailio/commit/0a149060aa4a1dfce119a4907a4bb2b… --- diff --git a/modules/snmpstats/README b/modules/snmpstats/README index 12d2c31..dbc1e43 100644 --- a/modules/snmpstats/README +++ b/modules/snmpstats/README @@ -417,6 +417,12 @@ modparam("snmpstats", "snmpCommunity", "customCommunityString") parameter is set to 1. This will result in more memory usage and bigger exporter structure. + If you enable this setting and NOT use it (i.e. not check the SNMP + tables for registrations) an internal memory queue of usrloc changes + will keep growing in shared (core) memory. To release the queue memory, + run snmpwalk or use a monitoring tool to check the tables with regular + intervals. + Default value is "0" (don't export). Example 1.8. Setting the export_registrar parameter diff --git a/modules/snmpstats/doc/snmpstats_admin.xml b/modules/snmpstats/doc/snmpstats_admin.xml index 71a7b61..6789a37 100644 --- a/modules/snmpstats/doc/snmpstats_admin.xml +++ b/modules/snmpstats/doc/snmpstats_admin.xml @@ -440,6 +440,13 @@ modparam("snmpstats", "snmpCommunity", "customCommunityString") this parameter is set to 1. This will result in more memory usage and bigger exporter structure. </para> + <para> + If you enable this setting and NOT use it (i.e. not check the SNMP tables + for registrations) an internal memory queue of usrloc changes will + keep growing in shared (core) memory. To release the queue memory, + run snmpwalk or use a monitoring tool to check the tables with + regular intervals. + </para> <para> <emphasis>

1 0

git:master:aa73c87a: snmpstats Improve formatting, add comments on InterProcessBuffer growing forever
by Olle E. Johansson 24 May '16

24 May '16

Module: kamailio Branch: master Commit: aa73c87a68bc2e916a045f7af65d1ab873fdced6 URL: https://github.com/kamailio/kamailio/commit/aa73c87a68bc2e916a045f7af65d1ab… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-05-24T15:18:24+02:00 snmpstats Improve formatting, add comments on InterProcessBuffer growing forever --- Modified: modules/snmpstats/interprocess_buffer.c Modified: modules/snmpstats/snmpObjects.c Modified: modules/snmpstats/snmpSIPContactTable.c --- Diff: https://github.com/kamailio/kamailio/commit/aa73c87a68bc2e916a045f7af65d1ab… Patch: https://github.com/kamailio/kamailio/commit/aa73c87a68bc2e916a045f7af65d1ab…

1 0

[kamailio/kamailio] Suspected design flaw in SNMPstats - shm memory slowly being allocated (#635)
by Olle E. Johansson 24 May '16

24 May '16

SNMPstats has a queued buffer that contains registration changes based on callbacks from usrloc. If one loads SNMPstats this queue grows forever and is only emptied when someone actually calls exactly the right parts of the MIB. At that time the queue is processed and an internal copy of the location table is produced and published. If one uses other parts of the MIB the queue keeps growing. This can be turned off by disabling the modparam "Export_registrar". Proposed changes: - Improve the README - Check if the processing of the queue can happen on timer instead of waiting for accidental checks. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/635

1 2

git:master:8e0ae1f8: uac: reset UAC_REG_DISABLED flag (if need) after refresh
by Dmitri Savolainen 24 May '16

24 May '16

Module: kamailio Branch: master Commit: 8e0ae1f825c080a050c7e755eea67d2c56d6841f URL: https://github.com/kamailio/kamailio/commit/8e0ae1f825c080a050c7e755eea67d2… Author: Dmitri Savolainen <savolainen(a)erinaco.ru> Committer: Dmitri Savolainen <savolainen(a)erinaco.ru> Date: 2016-05-24T12:51:06+03:00 uac: reset UAC_REG_DISABLED flag (if need) after refresh --- Modified: modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/8e0ae1f825c080a050c7e755eea67d2… Patch: https://github.com/kamailio/kamailio/commit/8e0ae1f825c080a050c7e755eea67d2… --- diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c index c1236ae..86b17e9 100644 --- a/modules/uac/uac_reg.c +++ b/modules/uac/uac_reg.c @@ -607,7 +607,10 @@ int reg_ht_update_attrs(reg_uac_t *reg) strncpy(ri->r->auth_proxy.s, reg->auth_proxy.s, reg->auth_proxy.len); ri->r->auth_proxy.len = reg->auth_proxy.len; ri->r->auth_proxy.s[reg->auth_proxy.len] = '\0'; - if(reg->flags & UAC_REG_DISABLED) ri->r->flags |= UAC_REG_DISABLED; + if(reg->flags & UAC_REG_DISABLED) + ri->r->flags |= UAC_REG_DISABLED; + else + ri->r->flags &= ~UAC_REG_DISABLED; lock_release(&_reg_htable->entries[slot].lock); return 0; }

1 0

git:master:bd09692f: Merge pull request #634 from snen/uac_flag_update_fix
by Daniel-Constantin Mierla 24 May '16

24 May '16

Module: kamailio Branch: master Commit: bd09692fbd7390a1f58deef4c410124e2b91f4bc URL: https://github.com/kamailio/kamailio/commit/bd09692fbd7390a1f58deef4c410124… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-24T13:50:59+02:00 Merge pull request #634 from snen/uac_flag_update_fix uac: reset UAC_REG_DISABLED flag (if need) after refresh --- Modified: modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/bd09692fbd7390a1f58deef4c410124… Patch: https://github.com/kamailio/kamailio/commit/bd09692fbd7390a1f58deef4c410124… --- diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c index c1236ae..86b17e9 100644 --- a/modules/uac/uac_reg.c +++ b/modules/uac/uac_reg.c @@ -607,7 +607,10 @@ int reg_ht_update_attrs(reg_uac_t *reg) strncpy(ri->r->auth_proxy.s, reg->auth_proxy.s, reg->auth_proxy.len); ri->r->auth_proxy.len = reg->auth_proxy.len; ri->r->auth_proxy.s[reg->auth_proxy.len] = '\0'; - if(reg->flags & UAC_REG_DISABLED) ri->r->flags |= UAC_REG_DISABLED; + if(reg->flags & UAC_REG_DISABLED) + ri->r->flags |= UAC_REG_DISABLED; + else + ri->r->flags &= ~UAC_REG_DISABLED; lock_release(&_reg_htable->entries[slot].lock); return 0; }

1 0

[kamailio/kamailio] uac: reset UAC_REG_DISABLED flag (if need) after refresh (#634)
by Dmitri Savolainen 24 May '16

24 May '16

i have noticed, it is possible set UAC_REG_DISABLED flag by uac.reg_refresh, but unpossible to reset it You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/634 -- Commit Summary -- * uac: reset UAC_REG_DISABLED flag (if need) after refresh -- File Changes -- M modules/uac/uac_reg.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/634.patch https://github.com/kamailio/kamailio/pull/634.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/634

2 2

git:4.4:d6710fda: kex Fix spelling error and add "core" as an example of a module name
by Olle E. Johansson 24 May '16

24 May '16

Module: kamailio Branch: 4.4 Commit: d6710fdaf1ea8705655025e231d27828ac89da82 URL: https://github.com/kamailio/kamailio/commit/d6710fdaf1ea8705655025e231d2782… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-05-24T10:43:39+02:00 kex Fix spelling error and add "core" as an example of a module name (cherry picked from commit b5ef63f447e82caf95aa7f03d3c3c0e0e5de5503) --- Modified: modules/kex/README Modified: modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d6710fdaf1ea8705655025e231d2782… Patch: https://github.com/kamailio/kamailio/commit/d6710fdaf1ea8705655025e231d2782…

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2016