sr-dev June 2016

sr-dev@lists.kamailio.org

37 participants
345 discussions

git:master:6774d7ab: test Adding documentation on module test

by Olle E. Johansson

Module: kamailio Branch: master Commit: 6774d7abf93bf8631c5bb498dc5158b9fbff247d URL: https://github.com/kamailio/kamailio/commit/6774d7abf93bf8631c5bb498dc5158b… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-06-03T21:27:26+02:00 test Adding documentation on module test At this point this is just ideas and a proposal. Let's test it. Includes ideas on variant of the abort() function in cfg_utils --- Added: test/README.md --- Diff: https://github.com/kamailio/kamailio/commit/6774d7abf93bf8631c5bb498dc5158b… Patch: https://github.com/kamailio/kamailio/commit/6774d7abf93bf8631c5bb498dc5158b… --- diff --git a/test/README.md b/test/README.md new file mode 100644 index 0000000..0547475 --- /dev/null +++ b/test/README.md @@ -0,0 +1,26 @@ +Test directory +=============== + +Modules +------- +Note: Under development (2016-06-03 OEJ) + +Modules found here test APIs in other modules or are just created for testing, not for production +use. In order to use the existing build system, each module needs a directory named mod_something +in test. + +Each module needs a subdirectory called "test" with a test configuration and a Makefile. + +A typical test script load the htable module and execute tests in the [event:htable_init] +event route when starting. Typically, if a test fails, it runs abort() from the cfg_utils +module to abort the process. + + +Ideas: We may need a way to exit kamailio from inside without dumping a core file, but simply +stopping execution and returning different return values to the shell. That way a test +config can run for a limited amount of time or until a test fails. We can also +stop on an external action, like a RPC request calling the same function. + +Targets: + - "test": Test syntax with "kamailio -c" + - "all": Run full test

8 years, 2 months

git:master:741dd5fc: Adding test modules for http_client API

by Olle E. Johansson

Module: kamailio Branch: master Commit: 741dd5fcfdae254404440253eb1687c3ab303707 URL: https://github.com/kamailio/kamailio/commit/741dd5fcfdae254404440253eb1687c… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-06-03T21:18:35+02:00 Adding test modules for http_client API --- Added: test/mod_httpapitest/Makefile Added: test/mod_httpapitest/httpapitest.c --- Diff: https://github.com/kamailio/kamailio/commit/741dd5fcfdae254404440253eb1687c… Patch: https://github.com/kamailio/kamailio/commit/741dd5fcfdae254404440253eb1687c…

8 years, 2 months

git:master:3d5111e3: modules_ims: fix to ensure active media session stats are correctly decremented

by Richard Good

Module: kamailio Branch: master Commit: 3d5111e38fa76fd13b0373ad6885769248e58e75 URL: https://github.com/kamailio/kamailio/commit/3d5111e38fa76fd13b0373ad6885769… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: 2016-06-03T15:46:54+02:00 modules_ims: fix to ensure active media session stats are correctly decremented --- Modified: modules/ims_qos/rx_aar.c Modified: modules/ims_qos/rx_authdata.c --- Diff: https://github.com/kamailio/kamailio/commit/3d5111e38fa76fd13b0373ad6885769… Patch: https://github.com/kamailio/kamailio/commit/3d5111e38fa76fd13b0373ad6885769…

8 years, 2 months

[kamailio/kamailio] Free database column name as part of database result cleanup (#611)

by William King

The column name is currently not free'd. Some db bankends copy this data so that memory is leaked. Some store internal database pointers and those shouldn't be free'd. One returns a pointer to a stack variable which shouldn't be done. The patch cleans up all db backends to copy the column name and frees that column name as part of the database result cleanup function. Author: Chris Double <doublec(a)silentcircle.com> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/611 -- Commit Summary -- * Free database column name as part of database result cleanup -- File Changes -- M lib/srdb1/db_res.c (3) M modules/db_berkeley/km_bdb_res.c (9) M modules/db_mongodb/mongodb_dbase.c (9) M modules/db_mysql/km_res.c (9) M modules/db_postgres/km_res.c (10) M modules/db_text/dbt_api.c (9) M modules/db_unixodbc/res.c (8) M modules/xmlrpc/xmlrpc.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/611.patch https://github.com/kamailio/kamailio/pull/611.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/611

8 years, 2 months

[kamailio/kamailio] build warnings (#653)

by Victor Seva

``` CC (clang) [M db_berkeley.so] km_db_berkeley.o km_db_berkeley.c:486:58: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if ((ret = bdb_get_columns(_tbc->dtp, *_r, lres, _nc)) < 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ km_db_berkeley.c:513:50: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if ((ret=bdb_append_row( *_r, dbuf, lres, i)) < 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ km_db_berkeley.c:567:58: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if ((ret = bdb_get_columns(_tbc->dtp, *_r, lres, _nc)) < 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ km_db_berkeley.c:572:47: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if ((ret=bdb_convert_row( *_r, dbuf, lres)) < 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ 4 warnings generated. ``` ``` CC (clang) [M auth_radius.so] authorize.o authorize.c:110:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_NONCE_REUSED; ~ ^~~~~~~~~~~~~~~~~ authorize.c:114:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_STALE_NONCE; ~ ^~~~~~~~~~~~~~~~ authorize.c:120:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_ERROR; ~ ^~~~~~~~~~ authorize.c:124:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_NO_CREDENTIALS; ~ ^~~~~~~~~~~~~~~~~~~ authorize.c:131:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_OK; ~ ^~~~~~~ authorize.c:148:9: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_ERROR; ~ ^~~~~~~~~~ authorize.c:153:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_ERROR; ~ ^~~~~~~~~~ authorize.c:159:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_ERROR;; ~ ^~~~~~~~~~ authorize.c:186:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_ERROR; ~ ^~~~~~~~~~ authorize.c:189:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_OK; ~ ^~~~~~~ authorize.c:193:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] ret = AUTH_INVALID_PASSWORD; ~ ^~~~~~~~~~~~~~~~~~~~~ 11 warnings generated. ``` ``` CC (clang) [M misc_radius.so] functions.o functions.c:47:27: warning: comparison of array 'vp->strvalue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (vp->lvalue==0 || vp->strvalue==0) ~~~~^~~~~~~~ ~ 1 warning generated. ``` ``` CC (clang) [M peering.so] verify.o verify.c:58:30: warning: comparison of array 'vp->strvalue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (vp->lvalue==0 || vp->strvalue==0) ~~~~^~~~~~~~ ~ 1 warning generated. ``` ``` CC (clang) [M pua_xmpp.so] xmpp2simple.o xmpp2simple.c:372:10: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion] slash= '\0'; ^~~~ 1 warning generated. ``` ``` CC (clang) [M db2_ldap.so] ld_fld.o ld_fld.c:831:19: warning: unused function 'db_double2ldap_str' [-Wunused-function] static inline int db_double2ldap_str(struct sbuf* buf, db_fld_t* fld) ^ ``` ``` CC (clang) [M xmpp.so] xmpp_server.o In file included from xmpp_server.c:96: ./xode.h:75:9: warning: 'snprintf' macro redefined [-Wmacro-redefined] #define snprintf ap_snprintf ^ /usr/include/x86_64-linux-gnu/bits/stdio2.h:68:11: note: previous definition is here # define snprintf(str, len, ...) \ ^ 1 warning generated. ``` ``` CC (clang) [M xmpp.so] xpool.o In file included from xpool.c:41: ./xode.h:75:9: warning: 'snprintf' macro redefined [-Wmacro-redefined] #define snprintf ap_snprintf ^ /usr/include/x86_64-linux-gnu/bits/stdio2.h:68:11: note: previous definition is here # define snprintf(str, len, ...) \ ^ 1 warning generated. ``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/653

8 years, 2 months

git:4.3:efe5903c: xmlrpc: remove redeclaration of snprintf and vsnprintf

by Victor Seva

Module: kamailio Branch: 4.3 Commit: efe5903cd17de9c5d94610e2345254e347e3aeb0 URL: https://github.com/kamailio/kamailio/commit/efe5903cd17de9c5d94610e2345254e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-03T14:08:50+02:00 xmlrpc: remove redeclaration of snprintf and vsnprintf compilation was failling with clang: > CC (clang) [M xmlrpc.so] xmlrpc.o > xmlrpc.c:152:5: error: expected parameter declarator > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: error: expected ')' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: note: to match this '(' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:28: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: error: conflicting types for '__builtin___snprintf_chk' > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: note: '__builtin___snprintf_chk' is a builtin with type 'int (char *, unsigned long, int, unsigned long, const char *, ...)' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > 3 errors generated. (cherry picked from commit 358de10a94bef4df6b1811ac8e88ea4e7919542c) --- Modified: modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/efe5903cd17de9c5d94610e2345254e… Patch: https://github.com/kamailio/kamailio/commit/efe5903cd17de9c5d94610e2345254e… --- diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index dabb526..16221e9 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -145,13 +145,6 @@ MODULE_VERSION -#if defined (__OS_darwin) || defined (__OS_freebsd) -/* redeclaration of functions from stdio.h throws errors */ -#else -int snprintf(char *str, size_t size, const char *format, ...); -int vsnprintf(char *str, size_t size, const char *format, va_list ap); -#endif - static int process_xmlrpc(sip_msg_t* msg); static int dispatch_rpc(sip_msg_t* msg, char* s1, char* s2); static int xmlrpc_reply(sip_msg_t* msg, char* code, char* reason);

8 years, 2 months

git:4.4:12b04801: xmlrpc: remove redeclaration of snprintf and vsnprintf

by Victor Seva

Module: kamailio Branch: 4.4 Commit: 12b0480169feab25ad68509c23f472155f10082b URL: https://github.com/kamailio/kamailio/commit/12b0480169feab25ad68509c23f4721… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-03T14:08:32+02:00 xmlrpc: remove redeclaration of snprintf and vsnprintf compilation was failling with clang: > CC (clang) [M xmlrpc.so] xmlrpc.o > xmlrpc.c:152:5: error: expected parameter declarator > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: error: expected ')' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: note: to match this '(' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:28: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: error: conflicting types for '__builtin___snprintf_chk' > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: note: '__builtin___snprintf_chk' is a builtin with type 'int (char *, unsigned long, int, unsigned long, const char *, ...)' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > 3 errors generated. (cherry picked from commit 358de10a94bef4df6b1811ac8e88ea4e7919542c) --- Modified: modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/12b0480169feab25ad68509c23f4721… Patch: https://github.com/kamailio/kamailio/commit/12b0480169feab25ad68509c23f4721… --- diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index dabb526..16221e9 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -145,13 +145,6 @@ MODULE_VERSION -#if defined (__OS_darwin) || defined (__OS_freebsd) -/* redeclaration of functions from stdio.h throws errors */ -#else -int snprintf(char *str, size_t size, const char *format, ...); -int vsnprintf(char *str, size_t size, const char *format, va_list ap); -#endif - static int process_xmlrpc(sip_msg_t* msg); static int dispatch_rpc(sip_msg_t* msg, char* s1, char* s2); static int xmlrpc_reply(sip_msg_t* msg, char* code, char* reason);

8 years, 2 months

git:master:031ea395: Merge pull request #652 from linuxmaniac/vseva_xmlrpc_fix

by Victor Seva

Module: kamailio Branch: master Commit: 031ea395c5f4febdedd635adef50e0910c0d9131 URL: https://github.com/kamailio/kamailio/commit/031ea395c5f4febdedd635adef50e09… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-03T14:06:45+02:00 Merge pull request #652 from linuxmaniac/vseva_xmlrpc_fix xmlrpc: remove redeclaration of snprintf and vsnprintf --- Modified: modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/031ea395c5f4febdedd635adef50e09… Patch: https://github.com/kamailio/kamailio/commit/031ea395c5f4febdedd635adef50e09… --- diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index cc4d37f..98835f9 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -146,13 +146,6 @@ MODULE_VERSION -#if defined (__OS_darwin) || defined (__OS_freebsd) -/* redeclaration of functions from stdio.h throws errors */ -#else -int snprintf(char *str, size_t size, const char *format, ...); -int vsnprintf(char *str, size_t size, const char *format, va_list ap); -#endif - static int process_xmlrpc(sip_msg_t* msg); static int dispatch_rpc(sip_msg_t* msg, char* s1, char* s2); static int xmlrpc_reply(sip_msg_t* msg, char* code, char* reason);

8 years, 2 months

git:master:358de10a: xmlrpc: remove redeclaration of snprintf and vsnprintf

by Victor Seva

Module: kamailio Branch: master Commit: 358de10a94bef4df6b1811ac8e88ea4e7919542c URL: https://github.com/kamailio/kamailio/commit/358de10a94bef4df6b1811ac8e88ea4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-03T13:55:42+02:00 xmlrpc: remove redeclaration of snprintf and vsnprintf compilation was failling with clang: > CC (clang) [M xmlrpc.so] xmlrpc.o > xmlrpc.c:152:5: error: expected parameter declarator > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: error: expected ')' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: note: to match this '(' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:28: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: error: conflicting types for '__builtin___snprintf_chk' > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: note: '__builtin___snprintf_chk' is a builtin with type 'int (char *, unsigned long, int, unsigned long, const char *, ...)' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > 3 errors generated. --- Modified: modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/358de10a94bef4df6b1811ac8e88ea4… Patch: https://github.com/kamailio/kamailio/commit/358de10a94bef4df6b1811ac8e88ea4… --- diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index cc4d37f..98835f9 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -146,13 +146,6 @@ MODULE_VERSION -#if defined (__OS_darwin) || defined (__OS_freebsd) -/* redeclaration of functions from stdio.h throws errors */ -#else -int snprintf(char *str, size_t size, const char *format, ...); -int vsnprintf(char *str, size_t size, const char *format, va_list ap); -#endif - static int process_xmlrpc(sip_msg_t* msg); static int dispatch_rpc(sip_msg_t* msg, char* s1, char* s2); static int xmlrpc_reply(sip_msg_t* msg, char* code, char* reason);

8 years, 2 months

[kamailio/kamailio] xmlrpc: remove redeclaration of snprintf and vsnprintf (#652)

by Victor Seva

compilation was failling with clang: > CC (clang) [M xmlrpc.so] xmlrpc.o > xmlrpc.c:152:5: error: expected parameter declarator > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: error: expected ')' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:39: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > /usr/include/features.h:329:31: note: expanded from macro '__USE_FORTIFY_LEVEL' > # define __USE_FORTIFY_LEVEL 2 > ^ > xmlrpc.c:152:5: note: to match this '(' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:28: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: error: conflicting types for '__builtin___snprintf_chk' > int snprintf(char *str, size_t size, const char *format, ...); > ^ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > xmlrpc.c:152:5: note: '__builtin___snprintf_chk' is a builtin with type 'int (char *, unsigned long, int, unsigned long, const char *, ...)' > /usr/include/x86_64-linux-gnu/bits/stdio2.h:69:3: note: expanded from macro 'snprintf' > __builtin___snprintf_chk (str, len, __USE_FORTIFY_LEVEL - 1, __bos (str), \ > ^ > 3 errors generated. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/652 -- Commit Summary -- * xmlrpc: remove redeclaration of snprintf and vsnprintf -- File Changes -- M modules/xmlrpc/xmlrpc.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/652.patch https://github.com/kamailio/kamailio/pull/652.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/652

8 years, 2 months

← Newer
1
...
28
29
30
31
32
33
34
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2016