sr-dev July 2016

sr-dev@lists.kamailio.org

29 participants
297 discussions

[kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

by Dragos Vingarzan

ims_qos: create a proper flow description for the SIP signaling - before there was just an empty one in the AAR - re-using the function typically used for the RTP media - fixing then that function to not just hard-code protocol 17 (UDP) for everything - now supporting also 6 (TCP) and IP (IP has no protocol number, we use just the magic word "ip" (see RFC 3588 IPFilterRule for more details) - adding the IP of the P-CSCF as a parameter to the module, as this is required in the flow (UE IP <-> P-CSCF IP) - also some inline/static fixes to function for avoiding warnings on gcc >=5 ims_registrar_pcscf: fixed removal of contacts on de-registration - the code was there, but I guess some API changes resulted in temporary commented-out code; this uses the new parameters and seems to fix the issue. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/721 -- Commit Summary -- * ims_qos: create a proper flow description for the SIP signaling * ims_registrar_pcscf: fixed removal of contacts on de-registration -- File Changes -- M modules/ims_qos/mod.c (4) M modules/ims_qos/rx_aar.c (32) M modules/ims_qos/rx_avp.c (47) M modules/ims_qos/rx_avp.h (12) M modules/ims_registrar_pcscf/save.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/721.patch https://github.com/kamailio/kamailio/pull/721.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/721

8 years, 4 months

git:master:476d6888: Merge pull request #721 from vingarzan/openimsrevamp_ims_modules

by GitHub

Module: kamailio Branch: master Commit: 476d6888f5e1c0ddfa835df7c3268000ef297221 URL: https://github.com/kamailio/kamailio/commit/476d6888f5e1c0ddfa835df7c326800… Author: richardgood <richardgood(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2016-07-21T20:37:52+02:00 Merge pull request #721 from vingarzan/openimsrevamp_ims_modules ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration --- Modified: modules/ims_qos/README Modified: modules/ims_qos/doc/ims_qos.xml Modified: modules/ims_qos/doc/ims_qos_admin.xml Modified: modules/ims_qos/mod.c Modified: modules/ims_qos/rx_aar.c Modified: modules/ims_qos/rx_avp.c Modified: modules/ims_qos/rx_avp.h Modified: modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/476d6888f5e1c0ddfa835df7c326800… Patch: https://github.com/kamailio/kamailio/commit/476d6888f5e1c0ddfa835df7c326800…

8 years, 4 months

git:master:d99753e4: ims_qos: better name for the rx_pcscf_ip parameter and added documentation

by Dragos Vingarzan

Module: kamailio Branch: master Commit: d99753e459cf8f84d9d63d91216a71e88182ef44 URL: https://github.com/kamailio/kamailio/commit/d99753e459cf8f84d9d63d91216a71e… Author: Dragos Vingarzan <dragos(a)corenetdynamics.com> Committer: Dragos Vingarzan <dragos(a)corenetdynamics.com> Date: 2016-07-21T11:16:02+02:00 ims_qos: better name for the rx_pcscf_ip parameter and added documentation --- Modified: modules/ims_qos/README Modified: modules/ims_qos/doc/ims_qos.xml Modified: modules/ims_qos/doc/ims_qos_admin.xml Modified: modules/ims_qos/mod.c Modified: modules/ims_qos/rx_aar.c --- Diff: https://github.com/kamailio/kamailio/commit/d99753e459cf8f84d9d63d91216a71e… Patch: https://github.com/kamailio/kamailio/commit/d99753e459cf8f84d9d63d91216a71e…

8 years, 4 months

git:master:e102306f: ims_registrar_pcscf: fixed removal of contacts on de-registration

by Dragos Vingarzan

Module: kamailio Branch: master Commit: e102306fe779b8d11ce2151e96d56b7d96c9e308 URL: https://github.com/kamailio/kamailio/commit/e102306fe779b8d11ce2151e96d56b7… Author: Dragos Vingarzan <dragos(a)corenetdynamics.com> Committer: Dragos Vingarzan <dragos(a)corenetdynamics.com> Date: 2016-07-20T18:51:27+02:00 ims_registrar_pcscf: fixed removal of contacts on de-registration - the code was there, but I guess some API changes resulted in temporary commented-out code; this uses the new parameters and seems to fix the issue. --- Modified: modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/e102306fe779b8d11ce2151e96d56b7… Patch: https://github.com/kamailio/kamailio/commit/e102306fe779b8d11ce2151e96d56b7… --- diff --git a/modules/ims_registrar_pcscf/save.c b/modules/ims_registrar_pcscf/save.c index 5a98d36..fbceae3 100644 --- a/modules/ims_registrar_pcscf/save.c +++ b/modules/ims_registrar_pcscf/save.c @@ -183,9 +183,9 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma LM_DBG("contact already exists and is in state (%d) : [%s]\n",pcontact->reg_state, reg_state_to_string(pcontact->reg_state)); if ((expires-local_time_now)<=0) { //remove contact - de-register LM_DBG("This is a de-registration for contact <%.*s>\n", c->uri.len, c->uri.s); -// if (ul.delete_pcontact(_d, &c->uri, &ci.received_host, ci.received_port, pcontact) != 0) { -// LM_ERR("failed to delete pcscf contact <%.*s>\n", c->uri.len, c->uri.s); -// } + if (ul.delete_pcontact(_d, pcontact) != 0) { + LM_ERR("failed to delete pcscf contact <%.*s>\n", c->uri.len, c->uri.s); + } //TODO_LATEST replace above } else { //update contact LM_DBG("Updating contact: <%.*s>, old expires: %li, new expires: %i which is in %i seconds\n", c->uri.len, c->uri.s,

8 years, 4 months

git:master:ab3d42c4: ims_qos: create a proper flow description for the SIP signaling

by Dragos Vingarzan

Module: kamailio Branch: master Commit: ab3d42c47d52b1b7b315272c00daf121d9f8fc92 URL: https://github.com/kamailio/kamailio/commit/ab3d42c47d52b1b7b315272c00daf12… Author: Dragos Vingarzan <dragos(a)corenetdynamics.com> Committer: Dragos Vingarzan <dragos(a)corenetdynamics.com> Date: 2016-07-20T18:31:01+02:00 ims_qos: create a proper flow description for the SIP signaling - before there was just an empty one in the AAR - re-using the function typically used for the RTP media - fixing then that function to not just hard-code protocol 17 (UDP) for everything - now supporting also 6 (TCP) and IP (IP has no protocol number, we use just the magic word "ip" (see RFC 3588 IPFilterRule for more details) - adding the IP of the P-CSCF as a parameter to the module, as this is required in the flow (UE IP <-> P-CSCF IP) - also some inline/static fixes to function for avoiding warnings on gcc >=5 --- Modified: modules/ims_qos/mod.c Modified: modules/ims_qos/rx_aar.c Modified: modules/ims_qos/rx_avp.c Modified: modules/ims_qos/rx_avp.h --- Diff: https://github.com/kamailio/kamailio/commit/ab3d42c47d52b1b7b315272c00daf12… Patch: https://github.com/kamailio/kamailio/commit/ab3d42c47d52b1b7b315272c00daf12…

8 years, 4 months

git:master:f36d8096: Merge pull request #719 from vingarzan/openimsrevamp_cdp_fixes

by GitHub

Module: kamailio Branch: master Commit: f36d80962258cefc6e490e752349aed83abf01f9 URL: https://github.com/kamailio/kamailio/commit/f36d80962258cefc6e490e752349aed… Author: ng-voice GmbH <info(a)ng-voice.com> Committer: GitHub <noreply(a)github.com> Date: 2016-07-20T20:26:13+02:00 Merge pull request #719 from vingarzan/openimsrevamp_cdp_fixes cdp: initializing a variable to 0 and checking a return ptr for null --- Modified: modules/cdp/authstatemachine.c Modified: modules/cdp/peermanager.c --- Diff: https://github.com/kamailio/kamailio/commit/f36d80962258cefc6e490e752349aed… Patch: https://github.com/kamailio/kamailio/commit/f36d80962258cefc6e490e752349aed… --- diff --git a/modules/cdp/authstatemachine.c b/modules/cdp/authstatemachine.c index b479080..203dfef 100644 --- a/modules/cdp/authstatemachine.c +++ b/modules/cdp/authstatemachine.c @@ -754,12 +754,14 @@ void Send_ASA(cdp_session_t* s, AAAMessage* msg) { // the PCRF because TS 29.214 says no Destination-Host and no Auth-Application-Id // in the ASA LM_INFO("sending ASA to peer %.*s\n", avp->data.len, avp->data.s); - peer *p; - p = get_peer_by_fqdn(&avp->data); - if (!peer_send_msg(p, asa)) { + peer *p = get_peer_by_fqdn(&avp->data); + if (!p) { + LM_ERR("Peer not found\n"); + }else if (!peer_send_msg(p, asa)) { if (asa) AAAFreeMessage(&asa); //needed in frequency - } else + } else { LM_INFO("success sending ASA\n"); + } } else if (!AAASendMessage(asa, 0, 0)) { LM_ERR("Send_ASA() : error sending ASA\n"); } diff --git a/modules/cdp/peermanager.c b/modules/cdp/peermanager.c index bce1c0e..1d6f6a9 100644 --- a/modules/cdp/peermanager.c +++ b/modules/cdp/peermanager.c @@ -209,7 +209,7 @@ peer *get_peer_from_sock(int sock) peer *get_peer_from_fqdn(str fqdn,str realm) { peer *i; - str dumb; + str dumb = {0,0}; lock_get(peer_list_lock); i = peer_list->head;

8 years, 4 months

git:master:e575d681: cdp: initializing a variable to 0 and checking a return ptr for null to prevent crashes

by Dragos Vingarzan

Module: kamailio Branch: master Commit: e575d6818ffd3f68de5094a0e8903fccb3aa3b23 URL: https://github.com/kamailio/kamailio/commit/e575d6818ffd3f68de5094a0e8903fc… Author: Dragos Vingarzan <dragos(a)corenetdynamics.com> Committer: Dragos Vingarzan <dragos(a)corenetdynamics.com> Date: 2016-07-20T17:38:24+02:00 cdp: initializing a variable to 0 and checking a return ptr for null to prevent crashes --- Modified: modules/cdp/authstatemachine.c Modified: modules/cdp/peermanager.c --- Diff: https://github.com/kamailio/kamailio/commit/e575d6818ffd3f68de5094a0e8903fc… Patch: https://github.com/kamailio/kamailio/commit/e575d6818ffd3f68de5094a0e8903fc… --- diff --git a/modules/cdp/authstatemachine.c b/modules/cdp/authstatemachine.c index b479080..203dfef 100644 --- a/modules/cdp/authstatemachine.c +++ b/modules/cdp/authstatemachine.c @@ -754,12 +754,14 @@ void Send_ASA(cdp_session_t* s, AAAMessage* msg) { // the PCRF because TS 29.214 says no Destination-Host and no Auth-Application-Id // in the ASA LM_INFO("sending ASA to peer %.*s\n", avp->data.len, avp->data.s); - peer *p; - p = get_peer_by_fqdn(&avp->data); - if (!peer_send_msg(p, asa)) { + peer *p = get_peer_by_fqdn(&avp->data); + if (!p) { + LM_ERR("Peer not found\n"); + }else if (!peer_send_msg(p, asa)) { if (asa) AAAFreeMessage(&asa); //needed in frequency - } else + } else { LM_INFO("success sending ASA\n"); + } } else if (!AAASendMessage(asa, 0, 0)) { LM_ERR("Send_ASA() : error sending ASA\n"); } diff --git a/modules/cdp/peermanager.c b/modules/cdp/peermanager.c index bce1c0e..1d6f6a9 100644 --- a/modules/cdp/peermanager.c +++ b/modules/cdp/peermanager.c @@ -209,7 +209,7 @@ peer *get_peer_from_sock(int sock) peer *get_peer_from_fqdn(str fqdn,str realm) { peer *i; - str dumb; + str dumb = {0,0}; lock_get(peer_list_lock); i = peer_list->head;

8 years, 4 months

[kamailio/kamailio] cdp: initializing a variable to 0 and checking a return ptr for null (#719)

by Dragos Vingarzan

This prevents some crashes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/719 -- Commit Summary -- * cdp: initializing a variable to 0 and checking a return ptr for null to prevent crashes -- File Changes -- M modules/cdp/authstatemachine.c (10) M modules/cdp/peermanager.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/719.patch https://github.com/kamailio/kamailio/pull/719.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/719

8 years, 4 months

[kamailio/kamailio] ims_qos: create a proper flow description for the SIP signaling (#720)

by Dragos Vingarzan

- before there was just an empty one in the AAR - re-using the function typically used for the RTP media - fixing then that function to not just hard-code protocol 17 (UDP) for everything - now supporting also 6 (TCP) and IP (IP has no protocol number, we use just the magic word "ip" (see RFC 3588 IPFilterRule for more details) - adding the IP of the P-CSCF as a parameter to the module, as this is required in the flow (UE IP <-> P-CSCF IP) - also some inline/static fixes to function for avoiding warnings on gcc >=5 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/720 -- Commit Summary -- * ims_qos: create a proper flow description for the SIP signaling -- File Changes -- M modules/ims_qos/mod.c (4) M modules/ims_qos/rx_aar.c (32) M modules/ims_qos/rx_avp.c (47) M modules/ims_qos/rx_avp.h (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/720.patch https://github.com/kamailio/kamailio/pull/720.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/720

8 years, 4 months

git:master:c6f4adf8: Merge pull request #711 from athonet-open/fix_log_imsauth

by GitHub

Module: kamailio Branch: master Commit: c6f4adf80356d9fa6aa14968ef564570329e584e URL: https://github.com/kamailio/kamailio/commit/c6f4adf80356d9fa6aa14968ef56457… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-07-19T22:06:05+02:00 Merge pull request #711 from athonet-open/fix_log_imsauth ims_auth: print ck in readable form and init var to 0 to avoid printing gibberish in the log --- Modified: modules/ims_auth/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/c6f4adf80356d9fa6aa14968ef56457… Patch: https://github.com/kamailio/kamailio/commit/c6f4adf80356d9fa6aa14968ef56457… --- diff --git a/modules/ims_auth/authorize.c b/modules/ims_auth/authorize.c index 595132f..8343de4 100644 --- a/modules/ims_auth/authorize.c +++ b/modules/ims_auth/authorize.c @@ -727,7 +727,7 @@ int authenticate(struct sip_msg* msg, char* _realm, char* str2, int is_proxy_aut str nonce, response16, nc, cnonce, qop_str = {0, 0}, auts = {0, 0}, body, *next_nonce = &empty_s; enum qop_type qop = QOP_UNSPEC; str uri = {0, 0}; - HASHHEX expected, ha1, hbody, rspauth; + HASHHEX expected, ha1, hbody = {0}, rspauth; int expected_len = 32; int expires = 0; auth_vector *av = 0; @@ -1152,6 +1152,8 @@ void auth_data_destroy() { auth_vector * new_auth_vector(int item_number, str auth_scheme, str authenticate, str authorization, str ck, str ik) { auth_vector *x = 0; + char base16_ck[32+1] = {0}; + int base16_ck_len = 0; x = shm_malloc(sizeof (auth_vector)); if (!x) { LM_ERR("error allocating mem\n"); @@ -1305,7 +1307,9 @@ auth_vector * new_auth_vector(int item_number, str auth_scheme, str authenticate x->status = AUTH_VECTOR_UNUSED; x->expires = 0; - LM_DBG("new auth-vector with ck [%.*s] with status %d\n", x->ck.len, x->ck.s, x->status); + base16_ck_len = bin_to_base16(x->ck.s, 16, base16_ck); + if (base16_ck_len) + LM_DBG("new auth-vector with ck [%s] with status %d\n", base16_ck, x->status); done: return x;

8 years, 4 months

← Newer
1
...
6
7
8
9
10
11
12
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2016