sr-dev September 2016

sr-dev@lists.kamailio.org

29 participants
319 discussions

git:master:d23aeb40: Merge pull request #784 from tverlaan/add_xenial_support

by GitHub

Module: kamailio Branch: master Commit: d23aeb40dd828b01ec9ff84892d8fb2f31d7c379 URL: https://github.com/kamailio/kamailio/commit/d23aeb40dd828b01ec9ff84892d8fb2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: GitHub <noreply(a)github.com> Date: 2016-09-20T10:09:24+02:00 Merge pull request #784 from tverlaan/add_xenial_support pkg/kamailio/deb: Add Ubuntu Xenial support --- Added: pkg/kamailio/deb/debian/backports/xenial Added: pkg/kamailio/deb/xenial/changelog Added: pkg/kamailio/deb/xenial/compat Added: pkg/kamailio/deb/xenial/control Added: pkg/kamailio/deb/xenial/copyright Added: pkg/kamailio/deb/xenial/debian Added: pkg/kamailio/deb/xenial/kamailio-autheph-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-berkeley-bin.dirs Added: pkg/kamailio/deb/xenial/kamailio-dnssec-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-outbound-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-tls-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-websocket-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio.README.Debian Added: pkg/kamailio/deb/xenial/kamailio.default Added: pkg/kamailio/deb/xenial/kamailio.examples Added: pkg/kamailio/deb/xenial/kamailio.init Added: pkg/kamailio/deb/xenial/kamailio.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio.postinst Added: pkg/kamailio/deb/xenial/kamailio.service Added: pkg/kamailio/deb/xenial/rules Added: pkg/kamailio/deb/xenial/source.lintian-overrides Added: pkg/kamailio/deb/xenial/source/format Added: pkg/kamailio/deb/xenial/watch --- Diff: https://github.com/kamailio/kamailio/commit/d23aeb40dd828b01ec9ff84892d8fb2… Patch: https://github.com/kamailio/kamailio/commit/d23aeb40dd828b01ec9ff84892d8fb2…

7 years, 12 months

git:master:eb1af794: pkg/kamailio/deb: Add Ubuntu Xenial support

by Timmo Verlaan

Module: kamailio Branch: master Commit: eb1af79404bd491401b640943bd0bd69918ede3d URL: https://github.com/kamailio/kamailio/commit/eb1af79404bd491401b640943bd0bd6… Author: Timmo Verlaan <tverlaan(a)gmail.com> Committer: Timmo Verlaan <tverlaan(a)gmail.com> Date: 2016-09-16T16:11:53+02:00 pkg/kamailio/deb: Add Ubuntu Xenial support --- Added: pkg/kamailio/deb/debian/backports/xenial Added: pkg/kamailio/deb/xenial/changelog Added: pkg/kamailio/deb/xenial/compat Added: pkg/kamailio/deb/xenial/control Added: pkg/kamailio/deb/xenial/copyright Added: pkg/kamailio/deb/xenial/debian Added: pkg/kamailio/deb/xenial/kamailio-autheph-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-berkeley-bin.dirs Added: pkg/kamailio/deb/xenial/kamailio-dnssec-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-outbound-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-tls-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-websocket-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio.README.Debian Added: pkg/kamailio/deb/xenial/kamailio.default Added: pkg/kamailio/deb/xenial/kamailio.examples Added: pkg/kamailio/deb/xenial/kamailio.init Added: pkg/kamailio/deb/xenial/kamailio.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio.postinst Added: pkg/kamailio/deb/xenial/kamailio.service Added: pkg/kamailio/deb/xenial/rules Added: pkg/kamailio/deb/xenial/source.lintian-overrides Added: pkg/kamailio/deb/xenial/source/format Added: pkg/kamailio/deb/xenial/watch --- Diff: https://github.com/kamailio/kamailio/commit/eb1af79404bd491401b640943bd0bd6… Patch: https://github.com/kamailio/kamailio/commit/eb1af79404bd491401b640943bd0bd6…

7 years, 12 months

[kamailio/kamailio] Add Ubuntu Xenial support (#784)

by Timmo Verlaan

This will add support for Ubuntu Xenial. This is my first PR for kamailio so any feedback is welcome. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/784 -- Commit Summary -- * pkg/kamailio/deb: Add Ubuntu Xenial support -- File Changes -- A pkg/kamailio/deb/debian/backports/xenial (16) A pkg/kamailio/deb/xenial/changelog (307) A pkg/kamailio/deb/xenial/compat (1) A pkg/kamailio/deb/xenial/control (680) A pkg/kamailio/deb/xenial/copyright (335) A pkg/kamailio/deb/xenial/debian (1) A pkg/kamailio/deb/xenial/kamailio-autheph-modules.lintian-overrides (1) A pkg/kamailio/deb/xenial/kamailio-berkeley-bin.dirs (1) A pkg/kamailio/deb/xenial/kamailio-dnssec-modules.lintian-overrides (1) A pkg/kamailio/deb/xenial/kamailio-outbound-modules.lintian-overrides (1) A pkg/kamailio/deb/xenial/kamailio-tls-modules.lintian-overrides (1) A pkg/kamailio/deb/xenial/kamailio-websocket-modules.lintian-overrides (1) A pkg/kamailio/deb/xenial/kamailio.README.Debian (39) A pkg/kamailio/deb/xenial/kamailio.default (28) A pkg/kamailio/deb/xenial/kamailio.examples (1) A pkg/kamailio/deb/xenial/kamailio.init (163) A pkg/kamailio/deb/xenial/kamailio.lintian-overrides (2) A pkg/kamailio/deb/xenial/kamailio.postinst (24) A pkg/kamailio/deb/xenial/kamailio.service (21) A pkg/kamailio/deb/xenial/rules (229) A pkg/kamailio/deb/xenial/source.lintian-overrides (1) A pkg/kamailio/deb/xenial/source/format (1) A pkg/kamailio/deb/xenial/watch (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/784.patch https://github.com/kamailio/kamailio/pull/784.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/784

7 years, 12 months

git:4.4:659b9122: presence: Fix memory leak in DB code

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.4 Commit: 659b912231d81dff8eac2b486f39919f0b7c45cb URL: https://github.com/kamailio/kamailio/commit/659b912231d81dff8eac2b486f39919… Author: Phil Lavin <phil(a)lavin.me.uk> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-09-19T23:05:38+02:00 presence: Fix memory leak in DB code (cherry picked from commit 0c36c1b62efef176ae6e9322f14096e3a63ed348) --- Modified: modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/659b912231d81dff8eac2b486f39919… Patch: https://github.com/kamailio/kamailio/commit/659b912231d81dff8eac2b486f39919… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index d81b90e..e601153 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -396,9 +396,11 @@ int delete_presentity_if_dialog_id_exists(presentity_t* presentity, char* dialog if(result == NULL) return -3; - // No results from query definitely means no dialog exists - if (result->n <= 0) + /* no results from query definitely means no dialog exists */ + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return 0; + } // Loop the rows returned from the DB for (i=0; i < result->n; i++)

7 years, 12 months

git:master:9c1b55e9: Merge pull request #788 from phil-lavin/mem-leaks

by GitHub

Module: kamailio Branch: master Commit: 9c1b55e90648f81514bdf2570eeeae83bf46dfff URL: https://github.com/kamailio/kamailio/commit/9c1b55e90648f81514bdf2570eeeae8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-09-19T23:04:38+02:00 Merge pull request #788 from phil-lavin/mem-leaks Fix memory leaks in presence and purple --- Modified: modules/presence/presentity.c Modified: modules/purple/mapping.c --- Diff: https://github.com/kamailio/kamailio/commit/9c1b55e90648f81514bdf2570eeeae8… Patch: https://github.com/kamailio/kamailio/commit/9c1b55e90648f81514bdf2570eeeae8… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index d81b90e..e601153 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -396,9 +396,11 @@ int delete_presentity_if_dialog_id_exists(presentity_t* presentity, char* dialog if(result == NULL) return -3; - // No results from query definitely means no dialog exists - if (result->n <= 0) + /* no results from query definitely means no dialog exists */ + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return 0; + } // Loop the rows returned from the DB for (i=0; i < result->n; i++) diff --git a/modules/purple/mapping.c b/modules/purple/mapping.c index e1aa00e..bbdb69f 100644 --- a/modules/purple/mapping.c +++ b/modules/purple/mapping.c @@ -133,8 +133,11 @@ char *find_sip_user(char *extern_user) { if (result == NULL) return NULL; - if (result->n <= 0) + + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return NULL; + } row = &result->rows[0]; row_vals = ROW_VALUES(row); @@ -208,6 +211,7 @@ extern_account_t *find_accounts(char* sip_user, int* count) { return NULL; } if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); LM_ERR("result count = %d\n", result->n); return NULL; } @@ -290,8 +294,11 @@ extern_user_t *find_users(char *sip_user, int* count) { if (result == NULL) return NULL; - if (result->n <= 0) + + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return NULL; + } users = (extern_user_t*) pkg_malloc(sizeof(extern_user_t)*result->n);

7 years, 12 months

git:master:0c36c1b6: presence: Fix memory leak in DB code

by Phil Lavin

Module: kamailio Branch: master Commit: 0c36c1b62efef176ae6e9322f14096e3a63ed348 URL: https://github.com/kamailio/kamailio/commit/0c36c1b62efef176ae6e9322f14096e… Author: Phil Lavin <phil(a)lavin.me.uk> Committer: Phil Lavin <phil(a)lavin.me.uk> Date: 2016-09-19T21:27:54+01:00 presence: Fix memory leak in DB code --- Modified: modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/0c36c1b62efef176ae6e9322f14096e… Patch: https://github.com/kamailio/kamailio/commit/0c36c1b62efef176ae6e9322f14096e… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index d81b90e..e601153 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -396,9 +396,11 @@ int delete_presentity_if_dialog_id_exists(presentity_t* presentity, char* dialog if(result == NULL) return -3; - // No results from query definitely means no dialog exists - if (result->n <= 0) + /* no results from query definitely means no dialog exists */ + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return 0; + } // Loop the rows returned from the DB for (i=0; i < result->n; i++)

7 years, 12 months

git:master:a361686b: purple: Fix multiple memory leaks in DB code

by Phil Lavin

Module: kamailio Branch: master Commit: a361686b2c872cad6493804eb71b8b8e7e151a4f URL: https://github.com/kamailio/kamailio/commit/a361686b2c872cad6493804eb71b8b8… Author: Phil Lavin <phil(a)lavin.me.uk> Committer: Phil Lavin <phil(a)lavin.me.uk> Date: 2016-09-19T21:27:25+01:00 purple: Fix multiple memory leaks in DB code --- Modified: modules/purple/mapping.c --- Diff: https://github.com/kamailio/kamailio/commit/a361686b2c872cad6493804eb71b8b8… Patch: https://github.com/kamailio/kamailio/commit/a361686b2c872cad6493804eb71b8b8… --- diff --git a/modules/purple/mapping.c b/modules/purple/mapping.c index e1aa00e..bbdb69f 100644 --- a/modules/purple/mapping.c +++ b/modules/purple/mapping.c @@ -133,8 +133,11 @@ char *find_sip_user(char *extern_user) { if (result == NULL) return NULL; - if (result->n <= 0) + + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return NULL; + } row = &result->rows[0]; row_vals = ROW_VALUES(row); @@ -208,6 +211,7 @@ extern_account_t *find_accounts(char* sip_user, int* count) { return NULL; } if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); LM_ERR("result count = %d\n", result->n); return NULL; } @@ -290,8 +294,11 @@ extern_user_t *find_users(char *sip_user, int* count) { if (result == NULL) return NULL; - if (result->n <= 0) + + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return NULL; + } users = (extern_user_t*) pkg_malloc(sizeof(extern_user_t)*result->n);

7 years, 12 months

[kamailio/kamailio] Fix memory leaks in presence and purple (#788)

by Phil Lavin

DB result is not freed when the resultset has <= 0 rows Needs backporting to 4.4 branch You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/788 -- Commit Summary -- * purple: Fix multiple memory leaks in DB code * presence: Fix memory leak in DB code -- File Changes -- M modules/presence/presentity.c (6) M modules/purple/mapping.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/788.patch https://github.com/kamailio/kamailio/pull/788.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/788

7 years, 12 months

git:4.4:1c740e85: presence: free db result when get_dialog_state() retrieves no rows

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.4 Commit: 1c740e85cabe62dec9314589dd0cb0141ffd1010 URL: https://github.com/kamailio/kamailio/commit/1c740e85cabe62dec9314589dd0cb01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-09-19T20:59:26+02:00 presence: free db result when get_dialog_state() retrieves no rows - db result and columns in the query are allocated (cherry picked from commit 7289417c39939f61ea116fe8dc8d23cdea6401be) --- Modified: modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/1c740e85cabe62dec9314589dd0cb01… Patch: https://github.com/kamailio/kamailio/commit/1c740e85cabe62dec9314589dd0cb01… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index b5d7b65..d81b90e 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -503,9 +503,11 @@ int get_dialog_state(presentity_t* presentity, char** state) if(result == NULL) return -3; - // No results from query definitely means no dialog exists - if (result->n <= 0) + /* no results from query definitely means no dialog exists */ + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return 0; + } // Loop the rows returned from the DB for (i=0; i < result->n; i++)

7 years, 12 months

git:master:7289417c: presence: free db result when get_dialog_state() retrieves no rows

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7289417c39939f61ea116fe8dc8d23cdea6401be URL: https://github.com/kamailio/kamailio/commit/7289417c39939f61ea116fe8dc8d23c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-09-19T20:58:31+02:00 presence: free db result when get_dialog_state() retrieves no rows - db result and columns in the query are allocated --- Modified: modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/7289417c39939f61ea116fe8dc8d23c… Patch: https://github.com/kamailio/kamailio/commit/7289417c39939f61ea116fe8dc8d23c… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index b5d7b65..d81b90e 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -503,9 +503,11 @@ int get_dialog_state(presentity_t* presentity, char** state) if(result == NULL) return -3; - // No results from query definitely means no dialog exists - if (result->n <= 0) + /* no results from query definitely means no dialog exists */ + if (result->n <= 0) { + pa_dbf.free_result(pa_db, result); return 0; + } // Loop the rows returned from the DB for (i=0; i < result->n; i++)

7 years, 12 months

← Newer
1
...
9
10
11
12
13
14
15
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2016