sr-dev September 2016

sr-dev@lists.kamailio.org

29 participants
319 discussions

git:master:2f151fc1: sca: sca_call_info_update() add [to|from] optional parameters

by Victor Seva

Module: kamailio Branch: master Commit: 2f151fc102a6e4eb832c78b93d4ac527d90eeeaf URL: https://github.com/kamailio/kamailio/commit/2f151fc102a6e4eb832c78b93d4ac52… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-09-13T12:02:05+02:00 sca: sca_call_info_update() add [to|from] optional parameters * skip parsing msg for header [to|from] if value is given Fix #775 --- Modified: modules/sca/doc/sca_admin.xml Modified: modules/sca/sca.c Modified: modules/sca/sca_call_info.c Modified: modules/sca/sca_call_info.h Modified: modules/sca/sca_util.c Modified: modules/sca/sca_util.h --- Diff: https://github.com/kamailio/kamailio/commit/2f151fc102a6e4eb832c78b93d4ac52… Patch: https://github.com/kamailio/kamailio/commit/2f151fc102a6e4eb832c78b93d4ac52…

8 years, 2 months

[kamailio/kamailio] sca: add a way to force from/to URI to sca_call_info_update() (#775)

by Victor Seva

Sipwise hat ON: We have an environment where we have to fix the From/To info in the message and right now we are forced to call msg_apply_changes() before calling sca_call_info_update() I'm planing to implement a way to skip the parsing of the From/To headers and instead read the values from vars defined in two new module parameters -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/775

8 years, 2 months

git:master:8a5b4d73: sca: use kamailio module interface

by Victor Seva

Module: kamailio Branch: master Commit: 8a5b4d73848b8722f1f47483fec649310d10f377 URL: https://github.com/kamailio/kamailio/commit/8a5b4d73848b8722f1f47483fec6493… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-09-12T19:10:20+02:00 sca: use kamailio module interface Related to #775, more than 2 parameters needed --- Modified: modules/sca/Makefile Modified: modules/sca/sca.c --- Diff: https://github.com/kamailio/kamailio/commit/8a5b4d73848b8722f1f47483fec6493… Patch: https://github.com/kamailio/kamailio/commit/8a5b4d73848b8722f1f47483fec6493… --- diff --git a/modules/sca/Makefile b/modules/sca/Makefile index 808f16f..bad0375 100644 --- a/modules/sca/Makefile +++ b/modules/sca/Makefile @@ -9,7 +9,7 @@ auto_gen= NAME=sca.so LIBS= -DEFS+=-DSER_MOD_INTERFACE +DEFS+=-DKAMAILIO_MOD_INTERFACE SERLIBPATH=../../lib SER_LIBS+=$(SERLIBPATH)/kcore/kcore diff --git a/modules/sca/sca.c b/modules/sca/sca.c index cca8b81..9bdb26f 100644 --- a/modules/sca/sca.c +++ b/modules/sca/sca.c @@ -74,13 +74,13 @@ static int sca_set_config(sca_mod *); * EXPORTED COMMANDS */ static cmd_export_t cmds[] = { - {"sca_handle_subscribe", sca_handle_subscribe, 0, NULL, + {"sca_handle_subscribe", (cmd_function)sca_handle_subscribe, 0, NULL, 0, REQUEST_ROUTE}, - {"sca_call_info_update", sca_call_info_update, 0, NULL, + {"sca_call_info_update", (cmd_function)sca_call_info_update, 0, NULL, 0, REQUEST_ROUTE | FAILURE_ROUTE | ONREPLY_ROUTE}, - {"sca_call_info_update", sca_call_info_update, 1, fixup_var_int_1, + {"sca_call_info_update", (cmd_function)sca_call_info_update, 1, fixup_var_int_1, 0, REQUEST_ROUTE | FAILURE_ROUTE | ONREPLY_ROUTE}, - {NULL, NULL, -1, 0, 0}, + {0, 0, 0, 0, 0, 0}, }; /* @@ -144,16 +144,19 @@ static param_export_t params[] = { /* * MODULE EXPORTS */ -struct module_exports exports = { - "sca", // module name - cmds, // exported functions - NULL, // RPC methods - params, // exported parameters - sca_mod_init, // module initialization function - NULL, // response handling function - sca_mod_destroy, // destructor function - NULL, // oncancel function - sca_child_init, // per-child initialization function +struct module_exports exports= { + "sca", + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, + params, + 0, /* exported statistics */ + 0, /* exported MI functions */ + 0, /* exported pseudo-variables */ + 0, /* extra processes */ + sca_mod_init, + 0, + sca_mod_destroy, + sca_child_init /* per-child init function */ }; static int sca_bind_sl(sca_mod *scam, sl_api_t *sl_api)

8 years, 2 months

[kamailio/kamailio] sca: add a way to force from/to URI to sca_call_info_update() (#776)

by Victor Seva

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/776 -- Commit Summary -- * sca: sca_call_info_update() add [to|from] optional parameters * sca: use kamailio module interface -- File Changes -- M modules/sca/Makefile (2) M modules/sca/doc/sca_admin.xml (12) M modules/sca/sca.c (66) M modules/sca/sca_call_info.c (18) M modules/sca/sca_call_info.h (2) M modules/sca/sca_util.c (56) M modules/sca/sca_util.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/776.patch https://github.com/kamailio/kamailio/pull/776.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/776

8 years, 2 months

git:master:56340d42: modules/ims_auth: buffer protection

by jaybeepee

Module: kamailio Branch: master Commit: 56340d423d6d87f8897d2b1cd045f9f24c575c89 URL: https://github.com/kamailio/kamailio/commit/56340d423d6d87f8897d2b1cd045f9f… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-09-13T11:07:50+02:00 modules/ims_auth: buffer protection --- Modified: modules/ims_auth/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/56340d423d6d87f8897d2b1cd045f9f… Patch: https://github.com/kamailio/kamailio/commit/56340d423d6d87f8897d2b1cd045f9f… --- diff --git a/modules/ims_auth/authorize.c b/modules/ims_auth/authorize.c index 8343de4..a89b15e 100644 --- a/modules/ims_auth/authorize.c +++ b/modules/ims_auth/authorize.c @@ -1307,9 +1307,11 @@ auth_vector * new_auth_vector(int item_number, str auth_scheme, str authenticate x->status = AUTH_VECTOR_UNUSED; x->expires = 0; - base16_ck_len = bin_to_base16(x->ck.s, 16, base16_ck); - if (base16_ck_len) - LM_DBG("new auth-vector with ck [%s] with status %d\n", base16_ck, x->status); + if (x->ck.len > 0 && x->ck.s) { + base16_ck_len = bin_to_base16(x->ck.s, 16, base16_ck); + if (base16_ck_len) + LM_DBG("new auth-vector with ck [%s] with status %d\n", base16_ck, x->status); + } done: return x;

8 years, 2 months

[kamailio/kamailio] Calling jsonrpc_notification fail in failure route when fr_timer timeout (#713)

by Ian Yu-Hsun Lin

## Environment Kamailio 4.3.3 Ubuntu 14.04.1 x86_64 ## Problem I'm using `t_suspend()` and `t_continue()` for mobile push notification scenario. Before calling `t_suspend()` I set the `fr_timer` to 12 seconds and `t_on_failure()` to my custom failure route (e.g. `failure_route[MY_FAILURE_ROUTE]`). The scenario is fairly similar to [[SR-Users] Timeout after t_suspend and failure route][1], the only difference is I try to use `jsonrpc_notificaion()` to notify the user asynchronously in my custom failure route. There are 2 different results depending on how it goes to the failure route: 1. Caller cancel the call before `fr_timer` expires - `jsonrpc_notification` can successfully be called in failure route 2. The `fr_timer` did timeout after 12 seconds - An error occurred while calling `jsonrpc_notification`: - `jsonrpc_notification(): failed to write to io pipe: Bad file descriptor` ## Investigation For the first case that perform normally, the IDs of Kamailio processes being used are the same for both **calling t_suspend()** and **entering failure route**, while in the second case the processes are different. Following added some debug messages in Kamailio's `main.c` it showed that the process being used in the failure route of case 2 is `slow timer process`, and from `jsonrpc_mod.c`'s `child_init()` function, the rank of `slow timer process` is **-1** therefore it doesn't assign the `fd` to this process. My workaround was just assigning the `fd` to each child during `child_init()` in `jsonrpc_mod.c` but that's definitely not a good way to go. I am appreciated if you can give me some advice to solve this problem correctly. Cheers, Ian [1]: http://lists.sip-router.org/pipermail/sr-users/2015-March/087519.html --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/713

8 years, 2 months

git:master:875c8ed0: janssonrpc-c: set the cmd pipe for all child processes

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 875c8ed09917825b4d4cd4e3f04e2665d957104a URL: https://github.com/kamailio/kamailio/commit/875c8ed09917825b4d4cd4e3f04e266… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-09-12T17:36:49+02:00 janssonrpc-c: set the cmd pipe for all child processes --- Modified: modules/janssonrpc-c/janssonrpc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/875c8ed09917825b4d4cd4e3f04e266… Patch: https://github.com/kamailio/kamailio/commit/875c8ed09917825b4d4cd4e3f04e266… --- diff --git a/modules/janssonrpc-c/janssonrpc_mod.c b/modules/janssonrpc-c/janssonrpc_mod.c index c69b843..b54bc0f 100644 --- a/modules/janssonrpc-c/janssonrpc_mod.c +++ b/modules/janssonrpc-c/janssonrpc_mod.c @@ -159,7 +159,7 @@ static int child_init(int rank) { int pid; - if (rank>PROC_MAIN) + if (rank!=PROC_INIT) cmd_pipe = pipe_fds[1]; if (rank!=PROC_MAIN)

8 years, 2 months

Still Failing: linuxmaniac/kamailio#43 (master - e30743f)

by Travis CI

Build Update for linuxmaniac/kamailio ------------------------------------- Build: #43 Status: Still Failing Duration: 10 minutes and 13 seconds Commit: e30743f (master) Author: jaybeepee Message: modules/ims_auth: missing bracket View the changeset: https://github.com/linuxmaniac/kamailio/compare/b156c836dba8...e30743f7e9dd View the full build log and details: https://travis-ci.org/linuxmaniac/kamailio/builds/159344260 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

8 years, 2 months

[kamailio/kamailio] Kamailio 4.4) sipcapture_module: ERROR: parse_msg: message=<HEP3#003�> (#599)

by goseeped

The sipcapture module works great when you send hepv3 packets over the UDP transport however if kamailio start listening those hepv3 packtes on TCP and sending those hepv3 on TCP it will concern about it. **This is what Kamilio receives over TCP.** > T 52.10.155.177:47283 -> 172.19.8.21:9060 [AP] > HEP3.0................... > ......... > ...........[............. > W*y6... > . > ..h...... > .................OPTIONS sip:edge.rarevase.com;transport=tcp SIP/2.0. > Via: SIP/2.0/TCP 172.19.16.130:53083;rport;branch=z9hG4bKPj66df463f-ca4b-4f98-ba17-722fe3fc4a92;alias. > From: <sip:asterisk@172.19.16.130>;tag=86ebab1d-eb4e-4986-898d-c7392b6b747b. > To: <sip:edge.rarevase.com>. > Contact: <sip:asterisk@172.19.16.130:53083;transport=TCP>. > Call-ID: ed24ab3c-4f42-4a9d-8e2d-9a3acd5b5b70. > CSeq: 3809 OPTIONS. > Max-Forwards: 70. > User-Agent: Asterisk PBX 13.8.0. > Content-Length: 0. > . > > ## > T 52.10.155.177:47283 -> 172.19.8.21:9060 [AP] > HEP3.\................... > ......... > ...................[..... > W*y6... > . > ..|...... > .................SIP/2.0 200 OK. > Via: SIP/2.0/TCP 172.19.16.130:53083;rport=53083;received=172.19.16.130;branch=z9hG4bKPj66df463f-ca4b-4f98-ba17-722fe3fc4a92;alias. > From: <sip:asterisk@172.19.16.130>;tag=86ebab1d-eb4e-4986-898d-c7392b6b747b. > To: <sip:edge.rarevase.com>;tag=24voZr. > Call-ID: ed24ab3c-4f42-4a9d-8e2d-9a3acd5b5b70. > CSeq: 3809 OPTIONS. > Max-Forwards: 70. > Content-Length: 0. > Supported: path,gruu,outbound. > Accept: */*. > Allow: INVITE,ACK,CANCEL,BYE,OPTIONS,INFO,UPDATE,SUBSCRIBE,NOTIFY,REFER,MESSAGE,REGISTER. > . > **This are the logs on the Kamailio.** `May 4 22:44:05 ip-172-19-8-21 /usr/sbin/kamailio[19285]: INFO: <core> [parser/parse_fline.c:144]: parse_first_line(): ERROR:parse_first_line: method not followed by SP May 4 22:44:05 ip-172-19-8-21 /usr/sbin/kamailio[19285]: ERROR: <core> [parser/parse_fline.c:257]: parse_first_line(): parse_first_line: bad message (offset: 0) May 4 22:44:05 ip-172-19-8-21 /usr/sbin/kamailio[19285]: DEBUG: <core> [parser/msg_parser.c:604]: parse_msg(): parse_msg: invalid message May 4 22:44:05 ip-172-19-8-21 /usr/sbin/kamailio[19285]: ERROR: <core> [parser/msg_parser.c:690]: parse_msg(): ERROR: parse_msg: message=<HEP3#003<98>> May 4 22:44:05 ip-172-19-8-21 /usr/sbin/kamailio[19285]: ERROR: <core> [receive.c:173]: receive_msg(): core parsing of SIP message failed (52.10.155.177:59607/2)` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/599

8 years, 2 months

git:master:3b31c51b: jsonrpc-c: set the cpm pipe for all child processes

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3b31c51bd66737891b549895dea068494929926c URL: https://github.com/kamailio/kamailio/commit/3b31c51bd66737891b549895dea0684… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-09-12T17:31:36+02:00 jsonrpc-c: set the cpm pipe for all child processes - reported by Ian Yu-Hsun Lin, GH #713 --- Modified: modules/jsonrpc-c/jsonrpc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/3b31c51bd66737891b549895dea0684… Patch: https://github.com/kamailio/kamailio/commit/3b31c51bd66737891b549895dea0684… --- diff --git a/modules/jsonrpc-c/jsonrpc_mod.c b/modules/jsonrpc-c/jsonrpc_mod.c index f462a14..39d8819 100644 --- a/modules/jsonrpc-c/jsonrpc_mod.c +++ b/modules/jsonrpc-c/jsonrpc_mod.c @@ -115,15 +115,15 @@ static int mod_init(void) { LM_ERR("pipe() failed\n"); return -1; } - + return(0); } -static int child_init(int rank) +static int child_init(int rank) { int pid; - - if (rank>PROC_MAIN) + + if (rank!=PROC_INIT) cmd_pipe = pipe_fds[1]; if (rank!=PROC_MAIN)

8 years, 2 months

← Newer
1
...
20
21
22
23
24
25
26
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2016