Module: kamailio
Branch: master
Commit: 82262107a1f3c14df1dd7430fb9611f4584df67e
URL: https://github.com/kamailio/kamailio/commit/82262107a1f3c14df1dd7430fb9611f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2017-01-02T09:10:57+01:00
smsops: removed unused internal libs from makefile
- bits of whitespacing formating
---
Modified: src/modules/smsops/Makefile
Modified: src/modules/smsops/smsops.c
Modified: src/modules/smsops/smsops_impl.c
Modified: src/modules/smsops/smsops_impl.h
---
Diff: https://github.com/kamailio/kamailio/commit/82262107a1f3c14df1dd7430fb9611f…
Patch: https://github.com/kamailio/kamailio/commit/82262107a1f3c14df1dd7430fb9611f…
---
diff --git a/src/modules/smsops/Makefile b/src/modules/smsops/Makefile
index 72e4703..633c5da 100644
--- a/src/modules/smsops/Makefile
+++ b/src/modules/smsops/Makefile
@@ -11,7 +11,4 @@ LIBS=
DEFS+=-DKAMAILIO_MOD_INTERFACE
-SERLIBPATH=../../lib
-SER_LIBS+=$(SERLIBPATH)/kmi/kmi
-SER_LIBS+=$(SERLIBPATH)/srutils/srutils
include ../../Makefile.modules
diff --git a/src/modules/smsops/smsops.c b/src/modules/smsops/smsops.c
index f69a9a1..9af52b2 100644
--- a/src/modules/smsops/smsops.c
+++ b/src/modules/smsops/smsops.c
@@ -13,8 +13,8 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c
index b797864..6840530 100644
--- a/src/modules/smsops/smsops_impl.c
+++ b/src/modules/smsops/smsops_impl.c
@@ -52,7 +52,7 @@ typedef enum _rp_message_type {
RP_ACK_NETWORK_TO_MS = 0x03,
} rp_message_type_t;
-enum SMS_DATA {
+enum SMS_DATA {
SMS_ALL,
SMS_RPDATA_TYPE,
SMS_RPDATA_REFERENCE,
@@ -103,7 +103,7 @@ typedef struct _sms_rp_data {
str originator;
str destination;
int pdu_len;
- sms_pdu_t pdu;
+ sms_pdu_t pdu;
} sms_rp_data_t;
// Pointer to current parsed rp_data/tpdu
diff --git a/src/modules/smsops/smsops_impl.h b/src/modules/smsops/smsops_impl.h
index 380b52d..be233c1 100644
--- a/src/modules/smsops/smsops_impl.h
+++ b/src/modules/smsops/smsops_impl.h
@@ -13,8 +13,8 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*
*/
Hello,
I propose to freeze the development of v5.0.0 on January 4, 2017.
Hopefully it is just in time for getting the frozen version in next
Debian stable.
Meanwhile, I hope we can get rid of mi code to have a proper fresh start
with cleaned up code in 5.0.0. The big code tree restructuring was
already done, config files in embedded languages is there as well (it
needs more exports, but that's only about available time to fill some
structures, not new feature development).
If anyone wants to make other proposals, reply to mailing lists and
let's discuss.
Cheers,
Daniel
--
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
Hi!
http://kamailio.org/docs/modules/devel/modules/pua_mi.html#idp35056788
This module has a lot of mi and needs to be rewritten. I looked at implementing the pua_publish as RPC a long time ago and remembers that doing this back then seemed impossible to me using the RPC interface.
If we’re looking into removing mi for 5.0.0 which is a good thing, then we need to handle this module.
Just wanted to start the conversation :-)
/O