sr-dev November 2017

sr-dev@lists.kamailio.org

26 participants
482 discussions

add_contact_alias(0) is proto differs
by Juha Heinanen 25 Nov '17

25 Nov '17

Currently add_contact_alias() works like this: Adds an “;alias=ip~port~transport” parameter to the contact URI containing either received ip, port, and transport protocol or those given as parameters. If called without parameters, “;alias” parameter is only added if received ip and port differ from those in contact URI. Now I noticed that a broken UA does not add a proper ;transport param to contact uri and therefore received transport does not match contact uri transport. Therefore transport proto does not match, but ip and port do match. It would be useful is add_contact_alias() would add ;alias param also if transports do not match. Is it OK if I make the change? After that README would read: Adds an “;alias=ip~port~transport” parameter to the contact URI containing either received ip, port, and transport protocol or those given as parameters. If called without parameters, “;alias” parameter is only added if received ip, port, and transport protocol differ from those in contact URI. -- Juha

2 4

[kamailio/kamailio] Possible issue with parameters (#1333)
by Sam 25 Nov '17

25 Nov '17

https://github.com/kamailio/kamailio/blob/f95fda89d4532ba333aed835c72f102a7… Hi, it seems that KEMI defines this method to accept one parameter but the ki_search_append seems to expect two arguments. I might have misunderstood how KEMI is implemented but wanted to open this ticket in case it is an issue. The same goes for: search_append_body -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1333

2 3

git:master:991fe9b2: rtpengine: proper check for empty string inside add_rtpengine_socks()
by Daniel-Constantin Mierla 25 Nov '17

25 Nov '17

Module: kamailio Branch: master Commit: 991fe9b28e0e201309048f3b38a135037e40357a URL: https://github.com/kamailio/kamailio/commit/991fe9b28e0e201309048f3b38a1350… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-25T09:18:23+01:00 rtpengine: proper check for empty string inside add_rtpengine_socks() - reported by GH #1325 --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/991fe9b28e0e201309048f3b38a1350… Patch: https://github.com/kamailio/kamailio/commit/991fe9b28e0e201309048f3b38a1350… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 9704693eee..c3bc770da9 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -906,7 +906,7 @@ int add_rtpengine_socks(struct rtpp_set * rtpp_list, char * rtpproxy, p1++; } - if (p1 != NULL && p1 != '\0') { + if (p1 != NULL && p1[0] != '\0') { s1.s = p1; s1.len = strlen(p1); if (str2int(&s1, &port) < 0 || port > 0xFFFF) {

1 0

[kamailio/kamailio] xmlrpc: compiler warnings in trunk and 5.1 (#1312)
by Ovidiu Sas 25 Nov '17

25 Nov '17

CentOS Linux release 7.4.1708 (Core) ``` CC (gcc) [M xmlrpc.so] xmlrpc.o xmlrpc.c: In function 'set_fault': xmlrpc.c:894:2: warning: implicit declaration of function 'vsnprintf' [-Wimplicit-function-declaration] vsnprintf(buf, REASON_BUF_LEN, fmt, ap); ^ xmlrpc.c: In function 'print_value': xmlrpc.c:1024:4: warning: implicit declaration of function 'snprintf' [-Wimplicit-function-declaration] body.len = snprintf(buf, 256, "%f", va_arg(*ap, double)); ^ xmlrpc.c:1024:15: warning: incompatible implicit declaration of built-in function 'snprintf' [enabled by default] body.len = snprintf(buf, 256, "%f", va_arg(*ap, double)); ^ ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1312

2 2

git:master:6e680c71: xmlrpc: define _XOPEN_SOURCE to 600
by Daniel-Constantin Mierla 25 Nov '17

25 Nov '17

Module: kamailio Branch: master Commit: 6e680c71b6a5d1571a38023427335922946a4160 URL: https://github.com/kamailio/kamailio/commit/6e680c71b6a5d1571a3802342733592… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-25T09:04:54+01:00 xmlrpc: define _XOPEN_SOURCE to 600 - needed for snprintf() and variants - reported by GH #1312 --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/6e680c71b6a5d1571a3802342733592… Patch: https://github.com/kamailio/kamailio/commit/6e680c71b6a5d1571a3802342733592… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index 2e7c644279..7b0066d988 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -18,16 +18,28 @@ * with this program; if not, write to the Free Software Foundation, Inc., 59 * Temple Place, Suite 330, Boston, MA 02111-1307 USA */ -/*This define breaks on Solaris OS */ + +/** + * make strptime available + * use 600 for 'Single UNIX Specification, Version 3' + * _XOPEN_SOURCE creates conflict in header definitions in Solaris + */ #ifndef __OS_solaris -#define _XOPEN_SOURCE 4 /* strptime */ + #define _XOPEN_SOURCE 600 /* glibc2 on linux, bsd */ + #define _BSD_SOURCE 1 /* needed on linux to "fix" the effect + * of the above define on + * features.h/unistd.h syscall() */ + #define _DEFAULT_SOURCE 1 /* _BSD_SOURCE is deprecated */ + #define _DARWIN_C_SOURCE 1 + + #define _SVID_SOURCE 1 /* timegm for old glib */ +#else + #define _XOPEN_SOURCE_EXTENDED 1 /* solaris */ #endif -#define _XOPEN_SOURCE_EXTENDED 1 /* solaris */ -#define _SVID_SOURCE 1 /* timegm */ -#define _DEFAULT_SOURCE 1 /* _SVID_SOURCE is deprecated */ -#include <strings.h> #include <time.h> + +#include <strings.h> #include <string.h> #include <stdlib.h> #include <stdio.h>

1 0

git:5.1:0ef5bef4: pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject
by Daniel-Constantin Mierla 25 Nov '17

25 Nov '17

Module: kamailio Branch: 5.1 Commit: 0ef5bef4738af52a8a7b173cfd662a04a4d568dd URL: https://github.com/kamailio/kamailio/commit/0ef5bef4738af52a8a7b173cfd662a0… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-25T08:19:59+01:00 pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject --- Added: .gitmodules Added: pkg/docker Modified: pkg/kamailio/alpine/APKBUILD Removed: pkg/kamailio/alpine_docker/Dockerfile Removed: pkg/kamailio/alpine_docker/README.md Removed: pkg/kamailio/alpine_docker/build.sh Removed: pkg/kamailio/alpine_docker/hooks/pre_build --- Diff: https://github.com/kamailio/kamailio/commit/0ef5bef4738af52a8a7b173cfd662a0… Patch: https://github.com/kamailio/kamailio/commit/0ef5bef4738af52a8a7b173cfd662a0…

1 0

[kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1330)
by sergey-safarov 25 Nov '17

25 Nov '17

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1330 -- Commit Summary -- * pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject -- File Changes -- A .gitmodules (3) A pkg/docker (1) M pkg/kamailio/alpine/APKBUILD (1) D pkg/kamailio/alpine_docker/Dockerfile (5) D pkg/kamailio/alpine_docker/README.md (85) D pkg/kamailio/alpine_docker/build.sh (144) D pkg/kamailio/alpine_docker/hooks/pre_build (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1330.patch https://github.com/kamailio/kamailio/pull/1330.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1330

2 1

git:5.0:2043ab77: pkg/kamailio/obs: Fixed build of lua module
by Daniel-Constantin Mierla 25 Nov '17

25 Nov '17

Module: kamailio Branch: 5.0 Commit: 2043ab77af5f6e3fe25bd402dc24a2449cffa67e URL: https://github.com/kamailio/kamailio/commit/2043ab77af5f6e3fe25bd402dc24a24… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-25T08:19:35+01:00 pkg/kamailio/obs: Fixed build of lua module --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/2043ab77af5f6e3fe25bd402dc24a24… Patch: https://github.com/kamailio/kamailio/commit/2043ab77af5f6e3fe25bd402dc24a24… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 4cf0d11441..1d0a01af83 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -11,6 +11,7 @@ %bcond_without http_async_client %bcond_without jansson %bcond_without json +%bcond_without lua %bcond_without kazoo %bcond_without memcached %bcond_without perl @@ -29,6 +30,7 @@ %bcond_without http_async_client %bcond_without jansson %bcond_without json +%bcond_without lua %bcond_without kazoo %bcond_without memcached %bcond_without perl @@ -47,6 +49,7 @@ %bcond_without http_async_client %bcond_without jansson %bcond_without json +%bcond_without lua %bcond_without kazoo %bcond_without memcached %bcond_without perl @@ -65,6 +68,7 @@ %bcond_with http_async_client %bcond_with jansson %bcond_with json +%bcond_without lua %bcond_with kazoo %bcond_without memcached %bcond_without perl @@ -84,6 +88,7 @@ %bcond_without http_async_client %bcond_without jansson %bcond_without json +%bcond_without lua %bcond_without kazoo %bcond_without memcached %bcond_without perl @@ -102,6 +107,7 @@ %bcond_without http_async_client %bcond_without jansson %bcond_without json +%bcond_without lua %bcond_with kazoo %bcond_without memcached %bcond_without perl @@ -120,6 +126,7 @@ %bcond_with http_async_client %bcond_with jansson %bcond_with json +%bcond_with lua %bcond_with kazoo %bcond_with memcached %bcond_with perl @@ -138,6 +145,7 @@ %bcond_with http_async_client %bcond_with jansson %bcond_with json +%bcond_with lua %bcond_with kazoo %bcond_with memcached %bcond_without perl

1 0

git:5.0:50e1a0d1: Revert "pkg/obs: enable the same modules for RHEL 7 as for Centos 7"
by Daniel-Constantin Mierla 25 Nov '17

25 Nov '17

Module: kamailio Branch: 5.0 Commit: 50e1a0d1837ce319abd57c73991b2ec00499da7a URL: https://github.com/kamailio/kamailio/commit/50e1a0d1837ce319abd57c73991b2ec… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-25T08:19:35+01:00 Revert "pkg/obs: enable the same modules for RHEL 7 as for Centos 7" This reverts commit cb42b9881b3d1f90f3cb54765eef65ce9d773f92. --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/50e1a0d1837ce319abd57c73991b2ec… Patch: https://github.com/kamailio/kamailio/commit/50e1a0d1837ce319abd57c73991b2ec… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 9f0b2a9f12..4cf0d11441 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -132,18 +132,18 @@ %if 0%{?rhel} == 7 && 0%{?centos_ver} != 7 %define dist_name rhel %define dist_version %{?rhel} -%bcond_without cnxcc +%bcond_with cnxcc %bcond_with dnssec -%bcond_without geoip -%bcond_without http_async_client -%bcond_without jansson -%bcond_without json -%bcond_without kazoo -%bcond_without memcached +%bcond_with geoip +%bcond_with http_async_client +%bcond_with jansson +%bcond_with json +%bcond_with kazoo +%bcond_with memcached %bcond_without perl %bcond_without redis -%bcond_without sctp -%bcond_without websocket +%bcond_with sctp +%bcond_with websocket %bcond_without xmlrpc %endif

1 0

[kamailio/kamailio] pkg/kamailio/obs: Fixed lua module build (#1317)
by sergey-safarov 25 Nov '17

25 Nov '17

Reverted commit cb42b9881b3d1f90f3cb54765eef65ce9d773f92 Fixed lua module build You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1317 -- Commit Summary -- * Revert "pkg/obs: enable the same modules for RHEL 7 as for Centos 7" * pkg/kamailio/obs: Fixed build of lua module -- File Changes -- M pkg/kamailio/obs/kamailio.spec (26) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1317.patch https://github.com/kamailio/kamailio/pull/1317.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1317

2 2

← Newer
1
...
12
13
14
15
16
17
18
...
49
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2017