Module: kamailio
Branch: master
Commit: 35985c78a502731bc8005688a1cc50af348aec71
URL: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2017-11-22T19:31:36+01:00
modules: readme files regenerated - dialog ... [skip ci]
---
Modified: src/modules/dialog/README
---
Diff: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a…
Patch: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a…
---
diff --git a/src/modules/dialog/README b/src/modules/dialog/README
index 0b4e3c1acb..03d531fb3c 100644
--- a/src/modules/dialog/README
+++ b/src/modules/dialog/README
@@ -1386,16 +1386,16 @@ unset_dlg_profile("caller","$fu");
7.3. is_in_profile(profile,[value])
- Checks if the current dialog belongs to a profile. If the profile
- supports values, the check can be reinforced to take into account a
- specific value, if the dialog was inserted into the profile for a
- specific value. If no value is passed, only the membership of the
- dialog in the profile per se is checked. Note that if the profile does
- not support values, the value parameter will be silently discarded.
+ Checks if the current dialog belongs to a profile. If the profile is
+ defined with values, then the check is also matching with the specific
+ value provided as parameter.
+
+ Note that if the profile is not defined with support for values, the
+ value parameter will be silently discarded.
Meaning of the parameters is as follows:
* profile - name of the profile to be checked against;
- * value (optional) - string value to further restrict the check.
+ * value (optional) - string value to be matched during the check.
Pseudo-variables are supported.
This function can be used from REQUEST_ROUTE, BRANCH_ROUTE, REPLY_ROUTE
Documentation:
7.3. is_in_profile(profile,[value])
Checks if the current dialog belongs to a profile. If the profile supports values, the check can be reinforced to take into account a specific value, if the dialog was inserted into the profile for a specific value. **If no value is passed, only the membership of the dialog in the profile per se is checked.** Note that if the profile does not support values, the value parameter will be silently discarded.
Code:
```
static int w_is_in_profile_helper(sip_msg_t *msg,
struct dlg_profile_table *profile, str *value)
{
if (profile->has_value) {
if (value==NULL || value->len<=0) {
LM_ERR("invalid value parameter\n");
return -1;
}
return is_dlg_in_profile( msg, profile, value);
} else {
return is_dlg_in_profile( msg, profile, NULL);
}
}
```
Expected result: Documentation should be corrected, or even better, code should be updated to perform as documented.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1320
Module: kamailio
Branch: master
Commit: d319c449c8c15334ed913633cfece869a7d955aa
URL: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2017-11-22T19:15:16+01:00
dialog: proper description of is_in_profile() to match the code
- reported by GH #1320
---
Modified: src/modules/dialog/doc/dialog_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86…
Patch: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86…
---
diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml
index e0041f75ed..4e7a654b2f 100644
--- a/src/modules/dialog/doc/dialog_admin.xml
+++ b/src/modules/dialog/doc/dialog_admin.xml
@@ -1608,11 +1608,12 @@ unset_dlg_profile("caller","$fu");
</title>
<para>
Checks if the current dialog belongs to a profile. If the profile
- supports values, the check can be reinforced to take into account a
- specific value, if the dialog was inserted into the profile for a
- specific value. If no value is passed, only the membership of
- the dialog in the profile per se is checked. Note that if the profile does
- not support values, the value parameter will be silently discarded.
+ is defined with values, then the check is also matching with the
+ specific value provided as parameter.
+ </para>
+ <para>
+ Note that if the profile is not defined with support for values, the
+ value parameter will be silently discarded.
</para>
<para>Meaning of the parameters is as follows:</para>
<itemizedlist>
@@ -1623,13 +1624,13 @@ unset_dlg_profile("caller","$fu");
</listitem>
<listitem>
<para><emphasis>value</emphasis> (optional) - string value to
- further restrict the check. Pseudo-variables are supported.
+ be matched during the check. Pseudo-variables are supported.
</para>
</listitem>
</itemizedlist>
<para>
This function can be used from REQUEST_ROUTE, BRANCH_ROUTE,
- REPLY_ROUTE and FAILURE_ROUTE.
+ REPLY_ROUTE and FAILURE_ROUTE.
</para>
<example>
<title><function>is_in_profile</function> usage</title>
Typo of "$T_branch_idx]" returns always nil - Error then "attempt to concatenate a nil value" from lua. Reorder the ] into a string.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1324
-- Commit Summary --
* fix typo in function ksr_branch_manage
-- File Changes --
M misc/examples/kemi/kamailio-basic-kemi-lua.lua (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1324.patchhttps://github.com/kamailio/kamailio/pull/1324.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1324
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1315
-- Commit Summary --
* core: removing the condition for second record_route ipv6 header
-- File Changes --
M src/core/msg_translator.c (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1315.patchhttps://github.com/kamailio/kamailio/pull/1315.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1315