sr-dev December 2017

sr-dev@lists.kamailio.org

26 participants
475 discussions

Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,jessie,slave #984
by jenkins＠sipwise.com 08 Dec '17

08 Dec '17

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> ------------------------------------------ [...truncated 396.18 KB...] CC (gcc) [M ims_charging.so] diameter_ro.o CC (gcc) [M ims_charging.so] ro_db_handler.o CC (gcc) [M ims_charging.so] ro_fixup.o CC (gcc) [M ims_charging.so] Ro_data.o make[4]: 'libkamailio_ims.so.0.1' is up to date. make[4]: 'libsrdb1.so.1.0' is up to date. LD (gcc) [M ims_charging.so] ims_charging.so CC (gcc) [M ims_ocs.so] ims_ocs_mod.o CC (gcc) [M ims_ocs.so] ocs_avp_helper.o CC (gcc) [M ims_ocs.so] msg_faker.o make[4]: 'libkamailio_ims.so.0.1' is up to date. LD (gcc) [M ims_ocs.so] ims_ocs.so CC (gcc) [M ims_diameter_server.so] ims_diameter_server.o CC (gcc) [M ims_diameter_server.so] cJSON.o CC (gcc) [M ims_diameter_server.so] avp_helper.o make[4]: 'libkamailio_ims.so.0.1' is up to date. LD (gcc) [M ims_diameter_server.so] ims_diameter_server.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="ksctp" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M sctp.so] sctp_mod.o CC (gcc) [M sctp.so] sctp_rpc.o CC (gcc) [M sctp.so] sctp_options.o CC (gcc) [M sctp.so] sctp_stats.o CC (gcc) [M sctp.so] sctp_server.o LD (gcc) [M sctp.so] sctp.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kjava" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M app_java.so] java_msgobj.o CC (gcc) [M app_java.so] java_support.o CC (gcc) [M app_java.so] java_iface.o CC (gcc) [M app_java.so] java_native_methods.o CC (gcc) [M app_java.so] app_java_mod.o CC (gcc) [M app_java.so] java_sig_parser.o CC (gcc) [M app_java.so] utils.o LD (gcc) [M app_java.so] app_java.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="ktls" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M crypto.so] crypto_uuid.o CC (gcc) [M crypto.so] crypto_mod.o LD (gcc) [M crypto.so] crypto.so CC (gcc) [M tls.so] tls_domain.o CC (gcc) [M tls.so] tls_locking.o CC (gcc) [M tls.so] tls_server.o CC (gcc) [M tls.so] tls_cfg.o CC (gcc) [M tls.so] tls_util.o CC (gcc) [M tls.so] tls_select.o CC (gcc) [M tls.so] tls_dump_vf.o CC (gcc) [M tls.so] tls_init.o CC (gcc) [M tls.so] tls_config.o CC (gcc) [M tls.so] tls_mod.o CC (gcc) [M tls.so] tls_bio.o CC (gcc) [M tls.so] tls_rpc.o CC (gcc) [M tls.so] tls_ct_wrq.o CC (gcc) [M tls.so] tls_verify.o LD (gcc) [M tls.so] tls.so CC (gcc) [M auth_identity.so] auth_http.o CC (gcc) [M auth_identity.so] auth_hdrs.o CC (gcc) [M auth_identity.so] auth_tables.o CC (gcc) [M auth_identity.so] auth_identity.o CC (gcc) [M auth_identity.so] auth_crypt.o CC (gcc) [M auth_identity.so] auth_dynstr.o LD (gcc) [M auth_identity.so] auth_identity.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="koutbound" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M outbound.so] config.o CC (gcc) [M outbound.so] outbound_mod.o LD (gcc) [M outbound.so] outbound.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kwebsocket" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M websocket.so] websocket.o CC (gcc) [M websocket.so] ws_frame.o CC (gcc) [M websocket.so] config.o CC (gcc) [M websocket.so] ws_handshake.o CC (gcc) [M websocket.so] ws_conn.o LD (gcc) [M websocket.so] websocket.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kautheph" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M auth_ephemeral.so] checks.o CC (gcc) [M auth_ephemeral.so] authorize.o CC (gcc) [M auth_ephemeral.so] auth_ephemeral_mod.o LD (gcc) [M auth_ephemeral.so] auth_ephemeral.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kdnssec" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M dnssec.so] dnssec_func.o CC (gcc) [M dnssec.so] dnssec_mod.o LD (gcc) [M dnssec.so] dnssec.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kkazoo" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M kazoo.so] const.o CC (gcc) [M kazoo.so] kz_trans.o CC (gcc) [M kazoo.so] kz_amqp.o CC (gcc) [M kazoo.so] kz_hash.o CC (gcc) [M kazoo.so] kazoo.o CC (gcc) [M kazoo.so] kz_json.o CC (gcc) [M kazoo.so] kz_pua.o CC (gcc) [M kazoo.so] kz_fixup.o make[4]: 'libsrdb1.so.1.0' is up to date. LD (gcc) [M kazoo.so] kazoo.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kcnxcc" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M cnxcc.so] cnxcc_redis.o CC (gcc) [M cnxcc.so] cnxcc_sip_msg_faker.o CC (gcc) [M cnxcc.so] cnxcc_check.o CC (gcc) [M cnxcc.so] cnxcc_select.o CC (gcc) [M cnxcc.so] cnxcc.o CC (gcc) [M cnxcc.so] cnxcc_mod.o CC (gcc) [M cnxcc.so] cnxcc_rpc.o make[4]: 'libsrdb1.so.1.0' is up to date. LD (gcc) [M cnxcc.so] cnxcc.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kerlang" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M erlang.so] erl_helpers.o CC (gcc) [M erlang.so] handle_rpc.o CC (gcc) [M erlang.so] pv_list.o CC (gcc) [M erlang.so] pv_ref.o CC (gcc) [M erlang.so] handle_emsg.o CC (gcc) [M erlang.so] cnode.o CC (gcc) [M erlang.so] pv_pid.o CC (gcc) [M erlang.so] pv_tuple.o CC (gcc) [M erlang.so] pv_xbuff.o CC (gcc) [M erlang.so] erlang_mod.o CC (gcc) [M erlang.so] pv_atom.o CC (gcc) [M erlang.so] epmd.o CC (gcc) [M erlang.so] erl_api.o CC (gcc) [M erlang.so] worker.o LD (gcc) [M erlang.so] erlang.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="ksystemd" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M log_systemd.so] journal_send.o CC (gcc) [M log_systemd.so] log_systemd_mod.o LD (gcc) [M log_systemd.so] log_systemd.so make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make every-module group_include="kphonenum" make[1]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' /usr/bin/make -C src/ every-module make[2]: Entering directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' CC (gcc) [M phonenum.so] phonenum_mod.o CC (gcc) [M phonenum.so] phonenum_pv.o Compiling cphonenumber.cpp g++ -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -Wall -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -Wno-write-strings -Wno-deprecated -Wno-unused-function -Wno-sign-compare -Wno-strict-aliasing -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -Wall -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"5.2.0-dev1"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 4.9.2"' -D__CPU_x86_64 -D__OS_linux -DSER_VER=5002000 -DCFG_DIR='"/etc/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -I/opt/local/include -DKAMAILIO_MOD_INTERFACE -DMOD_NAME='"phonenum"' -c cphonenumber.cpp -o cphonenumber.o In file included from cphonenumber.cpp:24:0: /usr/include/phonenumbers/geocoding/phonenumber_offline_geocoder.h:23:59: fatal error: unicode/locid.h: No such file or directory #include <unicode/locid.h> // NOLINT(build/include_order) ^ compilation terminated. Makefile:22: recipe for target 'cphonenumber.o' failed make[3]: *** [cphonenumber.o] Error 1 Makefile:511: recipe for target 'modules' failed make[2]: *** [modules] Error 1 make[2]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie/src' Makefile:27: recipe for target 'every-module' failed make[1]: *** [every-module] Error 2 make[1]: Leaving directory '/tmp/buildd/kamailio-5.2.0~dev1+0~20171208114049.988+jessie' debian/rules:137: recipe for target 'build-stamp' failed make: *** [build-stamp] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 E: Failed autobuilding of package I: user script /var/cache/pbuilder/build/cow.20911/tmp/hooks/C10shell starting ┌──────────────────────────────────────────────────────────────────────────────┐ │ FTBFS - problem with building Debian package │ └──────────────────────────────────────────────────────────────────────────────┘ ┌──────────────────────────────────────────────────────────────────────────────┐ │ DEB_KEEP_BUILD_ENV is not set to 'true', not keeping build environment │ └──────────────────────────────────────────────────────────────────────────────┘ I: user script /var/cache/pbuilder/build/cow.20911/tmp/hooks/C10shell finished I: unmounting /tmp/apt-jdg_IOYBHW filesystem I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem -> Cleaning COW directory forking: rm -rf /var/cache/pbuilder/build//cow.20911 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /var/run/lock/jessie-amd64.building.14974 + '[' -r /var/run/lock/jessie-amd64.update.14974 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…'> + '[' -n /tmp/tmp.zAfp9rLC9c ']' + rm -rf /tmp/tmp.zAfp9rLC9c + '[' -n /tmp/apt-jdg_IOYBHW ']' + sudo rm -rf /tmp/apt-jdg_IOYBHW + '[' -n 12017 ']' ++ sed -e 's/^\([0-9]*\).*/\1/' + SECONDS=374 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Fri Dec 8 12:31:19 UTC 2017 [running 374 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Fri Dec 8 12:31:19 UTC 2017 [running 374 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

1 1

git:5.1:a0bbb141: sipdump: safety check for received address
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: a0bbb14169eb82ffe5936c0fe73a5cc943407e83 URL: https://github.com/kamailio/kamailio/commit/a0bbb14169eb82ffe5936c0fe73a5cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:55:42+01:00 sipdump: safety check for received address (cherry picked from commit f6a05336de65bb929854c5843e5aa821901b63eb) --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a0bbb14169eb82ffe5936c0fe73a5cc… Patch: https://github.com/kamailio/kamailio/commit/a0bbb14169eb82ffe5936c0fe73a5cc… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index c95e0b091a..3247d71a70 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -229,7 +229,8 @@ int ki_sipdump_send(sip_msg_t *msg, str *stag) } sdi.af.len = 4; - if(msg->rcv.bind_address->address.af==AF_INET6) { + if(msg->rcv.bind_address!=NULL + && msg->rcv.bind_address->address.af==AF_INET6) { sdi.af.s = "ipv6"; } else { sdi.af.s = "ipv4"; @@ -298,7 +299,8 @@ int sipdump_msg_received(sr_event_param_t *evp) sdi.dst_port = (int)evp->rcv->bind_address->port_no; } sdi.af.len = 4; - if(evp->rcv->bind_address->address.af==AF_INET6) { + if(evp->rcv->bind_address!=NULL + && evp->rcv->bind_address->address.af==AF_INET6) { sdi.af.s = "ipv6"; } else { sdi.af.s = "ipv4";

1 0

git:5.1:b8698724: rls: avoid walking a null string
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: b8698724134095814339701c19f0d02bb37caa89 URL: https://github.com/kamailio/kamailio/commit/b8698724134095814339701c19f0d02… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:55:31+01:00 rls: avoid walking a null string (cherry picked from commit 5f62d05180c7148f3899732dfc0da44034a314f8) --- Modified: src/modules/rls/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/b8698724134095814339701c19f0d02… Patch: https://github.com/kamailio/kamailio/commit/b8698724134095814339701c19f0d02… --- diff --git a/src/modules/rls/notify.c b/src/modules/rls/notify.c index 9b5c3a5806..55a7019032 100644 --- a/src/modules/rls/notify.c +++ b/src/modules/rls/notify.c @@ -1220,7 +1220,7 @@ int parse_xcap_uri(char *uri, str *host, unsigned short *port, str *path) } } - while(path->s[path->len] != '\0') path->len++; + while(path->s != NULL && path->s[path->len] != '\0') path->len++; return 1; }

1 0

git:5.1:7b4a653a: pua: safety check for params values
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: 7b4a653abef51afe6a6289048ed989ba969c1310 URL: https://github.com/kamailio/kamailio/commit/7b4a653abef51afe6a6289048ed989b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:55:22+01:00 pua: safety check for params values (cherry picked from commit a009a5bf4f145b4e877e5ba41d218607c30849ec) --- Modified: src/modules/pua/send_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/7b4a653abef51afe6a6289048ed989b… Patch: https://github.com/kamailio/kamailio/commit/7b4a653abef51afe6a6289048ed989b… --- diff --git a/src/modules/pua/send_subscribe.c b/src/modules/pua/send_subscribe.c index 89b597a77a..b75290b936 100644 --- a/src/modules/pua/send_subscribe.c +++ b/src/modules/pua/send_subscribe.c @@ -803,7 +803,7 @@ ua_pres_t* subscribe_cbparam(subs_info_t* subs, int ua_flag) hentity->contact.len= subs->contact->len; size+= subs->contact->len; - if(subs->outbound_proxy) + if(subs->outbound_proxy && subs->outbound_proxy->s) { hentity->outbound_proxy= (str*)((char*)hentity+ size); size+= sizeof(str); @@ -821,7 +821,7 @@ ua_pres_t* subscribe_cbparam(subs_info_t* subs, int ua_flag) { CONT_COPY(hentity, hentity->id, subs->id); } - if(subs->extra_headers) + if(subs->extra_headers && hentity->extra_headers->s) { hentity->extra_headers= (str*)((char*)hentity+ size); size+= sizeof(str);

1 0

git:5.1:968722b7: auth_ephemeral: init the return code
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: 968722b7b6769c1416cc35b23969b06ce3416181 URL: https://github.com/kamailio/kamailio/commit/968722b7b6769c1416cc35b23969b06… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:55:14+01:00 auth_ephemeral: init the return code (cherry picked from commit 236b0b4bca0ce8931bd06fd88720f3293b651682) --- Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/968722b7b6769c1416cc35b23969b06… Patch: https://github.com/kamailio/kamailio/commit/968722b7b6769c1416cc35b23969b06… --- diff --git a/src/modules/auth_ephemeral/authorize.c b/src/modules/auth_ephemeral/authorize.c index 8e4489947c..745f12d7ab 100644 --- a/src/modules/auth_ephemeral/authorize.c +++ b/src/modules/auth_ephemeral/authorize.c @@ -213,7 +213,7 @@ static inline int digest_authenticate(struct sip_msg *_m, str *_realm, hdr_types_t _hftype, str *_method) { struct hdr_field* h; - auth_cfg_result_t ret; + auth_cfg_result_t ret = AUTH_ERROR; auth_result_t rauth; struct secret *secret_struct; str username; @@ -548,4 +548,4 @@ int autheph_authenticate(struct sip_msg *_m, char *_username, char *_password) } return ki_autheph_authenticate(_m, &susername, &spassword); -} \ No newline at end of file +}

1 0

git:5.1:d8696328: tls: safety checks for select values
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: d86963283cd7a58d94929959ca09ed31ae9bd116 URL: https://github.com/kamailio/kamailio/commit/d86963283cd7a58d94929959ca09ed3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:55:06+01:00 tls: safety checks for select values (cherry picked from commit 084364becd2f6f5d6e620721cb0837466c3a2f31) --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/d86963283cd7a58d94929959ca09ed3… Patch: https://github.com/kamailio/kamailio/commit/d86963283cd7a58d94929959ca09ed3… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index c1c44c3763..ba765ff755 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -198,7 +198,11 @@ static int get_cipher(str* res, sip_msg_t* msg) ERR("Cipher name too long\n"); goto err; } - memcpy(buf, cipher.s, cipher.len); + if(cipher.s!=NULL && cipher.len>0) { + memcpy(buf, cipher.s, cipher.len); + } else { + buf[0] = '\0'; + } res->s = buf; res->len = cipher.len; tcpconn_put(c); @@ -298,7 +302,11 @@ static int get_version(str* res, sip_msg_t* msg) ERR("Version string too long\n"); goto err; } - memcpy(buf, version.s, version.len); + if(version.s!=NULL && version.len>0) { + memcpy(buf, version.s, version.len); + } else { + buf[0] = '\0'; + } res->s = buf; res->len = version.len; tcpconn_put(c);

1 0

git:5.1:9c4c8b14: core: select - init proto string to udp
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: 9c4c8b14ddcb26b9514fb91f660b18ba12ea4572 URL: https://github.com/kamailio/kamailio/commit/9c4c8b14ddcb26b9514fb91f660b18b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:54:56+01:00 core: select - init proto string to udp (cherry picked from commit da31e70a2c63454dd7126d6ed47be977f36c73f0) --- Modified: src/core/select_core.c --- Diff: https://github.com/kamailio/kamailio/commit/9c4c8b14ddcb26b9514fb91f660b18b… Patch: https://github.com/kamailio/kamailio/commit/9c4c8b14ddcb26b9514fb91f660b18b… --- diff --git a/src/core/select_core.c b/src/core/select_core.c index d1f2ae7b4d..112dee489e 100644 --- a/src/core/select_core.c +++ b/src/core/select_core.c @@ -1286,7 +1286,7 @@ ABSTRACT_F(select_dst) ABSTRACT_F(select_rcv) int select_ip_port(str* res, select_t* s, struct sip_msg* msg) { - str ip_str=STR_NULL, port_str=STR_NULL, proto_str=STR_NULL; + str ip_str=STR_NULL, port_str=STR_NULL, proto_str=str_init("udp"); int param, pos;

1 0

git:5.1:8f1872a2: core: receive - clang format the code
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: 8f1872a27b406cfcd3300595c06ab53cb79eb082 URL: https://github.com/kamailio/kamailio/commit/8f1872a27b406cfcd3300595c06ab53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:54:47+01:00 core: receive - clang format the code (cherry picked from commit b9bbeeb11df841845d9f00897008fedf2c2eb9b6) --- Modified: src/core/receive.c --- Diff: https://github.com/kamailio/kamailio/commit/8f1872a27b406cfcd3300595c06ab53… Patch: https://github.com/kamailio/kamailio/commit/8f1872a27b406cfcd3300595c06ab53…

1 0

git:5.1:edb3c0ab: db2_ops: safety check for input parameter
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: edb3c0abfc2712aef8e6ec562aa0d2170dc81120 URL: https://github.com/kamailio/kamailio/commit/edb3c0abfc2712aef8e6ec562aa0d21… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:54:38+01:00 db2_ops: safety check for input parameter (cherry picked from commit 1be7a6903ace085e7518fa0d358a4ca899ee938f) --- Modified: src/modules/db2_ops/db2_ops.c Modified: src/modules/jsonrpcc/jsonrpc_io.c --- Diff: https://github.com/kamailio/kamailio/commit/edb3c0abfc2712aef8e6ec562aa0d21… Patch: https://github.com/kamailio/kamailio/commit/edb3c0abfc2712aef8e6ec562aa0d21… --- diff --git a/src/modules/db2_ops/db2_ops.c b/src/modules/db2_ops/db2_ops.c index 647faceb1c..dca2c81a1c 100644 --- a/src/modules/db2_ops/db2_ops.c +++ b/src/modules/db2_ops/db2_ops.c @@ -201,6 +201,9 @@ static int split_fields(char *part, int *n, struct xlstr **strs) { int i, res; char *c, *fld; + if(part==NULL || *part=='\0') + return -1; + *n = 0; *strs = 0; c = part; diff --git a/src/modules/jsonrpcc/jsonrpc_io.c b/src/modules/jsonrpcc/jsonrpc_io.c index ae96ace9c0..ddefd1b3a1 100644 --- a/src/modules/jsonrpcc/jsonrpc_io.c +++ b/src/modules/jsonrpcc/jsonrpc_io.c @@ -219,6 +219,7 @@ void cmd_pipe_cb(int fd, short event, void *arg) if (timerfd_settime(timerfd, 0, itime, NULL) == -1) { LM_ERR("Could not set timer."); + pkg_free(itime); goto error; } pkg_free(itime);

1 0

git:5.1:e5d96dec: db_postgres: avoid potential double free if sb url parsing fails
by Daniel-Constantin Mierla 08 Dec '17

08 Dec '17

Module: kamailio Branch: 5.1 Commit: e5d96dec3f986a2d98ea5e3c09da1fac3f45c14a URL: https://github.com/kamailio/kamailio/commit/e5d96dec3f986a2d98ea5e3c09da1fa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-08T16:54:29+01:00 db_postgres: avoid potential double free if sb url parsing fails (cherry picked from commit 3614b4e66d1b57dc722139fc0e1ccd8d838f13ee) --- Modified: src/modules/db_postgres/pg_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/e5d96dec3f986a2d98ea5e3c09da1fa… Patch: https://github.com/kamailio/kamailio/commit/e5d96dec3f986a2d98ea5e3c09da1fa… --- diff --git a/src/modules/db_postgres/pg_uri.c b/src/modules/db_postgres/pg_uri.c index 6170de310e..3e4f9a32bc 100644 --- a/src/modules/db_postgres/pg_uri.c +++ b/src/modules/db_postgres/pg_uri.c @@ -255,8 +255,10 @@ static int parse_postgres_uri(struct pg_uri *res, str *uri) return 0; err: - if(prev_token) - pkg_free(prev_token); + if(prev_token) { + if(res==NULL || (res->username!=prev_token && res->host!=prev_token)) + pkg_free(prev_token); + } if(res == NULL) return -1; if(res->username) {

1 0

← Newer
1
...
31
32
33
34
35
36
37
...
48
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2017