sr-dev December 2017

sr-dev@lists.kamailio.org

26 participants
475 discussions

Kamailio 5.1 nightly (rc2) crashing - udp_rcv_loop(): print buffer building failed

by George Diamantopoulos

Hello, I've just installed kamailio 5.1 nightly from the debian repo for stretch. I didn't change anything in the configuration compared to 5.0.4 (which I was testing previously), apart from the database structure as found in the wiki for upgrading from 5.0.x. Now kamailio crashes after a while, with the following output in the logs: Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 3(2502) ERROR: <core> [core/udp_server.c:481]: udp_rcv_loop(): print buffer building failed Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 26 Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) DEBUG: <core> [core/tcp_main.c:3512]: handle_ser_child(): dead child 3, pid 2502 (shutting down?) Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) DEBUG: <core> [core/io_wait.h:602]: io_watch_del(): DBG: io_watch_del (0x55ae7132ffc0, 26, -1, 0x0) fd_no=126 called Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) ALERT: <core> [main.c:741]: handle_sigs(): child process 2502 exited normally, status=255 Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) INFO: <core> [main.c:771]: handle_sigs(): terminating due to SIGCHLD Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) DEBUG: <core> [main.c:773]: handle_sigs(): terminating due to SIGCHLD Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 118(2617) INFO: <core> [main.c:826]: sig_usr(): signal 15 received Let me know if I can somehow help dissect this issue, I don't really know where to start. Thanks. BR, George

6 years, 11 months

git:master:e7d1e960: crypto: exported functions to kemi interface

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e7d1e96007683efcc193e0f6df16a1acb02be6b8 URL: https://github.com/kamailio/kamailio/commit/e7d1e96007683efcc193e0f6df16a1a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T15:13:47+01:00 crypto: exported functions to kemi interface --- Modified: src/modules/crypto/crypto_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e7d1e96007683efcc193e0f6df16a1a… Patch: https://github.com/kamailio/kamailio/commit/e7d1e96007683efcc193e0f6df16a1a…

6 years, 11 months

git:master:2b7ae0f0: dmq: exported functions to kemi framework

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2b7ae0f01ae7f9ee9a9ccf12ef9ffad24a76764f URL: https://github.com/kamailio/kamailio/commit/2b7ae0f01ae7f9ee9a9ccf12ef9ffad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T13:19:17+01:00 dmq: exported functions to kemi framework --- Modified: src/modules/dmq/bind_dmq.c Modified: src/modules/dmq/bind_dmq.h Modified: src/modules/dmq/dmq.c Modified: src/modules/dmq/dmq.h Modified: src/modules/dmq/dmq_funcs.c Modified: src/modules/dmq/dmq_funcs.h Modified: src/modules/dmq/dmqnode.c Modified: src/modules/dmq/dmqnode.h Modified: src/modules/dmq/message.c Modified: src/modules/dmq/message.h Modified: src/modules/dmq/notification_peer.c Modified: src/modules/dmq/notification_peer.h Modified: src/modules/dmq/peer.c Modified: src/modules/dmq/peer.h Modified: src/modules/dmq/worker.c Modified: src/modules/dmq/worker.h --- Diff: https://github.com/kamailio/kamailio/commit/2b7ae0f01ae7f9ee9a9ccf12ef9ffad… Patch: https://github.com/kamailio/kamailio/commit/2b7ae0f01ae7f9ee9a9ccf12ef9ffad…

6 years, 11 months

git:master:727b5c5f: dmq: use core fixup helper functions directly

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 727b5c5fed1e0972b80f005a801089a4afa2f114 URL: https://github.com/kamailio/kamailio/commit/727b5c5fed1e0972b80f005a801089a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T12:10:24+01:00 dmq: use core fixup helper functions directly --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/727b5c5fed1e0972b80f005a801089a… Patch: https://github.com/kamailio/kamailio/commit/727b5c5fed1e0972b80f005a801089a… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index f06111f830..b01e4604df 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -85,24 +85,22 @@ dmq_peer_t* dmq_notification_peer = NULL; static int mod_init(void); static int child_init(int); static void destroy(void); -static int handle_dmq_fixup(void** param, int param_no); -static int send_dmq_fixup(void** param, int param_no); -static int bcast_dmq_fixup(void** param, int param_no); static cmd_export_t cmds[] = { - {"dmq_handle_message", (cmd_function)dmq_handle_message, 0, handle_dmq_fixup, 0, - REQUEST_ROUTE}, - {"dmq_send_message", (cmd_function)cfg_dmq_send_message, 4, send_dmq_fixup, 0, - ANY_ROUTE}, - {"dmq_bcast_message", (cmd_function)cfg_dmq_bcast_message, 3, bcast_dmq_fixup, 0, - ANY_ROUTE}, - {"dmq_t_replicate", (cmd_function)cfg_dmq_t_replicate, 0, 0, 0, - REQUEST_ROUTE}, - {"dmq_t_replicate", (cmd_function)cfg_dmq_t_replicate, 1, fixup_spve_null, 0, - REQUEST_ROUTE}, - {"dmq_is_from_node", (cmd_function)cfg_dmq_is_from_node, 0, 0, 0, - REQUEST_ROUTE}, - {"bind_dmq", (cmd_function)bind_dmq, 0, 0, 0}, + {"dmq_handle_message", (cmd_function)dmq_handle_message, 0, + 0, 0, REQUEST_ROUTE}, + {"dmq_send_message", (cmd_function)cfg_dmq_send_message, 4, + fixup_spve_all, 0, ANY_ROUTE}, + {"dmq_bcast_message", (cmd_function)cfg_dmq_bcast_message, 3, + fixup_spve_all, 0, ANY_ROUTE}, + {"dmq_t_replicate", (cmd_function)cfg_dmq_t_replicate, 0, + 0, 0, REQUEST_ROUTE}, + {"dmq_t_replicate", (cmd_function)cfg_dmq_t_replicate, 1, + fixup_spve_null, 0, REQUEST_ROUTE}, + {"dmq_is_from_node", (cmd_function)cfg_dmq_is_from_node, 0, + 0, 0, REQUEST_ROUTE}, + {"bind_dmq", (cmd_function)bind_dmq, 0, + 0, 0, 0}, {0, 0, 0, 0, 0, 0} }; @@ -329,21 +327,6 @@ static void destroy(void) { } } -static int handle_dmq_fixup(void** param, int param_no) -{ - return 0; -} - -static int send_dmq_fixup(void** param, int param_no) -{ - return fixup_spve_null(param, 1); -} - -static int bcast_dmq_fixup(void** param, int param_no) -{ - return fixup_spve_null(param, 1); -} - static void dmq_rpc_list_nodes(rpc_t *rpc, void *c) { void *h;

6 years, 11 months

git:master:ebf570f8: topos: update contact in branch record before sending response

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ebf570f83c878363dfd1f53882de9a0f907f5971 URL: https://github.com/kamailio/kamailio/commit/ebf570f83c878363dfd1f53882de9a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T11:55:51+01:00 topos: update contact in branch record before sending response - might be updated in config execution - reported by GH #1339 --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/ebf570f83c878363dfd1f53882de9a0… Patch: https://github.com/kamailio/kamailio/commit/ebf570f83c878363dfd1f53882de9a0… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 75b6d02078..26e25b42c0 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -1081,6 +1081,9 @@ int tps_response_sent(sip_msg_t *msg) } tps_reappend_rr(msg, &btsd, &btsd.x_rr); + if(tps_storage_update_branch(msg, &mtsd, &btsd, TPS_DBU_CONTACT)<0) { + goto error; + } if(tps_storage_update_dialog(msg, &mtsd, &stsd, TPS_DBU_CONTACT)<0) { goto error1; }

6 years, 11 months

git:master:04cfb066: nat_traversal: exported functions to kemi framework

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 04cfb0662be9cc429e66b79545daf578993dab1f URL: https://github.com/kamailio/kamailio/commit/04cfb0662be9cc429e66b79545daf57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T11:23:00+01:00 nat_traversal: exported functions to kemi framework --- Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/04cfb0662be9cc429e66b79545daf57… Patch: https://github.com/kamailio/kamailio/commit/04cfb0662be9cc429e66b79545daf57… --- diff --git a/src/modules/nat_traversal/nat_traversal.c b/src/modules/nat_traversal/nat_traversal.c index ab1e33442c..ead4c696fe 100644 --- a/src/modules/nat_traversal/nat_traversal.c +++ b/src/modules/nat_traversal/nat_traversal.c @@ -66,6 +66,7 @@ #include "../../core/parser/contact/parse_contact.h" #include "../../core/counters.h" #include "../../core/rand/kam_rand.h" +#include "../../core/kemi.h" #include "../dialog/dlg_load.h" #include "../../modules/tm/tm_load.h" #include "../../modules/sl/sl.h" @@ -204,9 +205,9 @@ typedef struct Keepalive_Params // Function prototypes // -static int NAT_Keepalive(struct sip_msg *msg); -static int FixContact(struct sip_msg *msg); -static int ClientNatTest(struct sip_msg *msg, unsigned int tests); +static int w_NAT_Keepalive(struct sip_msg *msg, char *p1, char *p2); +static int w_FixContact(struct sip_msg *msg, char *p1, char *p2); +static int w_ClientNatTest(struct sip_msg *msg, char *ptests, char *p2); static bool test_private_contact(struct sip_msg *msg); static bool test_source_address(struct sip_msg *msg); @@ -270,9 +271,12 @@ static NatTest NAT_Tests[] = { sl_api_t slb; static cmd_export_t commands[] = { - {"nat_keepalive", (cmd_function)NAT_Keepalive, 0, NULL, 0, REQUEST_ROUTE}, - {"fix_contact", (cmd_function)FixContact, 0, NULL, 0, ANY_ROUTE}, - {"client_nat_test", (cmd_function)ClientNatTest, 1, fixup_uint_null, 0, ANY_ROUTE}, + {"nat_keepalive", (cmd_function)w_NAT_Keepalive, 0, NULL, 0, + REQUEST_ROUTE}, + {"fix_contact", (cmd_function)w_FixContact, 0, NULL, 0, + ANY_ROUTE}, + {"client_nat_test", (cmd_function)w_ClientNatTest, 1, fixup_igp_null, 0, + ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -1462,6 +1466,10 @@ static int NAT_Keepalive(struct sip_msg *msg) } } +static int w_NAT_Keepalive(struct sip_msg *msg, char *p1, char *p2) +{ + return NAT_Keepalive(msg); +} // Replace IP:Port in Contact field with the source address of the packet. static int FixContact(struct sip_msg *msg) @@ -1534,8 +1542,12 @@ static int FixContact(struct sip_msg *msg) return 1; } +static int w_FixContact(struct sip_msg *msg, char *p1, char *p2) +{ + return FixContact(msg); +} -static int ClientNatTest(struct sip_msg *msg, unsigned int tests) +static int ClientNatTest(struct sip_msg *msg, int tests) { int i; @@ -1548,6 +1560,17 @@ static int ClientNatTest(struct sip_msg *msg, unsigned int tests) return -1; // all failed } +static int w_ClientNatTest(struct sip_msg *msg, char *ptests, char *p2) +{ + int tests; + + if(fixup_get_ivalue(msg, (gparam_t*)ptests, &tests)<0) { + LM_ERR("failed to get tests parameter\n"); + return -1; + } + + return ClientNatTest(msg, tests); +} #define FROM_PREFIX "sip:keepalive@" #define MAX_BRANCHID 9999999 @@ -2103,3 +2126,34 @@ static int pv_get_source_uri( return 0; } + +/** + * + */ +/* clang-format off */ +static sr_kemi_t sr_kemi_nat_traversal_exports[] = { + { str_init("nat_traversal"), str_init("nat_keepalive"), + SR_KEMIP_INT, NAT_Keepalive, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("nat_traversal"), str_init("fix_contact"), + SR_KEMIP_INT, FixContact, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("nat_traversal"), str_init("client_nat_test"), + SR_KEMIP_INT, ClientNatTest, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } +}; +/* clang-format on */ + +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_nat_traversal_exports); + return 0; +} \ No newline at end of file

6 years, 11 months

git:master:3bad0073: nat_traversal: clang format the code

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3bad00732994813bc21c84d41342772783a5bddd URL: https://github.com/kamailio/kamailio/commit/3bad00732994813bc21c84d41342772… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T11:09:55+01:00 nat_traversal: clang format the code --- Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/3bad00732994813bc21c84d41342772… Patch: https://github.com/kamailio/kamailio/commit/3bad00732994813bc21c84d41342772…

6 years, 11 months

git:master:95da4cda: misc_radius: exported functions to kemi framework

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 95da4cda2c68ff25f7e14501a28cfe2ec0ebc50f URL: https://github.com/kamailio/kamailio/commit/95da4cda2c68ff25f7e14501a28cfe2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T10:54:07+01:00 misc_radius: exported functions to kemi framework --- Modified: src/modules/misc_radius/functions.c Modified: src/modules/misc_radius/functions.h Modified: src/modules/misc_radius/misc_radius.c --- Diff: https://github.com/kamailio/kamailio/commit/95da4cda2c68ff25f7e14501a28cfe2… Patch: https://github.com/kamailio/kamailio/commit/95da4cda2c68ff25f7e14501a28cfe2…

6 years, 11 months

Broken: kamailio/kamailio#5177 (master - f06e4d4)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #5177 Status: Broken Duration: 3 minutes and 55 seconds Commit: f06e4d4 (master) Author: Daniel-Constantin Mierla Message: misc_radius: use spve fixup helper instead of pvar - simplifies getting params View the changeset: https://github.com/kamailio/kamailio/compare/f283fe291917...f06e4d4b81e0 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/311735664?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

6 years, 11 months

git:master:61335063: misc_radius: fixed accessing str* params after previous commit

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 613350632c842c1775e1b5696b4cda4c96e5ba4c URL: https://github.com/kamailio/kamailio/commit/613350632c842c1775e1b5696b4cda4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-05T09:19:29+01:00 misc_radius: fixed accessing str* params after previous commit --- Modified: src/modules/misc_radius/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/613350632c842c1775e1b5696b4cda4… Patch: https://github.com/kamailio/kamailio/commit/613350632c842c1775e1b5696b4cda4… --- diff --git a/src/modules/misc_radius/functions.c b/src/modules/misc_radius/functions.c index c176084382..c10d3ce801 100644 --- a/src/modules/misc_radius/functions.c +++ b/src/modules/misc_radius/functions.c @@ -516,11 +516,11 @@ int radius_does_uri_user_host_exist(struct sip_msg *_m, str *user, str *host) } at = user_host; memcpy(at, user->s, user->len); - at += user.len; + at += user->len; *at = '@'; at++; memcpy(at, host->s, host->len); - at += host.len; + at += host->len; *at = '\0'; if(!rc_avpair_add( rh, &send, uri_attrs[SA_USER_NAME].v, user_host, -1, 0)) {

6 years, 11 months

← Newer
1
...
41
42
43
44
45
46
47
48
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2017