sr-dev February 2017

sr-dev@lists.kamailio.org

29 participants
365 discussions

Branch 5.0 created
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Hello, the GIT branch 5.0 has just been created, it will host the release series 5.0.x. To get this branch from GIT, you can use: git clone https://github.com/kamailio/kamailio.git kamailio cd kamailio git checkout -b 5.0 origin/5.0 Hopefully before the end of the month the full release of 5.0.0 will be out. >From now on, any corresponding fix has to be pushed first to master branch and then cherry-picked to branch 5.0. No new features can get in branch 5.0. Enhancements to documentation or helping tools are still allowed. If you are not sure about doing or not a backport, ask on sr-dev mailing list. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com

4 9

Jenkins build is back to normal : kamailio50-nightly-repos » i386,stretch,master #8
by jenkins＠kamailio.sipwise.com 15 Feb '17

15 Feb '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-repos/architecture=i386…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-repos » i386,stretch,master #653
by jenkins＠kamailio.sipwise.com 15 Feb '17

15 Feb '17

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…>

1 0

Build failed in Jenkins: kamailiodev-nightly-repos » i386,stretch,master #652
by jenkins＠kamailio.sipwise.com 15 Feb '17

15 Feb '17

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> ------------------------------------------ [...truncated 2.48 KB...] + false + '[' '' = true ']' + ARCHITECTURES='amd64 i386 source' + COMPONENTS=main + UDEB_COMPONENTS=main + '[' 1 -gt 1 ']' + '[' 1 -lt 1 ']' + REPOS=stretch ++ dpkg --list jenkins-debian-glue ++ awk '/^ii/ {print $3}' + JENKINS_DEBIAN_GLUE_VERSION=0.18.2+0~20170208150153.310~1.gbp6cd165 + '[' -n 0.18.2+0~20170208150153.310~1.gbp6cd165 ']' + echo '*** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 ***' *** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 *** + '[' -z '' ']' + echo '*** Repository variable DEFAULT_REPOSITORY is unset, using default [] ***' *** Repository variable DEFAULT_REPOSITORY is unset, using default [] *** + DEFAULT_REPOSITORY=/srv/repository + '[' -z /srv/repository/kamailiodev-nightly ']' + mkdir -p /srv/repository/kamailiodev-nightly/conf ++ id -un + chown jenkins /srv/repository/kamailiodev-nightly/conf + touch /srv/repository/kamailiodev-nightly/conf/distributions + '[' -z 508EA4C8 ']' ++ id -un + flock --timeout 5 9 + grep -q '^$Codename\|Suite$: stretch$' /srv/repository/kamailiodev-nightly/conf/distributions + echo 'Codename/repository stretch exists already, ignoring request to add again.' Codename/repository stretch exists already, ignoring request to add again. + exit 0 ++ id -un + rm -f /var/lock/jdg-generate-reprepro-codename.jenkins + set -u + umask 022 + PATH=/bin:/sbin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin + export QEMU_RESERVED_VA=0x0 + QEMU_RESERVED_VA=0x0 ++ date + echo '*** Starting /usr/bin/build-and-provide-package at Wed Feb 15 14:24:00 UTC 2017 ***' *** Starting /usr/bin/build-and-provide-package at Wed Feb 15 14:24:00 UTC 2017 *** ++ sed -e 's/^$[0-9]*$.*/\1/' + start_seconds=899 ++ awk '/^ii/ {print $3}' ++ dpkg --list jenkins-debian-glue + JENKINS_DEBIAN_GLUE_VERSION=0.18.2+0~20170208150153.310~1.gbp6cd165 + '[' -n 0.18.2+0~20170208150153.310~1.gbp6cd165 ']' + echo '*** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 ***' *** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 *** ++ dpkg --print-architecture + HOST_ARCH=amd64 + '[' -n amd64 ']' + echo '*** Identified host architecture amd64 ***' *** Identified host architecture amd64 *** + trap bailout SIGHUP SIGINT SIGQUIT SIGABRT SIGKILL SIGALRM SIGTERM + checks_and_defaults + '[' -z /srv/repository/kamailiodev-nightly ']' + local repository_is_missing_in_env=false + '[' -r /etc/jenkins/debian_glue ']' + . /etc/jenkins/debian_glue ++ PBUILDER_CONFIG=/etc/jenkins/pbuilderrc ++ KEY_ID=508EA4C8 + '[' -n /srv/repository/kamailiodev-nightly ']' + false + '[' -n '' ']' + '[' -z kamailiodev-nightly-repos/architecture=i386,distribution=stretch,label=master ']' + '[' -z i386 ']' + set_debootstrap + '[' -n '' ']' + '[' i386 = amd64 ']' + '[' i386 = all ']' + case "$HOST_ARCH" in + '[' i386 = i386 ']' + DEBOOTSTRAP=debootstrap + return 0 + '[' -z '' ']' + REPREPRO_OPTS='-v --waitforlock 1000' + echo '*** REPREPRO_OPTS is unset, using default: -v --waitforlock 1000 ***' *** REPREPRO_OPTS is unset, using default: -v --waitforlock 1000 *** + REPREPRO_CMD=reprepro + '[' -z '' ']' + DEFAULT_REPOSITORY=/srv/repository + '[' -z /srv/repository/kamailiodev-nightly ']' + '[' -z '' ']' + PBUILDER_HOOKDIR=/usr/share/jenkins-debian-glue/pbuilder-hookdir/ + '[' -z '' ']' + '[' -z '' ']' + FREIGHT_VARLIB=/var/lib/freight + FREIGHT_VARCACHE=/var/cache/freight + FREIGHT_CONF=/etc/freight.conf + clean_workspace ++ pwd + echo '*** The following files have been noticed in the workspace [<https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…]>: ***' *** The following files have been noticed in the workspace [<https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…]>: *** + ls -la ./ total 12 drwxr-xr-x 3 jenkins nogroup 4096 Feb 15 14:23 . drwxr-xr-x 3 jenkins nogroup 4096 Feb 15 14:23 .. drwxr-xr-x 2 jenkins nogroup 4096 Feb 15 14:24 binaries + identify_package_name + PACKAGE=kamailiodev-nightly + PACKAGE=kamailiodev-nightly + '[' -n kamailiodev-nightly ']' + echo '*** Identified Debian package name kamailiodev-nightly ***' *** Identified Debian package name kamailiodev-nightly *** + set_base_path + '[' -n binaries/ ']' + echo '*** Using provided binaries/ as BASE_PATH ***' *** Using provided binaries/ as BASE_PATH *** + build_info + '[' -n stretch ']' + echo '*** Using supplied repository name stretch ***' *** Using supplied repository name stretch *** + identify_sourcefile + '[' -n '' ']' + echo '*** Identifying newest package version ***' *** Identifying newest package version *** + newest_version= + for file in '"${BASE_PATH}/"*.dsc' ++ awk '/^Source: / {print $2}' binaries//kamailio_5.1.0~dev1+0~20170215005928.726+stretch.dsc + SOURCE_PACKAGE=kamailio ++ basename binaries//kamailio_5.1.0~dev1+0~20170215005928.726+stretch.dsc .dsc + p=kamailio_5.1.0~dev1+0~20170215005928.726+stretch + '[' kamailio_5.1.0~dev1+0~20170215005928.726+stretch = '*' ']' + cur_version=5.1.0~dev1+0~20170215005928.726+stretch + '[' -z '' ']' + newest_version=5.1.0~dev1+0~20170215005928.726+stretch + echo '*** Found package version 5.1.0~dev1+0~20170215005928.726+stretch ***' *** Found package version 5.1.0~dev1+0~20170215005928.726+stretch *** + sourcefile='binaries//kamailio_*5.1.0~dev1+0~20170215005928.726+stretch.dsc' + echo '*** Using binaries//kamailio_*5.1.0~dev1+0~20170215005928.726+stretch.dsc (version: 5.1.0~dev1+0~20170215005928.726+stretch)' *** Using binaries//kamailio_*5.1.0~dev1+0~20170215005928.726+stretch.dsc (version: 5.1.0~dev1+0~20170215005928.726+stretch) + dist_and_arch_settings + '[' -z i386 ']' + '[' i386 = all ']' + arch=i386 + echo '*** architecture is set to i386 ***' *** architecture is set to i386 *** + '[' -n stretch ']' + local DIST=stretch + '[' -n '' ']' + echo '*** Using cowbuilder base for distribution stretch ***' *** Using cowbuilder base for distribution stretch *** + COWBUILDER_DIST=stretch + '[' -n '' ']' + COWBUILDER_BASE=/var/cache/pbuilder/base-stretch-i386.cow + echo '*** No COWBUILDER_BASE set, using /var/cache/pbuilder/base-stretch-i386.cow as cowbuilder base.cow ***' *** No COWBUILDER_BASE set, using /var/cache/pbuilder/base-stretch-i386.cow as cowbuilder base.cow *** + local lockfiles=/var/run/lock/stretch-i386 + build_lockfile=/var/run/lock/stretch-i386.building.2713 + update_lockfile=/var/run/lock/stretch-i386.update + update_lockfile_pid=/var/run/lock/stretch-i386.update.2713 + '[' -n true ']' + echo '*** Config variable '\''PROVIDE_ONLY'\'' is set, ignoring request to run cowbuilder. ***' *** Config variable 'PROVIDE_ONLY' is set, ignoring request to run cowbuilder. *** + '[' -n '' ']' + deploy_to_releases + '[' -n '' ']' + '[' -n '' ']' + '[' -n '' ']' + '[' -n '' ']' + reprepro_wrapper + '[' -d /srv/repository/kamailiodev-nightly ']' + generate-reprepro-codename stretch + set -e + '[' -z /srv/repository/kamailiodev-nightly ']' + repository_is_missing_in_env=false + '[' -r /etc/jenkins/debian_glue ']' + echo '*** Sourcing /etc/jenkins/debian_glue ***' *** Sourcing /etc/jenkins/debian_glue *** + . /etc/jenkins/debian_glue ++ PBUILDER_CONFIG=/etc/jenkins/pbuilderrc ++ KEY_ID=508EA4C8 + '[' -n /srv/repository/kamailiodev-nightly ']' + false + '[' '' = true ']' + ARCHITECTURES='amd64 i386 source' + COMPONENTS=main + UDEB_COMPONENTS=main + '[' 1 -gt 1 ']' + '[' 1 -lt 1 ']' + REPOS=stretch ++ awk '/^ii/ {print $3}' ++ dpkg --list jenkins-debian-glue + JENKINS_DEBIAN_GLUE_VERSION=0.18.2+0~20170208150153.310~1.gbp6cd165 + '[' -n 0.18.2+0~20170208150153.310~1.gbp6cd165 ']' + echo '*** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 ***' *** Running jenkins-debian-glue version 0.18.2+0~20170208150153.310~1.gbp6cd165 *** + '[' -z '' ']' + echo '*** Repository variable DEFAULT_REPOSITORY is unset, using default [] ***' *** Repository variable DEFAULT_REPOSITORY is unset, using default [] *** + DEFAULT_REPOSITORY=/srv/repository + '[' -z /srv/repository/kamailiodev-nightly ']' + mkdir -p /srv/repository/kamailiodev-nightly/conf ++ id -un + chown jenkins /srv/repository/kamailiodev-nightly/conf + touch /srv/repository/kamailiodev-nightly/conf/distributions + '[' -z 508EA4C8 ']' ++ id -un + flock --timeout 5 9 + grep -q '^$Codename\|Suite$: stretch$' /srv/repository/kamailiodev-nightly/conf/distributions + echo 'Codename/repository stretch exists already, ignoring request to add again.' Codename/repository stretch exists already, ignoring request to add again. + exit 0 ++ id -un + rm -f /var/lock/jdg-generate-reprepro-codename.jenkins + remove_packages + '[' -n true ']' + echo '*** Skipping removal of existing packages as requested via SKIP_REMOVAL ***' *** Skipping removal of existing packages as requested via SKIP_REMOVAL *** + return 0 + remove_missing_binary_packages + '[' -n true ']' + echo '*** Skipping removal of existing packages as requested via SKIP_MISSING_BINARY_REMOVAL or SKIP_REMOVAL ***' *** Skipping removal of existing packages as requested via SKIP_MISSING_BINARY_REMOVAL or SKIP_REMOVAL *** + return 0 + archall=false + case $architecture in + echo '*** Including packages in repository stretch ***' *** Including packages in repository stretch *** + reprepro -b /srv/repository/kamailiodev-nightly -v --waitforlock 1000 --ignore=wrongdistribution --ignore=uploaders --ignore=surprisingbinary include stretch <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> Unknown file type: 'cf105042e4584c33ef843fab524947a7 25925 net optional kamailio_5.1.0~dev1+0~20170215005928.726+stretch_i386.buildinfo', assuming source format... .changes put in a distribution not listed within it! Ignoring as --ignore=wrongdistribution given. 'kamailio_5.1.0~dev1+0~20170215005928.726+stretch_i386.buildinfo' looks like part of an source package, but no dsc file listed in the .changes file! There have been errors! + '[' 255 -eq 0 ']' + bailout 1 'Error: Failed to include binary package in stretch repository.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to include binary package in stretch repository.' ']' + echo 'Error: Failed to include binary package in stretch repository.' Error: Failed to include binary package in stretch repository. + rm -f /var/run/lock/stretch-i386.building.2713 + '[' -r /var/run/lock/stretch-i386.update.2713 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> to avoid problems in next run. *** + rm -f <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> <https://kamailio.sipwise.com/job/kamailiodev-nightly-repos/architecture=i38…> + '[' -n '' ']' + '[' -n '' ']' + '[' -n 899 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=1 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Wed Feb 15 14:24:02 UTC 2017 [running 1 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Wed Feb 15 14:24:02 UTC 2017 [running 1 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts

1 0

Dialog keep alive timer minimum 30
by Olle E. Johansson 15 Feb '17

15 Feb '17

Hi! The dialog module has a hard-coded minimum setting of 30 seconds for dialog keep-alives. Is there a reason for this? I guess it’s using the default TM settings for T1 and other timers so one should be able to run it faster. /O

1 0

git:4.3:5e005732: sanity: reset proxy_require hdr parsed field after freeing
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Module: kamailio Branch: 4.3 Commit: 5e0057325baaef72e15f04c1ac6762294a4b12a7 URL: https://github.com/kamailio/kamailio/commit/5e0057325baaef72e15f04c1ac67622… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-15T13:02:39+01:00 sanity: reset proxy_require hdr parsed field after freeing (cherry picked from commit 06e219158131c2397a96bf5d3373c96752d7fd20) (cherry picked from commit 51949e50e0308c9ec41cd95bfe2be3d64e24802d) (cherry picked from commit 4844facff6b6ae66d7d1d9abd3c45bd470d5dfdc) --- Modified: modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/5e0057325baaef72e15f04c1ac67622… Patch: https://github.com/kamailio/kamailio/commit/5e0057325baaef72e15f04c1ac67622… --- diff --git a/modules/sanity/sanity.c b/modules/sanity/sanity.c index 8140c07..5812190 100644 --- a/modules/sanity/sanity.c +++ b/modules/sanity/sanity.c @@ -724,6 +724,7 @@ int check_proxy_require(struct sip_msg* _msg) { * freed when the message freed. Lets hope nobody needs to access * this header again later on */ free_str_list(_msg->proxy_require->parsed); + _msg->proxy_require->parsed = NULL; } } #ifdef EXTRA_DEBUG

1 0

git:4.3:7e7a3798: core: free parsed Required header structure
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Module: kamailio Branch: 4.3 Commit: 7e7a3798072c049516f0072677c91dd7e7a13396 URL: https://github.com/kamailio/kamailio/commit/7e7a3798072c049516f0072677c91dd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-15T13:02:30+01:00 core: free parsed Required header structure (cherry picked from commit d31558b31fd607f842caa04d85ce8870f6fc1740) (cherry picked from commit 8a02d964ffc6145b3ae2f349b8d25aff4dacde3a) (cherry picked from commit b81a228b5a680dff1dff911f1020c8494fbee935) --- Modified: parser/hf.c Modified: parser/parse_require.c --- Diff: https://github.com/kamailio/kamailio/commit/7e7a3798072c049516f0072677c91dd… Patch: https://github.com/kamailio/kamailio/commit/7e7a3798072c049516f0072677c91dd… --- diff --git a/parser/hf.c b/parser/hf.c index 3f2f879..8eb5e7f 100644 --- a/parser/hf.c +++ b/parser/hf.c @@ -150,6 +150,7 @@ void clean_hdr_field(struct hdr_field* const hf) free_subscription_state((subscription_state_t**)h_parsed); break; + case HDR_REQUIRE_T: case HDR_SUPPORTED_T: hdr_free_parsed(h_parsed); break; @@ -168,7 +169,6 @@ void clean_hdr_field(struct hdr_field* const hf) case HDR_CONTENTTYPE_T: case HDR_CONTENTLENGTH_T: case HDR_RETRY_AFTER_T: - case HDR_REQUIRE_T: case HDR_PROXYREQUIRE_T: case HDR_UNSUPPORTED_T: case HDR_ACCEPTLANGUAGE_T: diff --git a/parser/parse_require.c b/parser/parse_require.c index a520318..e343e7f 100644 --- a/parser/parse_require.c +++ b/parser/parse_require.c @@ -1,6 +1,6 @@ /* * Copyright (C) 2006 Andreas Granig <agranig(a)linguin.org> - * + * * This file is part of Kamailio, a free SIP server. * * Kamailio is free software; you can redistribute it and/or modify @@ -65,7 +65,7 @@ int parse_require( struct sip_msg *msg) require |= rb->option_tags; } - ((struct option_tag_body*)msg->require->parsed)->option_tags_all = + ((struct option_tag_body*)msg->require->parsed)->option_tags_all = require; return 0; }

1 0

git:4.4:4844facf: sanity: reset proxy_require hdr parsed field after freeing
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Module: kamailio Branch: 4.4 Commit: 4844facff6b6ae66d7d1d9abd3c45bd470d5dfdc URL: https://github.com/kamailio/kamailio/commit/4844facff6b6ae66d7d1d9abd3c45bd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-15T12:59:57+01:00 sanity: reset proxy_require hdr parsed field after freeing (cherry picked from commit 06e219158131c2397a96bf5d3373c96752d7fd20) (cherry picked from commit 51949e50e0308c9ec41cd95bfe2be3d64e24802d) --- Modified: modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/4844facff6b6ae66d7d1d9abd3c45bd… Patch: https://github.com/kamailio/kamailio/commit/4844facff6b6ae66d7d1d9abd3c45bd… --- diff --git a/modules/sanity/sanity.c b/modules/sanity/sanity.c index 8140c07..5812190 100644 --- a/modules/sanity/sanity.c +++ b/modules/sanity/sanity.c @@ -724,6 +724,7 @@ int check_proxy_require(struct sip_msg* _msg) { * freed when the message freed. Lets hope nobody needs to access * this header again later on */ free_str_list(_msg->proxy_require->parsed); + _msg->proxy_require->parsed = NULL; } } #ifdef EXTRA_DEBUG

1 0

git:4.4:b81a228b: core: free parsed Required header structure
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Module: kamailio Branch: 4.4 Commit: b81a228b5a680dff1dff911f1020c8494fbee935 URL: https://github.com/kamailio/kamailio/commit/b81a228b5a680dff1dff911f1020c84… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-15T12:59:42+01:00 core: free parsed Required header structure (cherry picked from commit d31558b31fd607f842caa04d85ce8870f6fc1740) (cherry picked from commit 8a02d964ffc6145b3ae2f349b8d25aff4dacde3a) --- Modified: parser/hf.c Modified: parser/parse_require.c --- Diff: https://github.com/kamailio/kamailio/commit/b81a228b5a680dff1dff911f1020c84… Patch: https://github.com/kamailio/kamailio/commit/b81a228b5a680dff1dff911f1020c84… --- diff --git a/parser/hf.c b/parser/hf.c index 963dd14..915a52d 100644 --- a/parser/hf.c +++ b/parser/hf.c @@ -150,6 +150,7 @@ void clean_hdr_field(struct hdr_field* const hf) free_subscription_state((subscription_state_t**)h_parsed); break; + case HDR_REQUIRE_T: case HDR_SUPPORTED_T: hdr_free_parsed(h_parsed); break; @@ -168,7 +169,6 @@ void clean_hdr_field(struct hdr_field* const hf) case HDR_CONTENTTYPE_T: case HDR_CONTENTLENGTH_T: case HDR_RETRY_AFTER_T: - case HDR_REQUIRE_T: case HDR_PROXYREQUIRE_T: case HDR_UNSUPPORTED_T: case HDR_ACCEPTLANGUAGE_T: diff --git a/parser/parse_require.c b/parser/parse_require.c index a520318..e343e7f 100644 --- a/parser/parse_require.c +++ b/parser/parse_require.c @@ -1,6 +1,6 @@ /* * Copyright (C) 2006 Andreas Granig <agranig(a)linguin.org> - * + * * This file is part of Kamailio, a free SIP server. * * Kamailio is free software; you can redistribute it and/or modify @@ -65,7 +65,7 @@ int parse_require( struct sip_msg *msg) require |= rb->option_tags; } - ((struct option_tag_body*)msg->require->parsed)->option_tags_all = + ((struct option_tag_body*)msg->require->parsed)->option_tags_all = require; return 0; }

1 0

git:5.0:51949e50: sanity: reset proxy_require hdr parsed field after freeing
by Daniel-Constantin Mierla 15 Feb '17

15 Feb '17

Module: kamailio Branch: 5.0 Commit: 51949e50e0308c9ec41cd95bfe2be3d64e24802d URL: https://github.com/kamailio/kamailio/commit/51949e50e0308c9ec41cd95bfe2be3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-15T12:56:01+01:00 sanity: reset proxy_require hdr parsed field after freeing (cherry picked from commit 06e219158131c2397a96bf5d3373c96752d7fd20) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/51949e50e0308c9ec41cd95bfe2be3d… Patch: https://github.com/kamailio/kamailio/commit/51949e50e0308c9ec41cd95bfe2be3d… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 9a791c1..0ab5792 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -704,6 +704,7 @@ int check_proxy_require(struct sip_msg* _msg) { * freed when the message freed. Lets hope nobody needs to access * this header again later on */ free_str_list(_msg->proxy_require->parsed); + _msg->proxy_require->parsed = NULL; } } #ifdef EXTRA_DEBUG

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2017