sr-dev May 2017

sr-dev@lists.kamailio.org

32 participants
299 discussions

git:master:395699a8: ndb_redis: rename variables to avoind name conflicts
by Claudiu Boriga 05 May '17

05 May '17

Module: kamailio Branch: master Commit: 395699a80345e5721580ebac3b5944f603acdb32 URL: https://github.com/kamailio/kamailio/commit/395699a80345e5721580ebac3b5944f… Author: Claudiu Boriga <paul.boriga(a)1and1.ro> Committer: Claudiu Boriga <paul.boriga(a)1and1.ro> Date: 2017-05-05T09:37:29+03:00 ndb_redis: rename variables to avoind name conflicts --- Modified: src/modules/ndb_redis/ndb_redis_mod.c Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/… [View More]kamailio/kamailio/commit/395699a80345e5721580ebac3b5944f… Patch: https://github.com/kamailio/kamailio/commit/395699a80345e5721580ebac3b5944f… --- diff --git a/src/modules/ndb_redis/ndb_redis_mod.c b/src/modules/ndb_redis/ndb_redis_mod.c index 0906aab..6e43849 100644 --- a/src/modules/ndb_redis/ndb_redis_mod.c +++ b/src/modules/ndb_redis/ndb_redis_mod.c @@ -48,8 +48,8 @@ int init_without_redis = 0; int redis_connect_timeout_param = 1000; int redis_cmd_timeout_param = 1000; int redis_cluster_param = 0; -int disable_time=0; -int allowed_timeouts=-1; +int redis_disable_time_param=0; +int redis_allowed_timeouts_param=-1; static int w_redis_cmd3(struct sip_msg* msg, char* ssrv, char* scmd, char* sres); @@ -122,8 +122,8 @@ static param_export_t params[]={ {"connect_timeout", INT_PARAM, &redis_connect_timeout_param}, {"cmd_timeout", INT_PARAM, &redis_cmd_timeout_param}, {"cluster", INT_PARAM, &redis_cluster_param}, - {"disable_time", INT_PARAM, &disable_time}, - {"allowed_timeouts", INT_PARAM, &allowed_timeouts}, + {"disable_time", INT_PARAM, &redis_disable_time_param}, + {"allowed_timeouts", INT_PARAM, &redis_allowed_timeouts_param}, {0, 0, 0} }; diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index 728a93d..0bf9838 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -49,8 +49,8 @@ extern int init_without_redis; extern int redis_connect_timeout_param; extern int redis_cmd_timeout_param; extern int redis_cluster_param; -extern int disable_time; -extern int allowed_timeouts; +extern int redis_disable_time_param; +extern int redis_allowed_timeouts_param; /* backwards compatibility with hiredis < 0.12 */ #if (HIREDIS_MAJOR == 0) && (HIREDIS_MINOR < 12) @@ -1043,17 +1043,17 @@ int redis_check_server(redisc_server_t *rsrv) int redis_count_err_and_disable(redisc_server_t *rsrv) { - if (allowed_timeouts < 0) + if (redis_allowed_timeouts_param < 0) { return 0; } rsrv->disable.consecutive_errors++; - if (rsrv->disable.consecutive_errors > allowed_timeouts) + if (rsrv->disable.consecutive_errors > redis_allowed_timeouts_param) { rsrv->disable.disabled=1; - rsrv->disable.restore_tick=get_ticks() + disable_time; - LM_WARN("REDIS server %.*s disabled for %d seconds",rsrv->sname->len,rsrv->sname->s,disable_time); + rsrv->disable.restore_tick=get_ticks() + redis_disable_time_param; + LM_WARN("REDIS server %.*s disabled for %d seconds",rsrv->sname->len,rsrv->sname->s,redis_disable_time_param); return 1; } return 0; [View Less]

1 0

git:master:d0101010: ndb_redis: add disable server on failure feature
by Claudiu Boriga 05 May '17

05 May '17

Module: kamailio Branch: master Commit: d0101010b891e60fdab0f76ae5ce899747d6586e URL: https://github.com/kamailio/kamailio/commit/d0101010b891e60fdab0f76ae5ce899… Author: Claudiu Boriga <paul.boriga(a)1and1.ro> Committer: Claudiu Boriga <paul.boriga(a)1and1.ro> Date: 2017-05-03T16:19:04+03:00 ndb_redis: add disable server on failure feature - if a server fails multiple consecutive times it is disabled temporarily and commands to it will not do anything. --- Modified: … [View More]

1 0

[kamailio/kamailio] ndb_redis: add disable server on failure feature (#1116)
by Paul Claudiu Boriga 05 May '17

05 May '17

Hello, We added a new feature to the ndb_redis module, similar to how the rtpengine_disable_tout parameter of the rtpengine module works. If a number of consecutive commands to a redis server fail, that server is temporarily disabled. This is configurable by parameters: "allowed_timeouts" and "disable_time". Disabling a server means that for "disable_time" seconds any command to that sever will not send the command to the server, but an error is returned instead. For example if … [View More]

2 5

git:master:ae081b25: tm: exported load contacts functions to kemi framework
by Daniel-Constantin Mierla 05 May '17

05 May '17

Module: kamailio Branch: master Commit: ae081b252e74e54509e45b3ee1163525e03e27f1 URL: https://github.com/kamailio/kamailio/commit/ae081b252e74e54509e45b3ee116352… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-05T08:54:52+02:00 tm: exported load contacts functions to kemi framework --- Modified: src/modules/tm/t_serial.c Modified: src/modules/tm/t_serial.h Modified: src/modules/tm/tm.c --- Diff: … [View More]

1 0

[kamailio/kamailio] Malforming of sip message by multiple forwards (#1108)
by hdssdsdsdsfsdf 04 May '17

04 May '17

### Description I forward a sip message multiple times. I expect the sip messages that are forwarded after previous ones, to look the same. In stead, multiple via-headers are added for the host. If I modify the sip message after forwarding it, I expect the modifications to be correctly processed for subsequent forwards, in stead the modifications are mixed with elements from the previously forwarded sip message. For example setting $td to value x, forwarding, setting $td to value y, and … [View More]forwarding again, results in a sip message with a to-domain of xy, in stead of just y. #### Reproduction To reproduce, add this to your main route and enable dispatching. For the example sip messages below, I ran this code on CANCEL messages. ``` ds_select_domain("2", "6"); $td = $nh(d); forward(); ds_next_domain(); $td = $nh(d); forward(); ``` Run wireshark to see the resulting sip-messages on the wire. #### SIP Traffic As an example of a 'double' forward along with modification of $td to send the initial sip message to both [a::3] and [b::4] (anonymized hosts): Part of the initial sip message (anonymized) CANCEL sip:x@x SIP/2.0 Via: SIP/2.0/UDP [x::1]:5060;rport;branch=z9hG4bK152CABB1BC44E9A0 From: <sip:y@x>;tag=00623356EBD9772B To: <sip:x@x> Part of the first forwarded sip message (anonymized) CANCEL sip:x@a:5060 SIP/2.0 Record-Route: <sip:[x];lr=on> Via: SIP/2.0/UDP [x:4A];branch=z9hG4bK9a21.932b3551ed4f18f509d1bfaeecb65ea5.0 Via: SIP/2.0/UDP [x::1]:5060;received=x:1;rport=5060;branch=z9hG4bK152CABB1BC44E9A0 From: <sip:y@x>;tag=00623356EBD9772B To: <sip:x@[a::3]> Part of the second forwarded sip message (anonymized) CANCEL sip:x@b:5060 SIP/2.0 Record-Route: <sip:[x];lr=on> Via: SIP/2.0/UDP [x:4A];branch=z9hG4bK9a21.932b3551ed4f18f509d1bfaeecb65ea5.0 Via: SIP/2.0/UDP [x:4A];branch=z9hG4bK9a21.932b3551ed4f18f509d1bfaeecb65ea5.0 Via: SIP/2.0/UDP [x::1]:5060;received=x:1;rport=5060;received=x:1;rport=5060;branch=z9hG4bK152CABB1BC44E9A0 From: <sip:y@x>;tag=00623356EBD9772B To: <sip:x@[a::3][b::4]> ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.4 (x86_64/linux) 852c47 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 852c47 compiled on 14:05:47 Mar 7 2017 with gcc 4.9.2 ``` * **Operating System**: Debian 8.7 ``` Linux x.x 3.16.0-4-amd64 #1 SMP Debian 3.16.39-1+deb8u2 (2017-03-07) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1108 [View Less]

2 2

git:master:22fc0253: tm: use NAME define for initializing uac
by Daniel-Constantin Mierla 04 May '17

04 May '17

Module: kamailio Branch: master Commit: 22fc02538a7576bf35ef321980a607bdfb9bcc5f URL: https://github.com/kamailio/kamailio/commit/22fc02538a7576bf35ef321980a607b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-04T18:12:04+02:00 tm: use NAME define for initializing uac --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/22fc02538a7576bf35ef321980a607b… Patch: … [View More]

1 0

[kamailio/kamailio] Potential bug in kamailio-basic-kemi-python.py (#1117)
by Sam 04 May '17

04 May '17

In the file kamailio-basic-kemi-python.py:65 it reads ``` # handle requests within SIP dialogs self.ksr_route_withindlg(msg); ``` I wonder if it shouldn't read: ``` # handle requests within SIP dialogs if self.ksr_route_withindlg(msg) == -255: return 1 # -- only initial requests (no To tag) ``` Seems like that is the intended behavior based on the native example script and the return codes from ksr_route_withindlg(). Kamailio will always keep processing everything below line 69 … [View More]

2 2

git:master:d678d095: misc/examples: handle return code for ksr_route_withindlg() in kemy python example
by Daniel-Constantin Mierla 04 May '17

04 May '17

Module: kamailio Branch: master Commit: d678d095858271a0282b8a824840880f9994041b URL: https://github.com/kamailio/kamailio/commit/d678d095858271a0282b8a824840880… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-04T18:06:46+02:00 misc/examples: handle return code for ksr_route_withindlg() in kemy python example - closes GH #1117 --- Modified: misc/examples/kemi/kamailio-basic-kemi-python.py --- Diff:… [View More]

1 0

git:master:a813dec2: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 04 May '17

04 May '17

Module: kamailio Branch: master Commit: a813dec2d82ced5ae0891f71f12e11dbd9a6cd37 URL: https://github.com/kamailio/kamailio/commit/a813dec2d82ced5ae0891f71f12e11d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-05-04T18:01:43+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git: new commits in branch 5.0
by lazedo 04 May '17

04 May '17

- URL: https://github.com/kamailio/kamailio/commit/42e57bdd1861bd5014a1f9156b298ac… Author: Luis Azedo <luis(a)2600hz.com> Date: 2017-05-04T16:55:32+01:00 kazoo : add specific pua helpers - URL: https://github.com/kamailio/kamailio/commit/e624d81c25c8fd67023f7c1aba7a119… Author: Luis Azedo <luis(a)2600hz.com> Date: 2017-05-04T16:55:32+01:00 kazoo : code cleanup - URL: https://github.com/kamailio/kamailio/commit/7b0983e35eb5e757e03f8b44cf714c4… Author: Luis Azedo <… [View More]

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2017