sr-dev July 2017

sr-dev@lists.kamailio.org

23 participants
410 discussions

git:master:b94ba195: db_postgres: safety checks for new constraint structures

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b94ba19595b06556c84f450b9e1b24d6479cec61 URL: https://github.com/kamailio/kamailio/commit/b94ba19595b06556c84f450b9e1b24d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-13T08:54:18+02:00 db_postgres: safety checks for new constraint structures - bits of code formating --- Modified: src/modules/db_postgres/km_dbase.c Modified: src/modules/db_postgres/km_pg_con.c --- Diff: https://github.com/kamailio/kamailio/commit/b94ba19595b06556c84f450b9e1b24d… Patch: https://github.com/kamailio/kamailio/commit/b94ba19595b06556c84f450b9e1b24d…

7 years, 4 months

git:master:d12f96af: db_postgres: added missing break for INT8OID results

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d12f96af28e170c3197a47af5840e5e30639adf6 URL: https://github.com/kamailio/kamailio/commit/d12f96af28e170c3197a47af5840e5e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-13T08:54:18+02:00 db_postgres: added missing break for INT8OID results - instead of DB1_BIGINT, the result type ended to be DB1_DOUBLE --- Modified: src/modules/db_postgres/km_res.c --- Diff: https://github.com/kamailio/kamailio/commit/d12f96af28e170c3197a47af5840e5e… Patch: https://github.com/kamailio/kamailio/commit/d12f96af28e170c3197a47af5840e5e… --- diff --git a/src/modules/db_postgres/km_res.c b/src/modules/db_postgres/km_res.c index 8e9b6288ff..5f6cbd4307 100644 --- a/src/modules/db_postgres/km_res.c +++ b/src/modules/db_postgres/km_res.c @@ -15,8 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * */ @@ -131,6 +131,7 @@ int db_postgres_get_columns(const db1_con_t* _h, db1_res_t* _r) case INT8OID: LM_DBG("use DB1_BIGINT result type\n"); RES_TYPES(_r)[col] = DB1_BIGINT; + break; case FLOAT4OID: case FLOAT8OID: @@ -166,7 +167,7 @@ int db_postgres_get_columns(const db1_con_t* _h, db1_res_t* _r) LM_DBG("use DB1_BITMAP result type\n"); RES_TYPES(_r)[col] = DB1_BITMAP; break; - + default: LM_WARN("unhandled data type column (%.*s) type id (%d), " "use DB1_STRING as default\n", RES_NAMES(_r)[col]->len,

7 years, 4 months

git:master:97b5d71e: modules: readme files regenerated - mqueue ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 97b5d71ef7c3d5828e0d467216d00372801e04ec URL: https://github.com/kamailio/kamailio/commit/97b5d71ef7c3d5828e0d467216d0037… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-12T21:01:19+02:00 modules: readme files regenerated - mqueue ... [skip ci] --- Modified: src/modules/mqueue/README --- Diff: https://github.com/kamailio/kamailio/commit/97b5d71ef7c3d5828e0d467216d0037… Patch: https://github.com/kamailio/kamailio/commit/97b5d71ef7c3d5828e0d467216d0037… --- diff --git a/src/modules/mqueue/README b/src/modules/mqueue/README index de19038637..7615f90381 100644 --- a/src/modules/mqueue/README +++ b/src/modules/mqueue/README @@ -127,7 +127,7 @@ Chapter 1. Admin Guide Value must be a list of parameters: attr=value;... * Mandatory attributes: - + value: name of the queue. + + name: name of the queue. * Optional attributes: + size: size of the queue. Specifies the maximum number of items in queue. If execeeded the oldest one is removed. If not set

7 years, 4 months

git:master:df6af83d: mqueue: doc updates for queue size

by Ovidiu Sas

Module: kamailio Branch: master Commit: df6af83d627de3de4669c887065c3a5357fa5f7b URL: https://github.com/kamailio/kamailio/commit/df6af83d627de3de4669c887065c3a5… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2017-07-12T13:33:45-04:00 mqueue: doc updates for queue size --- Modified: src/modules/mqueue/doc/mqueue.xml Modified: src/modules/mqueue/doc/mqueue_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/df6af83d627de3de4669c887065c3a5… Patch: https://github.com/kamailio/kamailio/commit/df6af83d627de3de4669c887065c3a5… --- diff --git a/src/modules/mqueue/doc/mqueue.xml b/src/modules/mqueue/doc/mqueue.xml index 94b77fd913..53ce810056 100644 --- a/src/modules/mqueue/doc/mqueue.xml +++ b/src/modules/mqueue/doc/mqueue.xml @@ -29,6 +29,12 @@ <email>abalashov(a)evaristesys.com</email> <affiliation><orgname>Evariste Systems</orgname></affiliation> </editor> + <editor> + <firstname>Ovidiu</firstname> + <surname>Sas</surname> + <email>osas(a)voipembedded.com</email> + <affiliation><orgname>VoIP Embedded, Inc.</orgname></affiliation> + </editor> </authorgroup> <copyright> <year>2010</year> diff --git a/src/modules/mqueue/doc/mqueue_admin.xml b/src/modules/mqueue/doc/mqueue_admin.xml index dc8463b6e7..dfaec773d9 100644 --- a/src/modules/mqueue/doc/mqueue_admin.xml +++ b/src/modules/mqueue/doc/mqueue_admin.xml @@ -72,10 +72,32 @@ </emphasis> </para> <para> - Value must be a list of parameters: attr=value;... The attribute 'name' - is mandatory, defining the name of the queue. Optional attribute 'size' - specifies the maximum number of items in queue, if it is execeeded the - oldest one is removed. + Value must be a list of parameters: attr=value;... + <itemizedlist> + <listitem> + <para>Mandatory attributes:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>value</emphasis>: name of the queue. + </para> + </listitem> + </itemizedlist> + </listitem> + <listitem> + <para>Optional attributes:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>size</emphasis>: size of the queue. + Specifies the maximum number of items in queue. + If execeeded the oldest one is removed. + If not set the queue will be limitless. + </para> + </listitem> + </itemizedlist> + </listitem> + </itemizedlist> </para> <para> The parameter can be set many times, each holding the definition of one

7 years, 4 months

git:master:a8a6fdd8: mqueue: fix typo in documentation

by Ovidiu Sas

Module: kamailio Branch: master Commit: a8a6fdd89384ad66e1b526e839fca84c8cd66c31 URL: https://github.com/kamailio/kamailio/commit/a8a6fdd89384ad66e1b526e839fca84… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2017-07-12T14:56:58-04:00 mqueue: fix typo in documentation - thanks to Daniel-Constantin Mierla for spotting it --- Modified: src/modules/mqueue/doc/mqueue_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a8a6fdd89384ad66e1b526e839fca84… Patch: https://github.com/kamailio/kamailio/commit/a8a6fdd89384ad66e1b526e839fca84… --- diff --git a/src/modules/mqueue/doc/mqueue_admin.xml b/src/modules/mqueue/doc/mqueue_admin.xml index dfaec773d9..e0a06bf901 100644 --- a/src/modules/mqueue/doc/mqueue_admin.xml +++ b/src/modules/mqueue/doc/mqueue_admin.xml @@ -79,7 +79,7 @@ <itemizedlist> <listitem> <para> - <emphasis>value</emphasis>: name of the queue. + <emphasis>name</emphasis>: name of the queue. </para> </listitem> </itemizedlist>

7 years, 4 months

git:master:4bfc1f4d: modules: readme files regenerated - mqueue ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 4bfc1f4d052b52d4d8119a65065c8e1c608ca750 URL: https://github.com/kamailio/kamailio/commit/4bfc1f4d052b52d4d8119a65065c8e1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-12T19:46:16+02:00 modules: readme files regenerated - mqueue ... [skip ci] --- Modified: src/modules/mqueue/README --- Diff: https://github.com/kamailio/kamailio/commit/4bfc1f4d052b52d4d8119a65065c8e1… Patch: https://github.com/kamailio/kamailio/commit/4bfc1f4d052b52d4d8119a65065c8e1… --- diff --git a/src/modules/mqueue/README b/src/modules/mqueue/README index fa963ae69d..de19038637 100644 --- a/src/modules/mqueue/README +++ b/src/modules/mqueue/README @@ -17,6 +17,13 @@ Alex Balashov Evariste Systems <abalashov(a)evaristesys.com> +Edited by + +Ovidiu Sas + + VoIP Embedded, Inc. + <osas(a)voipembedded.com> + Copyright © 2010 Elena-Ramona Modroiu (asipto.com) __________________________________________________________________ @@ -118,10 +125,13 @@ Chapter 1. Admin Guide Default value is “none”. - Value must be a list of parameters: attr=value;... The attribute 'name' - is mandatory, defining the name of the queue. Optional attribute 'size' - specifies the maximum number of items in queue, if it is execeeded the - oldest one is removed. + Value must be a list of parameters: attr=value;... + * Mandatory attributes: + + value: name of the queue. + * Optional attributes: + + size: size of the queue. Specifies the maximum number of items + in queue. If execeeded the oldest one is removed. If not set + the queue will be limitless. The parameter can be set many times, each holding the definition of one queue.

7 years, 4 months

git:master:f6c41abe: modules: readme files regenerated - dialog ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: f6c41abedecc987f570c100030fbc47cdaca2790 URL: https://github.com/kamailio/kamailio/commit/f6c41abedecc987f570c100030fbc47… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-12T15:16:41+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/f6c41abedecc987f570c100030fbc47… Patch: https://github.com/kamailio/kamailio/commit/f6c41abedecc987f570c100030fbc47…

7 years, 4 months

git:master:f2058b1a: dialog: documented early_dialog and noack_dialog parameters

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f2058b1ac158eea31b49943382a849738014d0e0 URL: https://github.com/kamailio/kamailio/commit/f2058b1ac158eea31b49943382a8497… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-12T15:02:14+02:00 dialog: documented early_dialog and noack_dialog parameters --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f2058b1ac158eea31b49943382a8497… Patch: https://github.com/kamailio/kamailio/commit/f2058b1ac158eea31b49943382a8497… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 88c6ed759e..45ce5cc690 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -313,6 +313,49 @@ modparam("dialog", "default_timeout", 21600) </example> </section> + <section id="dialog.p.early_timeout"> + <title><varname>early_timeout</varname> (integer)</title> + <para> + The timeout (in seconds) after which the dialogs in early state (no + final response received) are destroyed. + </para> + <para> + <emphasis> + Default value is <quote>300 (5 minutes)</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>early_timeout</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialog", "early_timeout", 180) +... +</programlisting> + </example> + </section> + + <section id="dialog.p.noack_timeout"> + <title><varname>noack_timeout</varname> (integer)</title> + <para> + The timeout (in seconds) after which the dialogs which were answered + with 200ok but didn't receive the ACK are marked for termination (the + lifetime is set to 10 more seconds). + </para> + <para> + <emphasis> + Default value is <quote>60 (1 minute)</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>noack_timeout</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialog", "noack_timeout", 90) +... +</programlisting> + </example> + </section> + <section id="dialog.p.dlg_extra_hdrs"> <title><varname>dlg_extra_hdrs</varname> (string)</title> <para>

7 years, 4 months

git:master:3c6b3ecb: dialog: new parameters - early_timeout and noack_timeout

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3c6b3ecbe14162d810286bac8f8aec87a5567e6f URL: https://github.com/kamailio/kamailio/commit/3c6b3ecbe14162d810286bac8f8aec8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-12T14:53:59+02:00 dialog: new parameters - early_timeout and noack_timeout - early_timeout - set the interval in seconds after which the dialogs in early state (not answered yet) are destroyed. Default value is 300. - noack_timeout - set the interval in seconds after which the dialogs that were answered with 200ok but didn't receive the ACK are marked for termination (lifetime set to 10 more seconds). Default value 60. --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/3c6b3ecbe14162d810286bac8f8aec8… Patch: https://github.com/kamailio/kamailio/commit/3c6b3ecbe14162d810286bac8f8aec8… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 9f90e07a0b..37b5dedde7 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -107,6 +107,8 @@ int dlg_wait_ack = 1; static int dlg_timer_procs = 0; static int _dlg_track_cseq_updates = 0; int dlg_ka_failed_limit = 1; +int dlg_early_timeout = 300; +int dlg_noack_timeout = 60; int dlg_enable_dmq = 0; @@ -301,7 +303,9 @@ static param_export_t mod_params[]={ { "db_skip_load", INT_PARAM, &db_skip_load }, { "ka_failed_limit", INT_PARAM, &dlg_ka_failed_limit }, { "enable_dmq", INT_PARAM, &dlg_enable_dmq }, - {"event_callback", PARAM_STR, &dlg_event_callback }, + { "event_callback", PARAM_STR, &dlg_event_callback }, + { "early_timeout", PARAM_INT, &dlg_early_timeout }, + { "noack_timeout", PARAM_INT, &dlg_noack_timeout }, { 0,0,0 } }; diff --git a/src/modules/dialog/dlg_hash.c b/src/modules/dialog/dlg_hash.c index 8c5c7a6acb..e9b0af65ea 100644 --- a/src/modules/dialog/dlg_hash.c +++ b/src/modules/dialog/dlg_hash.c @@ -48,6 +48,9 @@ extern int dlg_ka_interval; extern int dlg_enable_dmq; +extern int dlg_early_timeout; +extern int dlg_noack_timeout; + /*! global dialog table */ struct dlg_table *d_table = 0; @@ -229,14 +232,16 @@ int dlg_clean_run(ticks_t ti) while (dlg) { tdlg = dlg; dlg = dlg->next; - if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300) { + if(tdlg->state==DLG_STATE_UNCONFIRMED + && tdlg->init_ts<tm-dlg_early_timeout) { /* dialog in early state older than 5min */ LM_NOTICE("dialog in early state is too old (%p ref %d)\n", tdlg, tdlg->ref); unlink_unsafe_dlg(&d_table->entries[i], tdlg); destroy_dlg(tdlg); } - if(tdlg->state==DLG_STATE_CONFIRMED_NA && tdlg->start_ts<tm-60) { + if(tdlg->state==DLG_STATE_CONFIRMED_NA + && tdlg->start_ts<tm-dlg_noack_timeout) { if(update_dlg_timer(&tdlg->tl, 10)<0) { LM_ERR("failed to update dialog lifetime in long non-ack state\n"); }

7 years, 4 months

[kamailio/kamailio] 5.0.* dialogs expiring early (#1182)

by Jared Hull

### Description No matter what I set the dialog timeout to, the time between INVITE/ACK and timout and the timeout in the dialog db changed at random. It seems to be between 1 and 3 minutes. 94 seconds between the INVITE/ACK and dialog timeout in this case Jul 7 21:09:28 dev-dallas-sip2-int /usr/sbin/kamailio[30347]: INFO: <script>: RELAYING INVITE to 999999@207.91.156.195:5060 (999999e100a1 -> 102) Jul 7 21:11:02 dev-dallas-sip2-int /usr/sbin/kamailio[30353]: WARNING: dialog [dlg_handlers.c:1577]: dlg_ontimeout(): timeout for dlg with CallID '0_373726168(a)192.168.1.60' and tags '3498684614' '983bb3d4-38fe-4d47-8d73-c57b85e757d3' In the database for this dialog, this looks very strange. start_time 1499461769 timeout 1409235713 ### Troubleshooting I tried to use keep alive in the dialog with ka_timer and ka_interval, I do see the OPTIONS and 200 OK flowing between the two devices and kamailio. This does not prevent the dialog from timing out though. #### Reproduction I am just setting the dialog flag on the initial INVITE and let Kamailio do it's thing with the dialog. modparam("dialog", "db_mode", 1) modparam("dialog", "default_timeout", 43200) # this should be the default as per kamailio documentation ### Additional Information * **Kamailio Version**: ``` version: kamailio 5.0.2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 14:05:03 Jun 14 2017 with gcc 4.8.5 ``` * **Operating System**: ``` 3.10.0-514.21.1.el7.x86_64 #1 SMP Thu May 25 17:04:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1182

7 years, 4 months

← Newer
1
...
27
28
29
30
31
32
33
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2017