sr-dev August 2017

sr-dev@lists.kamailio.org

24 participants
306 discussions

git:master:d5fa8ec4: modules: readme files regenerated - kex ... [skip ci]
by Kamailio Dev 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: d5fa8ec41292e0cc1aaf3454fde6a251eff07fed URL: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-08-10T09:16:28+02:00 modules: readme files regenerated - kex ... [skip ci] --- Modified: src/modules/kex/README --- Diff: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25… Patch: https://github.com/kamailio/kamailio/commit/d5fa8ec41292e0cc1aaf3454fde6a25…

1 0

git:master:c06b1890: kex: documentation for rpc command core.ppdefines
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: c06b1890a59fe6998fdef8d26def3568816ab8d7 URL: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T09:08:13+02:00 kex: documentation for rpc command core.ppdefines --- Modified: src/modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… Patch: https://github.com/kamailio/kamailio/commit/c06b1890a59fe6998fdef8d26def356… --- diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 49414ed1a9..6c588a31b5 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -10,9 +10,9 @@  <chapter> - + <title>&adminguide;</title> - + <section> <title>Overview</title> <para> @@ -22,7 +22,7 @@ &kamailio; Core Cookbook is available at: &kamwikilink; </para> </section> - + <section> <title>Dependencies</title> <section> @@ -648,6 +648,26 @@ resetdebug(); ... </programlisting> </section> + <section id="kex.r.core.ppdefines"> + <title> + <function moreinfo="none">core.ppdefines</function> + </title> + <para> + List preprocessor defines enabled in config. + </para> + <para> + Name: <emphasis>core.ppdefines</emphasis> + </para> + <para>Parameters: <emphasis>none</emphasis>.</para> + <para> + RPC Command Format: + </para> + <programlisting format="linespecific"> +... +&kamcmd; core.ppdefines +... + </programlisting> + </section> <section id="kex.r.pkg.stats"> <title>

1 0

git:master:3324b33c: core: added rpc command core.ppdefines
by Daniel-Constantin Mierla 10 Aug '17

10 Aug '17

Module: kamailio Branch: master Commit: 3324b33c7eb6036a984666e4294323f2cb015032 URL: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-10T09:04:29+02:00 core: added rpc command core.ppdefines - list preprocessor defines enabled in config --- Modified: src/core/cfg.lex Modified: src/core/core_cmd.c Modified: src/core/ppcfg.c Modified: src/core/ppcfg.h --- Diff: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f… Patch: https://github.com/kamailio/kamailio/commit/3324b33c7eb6036a984666e4294323f…

1 0

git:master:3469156e: Makefile.groups: added acc_diameter to extra group
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 3469156e29565c03ea4a8e8bafe746eec06e3a83 URL: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T19:23:41+02:00 Makefile.groups: added acc_diameter to extra group --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… Patch: https://github.com/kamailio/kamailio/commit/3469156e29565c03ea4a8e8bafe746e… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index d7074cbc65..ab82466413 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -21,7 +21,7 @@ mod_list_basic=async auth benchmark blst cfg_rpc cfgutils corex counters \ mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \ pdb qos sca seas sms sst timer tmrec uac_redirect xhttp \ xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd rtjson \ - log_custom keepalive ss7ops app_sqlang + log_custom keepalive ss7ops app_sqlang acc_diameter # - common modules depending on database mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \

1 0

IMPORTANT: acc module - SQL define removed and diameter code relocated
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Hello, I just pushed a bit of clean up to acc module, therefore be aware of following changes: 1) the define conditions on SQL_ACC were removed -- this was enabled for more than 10 years and only made the code look complex and hard to follow up its logic. 2) the code related to DIAMETER accounting was relocated to acc_diameter (new) module. It was a consistent size of code that was not enabled for sooo... long. It is now a dedicated module, similar to acc_radius. The diameter accounting code, even a new module now, is in the same stage, compiling but not tested, in pair with auth_diameter module, it may work, but very likely not. In summary, what's important for those using the acc module -- it offers the same functionality as it was enabled by default in the past 10 years or more, only the unused code was relocated. It offers the functionality of writing accounting records to syslog and sql databases. The acc module is now slimmer, only with the code that it needs, therefore easier to maintain and enhance for the future. Hopefully, there was no side effect with this update -- anyhow, if you find any issue, just open a bug report on github project. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com

1 0

git:master:d05e4bff: acc_radius: coherent indentation and whitespacing
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: d05e4bffa921cb7daac24eda2ff7ddb09cde942d URL: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:28:59+02:00 acc_radius: coherent indentation and whitespacing --- Modified: src/modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… Patch: https://github.com/kamailio/kamailio/commit/d05e4bffa921cb7daac24eda2ff7ddb… --- diff --git a/src/modules/acc_radius/acc_radius_mod.c b/src/modules/acc_radius/acc_radius_mod.c index df5dbdf5f8..94e521f537 100644 --- a/src/modules/acc_radius/acc_radius_mod.c +++ b/src/modules/acc_radius/acc_radius_mod.c @@ -67,7 +67,7 @@ acc_api_t accb; acc_engine_t _acc_radius_engine; /* ----- RADIUS acc variables ----------- */ -/*! \name AccRadiusVariables Radius Variables */ +/*! \name AccRadiusVariables Radius Variables */ /*@{*/ static char *radius_config = 0; @@ -324,7 +324,7 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) int rc_result=-1; double tsecmicro; char smicrosec[18]; - + send=NULL; attr_cnt = accb.get_core_attrs( req, inf->varr, inf->iarr, inf->tarr ); @@ -344,16 +344,16 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) ADD_RAD_AVPAIR( RA_SIP_METHOD, &av_type, -1); // Event Time Stamp with Microseconds - if(rad_time_mode==1){ - gettimeofday(&inf->env->tv, NULL); - tsecmicro=inf->env->tv.tv_sec+((double)inf->env->tv.tv_usec/1000000.0); - //radius client doesn t support double so convert it - sprintf(smicrosec,"%17.6f",tsecmicro); - ADD_RAD_AVPAIR(RA_TIME_STAMP, &smicrosec, -1); - }else{ - av_type = (uint32_t)inf->env->ts; - ADD_RAD_AVPAIR(RA_TIME_STAMP, &av_type, -1); - } + if(rad_time_mode==1){ + gettimeofday(&inf->env->tv, NULL); + tsecmicro=inf->env->tv.tv_sec+((double)inf->env->tv.tv_usec/1000000.0); + //radius client doesn t support double so convert it + sprintf(smicrosec,"%17.6f",tsecmicro); + ADD_RAD_AVPAIR(RA_TIME_STAMP, &smicrosec, -1); + }else{ + av_type = (uint32_t)inf->env->ts; + ADD_RAD_AVPAIR(RA_TIME_STAMP, &av_type, -1); + } /* add extra also */ @@ -392,29 +392,29 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) rc_result=rc_acct(rh, SIP_PORT, send); - if (rc_result==ERROR_RC) { - LM_ERR("Radius accounting - ERROR - \n"); - goto error; - }else if(rc_result==BADRESP_RC){ - LM_ERR("Radius accounting - BAD RESPONSE \n"); - goto error; - }else if(rc_result==TIMEOUT_RC){ - LM_ERR("Radius accounting - TIMEOUT \n"); - goto error; - }else if(rc_result==REJECT_RC){ - LM_ERR("Radius accounting - REJECTED \n"); - goto error; - }else if(rc_result==OK_RC){ - LM_DBG("Radius accounting - OK \n"); - }else{ - LM_ERR("Radius accounting - Unknown response \n"); - goto error; - } - - rc_avpair_free(send); - /* free memory allocated by extra2strar */ - free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); - return 1; + if (rc_result==ERROR_RC) { + LM_ERR("Radius accounting - ERROR - \n"); + goto error; + }else if(rc_result==BADRESP_RC){ + LM_ERR("Radius accounting - BAD RESPONSE \n"); + goto error; + }else if(rc_result==TIMEOUT_RC){ + LM_ERR("Radius accounting - TIMEOUT \n"); + goto error; + }else if(rc_result==REJECT_RC){ + LM_ERR("Radius accounting - REJECTED \n"); + goto error; + }else if(rc_result==OK_RC){ + LM_DBG("Radius accounting - OK \n"); + }else{ + LM_ERR("Radius accounting - Unknown response \n"); + goto error; + } + + rc_avpair_free(send); + /* free memory allocated by extra2strar */ + free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); + return 1; error: rc_avpair_free(send);

1 0

git:master:5cb612b7: acc: relocated the code related to diameter accounting to acc_diameter
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 5cb612b7ff9bba75ec8e48dade06561810a77ccd URL: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:28:25+02:00 acc: relocated the code related to diameter accounting to acc_diameter --- Modified: src/modules/acc/Makefile Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc.h Modified: src/modules/acc/acc_api.h Modified: src/modules/acc/acc_cdr.c Modified: src/modules/acc/acc_extra.c Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/acc_logic.h Modified: src/modules/acc/acc_mod.c Modified: src/modules/acc/acc_mod.h Removed: src/modules/acc/diam_avp.c Removed: src/modules/acc/diam_dict.h Removed: src/modules/acc/diam_message.c Removed: src/modules/acc/diam_message.h Removed: src/modules/acc/diam_tcp.c Removed: src/modules/acc/diam_tcp.h --- Diff: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561… Patch: https://github.com/kamailio/kamailio/commit/5cb612b7ff9bba75ec8e48dade06561…

1 0

git:master:560c52cb: acc_diameter: diameter accounting module with code relocated from acc
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 560c52cbd4f6f4f934cd907621979ce33a676821 URL: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T15:27:47+02:00 acc_diameter: diameter accounting module with code relocated from acc --- Added: src/modules/acc_diameter/Makefile Added: src/modules/acc_diameter/README Added: src/modules/acc_diameter/acc_diameter_mod.c Added: src/modules/acc_diameter/diam_avp.c Added: src/modules/acc_diameter/diam_dict.h Added: src/modules/acc_diameter/diam_message.c Added: src/modules/acc_diameter/diam_message.h Added: src/modules/acc_diameter/diam_tcp.c Added: src/modules/acc_diameter/diam_tcp.h Added: src/modules/acc_diameter/doc/Makefile Added: src/modules/acc_diameter/doc/acc_diameter.xml Added: src/modules/acc_diameter/doc/acc_diameter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce… Patch: https://github.com/kamailio/kamailio/commit/560c52cbd4f6f4f934cd907621979ce…

1 0

git:master:60a35d4e: acc_radius: removed unused code left when split from acc module
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 60a35d4ea83fc0a6d2a29aa56ff94afc57eff9af URL: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T13:38:16+02:00 acc_radius: removed unused code left when split from acc module --- Modified: src/modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… Patch: https://github.com/kamailio/kamailio/commit/60a35d4ea83fc0a6d2a29aa56ff94af… --- diff --git a/src/modules/acc_radius/acc_radius_mod.c b/src/modules/acc_radius/acc_radius_mod.c index 05adfb1b11..df5dbdf5f8 100644 --- a/src/modules/acc_radius/acc_radius_mod.c +++ b/src/modules/acc_radius/acc_radius_mod.c @@ -203,14 +203,6 @@ static int acc_api_fixup(void** param, int param_no) accp->reason.len = strlen(accp->reason.s); } *param = (void*)accp; -#ifdef SQL_ACC - } else if (param_no == 2) { - /* only for db acc - the table name */ - if (db_url.s==0) { - pkg_free(p); - *param = 0; - } -#endif } return 0; }

1 0

git:master:8eb6e6a0: acc: removed define for SQL_ACC
by Daniel-Constantin Mierla 09 Aug '17

09 Aug '17

Module: kamailio Branch: master Commit: 8eb6e6a01d435955939ceddee82b3ba0a3ee93f8 URL: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-09T13:37:20+02:00 acc: removed define for SQL_ACC - it was enabled for more than 10 years and the module links to lib/srdb1 anyhow --- Modified: src/modules/acc/Makefile Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc.h Modified: src/modules/acc/acc_cdr.c Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/acc_logic.h Modified: src/modules/acc/acc_mod.c Modified: src/modules/acc/acc_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba… Patch: https://github.com/kamailio/kamailio/commit/8eb6e6a01d435955939ceddee82b3ba…

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2017