sr-dev September 2017

sr-dev@lists.kamailio.org

26 participants
272 discussions

[kamailio/kamailio] Problem with process limit of count wtimer secondary process (#1237)
by Julien Chavanton 30 Sep '17

30 Sep '17

### Description Kamailio won't start after pulling from master Commit triggering the problem ``` git show ec15b23f25ba2502a661157ae69b4dc1db923f66 Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 1 12:00:06 2017 +0200 core: main - don't count wtimer secondary process separately - it is registered via sr_wtimer_init() - fixes the extra empty entry in process table reported by Juha Heinanen ``` #### Reproduction Always with specific configuration (I can diagnose further is needed) #### Log Messages When trying to start Kamailio ``` 0(26583) CRITICAL: <core> [core/pt.c:285]: fork_process(): Process limit of 13 exceeded. Will simulate fork fail. 0(26583) CRITICAL: <core> [main.c:1720]: main_loop(): cannot fork tcp main process: Invalid argument ``` ### Possible Solutions Not sure is the config I am using is not supported or if Kamailio code should be fixed. rolling back the commit is fixing the issue `git revert ec15b23f25ba2502a661157ae69b4dc1db923f66` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1237

2 11

Hello
by Subba Krishna MG 29 Sep '17

29 Sep '17

Hello, i am using Kamailio for SIP Presence server. When ever the Presence PUBLISH is received on kamailio, kamailio is sending 200 OK with out Expires IE. I want Kamailio to send Expires IE with 200 OK. How do i modify it. Can you please help me in this regard. Thank u MGSK

1 0

git:5.0:eabe0f84: htable: do not fork clean timer if no auto-expire is defined
by Daniel-Constantin Mierla 29 Sep '17

29 Sep '17

Module: kamailio Branch: 5.0 Commit: eabe0f84b46840d1164c83791c998021f9c42bd1 URL: https://github.com/kamailio/kamailio/commit/eabe0f84b46840d1164c83791c99802… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-29T19:01:03+02:00 htable: do not fork clean timer if no auto-expire is defined - match the same condition used in mod init to declare the extra process - reported by GH #1237 (cherry picked from commit dc15a8cd44fa17bb5ad12bf418c78af9f6e071e1) --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/eabe0f84b46840d1164c83791c99802… Patch: https://github.com/kamailio/kamailio/commit/eabe0f84b46840d1164c83791c99802… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 8f79c77d39..14973ee3f0 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -226,7 +226,7 @@ static int child_init(int rank) LM_DBG("rank is (%d)\n", rank); if(rank==PROC_MAIN) { - if(ht_timer_procs>0) { + if(ht_has_autoexpire() && ht_timer_procs>0) { for(i=0; i<ht_timer_procs; i++) { if(fork_sync_timer(PROC_TIMER, "HTable Timer", 1 /*socks flag*/, ht_timer, (void*)(long)i, ht_timer_interval)<0) {

1 0

git:master:dc15a8cd: htable: do not fork clean timer if no auto-expire is defined
by Daniel-Constantin Mierla 29 Sep '17

29 Sep '17

Module: kamailio Branch: master Commit: dc15a8cd44fa17bb5ad12bf418c78af9f6e071e1 URL: https://github.com/kamailio/kamailio/commit/dc15a8cd44fa17bb5ad12bf418c78af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-29T18:58:49+02:00 htable: do not fork clean timer if no auto-expire is defined - match the same condition used in mod init to declare the extra process - reported by GH #1237 --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/dc15a8cd44fa17bb5ad12bf418c78af… Patch: https://github.com/kamailio/kamailio/commit/dc15a8cd44fa17bb5ad12bf418c78af… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 40d1a558d1..bce82e96bb 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -232,7 +232,7 @@ static int child_init(int rank) LM_DBG("rank is (%d)\n", rank); if(rank==PROC_MAIN) { - if(ht_timer_procs>0) { + if(ht_has_autoexpire() && ht_timer_procs>0) { for(i=0; i<ht_timer_procs; i++) { if(fork_sync_timer(PROC_TIMER, "HTable Timer", 1 /*socks flag*/, ht_timer, (void*)(long)i, ht_timer_interval)<0) {

1 0

[kamailio/kamailio] v5.0.3: "kamdbctl create" fails to grant permissions on drouting sequences. (#1256)
by 00Asgaroth00 29 Sep '17

29 Sep '17

When attempting to create the extra modules tables using "kamdbctl create" using the PGSQL DBENGINE the create fails when kamdbctl tries to set the permissions on the sequences that are to be created with the table. Example output (dr_gateways): ``` # kamdbctl create INFO: creating database kamailio_alexia ... INFO: Core Kamailio tables succesfully created. INFO: creating presence tables into kamailio_alexia ... INFO: Presence tables succesfully created. INFO: creating extra tables into kamailio_alexia ... ERROR: relation "dr_gateways_id_seq" does not exist ERROR: relation "dr_gateways_id_seq" does not exist ERROR: Grant privileges to extra tables failed! ``` Example output (dr_rules) ``` # kamdbctl create INFO: creating database kamailio_alexia ... INFO: Core Kamailio tables succesfully created. INFO: creating presence tables into kamailio_alexia ... INFO: Presence tables succesfully created. INFO: creating extra tables into kamailio_alexia ... ERROR: relation "dr_rules_id_seq" does not exist ERROR: relation "dr_rules_id_seq" does not exist ERROR: Grant privileges to extra tables failed! ``` This appears to be related to to primary key being being different in these two tables compared to what kamdbctl expects. drouting-create.sql ``` # cat drouting-create.sql CREATE TABLE dr_gateways ( gwid SERIAL PRIMARY KEY NOT NULL, type INTEGER DEFAULT 0 NOT NULL, address VARCHAR(128) NOT NULL, strip INTEGER DEFAULT 0 NOT NULL, pri_prefix VARCHAR(64) DEFAULT NULL, attrs VARCHAR(255) DEFAULT NULL, description VARCHAR(128) DEFAULT '' NOT NULL ); INSERT INTO version (table_name, table_version) values ('dr_gateways','3'); CREATE TABLE dr_rules ( ruleid SERIAL PRIMARY KEY NOT NULL, groupid VARCHAR(255) NOT NULL, prefix VARCHAR(64) NOT NULL, timerec VARCHAR(255) NOT NULL, priority INTEGER DEFAULT 0 NOT NULL, routeid VARCHAR(64) NOT NULL, gwlist VARCHAR(255) NOT NULL, description VARCHAR(128) DEFAULT '' NOT NULL ); INSERT INTO version (table_name, table_version) values ('dr_rules','3'); CREATE TABLE dr_gw_lists ( id SERIAL PRIMARY KEY NOT NULL, gwlist VARCHAR(255) NOT NULL, description VARCHAR(128) DEFAULT '' NOT NULL ); INSERT INTO version (table_name, table_version) values ('dr_gw_lists','1'); CREATE TABLE dr_groups ( id SERIAL PRIMARY KEY NOT NULL, username VARCHAR(64) NOT NULL, domain VARCHAR(128) DEFAULT '' NOT NULL, groupid INTEGER DEFAULT 0 NOT NULL, description VARCHAR(128) DEFAULT '' NOT NULL ); INSERT INTO version (table_name, table_version) values ('dr_groups','2'); ``` Then in kamdbctl.pgsql we see the following section for granting permissions and this is where it appears to fail: kamdbctl.pgsql ``` 241 for TABLE in $EXTRA_TABLES; do 242 sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE $TABLE TO $DBRWUSER;" 243 sql_query "$1" "GRANT SELECT ON TABLE $TABLE TO $DBROUSER;" 244 if [ $TABLE != "route_tree" ] ; then 245 sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE "$TABLE"_id_seq TO $DBRWUSER;" 246 sql_query "$1" "GRANT SELECT ON TABLE "$TABLE"_id_seq TO $DBROUSER;" 247 fi 248 if [ $? -ne 0 ] ; then 249 merr "Grant privileges to extra tables failed!" 250 exit 1 251 fi 252 done ``` Here it clearly expects the primary key of each table to be called "id", and thus the associated sequences created will be ${TABLE}_id_seq, however in this case these fail as the primary keys for these two tables are named differently. If I modify the primary keys for the dr_gateways and dr_rules tables to be "id", then kamdbctl is able to complete creating the tables. Looking at the drouting module documentation it appears that the module expects these primary keys to be called "gwid" and "ruleid". Can someone take a look please. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1256

2 2

git:5.0:445adb04: kamctl: do not set privileges on drouting tables without id for pgsql
by Daniel-Constantin Mierla 29 Sep '17

29 Sep '17

Module: kamailio Branch: 5.0 Commit: 445adb0482a95f47dce518ecb403cbb1aa7cd1ac URL: https://github.com/kamailio/kamailio/commit/445adb0482a95f47dce518ecb403cbb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-29T18:26:08+02:00 kamctl: do not set privileges on drouting tables without id for pgsql - reported by #1256 (cherry picked from commit 711917153a4be290fd7e405c2c5578fe42ef9aff) --- Modified: utils/kamctl/kamdbctl.pgsql --- Diff: https://github.com/kamailio/kamailio/commit/445adb0482a95f47dce518ecb403cbb… Patch: https://github.com/kamailio/kamailio/commit/445adb0482a95f47dce518ecb403cbb… --- diff --git a/utils/kamctl/kamdbctl.pgsql b/utils/kamctl/kamdbctl.pgsql index 059b6faa82..c41354ffc6 100644 --- a/utils/kamctl/kamdbctl.pgsql +++ b/utils/kamctl/kamdbctl.pgsql @@ -241,9 +241,9 @@ done for TABLE in $EXTRA_TABLES; do sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE $TABLE TO $DBRWUSER;" sql_query "$1" "GRANT SELECT ON TABLE $TABLE TO $DBROUSER;" - if [ $TABLE != "route_tree" ] ; then + if [ $TABLE != "route_tree" ] && [ $TABLE != "dr_gateways" ] && [ $TABLE != "dr_rules" ] ; then sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE "$TABLE"_id_seq TO $DBRWUSER;" - sql_query "$1" "GRANT SELECT ON TABLE "$TABLE"_id_seq TO $DBROUSER;" + sql_query "$1" "GRANT SELECT ON TABLE "$TABLE"_id_seq TO $DBROUSER;" fi if [ $? -ne 0 ] ; then merr "Grant privileges to extra tables failed!"

1 0

git:master:71191715: kamctl: do not set privileges on drouting tables without id for pgsql
by Daniel-Constantin Mierla 29 Sep '17

29 Sep '17

Module: kamailio Branch: master Commit: 711917153a4be290fd7e405c2c5578fe42ef9aff URL: https://github.com/kamailio/kamailio/commit/711917153a4be290fd7e405c2c5578f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-29T18:21:53+02:00 kamctl: do not set privileges on drouting tables without id for pgsql - reported by #1256 --- Modified: utils/kamctl/kamdbctl.pgsql --- Diff: https://github.com/kamailio/kamailio/commit/711917153a4be290fd7e405c2c5578f… Patch: https://github.com/kamailio/kamailio/commit/711917153a4be290fd7e405c2c5578f… --- diff --git a/utils/kamctl/kamdbctl.pgsql b/utils/kamctl/kamdbctl.pgsql index 059b6faa82..c41354ffc6 100644 --- a/utils/kamctl/kamdbctl.pgsql +++ b/utils/kamctl/kamdbctl.pgsql @@ -241,9 +241,9 @@ done for TABLE in $EXTRA_TABLES; do sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE $TABLE TO $DBRWUSER;" sql_query "$1" "GRANT SELECT ON TABLE $TABLE TO $DBROUSER;" - if [ $TABLE != "route_tree" ] ; then + if [ $TABLE != "route_tree" ] && [ $TABLE != "dr_gateways" ] && [ $TABLE != "dr_rules" ] ; then sql_query "$1" "GRANT ALL PRIVILEGES ON TABLE "$TABLE"_id_seq TO $DBRWUSER;" - sql_query "$1" "GRANT SELECT ON TABLE "$TABLE"_id_seq TO $DBROUSER;" + sql_query "$1" "GRANT SELECT ON TABLE "$TABLE"_id_seq TO $DBROUSER;" fi if [ $? -ne 0 ] ; then merr "Grant privileges to extra tables failed!"

1 0

git:master:21808cd5: pkg/kamailio: removed gentoo symlink
by Daniel-Constantin Mierla 29 Sep '17

29 Sep '17

Module: kamailio Branch: master Commit: 21808cd59b56c0e60f4c06b30615697438e41a55 URL: https://github.com/kamailio/kamailio/commit/21808cd59b56c0e60f4c06b30615697… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-09-29T14:41:57+02:00 pkg/kamailio: removed gentoo symlink --- Removed: pkg/kamailio/gentoo --- Diff: https://github.com/kamailio/kamailio/commit/21808cd59b56c0e60f4c06b30615697… Patch: https://github.com/kamailio/kamailio/commit/21808cd59b56c0e60f4c06b30615697… --- diff --git a/pkg/kamailio/gentoo b/pkg/kamailio/gentoo deleted file mode 120000 index 6cd8d42a99..0000000000 --- a/pkg/kamailio/gentoo +++ /dev/null @@ -1 +0,0 @@ -../ser/gentoo/ \ No newline at end of file

1 0

git:master:1542b5bf: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 29 Sep '17

29 Sep '17

Module: kamailio Branch: master Commit: 1542b5bf2a34b597e6b98870829f2248822b6294 URL: https://github.com/kamailio/kamailio/commit/1542b5bf2a34b597e6b98870829f224… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-09-29T14:16:30+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/1542b5bf2a34b597e6b98870829f224… Patch: https://github.com/kamailio/kamailio/commit/1542b5bf2a34b597e6b98870829f224…

1 0

git:master:67f2e8d9: Merge pull request #1253 from claudiupb/implement-stop-recording
by GitHub 29 Sep '17

29 Sep '17

Module: kamailio Branch: master Commit: 67f2e8d93ba670c88b5fc89f74d21f3fa097244d URL: https://github.com/kamailio/kamailio/commit/67f2e8d93ba670c88b5fc89f74d21f3… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: GitHub <noreply(a)github.com> Date: 2017-09-29T08:03:29-04:00 Merge pull request #1253 from claudiupb/implement-stop-recording Add stop_recording function, and make start/stop_recording functions accept flags --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine.h --- Diff: https://github.com/kamailio/kamailio/commit/67f2e8d93ba670c88b5fc89f74d21f3… Patch: https://github.com/kamailio/kamailio/commit/67f2e8d93ba670c88b5fc89f74d21f3…

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2017