sr-dev January 2018

sr-dev@lists.kamailio.org

35 participants
368 discussions

Fosdem dinner
by Daniel-Constantin Mierla 03 Feb '18

03 Feb '18

Hello, in the past 10 years or so, many of us met at Fosdem conference in Brussels (the edition this year happens during February 3-4) and had a dinner on Saturday evening. I know already couple of people from community that will go there, so the question is if there is any interest to organize again such event. If yes, it will be again on Saturday, on the evening of the 3rd of February. At the past editions, it turned into an all-RTC dinner, but we can consider to have it alone again (eventually with few other invited friends), if there are too many or people want a smaller meeting. Reply this week if you want to join, so we can estimate how many seats we need and have enough time to find a place that can accommodate us. More about Fosdem can be found at: - https://fosdem.org There is a devroom on Sunday with topics covering real time communications. I will have a presentation there. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - March 5-7, 2018, Berlin - www.asipto.com Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

7 10

[kamailio/kamailio] textops: Support RFC3264 for is_audio_on_hold() function (#1292)
by JuliaBoud 02 Feb '18

02 Feb '18

Function "is_audio_on_hold()" has support for rfc2543 only, where "hold" is indicated by setting the "c" destination addresses for the media streams to zero (0.0.0.0). Could you please add support for rfc3264 for this function, where "hold" is indicated by a=sendonly/inactive. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1292

2 2

[kamailio/kamailio] presence: add API endpoints to update presentity and notify watchers (#1417)
by Emmanuel Schmidbauer 01 Feb '18

01 Feb '18

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1417 -- Commit Summary -- * presence: add API endpoints to update presentity and notify watchers -- File Changes -- M src/modules/presence/bind_presence.c (2) M src/modules/presence/bind_presence.h (5) M src/modules/presence/presence.c (16) M src/modules/presence/presence.h (1) M src/modules/presence/presentity.c (133) M src/modules/presence/presentity.h (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1417.patch https://github.com/kamailio/kamailio/pull/1417.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1417

3 17

git:master:7bb6fa17: modules: readme files regenerated - app_python ... [skip ci]
by Kamailio Dev 31 Jan '18

31 Jan '18

Module: kamailio Branch: master Commit: 7bb6fa1794735803668e077e80597b41533d0cca URL: https://github.com/kamailio/kamailio/commit/7bb6fa1794735803668e077e80597b4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-01-31T21:31:24+01:00 modules: readme files regenerated - app_python ... [skip ci] --- Modified: src/modules/app_python/README --- Diff: https://github.com/kamailio/kamailio/commit/7bb6fa1794735803668e077e80597b4… Patch: https://github.com/kamailio/kamailio/commit/7bb6fa1794735803668e077e80597b4… --- diff --git a/src/modules/app_python/README b/src/modules/app_python/README index 8fcad886e9..54ea0697c7 100644 --- a/src/modules/app_python/README +++ b/src/modules/app_python/README @@ -167,7 +167,8 @@ python_exec("my_python_function", "$rU"); 5.1. app_python.reload - IMPORTANT: not implemented yet. + IMPORTANT: not functional yet (can crash a running instance, use it + only for testing). Marks the need to reload the js script. The actual reload is done by every working process when the next call to KEMI config is executed.

1 0

git:master:9e16ac86: app_python: adjusted the note about incomplete implementation for rpc reload
by Daniel-Constantin Mierla 31 Jan '18

31 Jan '18

Module: kamailio Branch: master Commit: 9e16ac869646ff62f648f9a822ffcc12a4614037 URL: https://github.com/kamailio/kamailio/commit/9e16ac869646ff62f648f9a822ffcc1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-31T21:20:16+01:00 app_python: adjusted the note about incomplete implementation for rpc reload --- Modified: src/modules/app_python/doc/app_python_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9e16ac869646ff62f648f9a822ffcc1… Patch: https://github.com/kamailio/kamailio/commit/9e16ac869646ff62f648f9a822ffcc1… --- diff --git a/src/modules/app_python/doc/app_python_admin.xml b/src/modules/app_python/doc/app_python_admin.xml index 9afeffb03f..50191f562d 100644 --- a/src/modules/app_python/doc/app_python_admin.xml +++ b/src/modules/app_python/doc/app_python_admin.xml @@ -165,7 +165,8 @@ python_exec("my_python_function", "$rU"); <function moreinfo="none">app_python.reload</function> </title> <para> - IMPORTANT: not implemented yet. + IMPORTANT: not functional yet (can crash a running instance, + use it only for testing). </para> <para> Marks the need to reload the js script.

1 0

git:master:39d98127: rtpegnine: honour the 'setid_default' variable in all instances
by Richard Fuchs 31 Jan '18

31 Jan '18

Module: kamailio Branch: master Commit: 39d98127268afdfa841e7c80ce26185fe8d0673c URL: https://github.com/kamailio/kamailio/commit/39d98127268afdfa841e7c80ce26185… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2018-01-31T12:10:16-05:00 rtpegnine: honour the 'setid_default' variable in all instances --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/39d98127268afdfa841e7c80ce26185… Patch: https://github.com/kamailio/kamailio/commit/39d98127268afdfa841e7c80ce26185… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6ad0c16d7e..f9e630f60e 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -734,14 +734,6 @@ struct rtpp_set *get_rtpp_set(unsigned int set_id) unsigned int my_current_id = 0; int new_list; -#if DEFAULT_RTPP_SET_ID > 0 - if (set_id < DEFAULT_RTPP_SET_ID ) - { - LM_ERR(" invalid rtpproxy set value [%u]\n", set_id); - return NULL; - } -#endif - my_current_id = set_id; /*search for the current_id*/ lock_get(rtpp_set_list->rset_head_lock); @@ -798,7 +790,7 @@ struct rtpp_set *get_rtpp_set(unsigned int set_id) rtpp_set_list->rset_last = rtpp_list; rtpp_set_count++; - if(my_current_id == DEFAULT_RTPP_SET_ID){ + if(my_current_id == setid_default){ default_rtpp_set = rtpp_list; } } @@ -1010,7 +1002,7 @@ static int rtpengine_add_rtpengine_set(char * rtp_proxies, unsigned int weight, rtp_proxies+=2; }else{ rtp_proxies = p; - my_current_id = DEFAULT_RTPP_SET_ID; + my_current_id = setid_default; } for(;*rtp_proxies && isspace(*rtp_proxies);rtp_proxies++); @@ -1490,10 +1482,6 @@ mod_init(void) } } - /* any rtpproxy configured? */ - if (rtpp_set_list) - default_rtpp_set = select_rtpp_set(DEFAULT_RTPP_SET_ID); - if (rtp_inst_pv_param.s) { rtp_inst_pv_param.len = strlen(rtp_inst_pv_param.s); rtp_inst_pvar = pv_cache_get(&rtp_inst_pv_param);

1 0

git:master:3430db51: siptrace: replaced use of copy defines with formated string functions
by Daniel-Constantin Mierla 30 Jan '18

30 Jan '18

Module: kamailio Branch: master Commit: 3430db51cabfca102109da582b355c0fd725523a URL: https://github.com/kamailio/kamailio/commit/3430db51cabfca102109da582b355c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-30T22:49:32+01:00 siptrace: replaced use of copy defines with formated string functions --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/3430db51cabfca102109da582b355c0… Patch: https://github.com/kamailio/kamailio/commit/3430db51cabfca102109da582b355c0…

1 0

[kamailio/kamailio] pua: removed null pointer access from subscribe_cbparam() (#1409)
by Christoph VALENTIN 30 Jan '18

30 Jan '18

A newly introduced condition in an if () statement leads to core dump in some scenarios. It is removed.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Without this Change a core dump happens in the P-CSCF during handling the SIP REGISTER. Obviously a condition was added to an if() Statement, which itself created a null pointer Access. This additional Statement was removed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1409 -- Commit Summary -- * pua: removed null pointer access from subscribe_cbparam() -- File Changes -- M src/modules/pua/send_subscribe.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1409.patch https://github.com/kamailio/kamailio/pull/1409.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1409

2 5

git:master:00da0530: Merge pull request #1418 from kamailio/json-update-api
by GitHub 30 Jan '18

30 Jan '18

Module: kamailio Branch: master Commit: 00da0530c7295b74b932307bad27580e14c3a987 URL: https://github.com/kamailio/kamailio/commit/00da0530c7295b74b932307bad27580… Author: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Committer: GitHub <noreply(a)github.com> Date: 2018-01-30T10:09:10-05:00 Merge pull request #1418 from kamailio/json-update-api json: pass str pointer to API --- Modified: src/modules/json/api.h Modified: src/modules/json/json_funcs.h Modified: src/modules/json/json_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/00da0530c7295b74b932307bad27580… Patch: https://github.com/kamailio/kamailio/commit/00da0530c7295b74b932307bad27580… --- diff --git a/src/modules/json/api.h b/src/modules/json/api.h index c900dd5c0d..0610eaffeb 100644 --- a/src/modules/json/api.h +++ b/src/modules/json/api.h @@ -26,7 +26,7 @@ typedef struct json_object *(*json_parse_f) (const char *str); typedef struct json_object *(*json_get_object_f) (struct json_object *json_obj, const char *str); -typedef str (*json_extract_field_f) (struct json_object *json_obj, char *json_name); +typedef int (*json_extract_field_f) (struct json_object *json_obj, char *json_name, str *var); typedef struct json_api { json_parse_f json_parse; diff --git a/src/modules/json/json_funcs.h b/src/modules/json/json_funcs.h index 331d1e3df8..747232efac 100644 --- a/src/modules/json/json_funcs.h +++ b/src/modules/json/json_funcs.h @@ -29,18 +29,18 @@ int json_get_field(struct sip_msg* msg, char* json, char* field, char* dst); -#define json_extract_field(json_name, field) \ - do { \ +#define json_extract_field(json_name, field) \ + do { \ struct json_object *obj = json_get_object(json_obj, json_name); \ - field.s = (char *)json_object_get_string(obj); \ - if(field.s == NULL) { \ - LM_DBG("Json-c error - failed to extract field [%s]\n", \ - json_name); \ - field.s = ""; \ - } else { \ - field.len = strlen(field.s); \ - } \ - LM_DBG("%s: [%s]\n", json_name, field.s ? field.s : "Empty"); \ + field->s = (char *)json_object_get_string(obj); \ + if(field->s == NULL) { \ + LM_DBG("Json-c error - failed to extract field [%s]\n", \ + json_name); \ + field->s = ""; \ + } else { \ + field->len = strlen(field->s); \ + } \ + LM_DBG("%s: [%s]\n", json_name, field->s ? field->s : "Empty"); \ } while(0); diff --git a/src/modules/json/json_mod.c b/src/modules/json/json_mod.c index 051da4dd59..f5de53d692 100644 --- a/src/modules/json/json_mod.c +++ b/src/modules/json/json_mod.c @@ -65,10 +65,9 @@ struct module_exports exports = { 0 /* per-child init function */ }; -str _json_extract_field(struct json_object *json_obj, char *json_name) { - str val = {0, 0}; +int _json_extract_field(struct json_object *json_obj, char *json_name, str *val) { json_extract_field(json_name, val); - return val; + return 0; } /**

1 0

git:master:26b09ae0: json: pass str pointer to API
by Emmanuel Schmidbauer 30 Jan '18

30 Jan '18

Module: kamailio Branch: master Commit: 26b09ae0d9b36dfed9688536e7f8cd6ff22d89fd URL: https://github.com/kamailio/kamailio/commit/26b09ae0d9b36dfed9688536e7f8cd6… Author: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Committer: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Date: 2018-01-29T12:42:29-07:00 json: pass str pointer to API --- Modified: src/modules/json/api.h Modified: src/modules/json/json_funcs.h Modified: src/modules/json/json_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/26b09ae0d9b36dfed9688536e7f8cd6… Patch: https://github.com/kamailio/kamailio/commit/26b09ae0d9b36dfed9688536e7f8cd6… --- diff --git a/src/modules/json/api.h b/src/modules/json/api.h index c900dd5c0d..0610eaffeb 100644 --- a/src/modules/json/api.h +++ b/src/modules/json/api.h @@ -26,7 +26,7 @@ typedef struct json_object *(*json_parse_f) (const char *str); typedef struct json_object *(*json_get_object_f) (struct json_object *json_obj, const char *str); -typedef str (*json_extract_field_f) (struct json_object *json_obj, char *json_name); +typedef int (*json_extract_field_f) (struct json_object *json_obj, char *json_name, str *var); typedef struct json_api { json_parse_f json_parse; diff --git a/src/modules/json/json_funcs.h b/src/modules/json/json_funcs.h index 331d1e3df8..747232efac 100644 --- a/src/modules/json/json_funcs.h +++ b/src/modules/json/json_funcs.h @@ -29,18 +29,18 @@ int json_get_field(struct sip_msg* msg, char* json, char* field, char* dst); -#define json_extract_field(json_name, field) \ - do { \ +#define json_extract_field(json_name, field) \ + do { \ struct json_object *obj = json_get_object(json_obj, json_name); \ - field.s = (char *)json_object_get_string(obj); \ - if(field.s == NULL) { \ - LM_DBG("Json-c error - failed to extract field [%s]\n", \ - json_name); \ - field.s = ""; \ - } else { \ - field.len = strlen(field.s); \ - } \ - LM_DBG("%s: [%s]\n", json_name, field.s ? field.s : "Empty"); \ + field->s = (char *)json_object_get_string(obj); \ + if(field->s == NULL) { \ + LM_DBG("Json-c error - failed to extract field [%s]\n", \ + json_name); \ + field->s = ""; \ + } else { \ + field->len = strlen(field->s); \ + } \ + LM_DBG("%s: [%s]\n", json_name, field->s ? field->s : "Empty"); \ } while(0); diff --git a/src/modules/json/json_mod.c b/src/modules/json/json_mod.c index 051da4dd59..f5de53d692 100644 --- a/src/modules/json/json_mod.c +++ b/src/modules/json/json_mod.c @@ -65,10 +65,9 @@ struct module_exports exports = { 0 /* per-child init function */ }; -str _json_extract_field(struct json_object *json_obj, char *json_name) { - str val = {0, 0}; +int _json_extract_field(struct json_object *json_obj, char *json_name, str *val) { json_extract_field(json_name, val); - return val; + return 0; } /**

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2018