sr-dev January 2018

sr-dev@lists.kamailio.org

35 participants
368 discussions

[kamailio/kamailio] to tags generation (#1164)

by Dmitri Savolainen

### Description Not shure is this relevant issue. according to rfc3261: > When a tag is generated by a UA for insertion into a request or > response, it MUST be globally unique and cryptographically random > with at least 32 bits of randomness. Kamailio has 16 instead and distribution is not good. I look at tags for 419485 sip flows (different callid) and table below (top keys ordered by count): tag suffix; count for different flows with this suffix ed54 6258 d118 5988 56ce 5923 a7a5 5220 de51 2150 82d8 1143 cf52 890 af92 740 7b5f 534 85f7 307 e553 163 7f7e 138 1d55 130 1afe 62 5a69 43 7caa 18 8474 18 9db2 18 11d3 18 f9ff 18 5420 17 dae6 17 908d 17 ede4 17 09ee 17 96be 17 25dc 17 af6d 16 2506 16 3da0 16 f161 16 1c29 16 #### SIP Traffic To: <sip:039*101@host:5071>;tag=555d2c3eafafcba8ac92b676e91bb6ed.58eb -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1164

5 years, 2 months

[kamailio/kamailio] token parser (#648)

by Dmitri Savolainen

i try script: ``` $var(some_string) = 'a=foo1;b=foo2;c=foo3,4,5;d=3'; $var(c_value) = $(var(some_string){param.value,c,;}); xlog("L_INFO", "'c' param from '$var(some_string)' is '$var(c_value)'"); ``` in log: > 'c' param from 'a=foo1;b=foo2;c=foo3,4,5;d=3' is 'foo3' Has this behaviour any reason? or it's possible to delete comma from stop list (and use separator parameter for comma-delimited list)? ``` diff --git a/parser/parse_param.c b/parser/parse_param.c index b9e0fbc..e7784c8 100644 --- a/parser/parse_param.c +++ b/parser/parse_param.c @@ -355,7 +355,6 @@ static inline int parse_token_param(str* _s, str* _r, char separator) case '\t': case '\r': case '\n': - case ',': /* So if you find * any of them * stop iterating ``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/648

5 years, 5 months

[kamailio/kamailio] core:server_id is not sufficient enough to store the one that is generated for the ipv6 socket (#1322)

by Surendra Tiwari

### Description i want to give decimal value of ip address to the server_id but when i am converting the ipv6 address to decimal then its bigger then integer range.so here in kamailio, we need to update every place where ever we are using server id by int64.we need to also make changes to database also by changing the server_id field type. ### Troubleshooting #### Reproduction issue can be reproduced by following steps: first get the server_id by converting the ipv6 ip address to decimal so whenever any endpoint register it will store the -1 into database as integer range is reached to limit. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.0.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 13:58:01 Nov 20 2017 with unknown ``` * **Operating System**:  ``` root@ip-172-31-0-35:~# uname -a Linux ip-172-31-0-35 4.4.0-1022-aws #31-Ubuntu SMP Tue Jun 27 11:27:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1322

5 years, 5 months

$fU pv Assign New Value Isnt Rewrite old value

by Cléviton Mendes de Araújo

Hi,Kamailio Community Is there a bug when we assign new value to $fU pseudo-variable multi time? My scenery is according below: In a point on config file, let us that $fU value is: 7777. When I do assign: ..... $fU = "5555" + $fU; ### Here $fU = 55557777 ..... In another point, let us that value $sht(htble=>$var(nnnn)) hold is: 44444444. And I do: ..... $fU = $sht(htble=>$var(nnnn)); #### Here, it seems that this is happening $fU = 5555777744444444 ..... When I turn on ngrep analysis, I catch From header: ................. ................. From: "User Name" <sip:5555777744444444@IP-Address> ................. ................. This two assignments are realizing on same route block. So, it seems to be a bug. Best Regards, CMA

5 years, 5 months

[kamailio] dialog: run event_route[dialog:end] in case of dialog termination by … (#246)

by Andrey Utkin

…interface commands You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/246 -- Commit Summary -- * dialog: run event_route[dialog:end] in case of dialog termination by interface commands -- File Changes -- M modules/dialog/dlg_req_within.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/246.patch https://github.com/kamailio/kamailio/pull/246.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/246

5 years, 5 months

[kamailio/kamailio] cfgt: wrong flow if route has no last action return (#569)

by Victor Seva

The actual implementation is based on the cfg actions, so when there is no 'return' action defined the route flow detected is wrong. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/569

5 years, 7 months

[kamailio/kamailio] Statistics: Average duration of DNS requests (#821)

by ng-voice GmbH

Hi, we do a lot of DNS requests (ENUM, Domain-Lookups, etc.). It would be quite awesome, if Kamailio would produce a statistic on the average duration of a DNS-Query. Thanks, Carsten P.S.: It would also be nice, to have similar stats on MySQL-DB-Queries. One day, if I find time.... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/821

5 years, 8 months

[kamailio] dialog module with broken defaults (#372)

by zabbal

If I enable dialog module Kamailio will fail to start with following error: ERROR: dialog [dialog.c:498]: mod_init(): no dlg flag set!! In the documentation this parameter is set to 4 as an example: modparam("dialog", "dlg_flag", 4) But no comments made as to why number 4 is used, which numbers are possible to use and most importantly - why such default value is chosen? In any case - module should use default which does not break server's configuration. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/372

5 years, 9 months

[kamailio/kamailio] Rich redirects (#1243)

by Alex Hermann

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  If Kamailio sends a 301/302, the current dset is added as Contact header automatically. The feature in this PR will optionally extend this Contact header with more information. - The path vector for each contact can be added as a Contact-uri Route header (rfc 3327 conformant). - The branch flags can be added as a Contact-header parameter (non-standard). In addition, the get_redirects function is extended to optionally parse the new flags parameter. The Route header can be extracted from the r-uri in the script. The new functionality must be enabled with module parameters, by default the behavior is unchanged. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1243 -- Commit Summary -- * core: Cleanup printing the dset * core: dset: Create Contacts header with path vector as Route header * core: dset: Create contacts with flags as header parameter * core modules/tm modules/sl: Make adding path and flags to redirected contacts optional * core: Increase MAX_REDIRECTION_LEN from 512 to 4096 * uac_redirect: Parse Contact's "flags" header parameter into branch flags. -- File Changes -- M src/core/config.h (2) M src/core/dset.c (252) M src/core/dset.h (6) M src/core/parser/contact/contact.c (2) M src/core/parser/contact/contact.h (1) M src/core/parser/parse_param.c (11) M src/core/parser/parse_param.h (2) M src/modules/pv/pv_core.c (2) M src/modules/sl/doc/sl_params.xml (30) M src/modules/sl/sl.c (1) M src/modules/sl/sl_funcs.c (5) M src/modules/sl/sl_funcs.h (2) M src/modules/tm/doc/params.xml (30) M src/modules/tm/t_reply.c (4) M src/modules/tm/tm.c (1) M src/modules/uac_redirect/doc/uac_redirect_admin.xml (40) M src/modules/uac_redirect/rd_funcs.c (11) M src/modules/uac_redirect/rd_funcs.h (2) M src/modules/uac_redirect/uac_redirect.c (2) M src/modules/xprint/xp_lib.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1243.patch https://github.com/kamailio/kamailio/pull/1243.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1243

5 years, 9 months

[kamailio/kamailio] BLOG conversion (#1255)

by sergey-safarov

### Description I use kazoo and postgres modules on my host. I found that many database operation generates error like ``` 19(150) exec: *** cfgtrace:request_route=[kazoo:consumer-event-presence-dialog-update] c=[//etc/kamailio/presence-role.cfg] l=270 a=32 n=kazoo_pua_publish_presence 17(148) exec: *** cfgtrace:request_route=[kazoo:consumer-event-presence-dialog-update] c=[//etc/kamailio/presence-role.cfg] l=271 a=27 n=pres_refresh_watchers Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ 17(148) ERROR: presence_xml [notify_body.c:551]: agregate_xmls(): while parsing xml body message 17(148) ERROR: presence_xml [notify_body.c:156]: pres_agg_nbody(): while aggregating body 19(150) exec: *** cfgtrace:request_route=[kazoo:consumer-event-presence-dialog-update] c=[//etc/kamailio/presence-role.cfg] l=271 a=27 n=pres_refresh_watchers Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ 19(150) ERROR: presence_xml [notify_body.c:551]: agregate_xmls(): while parsing xml body message 19(150) ERROR: presence_xml [notify_body.c:156]: pres_agg_nbody(): while aggregating body 18(149) exec: *** cfgtrace:request_route=[kazoo:consumer-event-nodes-advertise] c=[//etc/kamailio/nodes-role.cfg] l=66 a=63 n=assign 18(149) exec: *** cfgtrace:request_route=[kazoo:consumer-event-nodes-advertise] c=[//etc/kamailio/nodes-role.cfg] l=74 a=16 n=if 18(149) exec: *** cfgtrace:request_route=[kazoo:consumer-event-nodes-advertise] c=[//etc/kamailio/nodes-role.cfg] l=74 a=16 n=if 18(149) exec: *** cfgtrace:request_route=[kazoo:consumer-event-nodes-advertise] c=[//etc/kamailio/nodes-role.cfg] l=75 a=27 n=mq_add Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ 17(148) ERROR: presence_xml [notify_body.c:551]: agregate_xmls(): while parsing xml body message 17(148) ERROR: presence_xml [notify_body.c:156]: pres_agg_nbody(): while aggregating body Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ 19(150) ERROR: presence_xml [notify_body.c:551]: agregate_xmls(): while parsing xml body message 19(150) ERROR: presence_xml [notify_body.c:156]: pres_agg_nbody(): while aggregating body Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ 17(148) ERROR: presence_xml [notify_body.c:551]: agregate_xmls(): while parsing xml body message 17(148) ERROR: presence_xml [notify_body.c:156]: pres_agg_nbody(): while aggregating body 17(148) exec: *** cfgtrace:request_route=[kazoo:consumer-event-presence-dialog-update] c=[//etc/kamailio/presence-role.cfg] l=276 a=26 n=xlog 17(148) INFO: <script>: 3O75Qw3gqR3ZNla5RfCgQLVW0-8KKbrT|log|finished processing dialog update for sip:2496@rcsnet.ru state confirmed from sip:217.12.247.98:11000 at 1506632313/1506632313/1506632313 Entity: line 1: parser error : Start tag expected, '<' not found \x3c3f786d6c2076657273696f6e3d22312e302220656e636f64696e673d225554462d38223f3e3c ^ ``` After some debugging i found that kamailio wants save to database xml string like this as BLOB object ``` <?xml version="1.0" encoding="UTF-8"?><presence xmlns="urn:ietf:params:xml:ns:pidf" xmlns:dm="urn:ietf:params:xml:ns:pidf:data-model" xmlns:rpid="urn:ietf:params:xml:ns:pidf:rpid" xmlns:c="urn:ietf:params:xml:ns:pidf:cipid" entity="2496"> <tuple xmlns="urn:ietf:params:xml:ns:pidf" id="t8No1hQnp65U33jS1oqFMgxbIRPq-iFP"><status><basic>open</basic></status></tuple><note xmlns="urn:ietf:params:xml:ns:pidf">On the Phone</note><dm:person xmlns:dm="urn:ietf:params:xml:ns:pidf:data-model" xmlns:rpid="urn:ietf:params:xml:ns:pidf:rpid" id="1"><rpid:activities><rpid:on-the-phone/></rpid:activities><dm:note>On the Phone</dm:note></dm:person></presence> ``` And later tries to read. But when this XML read reverse conversion of BLOB to string is not take place. And late used BLOB as is. This breaks presentation logic completely. #### Reproduction Configure kamailio on kazoo cluster to use PostgreSQL database On phone create subscribe to second >From second phone create new call. #### Operating System CentOS 7 Linux node2.docker.rcsnet.ru 3.10.0-514.16.1.el7.x86_64 #1 SMP Wed Apr 12 15:04:24 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1255

5 years, 9 months

← Newer
1
2
3
4
5
6
7
...
37
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2018