sr-dev October 2018

sr-dev@lists.kamailio.org

23 participants
274 discussions

git:master:5e763029: kex: safety check for accessing CSeq in per method stats
by Daniel-Constantin Mierla 25 Oct '18

25 Oct '18

Module: kamailio Branch: master Commit: 5e763029dc207c99796adc1c3ace71cf6de59446 URL: https://github.com/kamailio/kamailio/commit/5e763029dc207c99796adc1c3ace71c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-25T07:07:52+02:00 kex: safety check for accessing CSeq in per method stats - GH #1687 --- Modified: src/modules/kex/core_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/5e763029dc207c99796adc1c3ace71c… Patch: https://github.com/kamailio/kamailio/commit/5e763029dc207c99796adc1c3ace71c… --- diff --git a/src/modules/kex/core_stats.c b/src/modules/kex/core_stats.c index 2f51a1f955..ef4d85dad8 100644 --- a/src/modules/kex/core_stats.c +++ b/src/modules/kex/core_stats.c @@ -234,8 +234,17 @@ static int km_cb_req_stats(struct sip_msg *msg, static int km_cb_rpl_stats_by_method(struct sip_msg *msg, unsigned int flags, void *param) { - int method = get_cseq(msg)->method_id; - int group = msg->first_line.u.reply.statuscode / 100 - 1; + int method = 0; + int group = 0; + + if(msg==NULL) { + return -1; + } + if (!msg->cseq && (parse_headers(msg, HDR_CSEQ_F, 0) < 0 || !msg->cseq)) { + return -1; + } + method = get_cseq(msg)->method_id; + group = msg->first_line.u.reply.statuscode / 100 - 1; if (group >= 0 && group <= 5) { switch(method) {

1 0

Pull request example
by Diego Nadares 25 Oct '18

25 Oct '18

Hi guys, I hit a little bug in evapi module. I would like to do a pull request but i don't know exactly how to accomplish this. I found this howto -> https://yangsu.github.io/pull-request-tutorial . Are these the correct steps? I tried but it's forbidden for my user. git checkout -b pull-request-demo git push origin pull-request-demo remote: Permission to kamailio/kamailio.git denied to dnadares. fatal: unable to access 'https://github.com/kamailio/kamailio.git/': The requested URL returned error: 403 Could you help me, please? Thanks in advance. Diego

2 3

Pull request example
by Diego Nadares 24 Oct '18

24 Oct '18

1 0

git:master:e87feb9f: modules: readme files regenerated - topos ... [skip ci]
by Kamailio Dev 24 Oct '18

24 Oct '18

Module: kamailio Branch: master Commit: e87feb9f11c1dde9710bf3ef3ef5e6626b735233 URL: https://github.com/kamailio/kamailio/commit/e87feb9f11c1dde9710bf3ef3ef5e66… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-10-24T15:01:48+02:00 modules: readme files regenerated - topos ... [skip ci] --- Modified: src/modules/topos/README --- Diff: https://github.com/kamailio/kamailio/commit/e87feb9f11c1dde9710bf3ef3ef5e66… Patch: https://github.com/kamailio/kamailio/commit/e87feb9f11c1dde9710bf3ef3ef5e66… --- diff --git a/src/modules/topos/README b/src/modules/topos/README index e745e4b9cf..d75a9de697 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -172,7 +172,7 @@ modparam("topos", "mask_callid", 1) 3.4. sanity_checks (int) - If set to 1, topoh module will bind to sanity module in order to + If set to 1, topos module will bind to sanity module in order to perform sanity checks over received SIP request. Default sanity checks are done. It is useful to check if received request is well formatted before proceeding to encoding/decoding. @@ -181,7 +181,7 @@ modparam("topos", "mask_callid", 1) Example 1.4. Set sanity_checks parameter ... -modparam("topoh", "sanity_checks", 1) +modparam("topos", "sanity_checks", 1) ... 3.5. branch_expire (int)

1 0

git:master:56c40ebe: topos: docs - replaced c&p topoh with topos
by Daniel-Constantin Mierla 24 Oct '18

24 Oct '18

Module: kamailio Branch: master Commit: 56c40ebefcbe0954c5c40470b22d4f26e163a2d0 URL: https://github.com/kamailio/kamailio/commit/56c40ebefcbe0954c5c40470b22d4f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-24T14:49:10+02:00 topos: docs - replaced c&p topoh with topos --- Modified: src/modules/topos/doc/topos_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/56c40ebefcbe0954c5c40470b22d4f2… Patch: https://github.com/kamailio/kamailio/commit/56c40ebefcbe0954c5c40470b22d4f2… --- diff --git a/src/modules/topos/doc/topos_admin.xml b/src/modules/topos/doc/topos_admin.xml index 281706b79b..b81672b006 100644 --- a/src/modules/topos/doc/topos_admin.xml +++ b/src/modules/topos/doc/topos_admin.xml @@ -150,7 +150,7 @@ modparam("topos", "mask_callid", 1) <section id="topos.p.sanity_checks"> <title><varname>sanity_checks</varname> (int)</title> <para> - If set to 1, topoh module will bind to sanity module in order + If set to 1, topos module will bind to sanity module in order to perform sanity checks over received SIP request. Default sanity checks are done. It is useful to check if received request is well formatted before proceeding to encoding/decoding. @@ -164,7 +164,7 @@ modparam("topos", "mask_callid", 1) <title>Set <varname>sanity_checks</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("topoh", "sanity_checks", 1) +modparam("topos", "sanity_checks", 1) ... </programlisting> </example>

1 0

Info: Pre-announcement about Kamailio World 2019
by Daniel-Constantin Mierla 24 Oct '18

24 Oct '18

Hello, being asked couple of times recently, for now I am sending a short note to say that the next edition of Kamailio World Conference is likely to take place at the same location in the city center of Berlin, Germany, during May 6-8, 2019. There are still some bits to sort out before making the dates final, so just have the dates in mind at this moment. Once all is set from organising point of view, we will make the official announcement. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

1 0

git:master:97855a17: core: cfg select - safety check accessing vars before initialization
by Daniel-Constantin Mierla 19 Oct '18

19 Oct '18

Module: kamailio Branch: master Commit: 97855a1766edf4ecc2cc4e38f3cc0d3cea3190db URL: https://github.com/kamailio/kamailio/commit/97855a1766edf4ecc2cc4e38f3cc0d3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-19T11:34:08+02:00 core: cfg select - safety check accessing vars before initialization --- Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/97855a1766edf4ecc2cc4e38f3cc0d3… Patch: https://github.com/kamailio/kamailio/commit/97855a1766edf4ecc2cc4e38f3cc0d3… --- diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c index b8b5d265a0..175c6bd589 100644 --- a/src/core/cfg/cfg_select.c +++ b/src/core/cfg/cfg_select.c @@ -220,7 +220,12 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) break; case CFG_VAR_STR: - memcpy(res, p, sizeof(str)); + if(p) { + memcpy(res, p, sizeof(str)); + } else { + res->s = 0; + res->len = 0; + } break; default:

1 0

git:master:f4fb19db: pkg/kamailio/deb: version set to 5.2.0~pre1
by Victor Seva 19 Oct '18

19 Oct '18

Module: kamailio Branch: master Commit: f4fb19dbdadb5a6fb55b83804f5064dee6f98a4f URL: https://github.com/kamailio/kamailio/commit/f4fb19dbdadb5a6fb55b83804f5064d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-10-19T10:36:52+02:00 pkg/kamailio/deb: version set to 5.2.0~pre1 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f4fb19dbdadb5a6fb55b83804f5064d… Patch: https://github.com/kamailio/kamailio/commit/f4fb19dbdadb5a6fb55b83804f5064d…

1 0

git:master:85290210: Makefile.defs: version set to 5.2.0-pre1
by Daniel-Constantin Mierla 19 Oct '18

19 Oct '18

Module: kamailio Branch: master Commit: 85290210f05be46a04109b4f850e379c54f1a6a4 URL: https://github.com/kamailio/kamailio/commit/85290210f05be46a04109b4f850e379… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-19T09:50:46+02:00 Makefile.defs: version set to 5.2.0-pre1 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/85290210f05be46a04109b4f850e379… Patch: https://github.com/kamailio/kamailio/commit/85290210f05be46a04109b4f850e379… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index da9e95585a..52167a5899 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -pre0 +EXTRAVERSION = -pre1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:82f7a6a7: ims_ipsec_pcscf: free memory on errors and variable supported
by Daniel-Constantin Mierla 19 Oct '18

19 Oct '18

Module: kamailio Branch: master Commit: 82f7a6a7f5c370442860a84a36ff449228bf1273 URL: https://github.com/kamailio/kamailio/commit/82f7a6a7f5c370442860a84a36ff449… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-19T09:36:00+02:00 ims_ipsec_pcscf: free memory on errors and variable supported --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/82f7a6a7f5c370442860a84a36ff449… Patch: https://github.com/kamailio/kamailio/commit/82f7a6a7f5c370442860a84a36ff449… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index e0eeea8764..17e6c7b000 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -357,15 +357,19 @@ int add_supported_secagree_header(struct sip_msg* m) if((supported->s = pkg_malloc(supported_sec_agree_len)) == NULL) { LM_ERR("Error allcationg pkg memory for supported header str\n"); + pkg_free(supported); return -1; } memcpy(supported->s, supported_sec_agree, supported_sec_agree_len); supported->len = supported_sec_agree_len; if(cscf_add_header(m, supported, HDR_SUPPORTED_T) != 1) { + pkg_free(supported->s); + pkg_free(supported); LM_ERR("Error adding security header to reply!\n"); return -1; } + pkg_free(supported); return 0; }

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2018