sr-dev October 2018

sr-dev@lists.kamailio.org

23 participants
274 discussions

git:master:c1bb3244: pkg/docker: updated submodule
by Sergey Safarov 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: c1bb32440e25a2c0751b9fc4b11d829ee6bbf636 URL: https://github.com/kamailio/kamailio/commit/c1bb32440e25a2c0751b9fc4b11d829… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2018-10-01T14:12:44Z pkg/docker: updated submodule --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/c1bb32440e25a2c0751b9fc4b11d829… Patch: https://github.com/kamailio/kamailio/commit/c1bb32440e25a2c0751b9fc4b11d829… --- diff --git a/pkg/docker b/pkg/docker index 5e6a821c3a..3c8a156abe 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit 5e6a821c3ab9b4c07729daa49ce2c6eb17ddbc15 +Subproject commit 3c8a156abef2a034d9a21df5bf73f4b5cc4d3e05

1 0

git:master:fe19995b: tm: reset the tm cell content during free
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: fe19995ba150beca0acf6f4bdc1bb92f3c8348e1 URL: https://github.com/kamailio/kamailio/commit/fe19995ba150beca0acf6f4bdc1bb92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T08:59:56+02:00 tm: reset the tm cell content during free --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/fe19995ba150beca0acf6f4bdc1bb92… Patch: https://github.com/kamailio/kamailio/commit/fe19995ba150beca0acf6f4bdc1bb92… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 1ec5747207..d4c86db9b5 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -253,6 +253,7 @@ void free_cell_helper( xavp_destroy_list_unsafe(&dead_cell->xavps_list); #endif + memset(dead_cell, 0, sizeof(tm_cell_t)); /* the cell's body */ shm_free_unsafe(dead_cell);

1 0

git:5.1:c2f0c834: nathelper: initialize local variable
by Luis Azedo 01 Oct '18

01 Oct '18

Module: kamailio Branch: 5.1 Commit: c2f0c834e9400d412f958e489887e90b234812a2 URL: https://github.com/kamailio/kamailio/commit/c2f0c834e9400d412f958e489887e90… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2018-10-01T20:36:38+01:00 nathelper: initialize local variable (cherry picked from commit c814f9fb6aa20ae18253f0d165795516a8869085) --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/c2f0c834e9400d412f958e489887e90… Patch: https://github.com/kamailio/kamailio/commit/c2f0c834e9400d412f958e489887e90… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 4042af3b1a..c616aa42eb 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1646,7 +1646,7 @@ static int ki_fix_nated_sdp(sip_msg_t *msg, int level) static int fix_nated_sdp_f(struct sip_msg *msg, char *str1, char *str2) { int level; - str ip; + str ip = {0,0}; if(fixup_get_ivalue(msg, (gparam_t *)str1, &level) != 0) { LM_ERR("failed to get value for first parameter\n");

1 0

git:5.1:0f839536: Revert "nathelper: fix call to alter_mediaip"
by Luis Azedo 01 Oct '18

01 Oct '18

Module: kamailio Branch: 5.1 Commit: 0f8395361acc9976dd20e8189b89ff4bed93a53e URL: https://github.com/kamailio/kamailio/commit/0f8395361acc9976dd20e8189b89ff4… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2018-10-01T20:35:48+01:00 Revert "nathelper: fix call to alter_mediaip" This reverts commit 17c14a966ff3ba67ce858dfe424d7cdf5100d4fa. (cherry picked from commit 3892c78ac59a7d894a5dc8804c20df07b52cc795) --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/0f8395361acc9976dd20e8189b89ff4… Patch: https://github.com/kamailio/kamailio/commit/0f8395361acc9976dd20e8189b89ff4… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 3c478c68b5..4042af3b1a 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1531,7 +1531,7 @@ static inline int replace_sdp_ip( body2.s = oldip.s + oldip.len; body2.len = bodylimit - body2.s; ret = alter_mediaip( - msg, &body2, &oldip, pf, &newip, pf, sdp_oldmediaip); + msg, &body1, &oldip, pf, &newip, pf, sdp_oldmediaip); if(ret == -1) { LM_ERR("can't alter '%s' IP\n", line); return -1;

1 0

[kamailio/kamailio] nathelper: initialize local variable (#1661)
by lazedo 01 Oct '18

01 Oct '18

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  previous PR #1655 was wrong and tests at the time didn't hit the correct path in the code, sorry for that. this pr reverts #1655 and properly initializes a variable You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1661 -- Commit Summary -- * Revert "nathelper: fix call to alter_mediaip" * nathelper: initialize local variable -- File Changes -- M src/modules/nathelper/nathelper.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1661.patch https://github.com/kamailio/kamailio/pull/1661.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1661

2 4

git: new commits in branch 5.1
by Daniel-Constantin Mierla 01 Oct '18

01 Oct '18

- URL: https://github.com/kamailio/kamailio/commit/fdc74217580a526b1848406b308c656… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:31:22+02:00 core: more info in log message when sendto() fails (cherry picked from commit 317701dc3d1ddb27395ded873a3055af2d029a5a) - URL: https://github.com/kamailio/kamailio/commit/bff608273684aa472547fb9bfccded2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:32:37+02:00 usrloc: use sruid_next_safe() (cherry picked from commit fd30ccf4473d43d98cfb0d896c47d4824c089bce) - URL: https://github.com/kamailio/kamailio/commit/592438a1991f5b2f4dca977032d0a2c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:32:49+02:00 registrar: use sruid_next_safe() (cherry picked from commit 89676b9774ecc0f72272b7027821a9531dc1a6ea) - URL: https://github.com/kamailio/kamailio/commit/514b2eb25b36f0a59c0897a462b276e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:33:04+02:00 nathelper: exported fix_nated_sdp() variants to KEMI framework (cherry picked from commit 0d14ce8bf45ada579f7ec85793d358a5fa32e4b7) - URL: https://github.com/kamailio/kamailio/commit/7141049975f265c8bb9cb9758e6fe65… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:33:40+02:00 path: use memcpy() instead of strncpy() - avoid gcc 8.2 warning: âstrncpyâ output truncated before terminating nul (cherry picked from commit daad89a516f1f298ef8f71505d7ab93b35fe76db) - URL: https://github.com/kamailio/kamailio/commit/8b8fccedeaede8e1d4828e4ccdd380b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:33:50+02:00 core: use parentesis to surround condtion on raw_ipip header size (cherry picked from commit 55575264332e07611c269873c9ce0b5a63c35454) - URL: https://github.com/kamailio/kamailio/commit/938db9426d005d99416ec4453b53135… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:34:10+02:00 core: use memcpy() instead of strncpy() - avoid gcc 8.2 warning: âstrncpyâ output truncated before terminating nul (cherry picked from commit 9e13c9512b48ab9522f508465c6031e7b4a96086) - URL: https://github.com/kamailio/kamailio/commit/5f1178f090916054aeccfe57db22e04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:34:28+02:00 tls: update to default session id value to reflect major version (cherry picked from commit 491e19eb47384162cba64fd9f043e77574ce5017) - URL: https://github.com/kamailio/kamailio/commit/1d86c8c858aa6362c0f7bd10d513573… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2018-10-01T20:35:06+02:00 src: Fix misspelled Kamailio (cherry picked from commit 62790cc279550fef9ce3f7a6c0ee8dcc055f9625) - URL: https://github.com/kamailio/kamailio/commit/5c5cfcf379cf9ecf74a3d2646bfaa91… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2018-10-01T20:35:17+02:00 rtpproxy: fix comment typo (cherry picked from commit f7ac556e699d323e816c14a554122c87d38b3a83) - URL: https://github.com/kamailio/kamailio/commit/09ea75e9100405a48ea7f2c9285b360… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2018-10-01T20:35:27+02:00 uac_redirect: fix documentation typo (cherry picked from commit f788766522cb0f9bb8bca42954337889198462ee) - URL: https://github.com/kamailio/kamailio/commit/8dda2f02b4bfdac65f73834d9251385… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2018-10-01T20:35:37+02:00 core: fix comment typo (cherry picked from commit 37fb1b68675c637c4d9bbfbc27572b2c748ad673) - URL: https://github.com/kamailio/kamailio/commit/edd92385da03cb64ed4ce38450bc5a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:35:51+02:00 mem: q_malloc - better log message on ignoring double free (cherry picked from commit 2cd82d39fe0fccf3237eb9947fd16b0be15c2270) - URL: https://github.com/kamailio/kamailio/commit/a5d77172fc9a2dac5eb711f2672437c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:36:01+02:00 mem: f_malloc - better log message on ignoring double free (cherry picked from commit 434518953c507b41b80adaf1a39b7b8f1e9a3048) - URL: https://github.com/kamailio/kamailio/commit/d42c2415acdb951ad93c68511257971… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-01T20:36:19+02:00 tm: warn message on unexpected fcount value (cherry picked from commit 1d24e36d95b97e41bc76949bdd8ba2a24babdffe) - URL: https://github.com/kamailio/kamailio/commit/24246a9206209a1417ced0dcd5bb2f7… Author: Markus BÃ¶nke <mb(a)tenios.de> Date: 2018-10-01T20:38:18+02:00 db_unixodbc: added section ids, updated application name (cherry picked from commit 636c8b5ab16bbac4a8a9db70476ffd93bf2d13cf)

1 0

git:master:dd9615e7: modules/lcr: tried to test unsigned int values against both DB1_INT
by Juha Heinanen 01 Oct '18

01 Oct '18

Module: kamailio Branch: master Commit: dd9615e7b0e20a2f63f380ee16837def985676aa URL: https://github.com/kamailio/kamailio/commit/dd9615e7b0e20a2f63f380ee16837de… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2018-10-01T20:43:43+03:00 modules/lcr: tried to test unsigned int values against both DB1_INT and DB1_UINT --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/dd9615e7b0e20a2f63f380ee16837de… Patch: https://github.com/kamailio/kamailio/commit/dd9615e7b0e20a2f63f380ee16837de…

1 0

module related crash
by Juha Heinanen 01 Oct '18

01 Oct '18

I have one local module and updated its module interface to the new one. Then I build K, started it and got a crash. I thought that it must my mistake in the module interface update, but when I looked at the core dump, it did point to another module: (gdb) where #0 0x00005643e66fd349 in register_module (e=0x7f494a5cb4a0 <exports>, path=0x7f494ce1a9d0 "/usr/lib/x86_64-linux-gnu/sip-proxy/modules/cfg_rpc.so", handle=0x5643e8151500) at core/sr_module.c:230 #1 0x00005643e670341d in load_module (mod_path=0x7f494ce1a930 "cfg_rpc") at core/sr_module.c:567 #2 0x00005643e6918741 in yyparse () at core/cfg.y:1704 #3 0x00005643e65ca49e in main (argc=18, argv=0x7ffd36a27948) at main.c:2141 -- Juha

2 16

git:master:c814f9fb: nathelper: initialize local variable
by lazedo 01 Oct '18

01 Oct '18

Module: kamailio Branch: master Commit: c814f9fb6aa20ae18253f0d165795516a8869085 URL: https://github.com/kamailio/kamailio/commit/c814f9fb6aa20ae18253f0d16579551… Author: Luis Azedo <luis(a)2600hz.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2018-10-01T17:13:05+02:00 nathelper: initialize local variable --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/c814f9fb6aa20ae18253f0d16579551… Patch: https://github.com/kamailio/kamailio/commit/c814f9fb6aa20ae18253f0d16579551… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index bb9c99767f..27015b7bd8 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1644,7 +1644,7 @@ static int ki_fix_nated_sdp(sip_msg_t *msg, int level) static int fix_nated_sdp_f(struct sip_msg *msg, char *str1, char *str2) { int level; - str ip; + str ip = {0,0}; if(fixup_get_ivalue(msg, (gparam_t *)str1, &level) != 0) { LM_ERR("failed to get value for first parameter\n");

1 0

git:master:3892c78a: Revert "nathelper: fix call to alter_mediaip"
by lazedo 01 Oct '18

01 Oct '18

Module: kamailio Branch: master Commit: 3892c78ac59a7d894a5dc8804c20df07b52cc795 URL: https://github.com/kamailio/kamailio/commit/3892c78ac59a7d894a5dc8804c20df0… Author: Luis Azedo <luis(a)2600hz.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2018-10-01T17:13:05+02:00 Revert "nathelper: fix call to alter_mediaip" This reverts commit 17c14a966ff3ba67ce858dfe424d7cdf5100d4fa. --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/3892c78ac59a7d894a5dc8804c20df0… Patch: https://github.com/kamailio/kamailio/commit/3892c78ac59a7d894a5dc8804c20df0… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 09b385f389..bb9c99767f 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1529,7 +1529,7 @@ static inline int replace_sdp_ip( body2.s = oldip.s + oldip.len; body2.len = bodylimit - body2.s; ret = alter_mediaip( - msg, &body2, &oldip, pf, &newip, pf, sdp_oldmediaip); + msg, &body1, &oldip, pf, &newip, pf, sdp_oldmediaip); if(ret == -1) { LM_ERR("can't alter '%s' IP\n", line); return -1;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2018