Hello,
if there is no other opinion, I am considering to create git branch 5.2
at the beginning of next week (likely on Monday evening), to be used for
5.2.x release series.
>From that moment, the master branch can get new features and the
appropriate bug fixes have to be backported to branch 5.2 as well.
With this step, the first release in 5.2.x series, respectively v5.2.0,
should be out in about 2-3 weeks.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com
In the struct `int param_no` is set to `2`. But `dp_replace()` has actually three
parameters `(dpid, inval, outvar)`, so kamailio's cfg parser fails when
`dp_replace()` is called:
```
yyparse(): cfg. parser: failed to find command dp_replace (params 3)
yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 366, column 45: unknown command, missing loadmodule?
```
This commit fixes `int param_no` to address this.
Signed-off-by: Sebastian Kemper <sebastian_ml(a)gmx.net>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [+] Commit message has the format required by CONTRIBUTING guide
- [+] Commits are split per component (core, individual modules, libs, utils, ...)
- [+] Each component has a single commit (if not, squash them into one commit)
- [+] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [+] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [+] PR should be backported to stable branches
- [+] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Hi all,
When trying out dp_replace() kamailio (5.1.6) wouldn't start. It was expecting 2 parameters instead of 3. This PR fixes that.
Kind regards,
Seb
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1704
-- Commit Summary --
* dialplan: fix dp_replace() in cmd_export_t struct
-- File Changes --
M src/modules/dialplan/dialplan.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1704.patchhttps://github.com/kamailio/kamailio/pull/1704.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1704
Module: kamailio
Branch: master
Commit: 2159e7b2af772beebe3af290c92f8e88ed864daf
URL: https://github.com/kamailio/kamailio/commit/2159e7b2af772beebe3af290c92f8e8…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2018-11-02T09:16:27+01:00
modules: readme files regenerated - db_redis ... [skip ci]
---
Modified: src/modules/db_redis/README
---
Diff: https://github.com/kamailio/kamailio/commit/2159e7b2af772beebe3af290c92f8e8…
Patch: https://github.com/kamailio/kamailio/commit/2159e7b2af772beebe3af290c92f8e8…
---
diff --git a/src/modules/db_redis/README b/src/modules/db_redis/README
index 75f31cf213..1a5c33caef 100644
--- a/src/modules/db_redis/README
+++ b/src/modules/db_redis/README
@@ -134,6 +134,12 @@ nce/string,server_id/int,connection_id/int,keepalive/int,partition/int
'address:entry::1', address:entry::2', address:entry::3', ... No 'keys'
modparam of 'db_redis' for 'address' table needs to be defined.
+ Important Note: at this moment the module requires at least one 'keys'
+ parameter, but it does not need to be related to the table loaded from
+ Redis server -- for example, if used only for permissions module with
+ 'address' table, then the 'keys' parameter can be specified for
+ 'version' table.
+
The mappings can be freely defined in the "keys" module parameter,
which is composed of a semi-colon separated list of definitions in the
format
@@ -231,6 +237,7 @@ loadmodule "db_redis.so"
#!define DBURL_PERM "redis://127.0.0.1:6379/8"
...
modparam("db_redis", "schema_path", "/usr/share/kamailio/db_redis/kamailio")
+modparam("db_redis", "keys", "version=entry:table_name")
modparam("db_redis", "keys", "location=entry:ruid&usrdom:username,domain&timer:p
artition,keepalive")
modparam("db_redis", "keys", "acc=entry:callid,time_hires&cid:callid")
Module: kamailio
Branch: master
Commit: 47a22c49a84941c8065c0dfa91fb0d07716126c1
URL: https://github.com/kamailio/kamailio/commit/47a22c49a84941c8065c0dfa91fb0d0…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2018-11-02T09:11:11+01:00
db_redis: docs - added note that keys parameter must be specified
---
Modified: src/modules/db_redis/doc/db_redis_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/47a22c49a84941c8065c0dfa91fb0d0…
Patch: https://github.com/kamailio/kamailio/commit/47a22c49a84941c8065c0dfa91fb0d0…
---
diff --git a/src/modules/db_redis/doc/db_redis_admin.xml b/src/modules/db_redis/doc/db_redis_admin.xml
index 9e5a7a2cbd..9c147a022b 100644
--- a/src/modules/db_redis/doc/db_redis_admin.xml
+++ b/src/modules/db_redis/doc/db_redis_admin.xml
@@ -76,6 +76,13 @@ username/string,domain/string,contact/string,received/string,path/string,expires
records can be: 'address:entry::1', address:entry::2', address:entry::3', ... No
'keys' modparam of 'db_redis' for 'address' table needs to be defined.
</para>
+ <para>
+ Important Note: at this moment the module requires at least one 'keys'
+ parameter, but it does not need to be related to the table loaded
+ from Redis server -- for example, if used only for permissions module with
+ 'address' table, then the 'keys' parameter can be specified for
+ 'version' table.
+ </para>
<para>
The mappings can be freely defined in the "keys" module parameter, which is
composed of a semi-colon separated list of definitions in the format
@@ -219,6 +226,7 @@ loadmodule "db_redis.so"
#!define DBURL_PERM "redis://127.0.0.1:6379/8"
...
modparam("db_redis", "schema_path", "/usr/share/kamailio/db_redis/kamailio")
+modparam("db_redis", "keys", "version=entry:table_name")
modparam("db_redis", "keys", "location=entry:ruid&usrdom:username,domain&timer:partition,keepalive")
modparam("db_redis", "keys", "acc=entry:callid,time_hires&cid:callid")
modparam("db_redis", "keys", "subscriber=entry:username,domain")