Module: kamailio
Branch: 4.4
Commit: b8ea200ee2f905b57beccfa4053b5f7d691aa371
URL: https://github.com/kamailio/kamailio/commit/b8ea200ee2f905b57beccfa4053b5f7…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2018-02-26T11:12:02+01:00
pkg/kamailio/deb: version set to 4.4.7
---
Modified: pkg/kamailio/deb/debian/changelog
Modified: pkg/kamailio/deb/jessie/changelog
Modified: pkg/kamailio/deb/precise/changelog
Modified: pkg/kamailio/deb/sid/changelog
Modified: pkg/kamailio/deb/squeeze/changelog
Modified: pkg/kamailio/deb/stretch/changelog
Modified: pkg/kamailio/deb/trusty/changelog
Modified: pkg/kamailio/deb/wheezy/changelog
Modified: pkg/kamailio/deb/xenial/changelog
---
Diff: https://github.com/kamailio/kamailio/commit/b8ea200ee2f905b57beccfa4053b5f7…
Patch: https://github.com/kamailio/kamailio/commit/b8ea200ee2f905b57beccfa4053b5f7…
---
diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/debian/changelog
+++ b/pkg/kamailio/deb/debian/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/jessie/changelog b/pkg/kamailio/deb/jessie/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/jessie/changelog
+++ b/pkg/kamailio/deb/jessie/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/precise/changelog b/pkg/kamailio/deb/precise/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/precise/changelog
+++ b/pkg/kamailio/deb/precise/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/sid/changelog b/pkg/kamailio/deb/sid/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/sid/changelog
+++ b/pkg/kamailio/deb/sid/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/squeeze/changelog b/pkg/kamailio/deb/squeeze/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/squeeze/changelog
+++ b/pkg/kamailio/deb/squeeze/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/stretch/changelog b/pkg/kamailio/deb/stretch/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/stretch/changelog
+++ b/pkg/kamailio/deb/stretch/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/trusty/changelog b/pkg/kamailio/deb/trusty/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/trusty/changelog
+++ b/pkg/kamailio/deb/trusty/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/wheezy/changelog b/pkg/kamailio/deb/wheezy/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/wheezy/changelog
+++ b/pkg/kamailio/deb/wheezy/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
diff --git a/pkg/kamailio/deb/xenial/changelog b/pkg/kamailio/deb/xenial/changelog
index 7b26f390d4..44c2096500 100644
--- a/pkg/kamailio/deb/xenial/changelog
+++ b/pkg/kamailio/deb/xenial/changelog
@@ -1,3 +1,9 @@
+kamailio (4.4.7) unstable; urgency=medium
+
+ * version set to 4.4.7
+
+ -- Victor Seva <vseva(a)debian.org> Mon, 26 Feb 2018 11:11:19 +0100
+
kamailio (4.4.6) unstable; urgency=medium
* version set to 4.4.6
Module: kamailio
Branch: master
Commit: 025b22999e2826fdb4183e05b0008407551527d6
URL: https://github.com/kamailio/kamailio/commit/025b22999e2826fdb4183e05b000840…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2018-02-26T08:22:31+01:00
ims_dialog: updated application name
---
Modified: src/modules/ims_dialog/dlg_var.c
Modified: src/modules/ims_dialog/dlg_var.h
---
Diff: https://github.com/kamailio/kamailio/commit/025b22999e2826fdb4183e05b000840…
Patch: https://github.com/kamailio/kamailio/commit/025b22999e2826fdb4183e05b000840…
---
diff --git a/src/modules/ims_dialog/dlg_var.c b/src/modules/ims_dialog/dlg_var.c
index 7972333d8a..e0648c6dc7 100644
--- a/src/modules/ims_dialog/dlg_var.c
+++ b/src/modules/ims_dialog/dlg_var.c
@@ -1,17 +1,16 @@
/**
- * $Id$
*
* Copyright (C) 2009 Daniel-Constantin Mierla (asipto.com)
* Copyright (C) 2011 Carsten Bock, carsten(a)ng-voice.com
*
* This file is part of kamailio, a free SIP server.
*
- * openser is free software; you can redistribute it and/or modify
+ * kamailio is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version
*
- * openser is distributed in the hope that it will be useful,
+ * kamailio is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
diff --git a/src/modules/ims_dialog/dlg_var.h b/src/modules/ims_dialog/dlg_var.h
index f5753075ef..706028dd20 100644
--- a/src/modules/ims_dialog/dlg_var.h
+++ b/src/modules/ims_dialog/dlg_var.h
@@ -1,17 +1,15 @@
/**
- * $Id$
- *
* Copyright (C) 2009 Daniel-Constantin Mierla (asipto.com)
* Copyright (C) 2011 Carsten Bock, carsten(a)ng-voice.com
*
* This file is part of kamailio, a free SIP server.
*
- * openser is free software; you can redistribute it and/or modify
+ * kamailio is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version
*
- * openser is distributed in the hope that it will be useful,
+ * kamailio is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
@@ -20,7 +18,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
-
+
#ifndef _DLG_VAR_H_
#define _DLG_VAR_H_
This module implements a generic db driver for kamailio. It
requires a "schema" and "key" definition of "tables" and corresponding
keys for redis in the kamailio config file, otherwise it's supposed to
work with every module.
Implemented methods are query (w/o order-by), insert, update, delete.
Tested with usrloc and acc.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #1137
#### Description
<!-- Describe your changes in detail -->
This module implements a generic db driver for redis, to be used by any module (with the help of some schema configuration in the config file).
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1432
-- Commit Summary --
* db_redis: Implement db_redis generic db driver
-- File Changes --
M src/Makefile.groups (2)
A src/modules/db_redis/Makefile (37)
A src/modules/db_redis/README (199)
A src/modules/db_redis/db_redis_mod.c (109)
A src/modules/db_redis/db_redis_mod.h (31)
A src/modules/db_redis/doc/Makefile (4)
A src/modules/db_redis/doc/db_redis.xml (37)
A src/modules/db_redis/doc/db_redis_admin.xml (190)
A src/modules/db_redis/redis_connection.c (287)
A src/modules/db_redis/redis_connection.h (71)
A src/modules/db_redis/redis_dbase.c (2056)
A src/modules/db_redis/redis_dbase.h (92)
A src/modules/db_redis/redis_table.c (697)
A src/modules/db_redis/redis_table.h (63)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1432.patchhttps://github.com/kamailio/kamailio/pull/1432.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1432
Hello,
(cross-posting being something I want to get developers and users
express their opinions).
We were recently in a (lucky) situation to have two new modules
submissions targeting more or less the same purpose: allowing to use
Kamailio with a Redis backend via database API.
One was submitted by Andreas Granig (Sipwise) and already merged with
the name db_redis, because it was designed from the beginning as a
generic DB connector, so the module can be used with auth_db, acc,
usrloc, ...
* https://www.kamailio.org/docs/modules/devel/modules/db_redis.html
The second one was submitted by Surendra Tiwari (Plivo), initially
having a naming conflict with db_redis, but renamed to db_redisusrloc,
see the pull request at:
* https://github.com/kamailio/kamailio/pull/1446
Now, this email is about deciding the way to go forward with the second
module.
It was designed to be used only for usrloc in the first phase, with many
specific usrloc attributes hard coded inside db_redisusrloc. Surendra
said (in a private chat) that the long term plan is to make it work for
other modules. Anyhow, at this moment is very tied to usrloc, therefore
the name of the module.
Given that the backend (Redis) is not an SQL engine, mapping over
Kamailio's DB API needs some schema definition (see the readme of
db_redis) in order to make it generic and work for all our modules that
use a DB backend.
On the other hand, to squeeze the best of the backend, specially in
no-SQL cases, having a dedicated DB connector module optimized for a
specific module might help to get more
performances/high-availability/scalability from the backend itself.
In this case, for example the expires value for a contact record can be
set inside redis, so kamailio module doesn't have to run a timer routine
to clean up (it doesn't mean db_redisusrloc does it right now, I didn't
have time for a proper review, just giving an example). Surendra said
they use it in production for couple of months now and it is several
times faster than using usrloc with db_postgres (iirc, not db_mysql) for
db_mode=3 (database only mode).
But of course, the reverse of the medal with a dedicated db connector
for a module: it adds overhead to code maintenance (besides generic
updates due to external library changes, I expect changing something
relevant in usrloc, like adding new columns, would require updates in
this module as well).
So, there are few things I want feedback on:
1) how do you fill about splitting from a generic-only DB connectors to
have also some dedicated ones? This is more from confusion point of
view, as a general rule so far, we do not deny contributions if there
are other options for same kind of feature (e.g., many lcr or nat
traversal options). As long as the contributor is willing to maintain
the code, we were fine.
2) I guess usrloc, presence and dialog modules would be the main
suspects that would benefit for such dedicated connectors, in other
cases might not worth adding dedicated connectors. Missing any other
module one would like to squeeze more performances with a dedicated
connector?
3) should we set a different naming policy for such modules, for
example: use *dbs_* prefix instead *db_*, to suggest better it is a
DataBase Specific connector?
4) Andreas said he plans to do some performance testing of usrloc module
with the two modules and see the differences. Anyone else that wants to
do it? It can be a good metric to see if it worth going one way or another?
5) Helping to review the pull request, specially if you use Redis, is
appreciated. Personally I am very short in available time these days,
next week I plan do to new Kamailio stable releases, so the schedule is
not getting lighter in my side.
Cheers,
Daniel
--
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - March 5-7, 2018, Berlin - www.asipto.com
Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com
Module: kamailio
Branch: 4.4
Commit: d2409502e003edec9fecda977bf15b2103d17a45
URL: https://github.com/kamailio/kamailio/commit/d2409502e003edec9fecda977bf15b2…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2018-02-22T13:16:13+01:00
modules: readme files regenerated - nathelper ... [skip ci]
---
Modified: modules/nathelper/README
Modified: modules/sdpops/README
Modified: modules/textops/README
---
Diff: https://github.com/kamailio/kamailio/commit/d2409502e003edec9fecda977bf15b2…
Patch: https://github.com/kamailio/kamailio/commit/d2409502e003edec9fecda977bf15b2…
---
diff --git a/modules/nathelper/README b/modules/nathelper/README
index 4d08229c06..ac0273d6bc 100644
--- a/modules/nathelper/README
+++ b/modules/nathelper/README
@@ -252,7 +252,7 @@ Chapter 1. Admin Guide
Example 1.1. Set force_socket parameter
...
-modparam("nathelper", "force_socket", "localhost:33333")
+modparam("nathelper", "force_socket", "127.0.0.1:5060")
...
4.2. natping_interval (integer)
diff --git a/modules/sdpops/README b/modules/sdpops/README
index 387858ae17..c34084e367 100644
--- a/modules/sdpops/README
+++ b/modules/sdpops/README
@@ -35,7 +35,7 @@ Daniel-Constantin Mierla
4.7. sdp_with_active_media(type)
4.8. sdp_remove_media(type)
4.9. sdp_with_transport(type)
- 4.10. sdp_with_transport_like(string)
+ 4.10. sdp_with_transport_like(type)
4.11. sdp_transport(pv)
4.12. sdp_remove_transport(type)
4.13. sdp_with_codecs_by_id(list)
@@ -90,7 +90,7 @@ Chapter 1. Admin Guide
4.7. sdp_with_active_media(type)
4.8. sdp_remove_media(type)
4.9. sdp_with_transport(type)
- 4.10. sdp_with_transport_like(string)
+ 4.10. sdp_with_transport_like(type)
4.11. sdp_transport(pv)
4.12. sdp_remove_transport(type)
4.13. sdp_with_codecs_by_id(list)
@@ -142,7 +142,7 @@ Chapter 1. Admin Guide
4.7. sdp_with_active_media(type)
4.8. sdp_remove_media(type)
4.9. sdp_with_transport(type)
- 4.10. sdp_with_transport_like(string)
+ 4.10. sdp_with_transport_like(type)
4.11. sdp_transport(pv)
4.12. sdp_remove_transport(type)
4.13. sdp_with_codecs_by_id(list)
@@ -321,26 +321,27 @@ sdp_remove_media("video");
4.9. sdp_with_transport(type)
Return true of the SDP has 'media=media port type ...' line. Useful to
- check the transport of the RTP sessions, such as 'RTP/AVP', 'RTP/SAVP'
- or 'RTP/SAVPF'. The parameter can be static string or variable holding
- the transport type.
+ check the transport of the RTP sessions, such as 'RTP/AVP', 'RTP/SAVP',
+ 'RTP/SAVPF' or 'UDP/TLS/RTP/SAVPF'. The parameter can be static string
+ or variable holding the transport type. The function does an exact
+ match of the strings.
This function can be used from ANY_ROUTE.
Example 1.9. sdp_with_transport usage
...
# check for RTP/SAVP stream
-if(sdp_with_transport("RTP/SAVP"))
+if(sdp_with_transport("UDP/TLS/RTP/SAVPF"))
{
- # the session has a SRTP/SAVP stream
+ # the session has a UDP/TLS/RTP/SAVPF stream
}
...
-4.10. sdp_with_transport_like(string)
+4.10. sdp_with_transport_like(type)
Returns true if the SDP has 'media=media port type ...' line, where
- type contains string. The parameter can be static string or variable
- holding a string.
+ type contains the string in the parameter. The parameter can be static
+ string or variable holding a string.
This function can be used from ANY_ROUTE.
diff --git a/modules/textops/README b/modules/textops/README
index 752607e39f..a3938c4874 100644
--- a/modules/textops/README
+++ b/modules/textops/README
@@ -999,7 +999,7 @@ if (starts_with("$rU", "+358"))
The core will take care of the last boundary ending "--". Detecting
wich one is the last and fixing the others if needed.
- Note: it may be required that msg_apply_changes() from textops module
+ Note: it may be required that msg_apply_changes() from textopsx module
has to be executed if there are other operations over the new body.
Example 1.37. set_body_multipart usage