sr-dev February 2018

sr-dev@lists.kamailio.org

33 participants
355 discussions

git:5.1:df9389a6: app_lua: do lua_checkstack() to ensure enough capacity on Lua stack
by Daniel-Constantin Mierla 12 Feb '18

12 Feb '18

Module: kamailio Branch: 5.1 Commit: df9389a613e16f15b860af60222abe43ca367d09 URL: https://github.com/kamailio/kamailio/commit/df9389a613e16f15b860af60222abe4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-12T08:42:38+01:00 app_lua: do lua_checkstack() to ensure enough capacity on Lua stack - Lua doesn't do automatic management of the stack * http://www.lua.org/manual/5.1/manual.html#3.2 - do exit on insufficient capacity - based on the report by GH #1433 (cherry picked from commit f6d69d87abdc48df22135c79ee2309248248ca8e) --- Modified: src/modules/app_lua/app_lua_sr.c --- Diff: https://github.com/kamailio/kamailio/commit/df9389a613e16f15b860af60222abe4… Patch: https://github.com/kamailio/kamailio/commit/df9389a613e16f15b860af60222abe4… --- diff --git a/src/modules/app_lua/app_lua_sr.c b/src/modules/app_lua/app_lua_sr.c index 86380ec6ad..64ebafae40 100644 --- a/src/modules/app_lua/app_lua_sr.c +++ b/src/modules/app_lua/app_lua_sr.c @@ -1970,10 +1970,14 @@ void lua_sr_kemi_register_libs(lua_State *L) } n++; } + if(!lua_checkstack(L, i+8)) { + LM_ERR("not enough Lua stack capacity\n"); + exit(-1); + } luaL_openlib(L, mname, _sr_crt_KSRMethods, 0); - LM_DBG("initializing kemi sub-module: %s (%s)\n", mname, - emods[k].kexp[0].mname.s); + LM_DBG("initializing kemi sub-module: %s (%s) (%d/%d/%d)\n", mname, + emods[k].kexp[0].mname.s, i, k, n); } } - LM_DBG("module 'KSR' has been initialized\n"); + LM_DBG("module 'KSR' has been initialized (%d/%d)\n", emods_size, n); }

1 0

git:master:0476993b: core: kemi - eol for debug message
by Daniel-Constantin Mierla 12 Feb '18

12 Feb '18

Module: kamailio Branch: master Commit: 0476993b7c341bcc7a994ab52986b89f240bd3b0 URL: https://github.com/kamailio/kamailio/commit/0476993b7c341bcc7a994ab52986b89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-12T08:25:18+01:00 core: kemi - eol for debug message --- Modified: src/core/kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/0476993b7c341bcc7a994ab52986b89… Patch: https://github.com/kamailio/kamailio/commit/0476993b7c341bcc7a994ab52986b89… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index 55630c28f5..5631f4b909 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -1342,7 +1342,7 @@ int sr_kemi_eng_register(str *ename, sr_kemi_eng_route_f froute) _sr_kemi_eng_list[_sr_kemi_eng_list_size].froute = froute; _sr_kemi_eng_list_size++; - LM_DBG("registered config routing enginge [%.*s]", + LM_DBG("registered config routing enginge [%.*s]\n", ename->len, ename->s); return 0;

1 0

git:master:f6d69d87: app_lua: do lua_checkstack() to ensure enough capacity on Lua stack
by Daniel-Constantin Mierla 12 Feb '18

12 Feb '18

Module: kamailio Branch: master Commit: f6d69d87abdc48df22135c79ee2309248248ca8e URL: https://github.com/kamailio/kamailio/commit/f6d69d87abdc48df22135c79ee23092… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-12T08:24:28+01:00 app_lua: do lua_checkstack() to ensure enough capacity on Lua stack - Lua doesn't do automatic management of the stack * http://www.lua.org/manual/5.1/manual.html#3.2 - do exit on insufficient capacity - based on the report by GH #1433 --- Modified: src/modules/app_lua/app_lua_sr.c --- Diff: https://github.com/kamailio/kamailio/commit/f6d69d87abdc48df22135c79ee23092… Patch: https://github.com/kamailio/kamailio/commit/f6d69d87abdc48df22135c79ee23092… --- diff --git a/src/modules/app_lua/app_lua_sr.c b/src/modules/app_lua/app_lua_sr.c index 86380ec6ad..64ebafae40 100644 --- a/src/modules/app_lua/app_lua_sr.c +++ b/src/modules/app_lua/app_lua_sr.c @@ -1970,10 +1970,14 @@ void lua_sr_kemi_register_libs(lua_State *L) } n++; } + if(!lua_checkstack(L, i+8)) { + LM_ERR("not enough Lua stack capacity\n"); + exit(-1); + } luaL_openlib(L, mname, _sr_crt_KSRMethods, 0); - LM_DBG("initializing kemi sub-module: %s (%s)\n", mname, - emods[k].kexp[0].mname.s); + LM_DBG("initializing kemi sub-module: %s (%s) (%d/%d/%d)\n", mname, + emods[k].kexp[0].mname.s, i, k, n); } } - LM_DBG("module 'KSR' has been initialized\n"); + LM_DBG("module 'KSR' has been initialized (%d/%d)\n", emods_size, n); }

1 0

[kamailio/kamailio] schema: allow null value for active_watchers user-agent column (#1431)
by lazedo 11 Feb '18

11 Feb '18

some UAs not sending User-Agent header on SUBSCRIBE causes insert error needs backport to 5.0/5.1 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1431 -- Commit Summary -- * schema: allow null value for active_watchers user-agent column -- File Changes -- M src/lib/srdb1/schema/pr_active_watchers.xml (4) M utils/kamctl/db_berkeley/kamailio/active_watchers (2) M utils/kamctl/db_berkeley/kamailio/version (2) M utils/kamctl/db_sqlite/presence-create.sql (4) M utils/kamctl/dbtext/kamailio/active_watchers (2) M utils/kamctl/dbtext/kamailio/version (2) M utils/kamctl/mongodb/kamailio/active_watchers.json (6) M utils/kamctl/mongodb/kamailio/version-create.mongo (2) M utils/kamctl/mysql/presence-create.sql (4) M utils/kamctl/oracle/presence-create.sql (4) M utils/kamctl/postgres/presence-create.sql (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1431.patch https://github.com/kamailio/kamailio/pull/1431.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1431

2 8

git:5.0:648cc189: presence: set user agent db field to empty string if no value is found
by Daniel-Constantin Mierla 11 Feb '18

11 Feb '18

Module: kamailio Branch: 5.0 Commit: 648cc1894e87ea6e3d254c83592fc385810740c0 URL: https://github.com/kamailio/kamailio/commit/648cc1894e87ea6e3d254c83592fc38… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-11T09:46:30+01:00 presence: set user agent db field to empty string if no value is found (cherry picked from commit 4654f8b4f341a6c9f8cf4daafc7d618871c95e1b) (cherry picked from commit c1ec6b02139475abe7da276cd36de4ebb9709ea2) --- Modified: src/modules/presence/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/648cc1894e87ea6e3d254c83592fc38… Patch: https://github.com/kamailio/kamailio/commit/648cc1894e87ea6e3d254c83592fc38… --- diff --git a/src/modules/presence/subscribe.c b/src/modules/presence/subscribe.c index 18bb2b1a70..8b53500c18 100644 --- a/src/modules/presence/subscribe.c +++ b/src/modules/presence/subscribe.c @@ -191,6 +191,7 @@ int insert_subs_db(subs_t* s, int type) contact_col, local_contact_col, version_col,socket_info_col,reason_col, watcher_user_col, watcher_domain_col, updated_col, updated_winfo_col, user_agent_col, flags_col; + str sval_empty = str_init(""); if(pa_dbf.use_table(pa_db, &active_watchers_table)< 0) { @@ -353,7 +354,8 @@ int insert_subs_db(subs_t* s, int type) query_vals[updated_col].val.int_val = s->updated; query_vals[updated_winfo_col].val.int_val = s->updated_winfo; query_vals[flags_col].val.int_val = s->flags; - query_vals[user_agent_col].val.str_val= s->user_agent; + query_vals[user_agent_col].val.str_val= + (s->user_agent.s && s->user_agent.len>0)?s->user_agent:sval_empty; if (pa_dbf.use_table(pa_db, &active_watchers_table) < 0) {

1 0

git:5.1:c1ec6b02: presence: set user agent db field to empty string if no value is found
by Daniel-Constantin Mierla 11 Feb '18

11 Feb '18

Module: kamailio Branch: 5.1 Commit: c1ec6b02139475abe7da276cd36de4ebb9709ea2 URL: https://github.com/kamailio/kamailio/commit/c1ec6b02139475abe7da276cd36de4e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-11T09:43:39+01:00 presence: set user agent db field to empty string if no value is found (cherry picked from commit 4654f8b4f341a6c9f8cf4daafc7d618871c95e1b) --- Modified: src/modules/presence/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/c1ec6b02139475abe7da276cd36de4e… Patch: https://github.com/kamailio/kamailio/commit/c1ec6b02139475abe7da276cd36de4e… --- diff --git a/src/modules/presence/subscribe.c b/src/modules/presence/subscribe.c index 3c6e4458d4..4c74ac7980 100644 --- a/src/modules/presence/subscribe.c +++ b/src/modules/presence/subscribe.c @@ -191,6 +191,7 @@ int insert_subs_db(subs_t* s, int type) contact_col, local_contact_col, version_col,socket_info_col,reason_col, watcher_user_col, watcher_domain_col, updated_col, updated_winfo_col, user_agent_col, flags_col; + str sval_empty = str_init(""); if(pa_dbf.use_table(pa_db, &active_watchers_table)< 0) { @@ -353,7 +354,8 @@ int insert_subs_db(subs_t* s, int type) query_vals[updated_col].val.int_val = s->updated; query_vals[updated_winfo_col].val.int_val = s->updated_winfo; query_vals[flags_col].val.int_val = s->flags; - query_vals[user_agent_col].val.str_val= s->user_agent; + query_vals[user_agent_col].val.str_val= + (s->user_agent.s && s->user_agent.len>0)?s->user_agent:sval_empty; if (pa_dbf.use_table(pa_db, &active_watchers_table) < 0) {

1 0

git:master:78e3ca66: Merge pull request #1431 from kamailio/active-watcher-null-user-agent
by GitHub 11 Feb '18

11 Feb '18

Module: kamailio Branch: master Commit: 78e3ca663ed73c6d3eb81e6e5a970d928e2a9310 URL: https://github.com/kamailio/kamailio/commit/78e3ca663ed73c6d3eb81e6e5a970d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2018-02-11T09:42:38+01:00 Merge pull request #1431 from kamailio/active-watcher-null-user-agent schema: allow null value for active_watchers user-agent column --- Modified: src/lib/srdb1/schema/pr_active_watchers.xml Modified: utils/kamctl/db_sqlite/presence-create.sql Modified: utils/kamctl/dbtext/kamailio/active_watchers Modified: utils/kamctl/mongodb/kamailio/active_watchers.json Modified: utils/kamctl/mysql/presence-create.sql Modified: utils/kamctl/postgres/presence-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/78e3ca663ed73c6d3eb81e6e5a970d9… Patch: https://github.com/kamailio/kamailio/commit/78e3ca663ed73c6d3eb81e6e5a970d9… --- diff --git a/src/lib/srdb1/schema/pr_active_watchers.xml b/src/lib/srdb1/schema/pr_active_watchers.xml index 8e4fd0604d..3d53eaf46d 100644 --- a/src/lib/srdb1/schema/pr_active_watchers.xml +++ b/src/lib/srdb1/schema/pr_active_watchers.xml @@ -220,6 +220,7 @@ <type>string</type> <size>&hf_len;</size> <default/> + <null/> <description>User-Agent header field contains information about the UAC originating the request.</description> </column> diff --git a/utils/kamctl/db_sqlite/presence-create.sql b/utils/kamctl/db_sqlite/presence-create.sql index 637ff14b62..df121b96d5 100644 --- a/utils/kamctl/db_sqlite/presence-create.sql +++ b/utils/kamctl/db_sqlite/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE active_watchers ( updated INTEGER NOT NULL, updated_winfo INTEGER NOT NULL, flags INTEGER DEFAULT 0 NOT NULL, - user_agent VARCHAR(255) DEFAULT '' NOT NULL, + user_agent VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_active_watchers_idx UNIQUE (callid, to_tag, from_tag) ); diff --git a/utils/kamctl/dbtext/kamailio/active_watchers b/utils/kamctl/dbtext/kamailio/active_watchers index 19719b72d5..04e96b39bc 100644 --- a/utils/kamctl/dbtext/kamailio/active_watchers +++ b/utils/kamctl/dbtext/kamailio/active_watchers @@ -1 +1 @@ -id(int,auto) presentity_uri(string) watcher_username(string) watcher_domain(string) to_user(string) to_domain(string) event(string) event_id(string,null) to_tag(string) from_tag(string) callid(string) local_cseq(int) remote_cseq(int) contact(string) record_route(string,null) expires(int) status(int) reason(string,null) version(int) socket_info(string) local_contact(string) from_user(string) from_domain(string) updated(int) updated_winfo(int) flags(int) user_agent(string) +id(int,auto) presentity_uri(string) watcher_username(string) watcher_domain(string) to_user(string) to_domain(string) event(string) event_id(string,null) to_tag(string) from_tag(string) callid(string) local_cseq(int) remote_cseq(int) contact(string) record_route(string,null) expires(int) status(int) reason(string,null) version(int) socket_info(string) local_contact(string) from_user(string) from_domain(string) updated(int) updated_winfo(int) flags(int) user_agent(string,null) diff --git a/utils/kamctl/mongodb/kamailio/active_watchers.json b/utils/kamctl/mongodb/kamailio/active_watchers.json index 123692d988..5dc8df8256 100644 --- a/utils/kamctl/mongodb/kamailio/active_watchers.json +++ b/utils/kamctl/mongodb/kamailio/active_watchers.json @@ -135,7 +135,7 @@ "user_agent": { "type": "string", "default": "", - "null": false + "null": true } ] } \ No newline at end of file diff --git a/utils/kamctl/mysql/presence-create.sql b/utils/kamctl/mysql/presence-create.sql index 9e7e71c138..d5fcc72770 100644 --- a/utils/kamctl/mysql/presence-create.sql +++ b/utils/kamctl/mysql/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE `active_watchers` ( `updated` INT(11) NOT NULL, `updated_winfo` INT(11) NOT NULL, `flags` INT(11) DEFAULT 0 NOT NULL, - `user_agent` VARCHAR(255) DEFAULT '' NOT NULL, + `user_agent` VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_idx UNIQUE (`callid`, `to_tag`, `from_tag`) ); diff --git a/utils/kamctl/postgres/presence-create.sql b/utils/kamctl/postgres/presence-create.sql index 2259c260a8..943aac0bd6 100644 --- a/utils/kamctl/postgres/presence-create.sql +++ b/utils/kamctl/postgres/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE active_watchers ( updated INTEGER NOT NULL, updated_winfo INTEGER NOT NULL, flags INTEGER DEFAULT 0 NOT NULL, - user_agent VARCHAR(255) DEFAULT '' NOT NULL, + user_agent VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_active_watchers_idx UNIQUE (callid, to_tag, from_tag) );

1 0

git:master:7653124c: schema: allow null value for active_watchers user-agent column
by lazedo 11 Feb '18

11 Feb '18

Module: kamailio Branch: master Commit: 7653124c2d3615e4f6229f12b699063f65b7afea URL: https://github.com/kamailio/kamailio/commit/7653124c2d3615e4f6229f12b699063… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2018-02-09T11:28:05Z schema: allow null value for active_watchers user-agent column some UAs not sending Userg-Agent header on SUBSCRIBE --- Modified: src/lib/srdb1/schema/pr_active_watchers.xml Modified: utils/kamctl/db_sqlite/presence-create.sql Modified: utils/kamctl/dbtext/kamailio/active_watchers Modified: utils/kamctl/mongodb/kamailio/active_watchers.json Modified: utils/kamctl/mysql/presence-create.sql Modified: utils/kamctl/postgres/presence-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/7653124c2d3615e4f6229f12b699063… Patch: https://github.com/kamailio/kamailio/commit/7653124c2d3615e4f6229f12b699063… --- diff --git a/src/lib/srdb1/schema/pr_active_watchers.xml b/src/lib/srdb1/schema/pr_active_watchers.xml index 8e4fd0604d..3d53eaf46d 100644 --- a/src/lib/srdb1/schema/pr_active_watchers.xml +++ b/src/lib/srdb1/schema/pr_active_watchers.xml @@ -220,6 +220,7 @@ <type>string</type> <size>&hf_len;</size> <default/> + <null/> <description>User-Agent header field contains information about the UAC originating the request.</description> </column> diff --git a/utils/kamctl/db_sqlite/presence-create.sql b/utils/kamctl/db_sqlite/presence-create.sql index 637ff14b62..df121b96d5 100644 --- a/utils/kamctl/db_sqlite/presence-create.sql +++ b/utils/kamctl/db_sqlite/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE active_watchers ( updated INTEGER NOT NULL, updated_winfo INTEGER NOT NULL, flags INTEGER DEFAULT 0 NOT NULL, - user_agent VARCHAR(255) DEFAULT '' NOT NULL, + user_agent VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_active_watchers_idx UNIQUE (callid, to_tag, from_tag) ); diff --git a/utils/kamctl/dbtext/kamailio/active_watchers b/utils/kamctl/dbtext/kamailio/active_watchers index 19719b72d5..04e96b39bc 100644 --- a/utils/kamctl/dbtext/kamailio/active_watchers +++ b/utils/kamctl/dbtext/kamailio/active_watchers @@ -1 +1 @@ -id(int,auto) presentity_uri(string) watcher_username(string) watcher_domain(string) to_user(string) to_domain(string) event(string) event_id(string,null) to_tag(string) from_tag(string) callid(string) local_cseq(int) remote_cseq(int) contact(string) record_route(string,null) expires(int) status(int) reason(string,null) version(int) socket_info(string) local_contact(string) from_user(string) from_domain(string) updated(int) updated_winfo(int) flags(int) user_agent(string) +id(int,auto) presentity_uri(string) watcher_username(string) watcher_domain(string) to_user(string) to_domain(string) event(string) event_id(string,null) to_tag(string) from_tag(string) callid(string) local_cseq(int) remote_cseq(int) contact(string) record_route(string,null) expires(int) status(int) reason(string,null) version(int) socket_info(string) local_contact(string) from_user(string) from_domain(string) updated(int) updated_winfo(int) flags(int) user_agent(string,null) diff --git a/utils/kamctl/mongodb/kamailio/active_watchers.json b/utils/kamctl/mongodb/kamailio/active_watchers.json index 123692d988..5dc8df8256 100644 --- a/utils/kamctl/mongodb/kamailio/active_watchers.json +++ b/utils/kamctl/mongodb/kamailio/active_watchers.json @@ -135,7 +135,7 @@ "user_agent": { "type": "string", "default": "", - "null": false + "null": true } ] } \ No newline at end of file diff --git a/utils/kamctl/mysql/presence-create.sql b/utils/kamctl/mysql/presence-create.sql index 9e7e71c138..d5fcc72770 100644 --- a/utils/kamctl/mysql/presence-create.sql +++ b/utils/kamctl/mysql/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE `active_watchers` ( `updated` INT(11) NOT NULL, `updated_winfo` INT(11) NOT NULL, `flags` INT(11) DEFAULT 0 NOT NULL, - `user_agent` VARCHAR(255) DEFAULT '' NOT NULL, + `user_agent` VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_idx UNIQUE (`callid`, `to_tag`, `from_tag`) ); diff --git a/utils/kamctl/postgres/presence-create.sql b/utils/kamctl/postgres/presence-create.sql index 2259c260a8..943aac0bd6 100644 --- a/utils/kamctl/postgres/presence-create.sql +++ b/utils/kamctl/postgres/presence-create.sql @@ -46,7 +46,7 @@ CREATE TABLE active_watchers ( updated INTEGER NOT NULL, updated_winfo INTEGER NOT NULL, flags INTEGER DEFAULT 0 NOT NULL, - user_agent VARCHAR(255) DEFAULT '' NOT NULL, + user_agent VARCHAR(255) DEFAULT '', CONSTRAINT active_watchers_active_watchers_idx UNIQUE (callid, to_tag, from_tag) );

1 0

git:master:4654f8b4: presence: set user agent db field to empty string if no value is found
by Daniel-Constantin Mierla 11 Feb '18

11 Feb '18

Module: kamailio Branch: master Commit: 4654f8b4f341a6c9f8cf4daafc7d618871c95e1b URL: https://github.com/kamailio/kamailio/commit/4654f8b4f341a6c9f8cf4daafc7d618… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-11T09:37:05+01:00 presence: set user agent db field to empty string if no value is found --- Modified: src/modules/presence/subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/4654f8b4f341a6c9f8cf4daafc7d618… Patch: https://github.com/kamailio/kamailio/commit/4654f8b4f341a6c9f8cf4daafc7d618… --- diff --git a/src/modules/presence/subscribe.c b/src/modules/presence/subscribe.c index 3c6e4458d4..4c74ac7980 100644 --- a/src/modules/presence/subscribe.c +++ b/src/modules/presence/subscribe.c @@ -191,6 +191,7 @@ int insert_subs_db(subs_t* s, int type) contact_col, local_contact_col, version_col,socket_info_col,reason_col, watcher_user_col, watcher_domain_col, updated_col, updated_winfo_col, user_agent_col, flags_col; + str sval_empty = str_init(""); if(pa_dbf.use_table(pa_db, &active_watchers_table)< 0) { @@ -353,7 +354,8 @@ int insert_subs_db(subs_t* s, int type) query_vals[updated_col].val.int_val = s->updated; query_vals[updated_winfo_col].val.int_val = s->updated_winfo; query_vals[flags_col].val.int_val = s->flags; - query_vals[user_agent_col].val.str_val= s->user_agent; + query_vals[user_agent_col].val.str_val= + (s->user_agent.s && s->user_agent.len>0)?s->user_agent:sval_empty; if (pa_dbf.use_table(pa_db, &active_watchers_table) < 0) {

1 0

git:master:8f9ddbf4: rr: removed unused variable after spliting code into a function
by Daniel-Constantin Mierla 11 Feb '18

11 Feb '18

Module: kamailio Branch: master Commit: 8f9ddbf43eb19c05efbb8a109b8151c023cc736a URL: https://github.com/kamailio/kamailio/commit/8f9ddbf43eb19c05efbb8a109b8151c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-11T09:27:38+01:00 rr: removed unused variable after spliting code into a function --- Modified: src/modules/rr/loose.c --- Diff: https://github.com/kamailio/kamailio/commit/8f9ddbf43eb19c05efbb8a109b8151c… Patch: https://github.com/kamailio/kamailio/commit/8f9ddbf43eb19c05efbb8a109b8151c… --- diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index f5164cd39b..6e9e888a2b 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -784,7 +784,6 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) int res; int status = RR_DRIVEN; str uri; - struct socket_info *si; int uri_is_myself; int use_ob = 0; str rparams;

1 0

← Newer
1
...
23
24
25
26
27
28
29
...
36
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2018