<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests.
If you have questions about using Kamailio or related to its configuration file,
ask on sr-users mailing list:
* http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing
C code, ask on sr-dev mailing list
* http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the
developers to troubleshoot the issue.
If you submit a feature request (or enhancement), you can delete the text of
the template and only add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
Kamailio start failed as carrierrouter
### Troubleshooting
Main error
`[parser_carrierroute.c:271]: parse_options(): Duplicate option definition max_targets`
#### Reproduction
Define module
```
modparam("carrierroute", "config_source", "file")
modparam("carrierroute", "match_mode", 128)
modparam("carrierroute", "config_file", "/etc/kamailio/carrierroute.conf")
```
Create carrierroute.conf like in module documentation
```
domain first {
prefix + {
max_targets = 2
target 192.168.1.1 {
prob = 0.500000
hash_index = 1
status = 1
comment = "First Master"
}
target 192.168.1.2 {
prob = 0.500000
hash_index = 2
status = 1
comment = "Firts Slave"
}
}
}
domain second {
prefix +99 {
max_targets = 2
target 192.168.1.3 {
prob = 0.500000
hash_index = 1
status = 1
comment = "Second Master"
}
target 192.168.1.4 {
prob = 0.500000
hash_index = 2
status = 1
comment = "Second Slave"
}
}
}
```
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: INFO: carrierroute [carrierroute.c:213]: mod_init(): use file as configuration source
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: INFO: carrierroute [cr_carrier.c:98]: add_domain_data(): adding domain 1 'first' to carrier 1 'default'
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: INFO: carrierroute [cr_rule.c:118]: add_route_rule(): no backed up rules
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: INFO: carrierroute [cr_rule.c:118]: add_route_rule(): no backed up rules
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: INFO: carrierroute [cr_carrier.c:98]: add_domain_data(): adding domain 2 'second' to carrier 1 'default'
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: ERROR: carrierroute [parser_carrierroute.c:271]: parse_options(): Duplicate option definition max_targets
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: ERROR: carrierroute [cr_config.c:351]: load_config(): Error in parsing
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: ERROR: carrierroute [cr_data.c:185]: reload_route_data(): could not load routing data
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: ERROR: carrierroute [carrierroute.c:255]: mod_init(): could not prepare route data
Apr 3 09:50:18 localhost /usr/sbin/kamailio[16964]: ERROR: <core> [core/sr_module.c:987]: init_mod(): Error while initializing module carrierroute (/usr/lib64/kamailio/modules/carrierroute.so)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.1.2 (x86_64/linux)
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled on 11:28:18 Mar 20 2018 with gcc 4.8.5
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Linux localhost 3.10.0-693.21.1.el7.x86_64 #1 SMP Wed Mar 7 19:03:37 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1492
Module: kamailio
Branch: master
Commit: f7ed7d289978490f374f4f3eea52e91dccc3752f
URL: https://github.com/kamailio/kamailio/commit/f7ed7d289978490f374f4f3eea52e91…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2018-04-04T08:47:25+02:00
dialog: added end labels needed by dlg_db_load_callid()
- they were removed by commit 27c23f57f70936e557d9566e6122958c2e032970
not being used after a previous commit, but meanwhile this function was
developed
---
Modified: src/modules/dialog/dlg_db_handler.c
---
Diff: https://github.com/kamailio/kamailio/commit/f7ed7d289978490f374f4f3eea52e91…
Patch: https://github.com/kamailio/kamailio/commit/f7ed7d289978490f374f4f3eea52e91…
---
diff --git a/src/modules/dialog/dlg_db_handler.c b/src/modules/dialog/dlg_db_handler.c
index ecacb1c43e..0a902952c3 100644
--- a/src/modules/dialog/dlg_db_handler.c
+++ b/src/modules/dialog/dlg_db_handler.c
@@ -503,6 +503,7 @@ int load_dialog_info_from_db(int dlg_hash_size, int fetch_num_rows,
}
}
+end:
dialog_dbf.free_result(dialog_db_handle, res);
return 0;
error:
@@ -634,6 +635,7 @@ static int load_dialog_vars_from_db(int fetch_num_rows, int mode,
}
}
+end:
dialog_dbf.free_result(dialog_db_handle, res);
return 0;
error: