Apologies if i have not kept with the reporting standard.
Insertion attempts of out-of-credit replies from resume_on_initial_ccr callback, are corrupting the ro_session list. i.e. they nullify the first and last fields, which under certain conditions the first entry gets restored but not the last.This then crashes the process at ro_session_hash.c (link_ro_session), where the first entry has a valid address but the last does not.
Solution: ro_session_hash.h - unlink_unsafe_ro_session - check if the session to be linked is actually part of list i.e
if ((ro_session->next == 0x00) &&
(ro_session->prev == 0x00) &&
(ro_session != ro_session_entry->first) )
{
ro_session, &(ro_session->ro_tl),
ro_session->callid.len,
ro_session->callid.len,
ro_session->callid.s);
return;
}
rest of the code ....
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1549
If I run set_contact_alias nothing happens - the contact remains the same on the outbound message There's no error returned and debug logs indicate a proper header
However, if I add "msg_apply_changes()" on the line after set_contact_alias the Contact sent to next hop has the alias content No other changes
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/445
in function unlink_contact_from_impu() (in file impurecord.c) an
assignment "=" is used instead of a comparision operator "==". This
leads to mess, when old contact expires.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally versus release 5.1.0
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This is the pull request for branch 5.1, which has been created by "cherry-pick" from the original commit
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1547
-- Commit Summary --
* ims_usrloc_scscf: bugfix Contct is removed when old Contct expires
-- File Changes --
M src/modules/ims_usrloc_scscf/impurecord.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1547.patchhttps://github.com/kamailio/kamailio/pull/1547.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1547
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests.
If you have questions about using Kamailio or related to its configuration file,
ask on sr-users mailing list:
* http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing
C code, ask on sr-dev mailing list
* http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the
developers to troubleshoot the issue.
If you submit a feature request (or enhancement), you can delete the text of
the template and only add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
log_prefix do not work in failure_route
### Troubleshooting
#### Reproduction
log_prefix="{$mt $hdr(CSeq) $ci} "
...
...
failure_route[RTF_LCR_ROUTE]
{
if (t_is_canceled()) {
exit;
}
xlog("L_INFO", "--- SCRIPT: failure_route - RTF_LCR_ROUTE\n");
if (t_check_status("408|50[0-4]") or (t_branch_timeout() and !t_branch_replied())) {
if(!next_gw()) {
send_reply("503", "No more LCR gateways");
exit;
}
xlog("L_INFO", "flag $avp(lcr_flag) \n");
t_on_failure("RTF_LCR_ROUTE");
t_set_retr(0, 4000);
route(RELAY);
exit;
}
}
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
INFO: <script>: --- SCRIPT: failure_route - RTF_LCR_ROUTE
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 4.4.7 (x86_64/linux) 35d8ab
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 35d8ab
compiled on 11:55:20 Mar 19 2018 with gcc 6.3.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Linux kamailio 4.13.0-37-generic #42~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1531
kamailio version: kamailio 5.1.2 (x86_64/linux)
If "onsend_route" routing block is defined at the beginning of the kamailio.cfg routing part, the name defined in "src/core/cfg.lex" file (DEFAULT_SEND) is used when printed in the json files.
Instead, if this routing block is defined in between the configuration, its name is changed to the previous defined block.
For example, if the cfg file looks like the following:
route[TEST_1]
{
...
}
onsend_route
{
...
}
route[TEST_2]
{
...
}
then in the output json file, the "onsend_route" block is called TEST_1.
The issue doesn't happen for "request_route" block.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1536
When loaded mod kazoo i get error
```
/ # kamailio -DD -E
0(178) WARNING: <core> [core/cfg.y:3426]: warn_at(): warning in config file /etc/kamailio/default.cfg, line 67, column 12: raw socket support not compiled in
0(178) ERROR: <core> [core/sr_module.c:582]: load_module(): could not open module </usr/lib/kamailio/modules/kazoo.so>: Error relocating /usr/lib/kamailio/modules/kazoo.so: is_error: symbol not found
0(178) CRITICAL: <core> [core/cfg.y:3446]: yyerror_at(): parse error in config file /etc/kamailio/default.cfg, line 188, column 12-21: failed to load module
0(178) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <kazoo> found
```
And ldd output
```
/ # LD_PRELOAD=/usr/sbin/kamailio ldd /usr/lib/kamailio/modules/kazoo.so
ldd (0x5592f5d09000)
/usr/sbin/kamailio => /usr/sbin/kamailio (0x7fa6235bc000)
libjson-c.so.4 => /usr/lib/libjson-c.so.4 (0x7fa6233ae000)
libuuid.so.1 => /lib/libuuid.so.1 (0x7fa6231a8000)
librabbitmq.so.4 => /usr/lib/librabbitmq.so.4 (0x7fa622f8c000)
libevent-2.1.so.6 => /usr/lib/libevent-2.1.so.6 (0x7fa622d42000)
libsrdb1.so.1 => /usr/lib/kamailio//libsrdb1.so.1 (0x7fa622b21000)
libc.musl-x86_64.so.1 => ldd (0x5592f5d09000)
libssl.so.45 => /lib/libssl.so.45 (0x7fa6228d5000)
libcrypto.so.43 => /lib/libcrypto.so.43 (0x7fa62252a000)
Error relocating /usr/lib/kamailio/modules/kazoo.so: is_error: symbol not found
/ #
```
Symbol `is_error` is defined at `/usr/include/json-c/bits.h`
```
/**
* @deprecated
*/
#define is_error(ptr) (ptr == NULL)
```
I not know why this simple definition is not compiled into mod kazoo on latest Alpine:edge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1540
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Presented at Kamailio World 2018, load balancing doing congestion detection
More information can be found
http://www.castmm.com/KW2018.pdfhttps://github.com/jchavanton/kam_load_balancing
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1533
-- Commit Summary --
* dispatcher: congestion detection load balancing
-- File Changes --
M src/modules/dispatcher/dispatch.c (103)
M src/modules/dispatcher/dispatch.h (2)
M src/modules/dispatcher/doc/dispatcher.xml (2)
M src/modules/dispatcher/doc/dispatcher_admin.xml (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1533.patchhttps://github.com/kamailio/kamailio/pull/1533.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1533
Hello,
I am considering to release a new minor version out of branch 5.1,
respectively the v5.1.4, sometime next week, likely on Tuesday, June 5,
2018. As usual, if there is any issue not yet reported on github
tracker, do it as soon as possible to give it a chance to be fixed.
Soon I am going to do the backports of commits with fixes in master that
apply in branch 5.1, so keep a close eye and if someone is missing, let
me know to push it in the stable branch.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Diameter request MAR and corresponding response MAA both contain authentication vectors in binary form. Ims_diameter_server lacks functionality to convert binary arrays to json and back. This pr is a couple of minor fixes to rectify the issue:
* when converting Diameter binary vector to json use %02x in sprintf() to form a proper hexdump which is possible to decode on json side. The hexdump is sent in "data" key value pair as string.
* introduce new key value pair "hexdump" in json which will contain hex dump of binary vector formed on json side. ims_diameter_server converts it to Diameter AVP using hex dump to binary transcoding.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1528
-- Commit Summary --
* use hexdump type of string to send binary data in json
* duplicate before giving it to cdp
* converting binary data to hex dump requires fixed width lenght in snprintf
-- File Changes --
M src/modules/ims_diameter_server/avp_helper.c (50)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1528.patchhttps://github.com/kamailio/kamailio/pull/1528.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1528