sr-dev July 2018

sr-dev@lists.kamailio.org

17 participants
229 discussions

git:master:e7734e60: Merge pull request #1590 from surendratiwari3/app_lua_child_fix

by GitHub

Module: kamailio Branch: master Commit: e7734e604fc7b0e6cc24454b53c9670c91ce5c05 URL: https://github.com/kamailio/kamailio/commit/e7734e604fc7b0e6cc24454b53c9670… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2018-07-12T15:47:09+02:00 Merge pull request #1590 from surendratiwari3/app_lua_child_fix app_lua : fixing bug for setting set SR lib version for lua 52 --- Modified: src/modules/app_lua/app_lua_api.c --- Diff: https://github.com/kamailio/kamailio/commit/e7734e604fc7b0e6cc24454b53c9670… Patch: https://github.com/kamailio/kamailio/commit/e7734e604fc7b0e6cc24454b53c9670… --- diff --git a/src/modules/app_lua/app_lua_api.c b/src/modules/app_lua/app_lua_api.c index 97d141cd22..8fe8a22569 100644 --- a/src/modules/app_lua/app_lua_api.c +++ b/src/modules/app_lua/app_lua_api.c @@ -297,8 +297,8 @@ int lua_sr_init_child(void) /* set SR lib version */ #if LUA_VERSION_NUM >= 502 - lua_pushstring(_sr_L_env.L, SRVERSION); - lua_setglobal(_sr_L_env.L, "SRVERSION"); + lua_pushstring(_sr_L_env.LL, SRVERSION); + lua_setglobal(_sr_L_env.LL, "SRVERSION"); #else lua_pushstring(_sr_L_env.LL, "SRVERSION"); lua_pushstring(_sr_L_env.LL, SRVERSION);

6 years, 1 month

git:master:ea390d69: app_lua: fixing bug for setting global table lua

by surendratiwari3

Module: kamailio Branch: master Commit: ea390d69d946314f93bfeeef77b4421f0c04cba3 URL: https://github.com/kamailio/kamailio/commit/ea390d69d946314f93bfeeef77b4421… Author: surendratiwari3 <surendratiwari3(a)gmail.com> Committer: surendratiwari3 <surendratiwari3(a)gmail.com> Date: 2018-07-12T13:07:09Z app_lua: fixing bug for setting global table lua --- Modified: src/modules/app_lua/app_lua_api.c --- Diff: https://github.com/kamailio/kamailio/commit/ea390d69d946314f93bfeeef77b4421… Patch: https://github.com/kamailio/kamailio/commit/ea390d69d946314f93bfeeef77b4421… --- diff --git a/src/modules/app_lua/app_lua_api.c b/src/modules/app_lua/app_lua_api.c index 7f0fd1fbc0..122c212da3 100644 --- a/src/modules/app_lua/app_lua_api.c +++ b/src/modules/app_lua/app_lua_api.c @@ -297,8 +297,8 @@ int lua_sr_init_child(void) /* set SR lib version */ #if LUA_VERSION_NUM >= 502 - lua_pushstring(_sr_L_env.L, SRVERSION); - lua_setglobal(_sr_L_env.L, "SRVERSION"); + lua_pushstring(_sr_L_env.LL, SRVERSION); + lua_setglobal(_sr_L_env.LL, "SRVERSION"); #else lua_pushstring(_sr_L_env.LL, "SRVERSION"); lua_pushstring(_sr_L_env.LL, SRVERSION);

6 years, 1 month

[kamailio/kamailio] app_lua : fixing bug for setting set SR lib version for lua 52 (#1590)

by Surendra Tiwari

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1590 -- Commit Summary -- * fixing bug for setting global table lua -- File Changes -- M src/modules/app_lua/app_lua_api.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1590.patch https://github.com/kamailio/kamailio/pull/1590.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1590

6 years, 1 month

[kamailio/kamailio] nathelper always sends SIP pings in IPv6 scenario (#1587)

by Sebastian Damm

### Description We upgraded from Kamailio 4.4.5 to 5.1.4 today. We have a IPv6-to-v4 loadbalancer which sends out NAT pings to keep the connection through routers alive. So it is not a real NAT scenario. Kamailio 4.4.5 sent out dummy 4-byte UDP packets. Kamailio 5.1.4 sends out SIP OPTIONS although we didn't even configure sipping_from. Our configuration: ``` loadmodule "nathelper.so" modparam("nathelper", "received_avp", "$(avp(i:801))") modparam("nathelper", "natping_interval" , 14) modparam("nathelper", "ping_nated_only" , 0) ``` When looking into the code, Kamailio should not even be able to send out OPTIONS without sipping_from being configured. It does anyhow. This results in broken keepalive packets. ``` OPTIONS sip:foobar@[2003:a:c6b:8400:204:aaaa:bbbb:cccc]:6060;transport=udp;line=s4cqtu SIP/2.0. Via: SIP/2.0/UDP [2001:AB7:0:0:0:0:0:1]:5060;branch=z9hG4bK9474521. From: ;tag=uloc-5b2b6211-355f-81fc4-3f1f9b57-6a9dc2. To: sip:foobar@[2003:a:c6b:8400:204:aaaa:bbbb:cccc]:6060;transport=udp;line=s4cqtu. Call-ID: -6a9dc2-cac4404@2001:AB7:0:0:0:0:0:1. CSeq: 1 OPTIONS. Content-Length: 0. .``` Those packets get rejected by some clients, bringing them offline, effectively. After adding the sipping_from modparam, those OPTIONS get sent with a correct From header. ### Troubleshooting #### Reproduction Our v4-only SIP proxies don't show the behavior, our v6-to-v4 loadbalancers do. I don't know if this can be reproduced with a default installation on a IPv6 setup. #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions Setting the sipping_from parameter at least fixes the OPTIONS packet. But we found no way to send those dummy UDP packets instead of full OPTIONS. ### Additional Information Kamailio branch 5.1 pulled yesterday, 5.1.4 * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 4.7.2 ``` * **Operating System**:  ``` Debian Wheezy, Linux hostname 3.2.0-5-amd64 #1 SMP Debian 3.2.96-3 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1587

6 years, 1 month

[kamailio/kamailio] Problem with IPv6, TLS and advertise param (#1581)

by Joel Serrano

### Description We want to be able to handle reINVITEs over TLS so calls can reconnect when they switch networks (for example from wifi to mobile data). We have the following config in kamailio.cfg: ``` listen=tls:1.1.1.1:443 advertise sbc01.domain.com:443 listen=tls:[AAAA:BBBB:CCCC:DDDD:EEEE:FFFF:GGGG:HHHH]:443 advertise sbc01.domain.com:443 listen=udp:1.1.1.1:5060 ``` In order to not break TLS validation (certs) we set the advertise to the FQDN so all headers are set with the FQDN and not the IP address, also notice no `[]` in the FQDN part of advertise IPv6 line. We do this, because we found that without the advertise, all headers have the IP address, which is also OK, but if the TCP connection breaks and the client reconnects, it will send the connection to the top request-route header, if it's an IP, the TLS validation will beak because the cn= doesn't match, having the FQDN there, the cn= will match and the request will continue. Example scenario: * IPv4 call: Our public domain is `sip.domain.com` that has SRV records pointing to `sbc01.domain.com` and `sbc02.domain.com`. For this example let's stick to `sbc01.domain.com`. Kamailio: 1.1.1.1 / sbc01.domain.com Media server: 2.2.2.2 Client <---TLS 443---> Kamailio <---UDP 5060---> Media server Example call: ![image](https://user-images.githubusercontent.com/16212586/42248688-cce7915c-7edb-11e8-84e8-f1917a6da7a4.png) Let's focus on the INVITE that Kamailio sends to the media server (the *blue* INVITE in the screenshot) The headers look like this: ``` INVITE sip:test@2.2.2.2:5060 SIP/2.0 Record-Route: <sip:1.1.1.1;r2=on;lr=on;ftag=eTdR161Ub;did=916.2391;nat=yes> Record-Route: <sip:sbc01.domain.com:443;transport=tls;r2=on;lr=on;ftag=eTdR161Ub;did=916.2391;nat=yes> ... ``` Which is correct, if the client has to send a reINVITE, it will do a DNS request to sbc01.domain.com and depending if it has AAAA and A records, and what the client's current transport is (ipv6/ipv4) it will select and use what it needs. ..Now let's say the same scenario, but origin transport is IPv6 this time.. * IPv6 call: Same scenario as above, same invite, this time the headers look like this: ``` INVITE sip:test@2.2.2.2:5060 SIP/2.0 Record-Route: <sip:1.1.1.1;r2=on;lr=on;ftag=iMwhZbnTA;did=fda.2803> Record-Route: <sip:[sbc01.domain.com]:443;transport=tls;r2=on;lr=on;ftag=iMwhZbnTA;did=fda.2803> ``` (notice the FQDN surrounded by `[]`) #### Reproduction Add the `advertise` option on a `listen=` param with transport tls and using an IPv6. Observe the format of the headers the `record_route()` function adds to the request. ### Possible Solutions When setting a FQDN instead of an IP address (v4/v6) in the `advertise` option; never enclose it with `[]` ? It's a suggestion, maybe what I'm saying is completely nuts. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.1.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: ``` OS: Debian stretch 9.4 Kernel: Linux kamailio 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1581

6 years, 1 month

[kamailio/kamailio] tls: much faster startup using shared SSL_CTX (#1585)

by Julien Chavanton

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [x] Optimization #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Kamailio TLS mod_init is creating one SSL_CTX, per process, some of the fonctions are taking between 1-3 seconds to execute, this is slowing down the startup sequence greatly. ``` SSL_CTX_load_verify_locations SSL_CTX_set_client_CA_list // list sent to the client SSL_load_client_CA_file SSL_CTX_get_client_CA_list ``` In fact it is safe to share the SSL_CTX since it is only used to store settings that will be used to internalize new structure, see the documentation reference : ``` tls: faster startup using shared SSL_CTX https://www.openssl.org/docs/man1.1.1/man7/ssl.html SSL_CTX (SSL Context) This is the global context structure which is created by a server or client once per program life-time and which holds mainly default values for the SSL structures which are later created for the connections. ``` I load tested this with 1000 TLS connections. We could push the refactoring further, this simple modification as a huge impact since the functions are now called only once per SSL / SNI, not per process ... You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1585 -- Commit Summary -- * tls: faster startup using shared SSL_CTX -- File Changes -- M src/modules/tls/tls_domain.c (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1585.patch https://github.com/kamailio/kamailio/pull/1585.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1585

6 years, 1 month

git:master:ab118fab: modules: readme files regenerated - nathelper ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: ab118fab76bc38abf245f7e3f19741489201defc URL: https://github.com/kamailio/kamailio/commit/ab118fab76bc38abf245f7e3f197414… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-07-11T18:46:24+02:00 modules: readme files regenerated - nathelper ... [skip ci] --- Modified: src/modules/nathelper/README --- Diff: https://github.com/kamailio/kamailio/commit/ab118fab76bc38abf245f7e3f197414… Patch: https://github.com/kamailio/kamailio/commit/ab118fab76bc38abf245f7e3f197414… --- diff --git a/src/modules/nathelper/README b/src/modules/nathelper/README index f21f198336..2e09145288 100644 --- a/src/modules/nathelper/README +++ b/src/modules/nathelper/README @@ -279,8 +279,12 @@ modparam("nathelper", "natping_interval", 10) 4.3. ping_nated_only (integer) - If this variable is set then only contacts that have “behind_NAT” flag - in user location database set will get ping. + If this parameter is set to 1 then only contacts that have “behind_NAT” + flag in user location database set will get ping. + + If it is 0 and sipping_flag is not set, then the 4-bytes UDP ping is + sent to all contacts. If it is 0 and sipping_flag parameter is set, + then SIP-request-based pinging is sent to all contacts. Default value is 0.

6 years, 1 month

git:master:8f7eca3c: nathelper: docs - note about the behavior of ping_nated_only=0 with sipping_flag set

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8f7eca3cdadd42ae2bf30a603b5b50c95f33937e URL: https://github.com/kamailio/kamailio/commit/8f7eca3cdadd42ae2bf30a603b5b50c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-07-11T18:39:19+02:00 nathelper: docs - note about the behavior of ping_nated_only=0 with sipping_flag set --- Modified: src/modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8f7eca3cdadd42ae2bf30a603b5b50c… Patch: https://github.com/kamailio/kamailio/commit/8f7eca3cdadd42ae2bf30a603b5b50c… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index 975f579d93..e3c47e2d70 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -172,11 +172,16 @@ modparam("nathelper", "natping_interval", 10) <section id="nathelper.p.ping_nated_only"> <title><varname>ping_nated_only</varname> (integer)</title> <para> - If this variable is set then only contacts that have - <quote>behind_NAT</quote> flag in user location database set will + If this parameter is set to 1 then only contacts that have + <quote>behind_NAT</quote> flag in user location database set will get ping. </para> <para> + If it is 0 and sipping_flag is not set, then the 4-bytes UDP ping is + sent to all contacts. If it is 0 and sipping_flag parameter is set, then + SIP-request-based pinging is sent to all contacts. + </para> + <para> <emphasis> Default value is 0. </emphasis>

6 years, 1 month

git:master:1be693d4: nathelper: send always SIP ping if ping_nated_only=0 and sipping_flag is set

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1be693d432cd0ec3ce2cd68847791689143ae351 URL: https://github.com/kamailio/kamailio/commit/1be693d432cd0ec3ce2cd6884779168… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-07-11T18:27:08+02:00 nathelper: send always SIP ping if ping_nated_only=0 and sipping_flag is set - reported by GH #1587 --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/1be693d432cd0ec3ce2cd6884779168… Patch: https://github.com/kamailio/kamailio/commit/1be693d432cd0ec3ce2cd6884779168… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 5382d4c6b8..b9d9d622b3 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -1921,7 +1921,7 @@ static void nh_timer(unsigned int ticks, void *timer_idx) unsigned int path_ip = 0; unsigned short path_port = 0; int options = 0; - int should_send_ping = 0; + int send_sip_ping = 0; if((*natping_state) == 0) goto done; @@ -2060,9 +2060,11 @@ static void nh_timer(unsigned int ticks, void *timer_idx) dst.proto = PROTO_UDP; dst.send_sock = send_sock; - should_send_ping = (flags & sipping_flag) != 0 || ping_nated_only == 0; + send_sip_ping = ((flags & sipping_flag) != 0) + || (ping_nated_only == 0 && sipping_flag != 0); - if ( should_send_ping && (opt.s = build_sipping(&c, send_sock, &path, &ruid, aorhash, &opt.len)) != 0) { + if ( send_sip_ping && (opt.s = build_sipping(&c, send_sock, &path, + &ruid, aorhash, &opt.len)) != 0) { if(udp_send(&dst, opt.s, opt.len) < 0) { LM_ERR("sip udp_send failed\n"); }

6 years, 1 month

[kamailio/kamailio] Modules: Evapi async_relay export to kemi (#1563)

by Surendra Tiwari

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description evapi_async_relay is exported to kemi interface You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1563 -- Commit Summary -- * Modules: Evapi async_relay export to kemi -- File Changes -- M src/modules/evapi/evapi_mod.c (56) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1563.patch https://github.com/kamailio/kamailio/pull/1563.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1563

6 years, 1 month

← Newer
1
...
13
14
15
16
17
18
19
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2018