sr-dev August 2018

sr-dev@lists.kamailio.org

22 participants
281 discussions

git:master:26449dc2: modules/auth: fixed path in auth.xml
by Juha Heinanen 23 Aug '18

23 Aug '18

Module: kamailio Branch: master Commit: 26449dc2da3b47dd71265e8103de5957bd2245f4 URL: https://github.com/kamailio/kamailio/commit/26449dc2da3b47dd71265e8103de595… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2018-08-23T11:53:34+03:00 modules/auth: fixed path in auth.xml --- Modified: src/modules/auth/auth.xml --- Diff: https://github.com/kamailio/kamailio/commit/26449dc2da3b47dd71265e8103de595… Patch: https://github.com/kamailio/kamailio/commit/26449dc2da3b47dd71265e8103de595… --- diff --git a/src/modules/auth/auth.xml b/src/modules/auth/auth.xml index 6f5f001d1c..1470f7c9d9 100644 --- a/src/modules/auth/auth.xml +++ b/src/modules/auth/auth.xml @@ -3,7 +3,7 @@ "http://www.oasis-open.org/docbook/xml/4.4/docbookx.dtd" [  -<!ENTITY % docentities SYSTEM "../../../../doc/docbook/entities.xml"> +<!ENTITY % docentities SYSTEM "../../../doc/docbook/entities.xml"> %docentities; ]>

1 0

git:master:e2994b6a: ims_ipsec_pcscf: Fix memory leaks in cmd.c
by Tsvetomir Dimitrov 23 Aug '18

23 Aug '18

Module: kamailio Branch: master Commit: e2994b6ac4846c869894a2783304782854f96f57 URL: https://github.com/kamailio/kamailio/commit/e2994b6ac4846c869894a2783304782… Author: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Committer: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Date: 2018-08-23T10:57:44+03:00 ims_ipsec_pcscf: Fix memory leaks in cmd.c --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/e2994b6ac4846c869894a2783304782… Patch: https://github.com/kamailio/kamailio/commit/e2994b6ac4846c869894a2783304782… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index b5741e30d8..46056b9214 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -161,7 +161,7 @@ static int fill_contact(struct pcontact_info* ci, struct sip_msg* m) cb = cscf_parse_contacts(req); if (!cb || (!cb->contacts)) { LM_ERR("fill_contact(): No contact headers\n"); - return -3; + return -1; } // populate CI with bare minimum @@ -172,8 +172,11 @@ static int fill_contact(struct pcontact_info* ci, struct sip_msg* m) } - char* srcip; - srcip = pkg_malloc(50); + char* srcip = NULL; + if((srcip = pkg_malloc(50)) == NULL) { + LM_ERR("Error allocating memory for source IP address\n"); + return -1; + } ci->received_host.len = ip_addr2sbuf(&req->rcv.src_ip, srcip, 50); ci->received_host.s = srcip; @@ -386,6 +389,7 @@ int add_security_server_header(struct sip_msg* m, ipsec_t* s) // copy to the header and add if((sec_header->s = pkg_malloc(sec_header->len)) == NULL) { LM_ERR("Error allocating pkg memory for security header payload\n"); + pkg_free(sec_header); return -1; } memcpy(sec_header->s, sec_hdr_buf, sec_header->len); @@ -393,6 +397,8 @@ int add_security_server_header(struct sip_msg* m, ipsec_t* s) // add security-server header in reply if(cscf_add_header(m, sec_header, HDR_OTHER_T) != 1) { LM_ERR("Error adding security header to reply!\n"); + pkg_free(sec_header->s); + pkg_free(sec_header); return -1; }

1 0

Build failed in Jenkins: kamailio51-binaries » i386,buster,slave #5
by jenkins＠sipwise.com 22 Aug '18

22 Aug '18

See <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> ------------------------------------------ [...truncated 153.96 KB...] + '[' -n '' ']' + '[' -n '' ']' ++ date + echo '# pbuilder config file generated by jenkins-debian-glue on Tue Jun 5 14:33:14 UTC 2018' + '[' -n '' ']' + use_eatmydata + '[' '' = false ']' + '[' '' = true ']' + dpkg-query --show '--showformat=${Status}' eatmydata + grep -q '^install' ++ dpkg-query --show '--showformat=${Version}' eatmydata + dpkg --compare-versions 82-6 gt 26-2 + echo '*** eatmydata is present on host system, now checking distribution support ***' *** eatmydata is present on host system, now checking distribution support *** + case "${COWBUILDER_DIST}" in + echo '*** Distribution buster should provide recent eatmydata support, enabling eatmydata ***' *** Distribution buster should provide recent eatmydata support, enabling eatmydata *** + enable_eatmydata + echo 'EXTRAPACKAGES="$EXTRAPACKAGES eatmydata"' + echo 'export LD_PRELOAD="${LD_PRELOAD:+$LD_PRELOAD:}libeatmydata.so"' + echo '# builtin support available with pbuilder >=0.225 (otherwise ignored):' + echo EATMYDATA=yes + use_ccache + '[' '' = true ']' + '[' -n /etc/jenkins/pbuilderrc ']' + echo '*** PBUILDER_CONFIG is set, considering /etc/jenkins/pbuilderrc for pbuilder config ***' *** PBUILDER_CONFIG is set, considering /etc/jenkins/pbuilderrc for pbuilder config *** + '[' -r /etc/jenkins/pbuilderrc ']' + echo '*** Adding content of /etc/jenkins/pbuilderrc to pbuilder configfile ***' *** Adding content of /etc/jenkins/pbuilderrc to pbuilder configfile *** + cat /etc/jenkins/pbuilderrc + counter=3600 + ls '/var/run/lock/buster-i386.update.*' + '[' 3600 -eq 0 ']' + touch /var/run/lock/buster-i386.building.931 + case "$architecture" in + linux32 sudo DIST=buster ARCH=i386 cowbuilder --buildresult <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> --build <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> --basepath /var/cache/pbuilder/base-buster-i386.cow --debbuildopts -B --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts '/tmp/apt-jdg_PCk8AQ ' --configfile=/tmp/tmp.xPZCwzG34W -> Copying COW directory forking: rm -rf /var/cache/pbuilder/build//cow.1591 forking: cp -al /var/cache/pbuilder/base-buster-i386.cow /var/cache/pbuilder/build//cow.1591 I: removed stale ilistfile /var/cache/pbuilder/build//cow.1591/.ilist forking: chroot /var/cache/pbuilder/build//cow.1591 cowdancer-ilistcreate /.ilist find . -xdev -path ./home -prune -o $ \( -type l -o -type f $ -a -links +1 -print0 \) | xargs -0 stat --format '%d %i ' -> Invoking pbuilder forking: pbuilder build --debbuildopts -B --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts /tmp/apt-jdg_PCk8AQ --configfile /tmp/tmp.xPZCwzG34W --buildplace /var/cache/pbuilder/build//cow.1591 --buildresult <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> --debbuildopts -B --no-targz --internal-chrootexec chroot /var/cache/pbuilder/build//cow.1591 cow-shell <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> W: /root/.pbuilderrc does not exist I: Running in no-targz mode I: using fakeroot in build. I: pbuilder: network access will be disabled during build I: Current time: Tue Jun 5 14:33:15 UTC 2018 I: pbuilder-time-stamp: 1528209195 I: copying local configuration I: mounting /proc filesystem I: mounting /run/shm filesystem I: mounting /dev/pts filesystem I: Mounting /tmp/apt-jdg_PCk8AQ I: policy-rc.d already exists I: Obtaining the cached apt archive contents I: Installing the build-deps I: user script /var/cache/pbuilder/build/cow.1591/tmp/hooks/D10-man-db starting I: Preseed man-db/auto-update to false I: user script /var/cache/pbuilder/build/cow.1591/tmp/hooks/D10-man-db finished I: user script /var/cache/pbuilder/build/cow.1591/tmp/hooks/D20releaserepo starting + set -- /tmp/apt-jdg_PCk8AQ/ + TMPAPT=/tmp/apt-jdg_PCk8AQ/ + [ -d /tmp/apt-jdg_PCk8AQ/ ] + UPDATE_PKGLIST=0 + ls /tmp/apt-jdg_PCk8AQ/*.list + [ -e /tmp/apt-jdg_PCk8AQ//keyring.gpg ] + [ 0 = 1 ] I: user script /var/cache/pbuilder/build/cow.1591/tmp/hooks/D20releaserepo finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy Version: 0.invalid.0 Architecture: i386 Maintainer: Debian Pbuilder Team <pbuilder-maint(a)lists.alioth.debian.org> Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder This package was created automatically by pbuilder to satisfy the build-dependencies of the package being currently built. Depends: bison, debhelper (>= 9), default-libmysqlclient-dev, dh-systemd (>= 1.5), docbook-xml, dpkg-dev (>= 1.16.1.1), erlang-dev, flex, gcj-jdk, libconfuse-dev, libcurl4-openssl-dev, libdb-dev (>= 4.6.19), libev-dev, libevent-dev, libexpat1-dev, libgeoip-dev (>= 1.4.5), libhiredis-dev (>= 0.10.0), libjansson-dev, libjson-c-dev, libldap2-dev, liblua5.1-0-dev, libmaxminddb-dev, libmemcached-dev, libmongoc-dev, libmono-2.0-dev, libncurses5-dev, libpcre3-dev, libperl-dev, libphonenumber-dev (>= 7), libpq-dev, librabbitmq-dev, libradcli-dev, libreadline-dev, libsasl2-dev, libsctp-dev, libsnmp-dev, libsqlite3-dev, libssl-dev, libsystemd-dev, libunistring-dev, libxml2-dev, openssl, pkg-config, python, python-dev, unixodbc-dev, uuid-dev, xsltproc, zlib1g-dev dpkg-deb: building package 'pbuilder-satisfydepends-dummy' in '/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'. Selecting previously unselected package pbuilder-satisfydepends-dummy. (Reading database ... 12170 files and directories currently installed.) Preparing to unpack .../pbuilder-satisfydepends-dummy.deb ... Unpacking pbuilder-satisfydepends-dummy (0.invalid.0) ... dpkg: pbuilder-satisfydepends-dummy: dependency problems, but configuring anyway as you requested: pbuilder-satisfydepends-dummy depends on bison; however: Package bison is not installed. pbuilder-satisfydepends-dummy depends on debhelper (>= 9); however: Package debhelper is not installed. pbuilder-satisfydepends-dummy depends on default-libmysqlclient-dev; however: Package default-libmysqlclient-dev is not installed. pbuilder-satisfydepends-dummy depends on dh-systemd (>= 1.5); however: Package dh-systemd is not installed. pbuilder-satisfydepends-dummy depends on docbook-xml; however: Package docbook-xml is not installed. pbuilder-satisfydepends-dummy depends on erlang-dev; however: Package erlang-dev is not installed. pbuilder-satisfydepends-dummy depends on flex; however: Package flex is not installed. pbuilder-satisfydepends-dummy depends on gcj-jdk; however: Package gcj-jdk is not installed. pbuilder-satisfydepends-dummy depends on libconfuse-dev; however: Package libconfuse-dev is not installed. pbuilder-satisfydepends-dummy depends on libcurl4-openssl-dev; however: Package libcurl4-openssl-dev is not installed. pbuilder-satisfydepends-dummy depends on libdb-dev (>= 4.6.19); however: Package libdb-dev is not installed. pbuilder-satisfydepends-dummy depends on libev-dev; however: Package libev-dev is not installed. pbuilder-satisfydepends-dummy depends on libevent-dev; however: Package libevent-dev is not installed. pbuilder-satisfydepends-dummy depends on libexpat1-dev; however: Package libexpat1-dev is not installed. pbuilder-satisfydepends-dummy depends on libgeoip-dev (>= 1.4.5); however: Package libgeoip-dev is not installed. pbuilder-satisfydepends-dummy depends on libhiredis-dev (>= 0.10.0); however: Package libhiredis-dev is not installed. pbuilder-satisfydepends-dummy depends on libjansson-dev; however: Package libjansson-dev is not installed. pbuilder-satisfydepends-dummy depends on libjson-c-dev; however: Package libjson-c-dev is not installed. pbuilder-satisfydepends-dummy depends on libldap2-dev; however: Package libldap2-dev is not installed. pbuilder-satisfydepends-dummy depends on liblua5.1-0-dev; however: Package liblua5.1-0-dev is not installed. pbuilder-satisfydepends-dummy depends on libmaxminddb-dev; however: Package libmaxminddb-dev is not installed. pbuilder-satisfydepends-dummy depends on libmemcached-dev; however: Package libmemcached-dev is not installed. pbuilder-satisfydepends-dummy depends on libmongoc-dev; however: Package libmongoc-dev is not installed. pbuilder-satisfydepends-dummy depends on libmono-2.0-dev; however: Package libmono-2.0-dev is not installed. pbuilder-satisfydepends-dummy depends on libncurses5-dev; however: Package libncurses5-dev is not installed. pbuilder-satisfydepends-dummy depends on libpcre3-dev; however: Package libpcre3-dev is not installed. pbuilder-satisfydepends-dummy depends on libperl-dev; however: Package libperl-dev is not installed. pbuilder-satisfydepends-dummy depends on libphonenumber-dev (>= 7); however: Package libphonenumber-dev is not installed. pbuilder-satisfydepends-dummy depends on libpq-dev; however: Package libpq-dev is not installed. pbuilder-satisfydepends-dummy depends on librabbitmq-dev; however: Package librabbitmq-dev is not installed. pbuilder-satisfydepends-dummy depends on libradcli-dev; however: Package libradcli-dev is not installed. pbuilder-satisfydepends-dummy depends on libreadline-dev; however: Package libreadline-dev is not installed. pbuilder-satisfydepends-dummy depends on libsasl2-dev; however: Package libsasl2-dev is not installed. pbuilder-satisfydepends-dummy depends on libsctp-dev; however: Package libsctp-dev is not installed. pbuilder-satisfydepends-dummy depends on libsnmp-dev; however: Package libsnmp-dev is not installed. pbuilder-satisfydepends-dummy depends on libsqlite3-dev; however: Package libsqlite3-dev is not installed. pbuilder-satisfydepends-dummy depends on libssl-dev; however: Package libssl-dev is not installed. pbuilder-satisfydepends-dummy depends on libsystemd-dev; however: Package libsystemd-dev is not installed. pbuilder-satisfydepends-dummy depends on libunistring-dev; however: Package libunistring-dev is not installed. pbuilder-satisfydepends-dummy depends on libxml2-dev; however: Package libxml2-dev is not installed. pbuilder-satisfydepends-dummy depends on openssl; however: Package openssl is not installed. pbuilder-satisfydepends-dummy depends on pkg-config; however: Package pkg-config is not installed. pbuilder-satisfydepends-dummy depends on python; however: Package python is not installed. pbuilder-satisfydepends-dummy depends on python-dev; however: Package python-dev is not installed. pbuilder-satisfydepends-dummy depends on unixodbc-dev; however: Package unixodbc-dev is not installed. pbuilder-satisfydepends-dummy depends on uuid-dev; however: Package uuid-dev is not installed. pbuilder-satisfydepends-dummy depends on xsltproc; however: Package xsltproc is not installed. pbuilder-satisfydepends-dummy depends on zlib1g-dev; however: Package zlib1g-dev is not installed. Setting up pbuilder-satisfydepends-dummy (0.invalid.0) ... Reading package lists... Building dependency tree... Reading state information... Initializing package states... Writing extended state information... Building tag database... pbuilder-satisfydepends-dummy is already installed at the requested version (0.invalid.0) pbuilder-satisfydepends-dummy is already installed at the requested version (0.invalid.0) The following NEW packages will be installed: autoconf{a} automake{a} autopoint{a} autotools-dev{a} bison{a} bsdmainutils{a} debhelper{a} default-libmysqlclient-dev{a} dh-autoreconf{a} dh-strip-nondeterminism{a} dh-systemd{a} docbook-xml{a} dwz{a} erlang-base{a} erlang-dev{a} file{a} flex{a} geoip-bin{a} gettext{a} gettext-base{a} gir1.2-glib-2.0{a} gir1.2-harfbuzz-0.0{a} groff-base{a} icu-devtools{a} intltool-debian{a} libarchive-zip-perl{a} libbison-dev{a} libboost-atomic1.62-dev{a} libboost-atomic1.62.0{a} libboost-chrono1.62-dev{a} libboost-chrono1.62.0{a} libboost-date-time1.62-dev{a} libboost-date-time1.62.0{a} libboost-dev{a} libboost-serialization1.62-dev{a} libboost-serialization1.62.0{a} libboost-system-dev{a} libboost-system1.62-dev{a} libboost-thread-dev{a} libboost-thread1.62-dev{a} libboost-thread1.62.0{a} libboost1.62-dev{a} libbsd0{a} libbson-1.0-0{a} libbson-dev{a} libconfuse-common{a} libconfuse-dev{a} libconfuse2{a} libcroco3{a} libcurl4{a} libcurl4-openssl-dev{a} libdb-dev{a} libdb5.3-dev{a} libelf1{a} libev-dev{a} libev4{a} libevent-2.1-6{a} libevent-core-2.1-6{a} libevent-dev{a} libevent-extra-2.1-6{a} libevent-openssl-2.1-6{a} libevent-pthreads-2.1-6{a} libexpat1{a} libexpat1-dev{a} libfile-stripnondeterminism-perl{a} libfreetype6{a} libgeocoding7{a} libgeoip-dev{a} libgeoip1{a} libgirepository-1.0-1{a} libglib2.0-0{a} libglib2.0-bin{a} libglib2.0-data{a} libglib2.0-dev{a} libglib2.0-dev-bin{a} libgraphite2-3{a} libgraphite2-dev{a} libgssapi-krb5-2{a} libharfbuzz-dev{a} libharfbuzz-gobject0{a} libharfbuzz-icu0{a} libharfbuzz0b{a} libhashkit-dev{a} libhashkit2{a} libhiredis-dev{a} libhiredis0.13{a} libicu-dev{a} libicu-le-hb-dev{a} libicu-le-hb0{a} libicu60{a} libjansson-dev{a} libjansson4{a} libjson-c-dev{a} libjson-c3{a} libk5crypto3{a} libkeyutils1{a} libkrb5-3{a} libkrb5support0{a} libldap-2.4-2{a} libldap-common{a} libldap2-dev{a} libltdl-dev{a} libltdl7{a} liblua5.1-0{a} liblua5.1-0-dev{a} libmagic-mgc{a} libmagic1{a} libmariadbclient-dev{a} libmariadbclient-dev-compat{a} libmariadbclient18{a} libmaxminddb-dev{a} libmaxminddb0{a} libmemcached-dev{a} libmemcached11{a} libmemcachedutil2{a} libmongoc-1.0-0{a} libmongoc-dev{a} libmono-2.0-dev{a} libmonosgen-2.0-1{a} libmonosgen-2.0-dev{a} libmpdec2{a} libncurses-dev{a} libnghttp2-14{a} libodbc1{a} libpci-dev{a} libpci3{a} libpcre16-3{a} libpcre3-dev{a} libpcre32-3{a} libpcrecpp0v5{a} libperl-dev{a} libphonenumber-dev{a} libphonenumber7{a} libpipeline1{a} libpng16-16{a} libpq-dev{a} libpq5{a} libprocps7{a} libprotobuf-dev{a} libprotobuf-lite10{a} libprotobuf10{a} libpsl5{a} libpython-dev{a} libpython-stdlib{a} libpython2.7{a} libpython2.7-dev{a} libpython2.7-minimal{a} libpython2.7-stdlib{a} libpython3-stdlib{a} libpython3.6-minimal{a} libpython3.6-stdlib{a} librabbitmq-dev{a} librabbitmq4{a} libradcli-dev{a} libradcli4{a} libreadline-dev{a} libreadline7{a} librtmp1{a} libsasl2-2{a} libsasl2-dev{a} libsasl2-modules-db{a} libsctp-dev{a} libsctp1{a} libsensors4{a} libsensors4-dev{a} libsigsegv2{a} libsnappy-dev{a} libsnappy1v5{a} libsnmp-base{a} libsnmp-dev{a} libsnmp30{a} libsqlite3-dev{a} libssh2-1{a} libssl-dev{a} libssl1.1{a} libsystemd-dev{a} libtimedate-perl{a} libtool{a} libudev-dev{a} libunistring-dev{a} libwrap0{a} libwrap0-dev{a} libxml2{a} libxml2-dev{a} libxslt1.1{a} m4{a} man-db{a} mime-support{a} mysql-common{a} odbcinst{a} odbcinst1debian2{a} openssl{a} pkg-config{a} po-debconf{a} procps{a} python{a} python-dev{a} python-minimal{a} python2.7{a} python2.7-dev{a} python2.7-minimal{a} python3{a} python3-distutils{a} python3-lib2to3{a} python3-minimal{a} python3.6{a} python3.6-minimal{a} readline-common{a} sgml-base{a} sgml-data{a} unixodbc-dev{a} uuid-dev{a} xml-core{a} xsltproc{a} zlib1g-dev{a} The following packages are RECOMMENDED but will NOT be installed: ca-certificates curl erlang-crypto erlang-syntax-tools geoip-database krb5-locales libarchive-cpio-perl libconfuse-doc libfl-dev libmail-sendmail-perl libsasl2-modules libtool-bin lynx psmisc publicsuffix shared-mime-info wget xdg-user-dirs 0 packages upgraded, 215 newly installed, 0 to remove and 0 not upgraded. Need to get 136 MB of archives. After unpacking 507 MB will be used. The following packages have unmet dependencies: pbuilder-satisfydepends-dummy : Depends: gcj-jdk which is a virtual package and is not provided by any available package Unable to resolve dependencies! Giving up... The following NEW packages will be installed: autoconf{a} automake{a} autopoint{a} autotools-dev{a} bison{a} bsdmainutils{a} debhelper{a} default-libmysqlclient-dev{a} dh-autoreconf{a} dh-strip-nondeterminism{a} dh-systemd{a} docbook-xml{a} dwz{a} erlang-base{a} erlang-dev{a} file{a} flex{a} geoip-bin{a} gettext{a} gettext-base{a} gir1.2-glib-2.0{a} gir1.2-harfbuzz-0.0{a} groff-base{a} icu-devtools{a} intltool-debian{a} libarchive-zip-perl{a} libbison-dev{a} libboost-atomic1.62-dev{a} libboost-atomic1.62.0{a} libboost-chrono1.62-dev{a} libboost-chrono1.62.0{a} libboost-date-time1.62-dev{a} libboost-date-time1.62.0{a} libboost-dev{a} libboost-serialization1.62-dev{a} libboost-serialization1.62.0{a} libboost-system-dev{a} libboost-system1.62-dev{a} libboost-thread-dev{a} libboost-thread1.62-dev{a} libboost-thread1.62.0{a} libboost1.62-dev{a} libbsd0{a} libbson-1.0-0{a} libbson-dev{a} libconfuse-common{a} libconfuse-dev{a} libconfuse2{a} libcroco3{a} libcurl4{a} libcurl4-openssl-dev{a} libdb-dev{a} libdb5.3-dev{a} libelf1{a} libev-dev{a} libev4{a} libevent-2.1-6{a} libevent-core-2.1-6{a} libevent-dev{a} libevent-extra-2.1-6{a} libevent-openssl-2.1-6{a} libevent-pthreads-2.1-6{a} libexpat1{a} libexpat1-dev{a} libfile-stripnondeterminism-perl{a} libfreetype6{a} libgeocoding7{a} libgeoip-dev{a} libgeoip1{a} libgirepository-1.0-1{a} libglib2.0-0{a} libglib2.0-bin{a} libglib2.0-data{a} libglib2.0-dev{a} libglib2.0-dev-bin{a} libgraphite2-3{a} libgraphite2-dev{a} libgssapi-krb5-2{a} libharfbuzz-dev{a} libharfbuzz-gobject0{a} libharfbuzz-icu0{a} libharfbuzz0b{a} libhashkit-dev{a} libhashkit2{a} libhiredis-dev{a} libhiredis0.13{a} libicu-dev{a} libicu-le-hb-dev{a} libicu-le-hb0{a} libicu60{a} libjansson-dev{a} libjansson4{a} libjson-c-dev{a} libjson-c3{a} libk5crypto3{a} libkeyutils1{a} libkrb5-3{a} libkrb5support0{a} libldap-2.4-2{a} libldap-common{a} libldap2-dev{a} libltdl-dev{a} libltdl7{a} liblua5.1-0{a} liblua5.1-0-dev{a} libmagic-mgc{a} libmagic1{a} libmariadbclient-dev{a} libmariadbclient-dev-compat{a} libmariadbclient18{a} libmaxminddb-dev{a} libmaxminddb0{a} libmemcached-dev{a} libmemcached11{a} libmemcachedutil2{a} libmongoc-1.0-0{a} libmongoc-dev{a} libmono-2.0-dev{a} libmonosgen-2.0-1{a} libmonosgen-2.0-dev{a} libmpdec2{a} libncurses-dev{a} libnghttp2-14{a} libodbc1{a} libpci-dev{a} libpci3{a} libpcre16-3{a} libpcre3-dev{a} libpcre32-3{a} libpcrecpp0v5{a} libperl-dev{a} libphonenumber-dev{a} libphonenumber7{a} libpipeline1{a} libpng16-16{a} libpq-dev{a} libpq5{a} libprocps7{a} libprotobuf-dev{a} libprotobuf-lite10{a} libprotobuf10{a} libpsl5{a} libpython-dev{a} libpython-stdlib{a} libpython2.7{a} libpython2.7-dev{a} libpython2.7-minimal{a} libpython2.7-stdlib{a} libpython3-stdlib{a} libpython3.6-minimal{a} libpython3.6-stdlib{a} librabbitmq-dev{a} librabbitmq4{a} libradcli-dev{a} libradcli4{a} libreadline-dev{a} libreadline7{a} librtmp1{a} libsasl2-2{a} libsasl2-dev{a} libsasl2-modules-db{a} libsctp-dev{a} libsctp1{a} libsensors4{a} libsensors4-dev{a} libsigsegv2{a} libsnappy-dev{a} libsnappy1v5{a} libsnmp-base{a} libsnmp-dev{a} libsnmp30{a} libsqlite3-dev{a} libssh2-1{a} libssl-dev{a} libssl1.1{a} libsystemd-dev{a} libtimedate-perl{a} libtool{a} libudev-dev{a} libunistring-dev{a} libwrap0{a} libwrap0-dev{a} libxml2{a} libxml2-dev{a} libxslt1.1{a} m4{a} man-db{a} mime-support{a} mysql-common{a} odbcinst{a} odbcinst1debian2{a} openssl{a} pkg-config{a} po-debconf{a} procps{a} python{a} python-dev{a} python-minimal{a} python2.7{a} python2.7-dev{a} python2.7-minimal{a} python3{a} python3-distutils{a} python3-lib2to3{a} python3-minimal{a} python3.6{a} python3.6-minimal{a} readline-common{a} sgml-base{a} sgml-data{a} unixodbc-dev{a} uuid-dev{a} xml-core{a} xsltproc{a} zlib1g-dev{a} The following packages are RECOMMENDED but will NOT be installed: ca-certificates curl erlang-crypto erlang-syntax-tools geoip-database krb5-locales libarchive-cpio-perl libconfuse-doc libfl-dev libmail-sendmail-perl libsasl2-modules libtool-bin lynx psmisc publicsuffix shared-mime-info wget xdg-user-dirs 0 packages upgraded, 215 newly installed, 0 to remove and 0 not upgraded. Need to get 136 MB of archives. After unpacking 507 MB will be used. Abort. E: pbuilder-satisfydepends failed. I: Copying back the cached apt archive contents I: unmounting /tmp/apt-jdg_PCk8AQ filesystem I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem -> Cleaning COW directory forking: rm -rf /var/cache/pbuilder/build//cow.1591 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /var/run/lock/buster-i386.building.931 + '[' -r /var/run/lock/buster-i386.update.931 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailio51-binaries/architecture=i386,dist…'> + '[' -n /tmp/tmp.xPZCwzG34W ']' + rm -rf /tmp/tmp.xPZCwzG34W + '[' -n /tmp/apt-jdg_PCk8AQ ']' + sudo rm -rf /tmp/apt-jdg_PCk8AQ + '[' -n 307161 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=10 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Tue Jun 5 14:33:19 UTC 2018 [running 10 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Tue Jun 5 14:33:19 UTC 2018 [running 10 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

1 1

git:master:bf6d926d: jansson: exported jansson_get(...) to kemi framework
by Daniel-Constantin Mierla 22 Aug '18

22 Aug '18

Module: kamailio Branch: master Commit: bf6d926d5d22f99c1a2776aaeb9ec705b58592c5 URL: https://github.com/kamailio/kamailio/commit/bf6d926d5d22f99c1a2776aaeb9ec70… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-08-22T16:50:22+02:00 jansson: exported jansson_get(...) to kemi framework - jansson.get(...) --- Modified: src/modules/jansson/jansson_funcs.c Modified: src/modules/jansson/jansson_funcs.h Modified: src/modules/jansson/jansson_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/bf6d926d5d22f99c1a2776aaeb9ec70… Patch: https://github.com/kamailio/kamailio/commit/bf6d926d5d22f99c1a2776aaeb9ec70… --- diff --git a/src/modules/jansson/jansson_funcs.c b/src/modules/jansson/jansson_funcs.c index 9f82243114..012f1aba40 100644 --- a/src/modules/jansson/jansson_funcs.c +++ b/src/modules/jansson/jansson_funcs.c @@ -31,38 +31,23 @@ #include "jansson_funcs.h" #include "jansson_utils.h" -int janssonmod_get(struct sip_msg* msg, char* path_in, char* src_in, char* dst) +int janssonmod_get_helper(sip_msg_t* msg, str *path_s, str *src_s, pv_spec_t *dst_pv) { - str src_s; - str path_s; - pv_spec_t *dst_pv; - pv_value_t dst_val; - - if (fixup_get_svalue(msg, (gparam_p)src_in, &src_s) != 0) { - ERR("cannot get json string value\n"); - return -1; - } - - if (fixup_get_svalue(msg, (gparam_p)path_in, &path_s) != 0) { - ERR("cannot get path string value\n"); - return -1; - } - - dst_pv = (pv_spec_t *)dst; + pv_value_t dst_val; json_t* json = NULL; json_error_t parsing_error; - json = json_loads(src_s.s, JSON_REJECT_DUPLICATES, &parsing_error); + json = json_loads(src_s->s, JSON_REJECT_DUPLICATES, &parsing_error); if(!json) { - ERR("failed to parse: %.*s\n", src_s.len, src_s.s); + ERR("failed to parse: %.*s\n", src_s->len, src_s->s); ERR("json error at line %d: %s\n", parsing_error.line, parsing_error.text); goto fail; } - char* path = path_s.s; + char* path = path_s->s; json_t* v = json_path_get(json, path); if(!v) { @@ -87,6 +72,24 @@ int janssonmod_get(struct sip_msg* msg, char* path_in, char* src_in, char* dst) return -1; } +int janssonmod_get(struct sip_msg* msg, char* path_in, char* src_in, char* dst) +{ + str src_s; + str path_s; + + if (fixup_get_svalue(msg, (gparam_p)src_in, &src_s) != 0) { + ERR("cannot get json string value\n"); + return -1; + } + + if (fixup_get_svalue(msg, (gparam_p)path_in, &path_s) != 0) { + ERR("cannot get path string value\n"); + return -1; + } + + return janssonmod_get_helper(msg, &path_s, &src_s, (pv_spec_t *)dst); +} + #define STR_EQ_STATIC(a,b) ((a.len == sizeof(b)-1) && (strncmp(a.s, b, sizeof(b)-1)==0)) int janssonmod_set(unsigned int append, struct sip_msg* msg, char* type_in, diff --git a/src/modules/jansson/jansson_funcs.h b/src/modules/jansson/jansson_funcs.h index 9373956520..abf3e15ba3 100644 --- a/src/modules/jansson/jansson_funcs.h +++ b/src/modules/jansson/jansson_funcs.h @@ -31,5 +31,7 @@ int janssonmod_set(unsigned int append, struct sip_msg* msg, char* type_in, char* path_in, char* value_in, char* result); int janssonmod_array_size(struct sip_msg* msg, char* json_in, char* path_in, char* dst); +int janssonmod_get_helper(sip_msg_t* msg, str *path_s, str *src_s, + pv_spec_t *dst_pv); #endif diff --git a/src/modules/jansson/jansson_mod.c b/src/modules/jansson/jansson_mod.c index a8404a241f..50c3d91292 100644 --- a/src/modules/jansson/jansson_mod.c +++ b/src/modules/jansson/jansson_mod.c @@ -25,6 +25,7 @@ #include "../../core/mod_fix.h" #include "../../core/sr_module.h" +#include "../../core/kemi.h" #include "jansson_funcs.h" #include "jansson_utils.h" @@ -147,3 +148,46 @@ static int fixup_set_params_free(void** param, int param_no) static int mod_init(void) { return 0; } + +/** + * + */ +static int ki_jansson_get(sip_msg_t *msg, str *spath, str *sdoc, str *spv) +{ + pv_spec_t *pvs = NULL; + + pvs = pv_cache_get(spv); + if(pvs==NULL) { + LM_ERR("cannot get pv spec for [%.*s]\n", spv->len, spv->s); + return -1; + } + + if(pvs->setf==NULL) { + LM_ERR("read only output var [%.*s]\n", spv->len, spv->s); + return -1; + } + + return janssonmod_get_helper(msg, spath, sdoc, pvs); +} + +/** + * + */ +static sr_kemi_t sr_kemi_jansson_exports[] = { + { str_init("jansson"), str_init("get"), + SR_KEMIP_INT, ki_jansson_get, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + + {{0, 0}, {0, 0}, 0, NULL, {0, 0, 0, 0, 0, 0}} +}; + +/** + * + */ +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_jansson_exports); + return 0; +} \ No newline at end of file

1 0

git:master:8f5b70ca: misc/examples/ims/pcscf/route: Update the rest of the routing scripts for P-CSCF with IPSec support; Fix Rx_AAR() calls.
by Tsvetomir Dimitrov 22 Aug '18

22 Aug '18

Module: kamailio Branch: master Commit: 8f5b70ca81e1d49c926a6174191ffe8d7097e3cc URL: https://github.com/kamailio/kamailio/commit/8f5b70ca81e1d49c926a6174191ffe8… Author: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Committer: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Date: 2018-08-22T16:03:24+03:00 misc/examples/ims/pcscf/route: Update the rest of the routing scripts for P-CSCF with IPSec support; Fix Rx_AAR() calls. --- Modified: misc/examples/ims/pcscf/route/mo.cfg Modified: misc/examples/ims/pcscf/route/mt.cfg Modified: misc/examples/ims/pcscf/route/register.cfg --- Diff: https://github.com/kamailio/kamailio/commit/8f5b70ca81e1d49c926a6174191ffe8… Patch: https://github.com/kamailio/kamailio/commit/8f5b70ca81e1d49c926a6174191ffe8… --- diff --git a/misc/examples/ims/pcscf/route/mo.cfg b/misc/examples/ims/pcscf/route/mo.cfg index f00aad61fc..235b9f1275 100644 --- a/misc/examples/ims/pcscf/route/mo.cfg +++ b/misc/examples/ims/pcscf/route/mo.cfg @@ -95,6 +95,7 @@ onreply_route[MO_reply] { remove_hf("C-Params"); append_hf("Contact: $ct;$hdr(C-Params)\r\n"); } + ipsec_forward("location"); # In case of 1xx and 2xx do NAT if(status=~"[12][0-9][0-9]") route(NATMANAGE); @@ -112,7 +113,7 @@ onreply_route[MO_reply] { $avp(TTAG_CUSTOM_AVP)=$tt; $avp(CALLID_CUSTOM_AVP)=$ci; - $var(aarret) = Rx_AAR("MO_aar_reply","orig"); + $var(aarret) = Rx_AAR("MO_aar_reply","orig","",-1); xlog("L_DBG", "AAR return code is $var(aarret)\n"); switch ($var(aarret)) { @@ -135,6 +136,7 @@ onreply_route[MO_reply] { } } +} route[MO_aar_reply] { @@ -184,7 +186,7 @@ onreply_route[MO_indialog_reply] { $avp(TTAG_CUSTOM_AVP)=$tt; $avp(CALLID_CUSTOM_AVP)=$ci; - $var(aarret) = Rx_AAR("MO_indialog_aar_reply","orig"); + $var(aarret) = Rx_AAR("MO_indialog_aar_reply","orig","",-1); xlog("L_DBG", "AAR return code is $var(aarret)\n"); switch ($var(aarret)) { diff --git a/misc/examples/ims/pcscf/route/mt.cfg b/misc/examples/ims/pcscf/route/mt.cfg index 3ee9d66c52..eab2c7c37e 100644 --- a/misc/examples/ims/pcscf/route/mt.cfg +++ b/misc/examples/ims/pcscf/route/mt.cfg @@ -30,7 +30,7 @@ onreply_route[MT_reply] { $avp(TTAG_CUSTOM_AVP)=$tt; $avp(CALLID_CUSTOM_AVP)=$ci; - $var(aarret) = Rx_AAR("MT_aar_reply","term"); + $var(aarret) = Rx_AAR("MT_aar_reply","term","",-1); xlog("L_DBG", "AAR return code is $var(aarret)\n"); switch ($var(aarret)) { @@ -104,7 +104,7 @@ onreply_route[MT_indialog_reply] { $avp(TTAG_CUSTOM_AVP)=$tt; $avp(CALLID_CUSTOM_AVP)=$ci; - $var(aarret) = Rx_AAR("MT_indialog_aar_reply","term"); + $var(aarret) = Rx_AAR("MT_indialog_aar_reply","term","",-1); xlog("L_DBG", "AAR return code is $var(aarret)\n"); switch ($var(aarret)) { diff --git a/misc/examples/ims/pcscf/route/register.cfg b/misc/examples/ims/pcscf/route/register.cfg index df7ddcd1cd..b2d1f92638 100644 --- a/misc/examples/ims/pcscf/route/register.cfg +++ b/misc/examples/ims/pcscf/route/register.cfg @@ -156,7 +156,13 @@ onreply_route[REGISTER_reply] xlog("L_DBG", "REGISTER SUCCESS[$ci] took $var(stat_add)ms\n"); update_stat("register_success", "+1"); update_stat("register_time", "$var(stat_add)"); + ipsec_forward("location"); } + else { + if (t_check_status("401")) { + ipsec_create("location"); + } + } exit; }

1 0

git:master:c4daee86: misc/examples/ims/pcscf: Add support for IPSec in the P-CSCF examples
by Tsvetomir Dimitrov 22 Aug '18

22 Aug '18

Module: kamailio Branch: master Commit: c4daee863519b1795c605e3896506e5ec7e26a41 URL: https://github.com/kamailio/kamailio/commit/c4daee863519b1795c605e3896506e5… Author: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Committer: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Date: 2018-08-22T15:28:11+03:00 misc/examples/ims/pcscf: Add support for IPSec in the P-CSCF examples --- Modified: misc/examples/ims/pcscf/kamailio.cfg Modified: misc/examples/ims/pcscf/pcscf.cfg.sample --- Diff: https://github.com/kamailio/kamailio/commit/c4daee863519b1795c605e3896506e5… Patch: https://github.com/kamailio/kamailio/commit/c4daee863519b1795c605e3896506e5… --- diff --git a/misc/examples/ims/pcscf/kamailio.cfg b/misc/examples/ims/pcscf/kamailio.cfg index 8502ce6dc0..0c3f65de77 100644 --- a/misc/examples/ims/pcscf/kamailio.cfg +++ b/misc/examples/ims/pcscf/kamailio.cfg @@ -162,6 +162,9 @@ loadmodule "statistics" loadmodule "ims_dialog" loadmodule "ims_usrloc_pcscf" loadmodule "ims_registrar_pcscf" +#!ifdef WITH_IPSEC +loadmodule "ims_ipsec_pcscf" +#!endif #!ifdef WITH_XMLRPC loadmodule "xmlrpc" @@ -366,6 +369,12 @@ modparam("ims_registrar_pcscf", "subscribe_to_reginfo", 0) modparam("ims_registrar_pcscf", "publish_reginfo", 0) #!endif +#!ifdef WITH_IPSEC +modparam("ims_ipsec_pcscf", "ipsec_listen_addr", IPSEC_LISTEN_ADDR) +modparam("ims_ipsec_pcscf", "ipsec_client_port", IPSEC_CLIENT_PORT) +modparam("ims_ipsec_pcscf", "ipsec_server_port", IPSEC_SERVER_PORT) +#!endif + #!ifdef WITH_RX # -- CDP params -- modparam("cdp","config_file","/etc/kamailio_pcscf/pcscf.xml") @@ -700,7 +709,11 @@ route[REQINIT] { send_reply("503", "Server shutting down"); exit; } - + + if (!is_method("REGISTER")) { + ipsec_forward("location"); + } + # Ignore Re-Transmits: if (t_lookup_request()) { exit; @@ -852,6 +865,7 @@ event_route[uac:reply] { } xlog(" Unregistering $uac_req(ruri);$var(alias)\n"); setdebug("9"); + ipsec_destroy("location"); pcscf_unregister("location", "$uac_req(ruri);$var(alias)", "$(uac_req(ouri){uri.host})", "$(uac_req(ouri){uri.port})"); resetdebug(); $sht(natping=>$uac_req(ouri)) = $null; diff --git a/misc/examples/ims/pcscf/pcscf.cfg.sample b/misc/examples/ims/pcscf/pcscf.cfg.sample index 5a89ee1020..6b7a7231ca 100644 --- a/misc/examples/ims/pcscf/pcscf.cfg.sample +++ b/misc/examples/ims/pcscf/pcscf.cfg.sample @@ -7,6 +7,11 @@ listen=udp:11.22.33.44:5060 # SIP / TCP/TLS #listen=tls:11.22.33.44:5061 +# IPSEC / UDP +#!define IPSEC_LISTEN_ADDR "11.22.33.44" +#!define IPSEC_CLIENT_PORT 5062 +#!define IPSEC_SERVER_PORT 5063 + alias=pcscf.mnc001.mcc001.3gppnetwork.org #!define MY_WS_PORT 80 @@ -104,4 +109,4 @@ alias=pcscf.mnc001.mcc001.3gppnetwork.org ##!define WITH_REGINFO ##!define WITH_RTPPING ##!define WITH_WEBSOCKET - +##!define WITH_IPSEC

1 0

Kamailio v5.1.5 Released
by Daniel-Constantin Mierla 22 Aug '18

22 Aug '18

Hello, Kamailio SIP Server v5.1.5 stable release is out. This is a maintenance release of the latest stable branch, 5.1, that includes fixes since the release of v5.1.4. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.1.x. Deployments running previous v5.1.x versions are strongly recommended to be upgraded to v5.1.5. For more details about version 5.1.5 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2018/08/kamailio-v5-1-5-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com

1 0

git:master:f6921b92: sdpops: cast in dbg message to avoid compile warning on 32b systems
by Daniel-Constantin Mierla 22 Aug '18

22 Aug '18

Module: kamailio Branch: master Commit: f6921b92d382db3c0a72bd1d97eb46d1f4aee2d7 URL: https://github.com/kamailio/kamailio/commit/f6921b92d382db3c0a72bd1d97eb46d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-08-22T12:03:52+02:00 sdpops: cast in dbg message to avoid compile warning on 32b systems --- Modified: src/modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f6921b92d382db3c0a72bd1d97eb46d… Patch: https://github.com/kamailio/kamailio/commit/f6921b92d382db3c0a72bd1d97eb46d… --- diff --git a/src/modules/sdpops/sdpops_mod.c b/src/modules/sdpops/sdpops_mod.c index b47f824e33..b317c0ac9b 100644 --- a/src/modules/sdpops/sdpops_mod.c +++ b/src/modules/sdpops/sdpops_mod.c @@ -512,8 +512,9 @@ int sdp_remove_line_by_prefix(sip_msg_t* msg, str* prefix, str* media) LM_DBG("range for media type %.*s: %ld - %ld\n", sdp_stream->media.len, sdp_stream->media.s, - sdp_stream->raw_stream.s - body.s, - sdp_stream->raw_stream.s + sdp_stream->raw_stream.len - body.s + (long int)(sdp_stream->raw_stream.s - body.s), + (long int)(sdp_stream->raw_stream.s + + sdp_stream->raw_stream.len - body.s) ); found += sdp_remove_line_lump_by_prefix(msg,&(sdp_stream->raw_stream),prefix);

1 0

git:5.1:d060804b: ChangeLog: content updated for v5.1.5
by Daniel-Constantin Mierla 22 Aug '18

22 Aug '18

Module: kamailio Branch: 5.1 Commit: d060804b66b0f7eb064810b1445d4d076e246423 URL: https://github.com/kamailio/kamailio/commit/d060804b66b0f7eb064810b1445d4d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-08-22T11:33:14+02:00 ChangeLog: content updated for v5.1.5 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/d060804b66b0f7eb064810b1445d4d0… Patch: https://github.com/kamailio/kamailio/commit/d060804b66b0f7eb064810b1445d4d0…

1 0

[kamailio/kamailio] Issues with PUA_REGINFO module (#1579)
by Lars Olsson 22 Aug '18

22 Aug '18

### Description While testing to implement an IMS AS, I used the PUA_REGINFO module to receive details about the SIP registration. PUA_REGINFO module uses PUA and USRLOC modules. However, a couple of issues was found including a crash: 1) Crash when processing SIP Notify with registration terminated info. 2) Randomly fails storing data to USRLOC, (entries already exists) 3) Saves corrupt data to database use_domain is set in usrloc but domain not provided in Notify request ### Troubleshooting I am pretty new to Kamailio, but my findings are the following in notify.c 1) PUA_REGINFO modules, deletes the record with "ul.delete_urecord(...)" and later down in the code calls "if (ul_record) ul.release_urecord(ul_record);". Crashes on the release_urecord call. My assumption without knowing to much about userloc is that release can not be called on a deleted record. Hence it should be enough to set ul_record = NULL after calling "ul.delete_urecord(...)" to not call release_urecord later on. 2) It looks like there is an issue handling parallell request. Without knowing too much, it replacing sruid_next(..) with sruid_next_safe() resolves the issue. Also, the static variable of type ucontact_info_t should probably become local as well. 3) Maybe incorrect to set use_domain to 1 when using the module, however I think it should be failsafe and not store garbage data in to database. Not looked into this issue. #### Reproduction Send Notify request with REGINFO body for registration and unregistration and forward it to the module according to the documentation of PUA_REGINFO. #### Debugging Data Attaching SIPp scenario. Changing code according to 1) and 2) make the SIPp script runs and no critical issues seen. (Have too less experience to ensure that no memleaks are introduced or still present in the module code) <?xml version="1.0" encoding="ISO-8859-1" ?> <scenario name="notify"> <send retrans="500"> <![CDATA[ NOTIFY sip:[remote_ip] SIP/2.0 Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch] From: <sip:[field0]@[field1]>;tag=[call_number] To: <sip:[field0]@[field1]> Call-ID: [call_id] CSeq: 1 NOTIFY Contact: sip:[field0]@[local_ip]:[local_port] Max-Forwards: 70 Expires: 1800 Event: reg User-Agent: SIPp/Linux Subscription-State: active;expires=6888 Content-Type: application/reginfo+xml Content-Length: [len] <?xml version="1.0"?> <reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="2" state="full"> <registration aor="sip:[field0]@mnc001.mcc001.3gppnetwork.org" id="0x7feff71118f8" state="active"> <contact id="0x7feff7126e58" state="active" event="registered" expires="595" q="0.500"> <uri>sip:[field0]@192.168.55.103:21061;ob;alias=192.168.55.103~21061~1</uri> <unknown-param name="+g.3gpp.smsip"></unknown-param> <unknown-param name="q">"0.5"</unknown-param> </contact> </registration> </reginfo> ]]> </send> <recv response="202" rtd="true"> </recv> <pause milliseconds="1000"/> <send retrans="500"> <![CDATA[ NOTIFY sip:[remote_ip] SIP/2.0 Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch] From: <sip:[field0]@[field1]>;tag=[call_number] To: <sip:[field0]@[field1]> Call-ID: [call_id] CSeq: 2 NOTIFY Contact: sip:[field0]@[local_ip]:[local_port] Max-Forwards: 70 Expires: 1800 User-Agent: SIPp/Linux Event: reg Subscription-State: active;expires=6888 Content-Type: application/reginfo+xml Content-Length: [len] <?xml version="1.0"?> <reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="3" state="full"> <registration aor="sip:[field0]@mnc001.mcc001.3gppnetwork.org" id="0x7feff71118f8" state="terminated"> <contact id="0x1" state="terminated" event="expired" expires="0" q="0.000"> <uri>sip:[field0]@192.168.55.103:21061;ob;alias=192.168.55.103~21061~1</uri> </contact> </registration> </reginfo> ]]> </send> <recv response="202" rtd="true"> </recv> </scenario> #### Log Messages #### SIP Traffic ### Possible Solutions See troubleshooting. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.1.4 ``` * **Operating System**: ``` Debian 8.11 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1579

6 15

← Newer
1
...
11
12
13
14
15
16
17
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2018