sr-dev November 2019

sr-dev@lists.kamailio.org

22 participants
381 discussions

[kamailio/kamailio] Crash in permissions module (#2151)
by sjthomason 03 Dec '19

03 Dec '19

### Description Crash in permissions module when `load_backends` set to 1 ``` modparam("permissions", "db_url", DBURL) modparam("permissions", "db_mode", 0) modparam("permissions", "address_table", "gw_auth_ip") modparam("permissions", "trusted_table", "user_auth_ip") modparam("permissions", "load_backends", 1) ``` ### Troubleshooting #### Reproduction To avoid Kamailio complaining about an old version table during an upgrade, I attempted to disable the "trusted" backend as we're not using it. Kamailio seg faults on startup. This is on 5.1.8 but I didn't see much difference in permissions with master #### Debugging Data ``` (gdb) bt full #0 0x0000000000000000 in ?? () No symbol table info available. #1 0xffffffff3ee2991c in init_child_trusted (rank=rank@entry=-2) at trusted.c:267 __func__ = "init_child_trusted" #2 0xffffffff3ee2d1d0 in child_init (rank=<optimized out>) at permissions.c:651 No locals. #3 0x000000010014a230 in init_mod_child (m=0x1007affd8, rank=rank@entry=-2) at core/sr_module.c:943 __func__ = "init_mod_child" #4 0x000000010014a0ec in init_mod_child (m=0x1007b0658, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #5 0x000000010014a0ec in init_mod_child (m=0x1007b0d80, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #6 0x000000010014a0ec in init_mod_child (m=0x1007b1a88, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #7 0x000000010014a0ec in init_mod_child (m=0x1007b1ea0, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #8 0x000000010014a0ec in init_mod_child (m=0x1007b22b8, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #9 0x000000010014a0ec in init_mod_child (m=0x1007b29c0, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #10 0x000000010014a0ec in init_mod_child (m=0x1007b33d8, rank=rank@entry=-2) at core/sr_module.c:939 __func__ = "init_mod_child" #11 0x00000001001565d0 in init_child (rank=rank@entry=-2) at core/sr_module.c:970 No locals. #12 0x000000010018cbf4 in fork_process (child_id=child_id@entry=-2, desc=<optimized out>, make_sock=make_sock@entry=1) at core/pt.c:338 pid = <optimized out> child_process_no = <optimized out> ret = -1 new_seed1 = <optimized out> new_seed2 = <optimized out> sockfd = {6, 13} __func__ = "fork_process" #13 0xffffffff3f211cd4 in mod_child (rank=<optimized out>) at ctl.c:327 pid = <optimized out> cs = <optimized out> rank = 0 rpc_handler = 1 rpc_handler = 1 #14 0x000000010014a230 in init_mod_child (m=0x1007af178, rank=rank@entry=0) at core/sr_module.c:943 __func__ = "init_mod_child" #15 0x000000010014a0ec in init_mod_child (m=0x1007af800, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #16 0x000000010014a0ec in init_mod_child (m=0x1007affd8, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #17 0x000000010014a0ec in init_mod_child (m=0x1007b0658, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #18 0x000000010014a0ec in init_mod_child (m=0x1007b0d80, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #19 0x000000010014a0ec in init_mod_child (m=0x1007b1a88, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #20 0x000000010014a0ec in init_mod_child (m=0x1007b1ea0, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #21 0x000000010014a0ec in init_mod_child (m=0x1007b22b8, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #22 0x000000010014a0ec in init_mod_child (m=0x1007b29c0, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #23 0x000000010014a0ec in init_mod_child (m=0x1007b33d8, rank=rank@entry=0) at core/sr_module.c:939 __func__ = "init_mod_child" #24 0x00000001001565d0 in init_child (rank=rank@entry=0) at core/sr_module.c:970 No locals. #25 0x00000001000c4c44 in main_loop () at main.c:1419 i = <optimized out> pid = <optimized out> si = <optimized out> si_desc = "\000\000\000\001\000h\200\000\000\000\000\000\000\000\000\330\000\000\000\001\000o6H\000\000\000\000\000\000\000\004\000\000\000\000\000\000\000n\000\000\000\000\000\000\000\t\000\000\000\000\000\000\000\002\000\000\000\000\000\000\000\004\377\377\377\377\177\377\357\241\000\000\000\001\000\f\345\004", '\000' <repeats 11 times>, "\001\000\003\277\320\377\377\377\377\377\377\377\375\377\377\377\377\377\377\377\375\377\377\377\377\377\377\377\375\377\377\377\377\377\377\377\375" nrprocs = <optimized out> woneinit = <optimized out> __func__ = "main_loop" #26 0x00000001000ce704 in main (argc=<optimized out>, argv=<optimized out>) at main.c:2663 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0xffffffff7ffffbb5 "" tmp_len = 0 port = 0 proto = 0 options = 0x10003ee20 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 1842495819 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> p = <optimized out> st = {st_dev = 70325794504717, st_ino = 205858632, st_mode = 16872, st_nlink = 2, st_uid = 1, st_gid = 12, st_rdev = 18446744073709551615, st_size = 334, st_atim = {tv_sec = 1574807105, tv_nsec = 898072627}, st_mtim = {tv_sec = 1574810139, tv_nsec = 861570968}, st_ctim = {tv_sec = 1574810139, tv_nsec = 861570968}, st_blksize = 8192, st_blocks = 16, st_fstype = "tmpfs\000\000\000\000\000\000\000\000\000\000"} __func__ = "main" (gdb) info locals cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0xffffffff7ffffbb5 "" tmp_len = 0 port = 0 proto = 0 options = 0x10003ee20 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 1842495819 rfd = <optimized out> debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> p = <optimized out> st = {st_dev = 70325794504717, st_ino = 205858632, st_mode = 16872, st_nlink = 2, st_uid = 1, st_gid = 12, st_rdev = 18446744073709551615, st_size = 334, st_atim = {tv_sec = 1574807105, tv_nsec = 898072627}, st_mtim = {tv_sec = 1574810139, tv_nsec = 861570968}, st_ctim = {tv_sec = 1574810139, tv_nsec = 861570968}, st_blksize = 8192, st_blocks = 16, st_fstype = "tmpfs\000\000\000\000\000\000\000\000\000\000"} __func__ = "main" ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ```kamailio -v version: kamailio 5.1.8 (sparc64/solaris) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, /dev/poll. id: unknown compiled with gcc 7.3.0``` * **Operating System**: Solaris 11.4 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2151

2 5

Kamailio Developer Guide
by Markus Bönke 02 Dec '19

02 Dec '19

Hello all, I’ve a question about the kamailio developer guide. I’ve found 2 locations: 1. The source code on https://github.com/asipto/kamailio-devel-guide <https://github.com/asipto/kamailio-devel-guide> and 2. an HTML version on https://www.asipto.com/pub/kamailio-devel-guide/ <https://www.asipto.com/pub/kamailio-devel-guide/> . The HTML version seems to be different from the source, e.g. the doxygen link points to http://rpm.kamailio.org/doxygen/sip-router/branch/master/index.html <http://rpm.kamailio.org/doxygen/sip-router/branch/master/index.html> in the github version but to http://devel.kamailio.net/doxygen/ <http://devel.kamailio.net/doxygen/> on the html version (actually both links are dead). Also some paragraphs differ slightly. As I start with Kamailio development, I can review the document and update links, remove outdated stuff like MI - Management Interface, etc to be compatible with the lastest version. I also can add a new chapter how to setup an IDE like vscode for debugging kamailio. Let me know where I can find the latest source version of the guide. Best Regards Markus

2 2

git:5.3:dc322c0d: tm: extend t_newtran docs with a note about flag behaviour
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.3 Commit: dc322c0d24fec1a864e133bff6bb8a7a67e136b5 URL: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T19:42:37+01:00 tm: extend t_newtran docs with a note about flag behaviour (cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a) --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7… Patch: https://github.com/kamailio/kamailio/commit/dc322c0d24fec1a864e133bff6bb8a7… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 8ceaa6360a..82647117cd 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -302,6 +302,12 @@ branch_route[1] { is the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. </para> + <para> + Note that any flag operations (e.g. for accounting) after this + function has been called will be ignored. You can use the the tmx + module function t_flush_flags() to flush the altered flags to the + already created transaction. + </para> <example> <title><function>t_newtran</function> usage</title> <programlisting>

1 0

git:5.2:bb7e84d4: tm: extend t_newtran docs with a note about flag behaviour
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.2 Commit: bb7e84d46017a112b88fa0c4a187bb5ca7f961c5 URL: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T19:42:10+01:00 tm: extend t_newtran docs with a note about flag behaviour (cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a) --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5… Patch: https://github.com/kamailio/kamailio/commit/bb7e84d46017a112b88fa0c4a187bb5… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 67cc5d017c..447f000eb6 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -302,6 +302,12 @@ branch_route[1] { is the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. </para> + <para> + Note that any flag operations (e.g. for accounting) after this + function has been called will be ignored. You can use the the tmx + module function t_flush_flags() to flush the altered flags to the + already created transaction. + </para> <example> <title><function>t_newtran</function> usage</title> <programlisting>

1 0

git:5.1:c039af87: tm: extend t_newtran docs with a note about flag behaviour
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.1 Commit: c039af8752b553c65d375a00a017820f85ead41a URL: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T19:41:48+01:00 tm: extend t_newtran docs with a note about flag behaviour (cherry picked from commit f2f492bd580621dec23d0538b8785635a013497a) --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820… Patch: https://github.com/kamailio/kamailio/commit/c039af8752b553c65d375a00a017820… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 7983de257b..af8f10ffc2 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -302,6 +302,12 @@ branch_route[1] { is the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. </para> + <para> + Note that any flag operations (e.g. for accounting) after this + function has been called will be ignored. You can use the the tmx + module function t_flush_flags() to flush the altered flags to the + already created transaction. + </para> <example> <title><function>t_newtran</function> usage</title> <programlisting>

1 0

git:master:f2f492bd: tm: extend t_newtran docs with a note about flag behaviour
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: master Commit: f2f492bd580621dec23d0538b8785635a013497a URL: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T19:40:03+01:00 tm: extend t_newtran docs with a note about flag behaviour --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563… Patch: https://github.com/kamailio/kamailio/commit/f2f492bd580621dec23d0538b878563… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 8ceaa6360a..82647117cd 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -302,6 +302,12 @@ branch_route[1] { is the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. </para> + <para> + Note that any flag operations (e.g. for accounting) after this + function has been called will be ignored. You can use the the tmx + module function t_flush_flags() to flush the altered flags to the + already created transaction. + </para> <example> <title><function>t_newtran</function> usage</title> <programlisting>

1 0

git:5.1:e5d94d3a: utils: Change sh(1) "test ==" usage to "="
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.1 Commit: e5d94d3a8c9ce2962c03b130972715785652b605 URL: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157… Author: Greg Troxel <gdt(a)lexort.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T18:43:20+01:00 utils: Change sh(1) "test ==" usage to "=" The POSIX sh(1) specification says that strings are compared with test(1) (also "[") with "=". Bash accepts "==" and this leads to non-portable code. This commit simply changes "==" within test/[ to "=". (cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d) --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157… Patch: https://github.com/kamailio/kamailio/commit/e5d94d3a8c9ce2962c03b1309727157… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index ea15329a19..a8b0f60e7b 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name> merr "kamailio_dump function takes two param" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_dump $1 $2 elif [ "$PW" = "" ] ; then $DUMP_CMD $1 > $2 @@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename> merr "kamailio_restore function takes two params" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_restore $1 $2 else sql_query $1 < $2 @@ -313,7 +313,7 @@ case $1 in ;; copy) # copy database to some other name - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -346,7 +346,7 @@ case $1 in exit $ret ;; backup) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -360,7 +360,7 @@ case $1 in exit $? ;; restore) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi

1 0

git:5.3:3eac2726: utils: Change sh(1) "test ==" usage to "="
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.3 Commit: 3eac27269bb60ec062eb0c2058319c70a94e0fbb URL: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7… Author: Greg Troxel <gdt(a)lexort.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T18:42:52+01:00 utils: Change sh(1) "test ==" usage to "=" The POSIX sh(1) specification says that strings are compared with test(1) (also "[") with "=". Bash accepts "==" and this leads to non-portable code. This commit simply changes "==" within test/[ to "=". (cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d) --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7… Patch: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c7… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index f291228180..f9d48c9b4e 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name> merr "kamailio_dump function takes two param" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_dump $1 $2 elif [ "$PW" = "" ] ; then $DUMP_CMD $1 > $2 @@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename> merr "kamailio_restore function takes two params" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_restore $1 $2 else sql_query $1 < $2 @@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action> case $1 in copy) # copy database to some other name - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -323,7 +323,7 @@ case $1 in exit $ret ;; backup) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -337,7 +337,7 @@ case $1 in exit $? ;; restore) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi

1 0

git:5.2:d55905c1: utils: Change sh(1) "test ==" usage to "="
by Henning Westerholt 29 Nov '19

29 Nov '19

Module: kamailio Branch: 5.2 Commit: d55905c1877b13f5d8367e8d4fd16cd0f01dffee URL: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd… Author: Greg Troxel <gdt(a)lexort.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-29T18:42:04+01:00 utils: Change sh(1) "test ==" usage to "=" The POSIX sh(1) specification says that strings are compared with test(1) (also "[") with "=". Bash accepts "==" and this leads to non-portable code. This commit simply changes "==" within test/[ to "=". (cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d) --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd… Patch: https://github.com/kamailio/kamailio/commit/d55905c1877b13f5d8367e8d4fd16cd… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index ae44c5df45..7a7cfaa7f7 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name> merr "kamailio_dump function takes two param" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_dump $1 $2 elif [ "$PW" = "" ] ; then $DUMP_CMD $1 > $2 @@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename> merr "kamailio_restore function takes two params" exit 1 fi - if [ "$USED_DBENGINE" == "oracle" ]; then + if [ "$USED_DBENGINE" = "oracle" ]; then oracle_restore $1 $2 else sql_query $1 < $2 @@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action> case $1 in copy) # copy database to some other name - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -323,7 +323,7 @@ case $1 in exit $ret ;; backup) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi @@ -337,7 +337,7 @@ case $1 in exit $? ;; restore) - if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then + if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then merr "$USED_DBENGINE don't support this operation" exit 1 fi

1 0

[kamailio/kamailio] kamdbctl has bashism ("test ==") (#2157)
by Greg Troxel 29 Nov '19

29 Nov '19

### Description utils/kamctl/kamdbctl contains syntax beyond the POSIX sh stnadard. Specifically, there are multiple instances of "==" in test(1), which should be "=" #### Reproduction In the 5.3.1 release, see line 156. ### Possible Solutions Change == to = (multiple places). ### Additional Information 5.3.1 source tarball This was detected by pkgsrc which has checks for various portability issues. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2157

3 4

← Newer
1
...
11
12
13
14
15
16
17
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2019